From d741c46d4e0dbbbacdcf7e95f725022c262de8c5 Mon Sep 17 00:00:00 2001
From: Jakob Wennberg <149234542+jakobwennberg@users.noreply.github.com>
Date: Sat, 18 Apr 2026 14:29:36 +0200
Subject: [PATCH] =?UTF-8?q?fix:=20show=20Ers=C3=A4tt=20befintlig=20import?=
 =?UTF-8?q?=20button=20for=20duplicate-file=20SIE=20uploads=20(#270)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The duplicate (file-hash) error path returned an importId but the UI only
captured it for the duplicate_period branch, so users saw a misleading
"ta bort under Bokföring" message with no way to act on it. The replace
flow (and its BFL 5:5 audit trail) is identical in both cases, so expose
the existing button for both.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 app/(dashboard)/import/page.tsx     | 12 ++++++------
 components/import/SIEUploadStep.tsx | 13 +++++--------
 2 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/app/(dashboard)/import/page.tsx b/app/(dashboard)/import/page.tsx
index 5dde7586..701e1e81 100644
--- a/app/(dashboard)/import/page.tsx
+++ b/app/(dashboard)/import/page.tsx
@@ -334,7 +334,7 @@ function SIEImportWizard() {
   const [errorType, setErrorType] = useState<'duplicate' | 'duplicate_period' | 'validation' | 'parse' | undefined>()
   const [validationErrors, setValidationErrors] = useState<string[]>([])
   const [validationWarnings, setValidationWarnings] = useState<string[]>([])
-  const [duplicatePeriodImportId, setDuplicatePeriodImportId] = useState<string | null>(null)
+  const [duplicateImportId, setDuplicateImportId] = useState<string | null>(null)
   const [isReplacing, setIsReplacing] = useState(false)
 
   const [file, setFile] = useState<File | null>(null)
@@ -380,8 +380,8 @@ function SIEImportWizard() {
         if (type === 'duplicate' || type === 'duplicate_period') {
           setErrorType(type)
           setError(data.message)
-          if (type === 'duplicate_period' && data.importId) {
-            setDuplicatePeriodImportId(data.importId)
+          if (data.importId) {
+            setDuplicateImportId(data.importId)
           }
           toast({ title: type === 'duplicate' ? 'Filen har redan importerats' : 'Överlappande räkenskapsår', description: data.message, variant: 'destructive' })
         } else if (type === 'validation') {
@@ -459,7 +459,7 @@ function SIEImportWizard() {
       // Clear error state and re-trigger the file upload
       setError(null)
       setErrorType(undefined)
-      setDuplicatePeriodImportId(null)
+      setDuplicateImportId(null)
 
       // Small delay so the user sees the success toast before re-upload starts
       await new Promise(resolve => setTimeout(resolve, 500))
@@ -618,7 +618,7 @@ function SIEImportWizard() {
   const handleNewImport = () => {
     setStep('upload'); setFile(null); setParsed(null); setMappings([])
     setPreview(null); setIssues([]); setImportResult(null); setError(null); setErrorType(undefined)
-    setValidationErrors([]); setValidationWarnings([]); setDuplicatePeriodImportId(null)
+    setValidationErrors([]); setValidationWarnings([]); setDuplicateImportId(null)
     setSieAccounts([]); setIsCreatingAccounts(false)
   }
 
@@ -645,7 +645,7 @@ function SIEImportWizard() {
         </CardContent>
       </Card>
 
-      {step === 'upload' && <SIEUploadStep onFileSelect={handleFileSelect} isLoading={isLoading} error={error} errorType={errorType} validationErrors={validationErrors} validationWarnings={validationWarnings} duplicatePeriodImportId={duplicatePeriodImportId} onReplace={handleReplace} isReplacing={isReplacing} />}
+      {step === 'upload' && <SIEUploadStep onFileSelect={handleFileSelect} isLoading={isLoading} error={error} errorType={errorType} validationErrors={validationErrors} validationWarnings={validationWarnings} duplicateImportId={duplicateImportId} onReplace={handleReplace} isReplacing={isReplacing} />}
       {step === 'preview' && preview && (
         <SIEPreviewStep preview={preview} issues={issues} missingAccounts={missingAccounts}
           onCreateAccounts={handleCreateAccounts} isCreatingAccounts={isCreatingAccounts}
diff --git a/components/import/SIEUploadStep.tsx b/components/import/SIEUploadStep.tsx
index 9c9998d1..7fc9a6a7 100644
--- a/components/import/SIEUploadStep.tsx
+++ b/components/import/SIEUploadStep.tsx
@@ -20,12 +20,12 @@ interface SIEUploadStepProps {
   errorType?: 'duplicate' | 'duplicate_period' | 'validation' | 'parse'
   validationErrors?: string[]
   validationWarnings?: string[]
-  duplicatePeriodImportId?: string | null
+  duplicateImportId?: string | null
   onReplace?: (importId: string) => Promise<void>
   isReplacing?: boolean
 }
 
-export default function SIEUploadStep({ onFileSelect, isLoading, error, errorType, validationErrors, validationWarnings, duplicatePeriodImportId, onReplace, isReplacing }: SIEUploadStepProps) {
+export default function SIEUploadStep({ onFileSelect, isLoading, error, errorType, validationErrors, validationWarnings, duplicateImportId, onReplace, isReplacing }: SIEUploadStepProps) {
   const [isDragging, setIsDragging] = useState(false)
   const [selectedFile, setSelectedFile] = useState<File | null>(null)
   const [loadingPhase, setLoadingPhase] = useState(0)
@@ -192,13 +192,10 @@ export default function SIEUploadStep({ onFileSelect, isLoading, error, errorTyp
 
                   {/* Actionable guidance */}
                   <div className="text-sm text-muted-foreground pt-1 border-t border-border/50 mt-2">
-                    {errorType === 'duplicate' && (
-                      <p>Om du vill importera om filen, ta först bort den tidigare importen under Bokföring.</p>
-                    )}
-                    {errorType === 'duplicate_period' && (
+                    {(errorType === 'duplicate' || errorType === 'duplicate_period') && (
                       <div className="space-y-2">
                         <p>Den befintliga importens verifikationer kommer att makuleras (status ändras till &quot;makulerad&quot;). De finns kvar som spårbar historik.</p>
-                        {duplicatePeriodImportId && onReplace && (
+                        {duplicateImportId && onReplace && (
                           <Button
                             variant="outline"
                             size="sm"
@@ -206,7 +203,7 @@ export default function SIEUploadStep({ onFileSelect, isLoading, error, errorTyp
                             disabled={isReplacing}
                             onClick={(e) => {
                               e.stopPropagation()
-                              onReplace(duplicatePeriodImportId)
+                              onReplace(duplicateImportId)
                             }}
                           >
                             {isReplacing ? (