4.0.0-beta.2 (#1086)

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 4.0.0-beta.2
+### Fixes
+- #1085 not adding -n if empty to do-upload command
+
 ## 4.0.0-beta.1
 
 `v4` represents a move from the [universal uploader](https://github.com/codecov/uploader) to the [Codecov CLI](https://github.com/codecov/codecov-cli). Although this will unlock new features for our users, the CLI is not yet at feature parity with the universal uploader.

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "codecov-action",
-  "version": "4.0.0-beta.1",
+  "version": "4.0.0-beta.2",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "codecov-action",
-      "version": "4.0.0-beta.1",
+      "version": "4.0.0-beta.2",
       "license": "MIT",
       "dependencies": {
         "@actions/core": "^1.10.1",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "codecov-action",
-  "version": "4.0.0-beta.1",
+  "version": "4.0.0-beta.2",
   "description": "Upload coverage reports to Codecov from GitHub Actions",
   "main": "index.js",
   "scripts": {

src/buildExec.test.ts

@@ -35,10 +35,7 @@ test('general args', () => {
 
 
 test('upload args using context', () => {
-  const expectedArgs = [
+  const expectedArgs = [];
-    '-n',
-    '',
-  ];
   const {uploadExecArgs, uploadCommand} = buildUploadExec();
   if (context.eventName == 'pull_request') {
     expectedArgs.push('-C', `${context.payload.pull_request.head.sha}`);

src/buildExec.ts

@@ -149,10 +149,6 @@ const buildUploadExec = () => {
   const exclude = core.getInput('exclude');
 
   const uploadExecArgs = [];
-  uploadExecArgs.push(
-      '-n',
-      `${name}`,
-  );
   const uploadCommand = 'do-upload';
   const uploadOptions:any = {};
   uploadOptions.env = Object.assign(process.env, {
@@ -172,7 +168,12 @@ const buildUploadExec = () => {
       envVarsArg.push(envVarClean);
     }
   }
-
+  if (name) {
+    uploadExecArgs.push(
+        '-n',
+        `${name}`,
+    );
+  }
   if (token) {
     uploadOptions.env.CODECOV_TOKEN = token;
   }