MattssonandClaude Fable 5
c187fabf92
* feat(shopify): Shopify order/refund feed into the transactions inbox
New extensions/general/shopify feed extension, modeled on the WooCommerce
feed: connect a Shopify store with Dev Dashboard custom-app client
credentials (client credentials grant, ~24h tokens, never stored), then a
nightly cron + manual sync imports paid orders and refunds via the GraphQL
Admin API (pinned 2026-07) into the transactions inbox on clearing account
1584. Feed-only: nothing auto-books. Zero PII fields are queried, keeping
the app outside Shopify's protected customer data program.
- shopify_connections migration (RLS, revoke-never-delete, encrypted
client id/secret) + shopify_sync capability and bank_sync-mirrored
backfill
- frozen external_id scheme shopify_{shop_domain}_order|refund_{id},
scoped on the shop domain so reconnects never re-import
- cursor sync on updated_at windows with 24h overlap, lock-date drop at
map time, ingest-failure cursor floor, deadline stop-and-resume,
revoked-credential flip
- /import card + settings panel, sv/en i18n, cron 03:15 in vercel.json +
regenerated Docker crontabs, logo, events, panel registry
- 65 unit tests + pg-real RLS test; extensions.schema.json enum also
gains the missing stripe entry (pre-existing drift)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(shopify): review findings from PR 1474
- token exchange: a 429 that survives every retry is throttling, not a
credential failure; stop remapping retryable 4xx to 401 so sustained
throttling can no longer flip the connection to revoked and delete the
stored credentials (CodeRabbit critical)
- order sync: advance a scanned-through watermark (run start, capped by
the failure floor) after a fully-listed window, so empty first runs and
quiet stores rotate to the back of the cron's oldest-first selection
instead of permanently occupying the 50-connection batch (CodeRabbit
major, starvation)
- add handler-level tests for the orders cron route (auth 401, disabled
503, unconfigured no-op, query failure, capability skip, happy path,
per-connection failure isolation, revoked marking)
- add 401 tests for /sync, /transaction-sync and /disconnect; pin the
cursor floor rule with a two-order page; stub the encryption key via
vi.stubEnv
- note in the panel description (sv/en) that orders can mix VAT rates and
must be split at booking (Swedish review advisory)
- DECISIONS.md: wrap underscore identifiers in backticks (MD037)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
59 lines
2.0 KiB
TypeScript
59 lines
2.0 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { serverErrorMessage, syncSummary, type ShopifySyncPayload } from '../lib/settings-actions'
|
|
|
|
describe('syncSummary', () => {
|
|
const base = { fetched: 5, refundsFetched: 1, imported: 4, duplicates: 1, errors: 0 }
|
|
|
|
it('classifies a revoked run before anything else', () => {
|
|
expect(syncSummary({ transactions: { ...base, revoked: true } })).toEqual({
|
|
reason: 'revoked',
|
|
})
|
|
})
|
|
|
|
it('classifies a truncated run as partial, keeping the error count', () => {
|
|
expect(
|
|
syncSummary({ transactions: { ...base, errors: 2, deadlineReached: true } }),
|
|
).toEqual({ reason: 'partial', values: { fetched: 5, imported: 4, errors: 2 } })
|
|
})
|
|
|
|
it('classifies an empty window as its own outcome', () => {
|
|
expect(
|
|
syncSummary({ transactions: { ...base, fetched: 0, imported: 0 } }),
|
|
).toEqual({ reason: 'empty' })
|
|
})
|
|
|
|
it('reports both halves when rows landed and rows failed', () => {
|
|
expect(syncSummary({ transactions: { ...base, errors: 2 } })).toEqual({
|
|
reason: 'errors',
|
|
values: { fetched: 5, imported: 4, errors: 2 },
|
|
})
|
|
})
|
|
|
|
it('classifies a clean run as feed', () => {
|
|
expect(syncSummary({ transactions: base })).toEqual({
|
|
reason: 'feed',
|
|
values: { fetched: 5, imported: 4 },
|
|
})
|
|
})
|
|
|
|
it('classifies an unreadable body as unknown', () => {
|
|
expect(syncSummary(null)).toEqual({ reason: 'unknown' })
|
|
expect(syncSummary({} as ShopifySyncPayload)).toEqual({ reason: 'unknown' })
|
|
expect(syncSummary({ transactions: {} })).toEqual({ reason: 'unknown' })
|
|
})
|
|
})
|
|
|
|
describe('serverErrorMessage', () => {
|
|
it('prefers route copy over the generic map', () => {
|
|
expect(serverErrorMessage({ error: 'Ingen ansluten Shopify-butik.' }, 404, 'sv')).toBe(
|
|
'Ingen ansluten Shopify-butik.',
|
|
)
|
|
})
|
|
|
|
it('prefers the English variant when present and the locale is en', () => {
|
|
expect(
|
|
serverErrorMessage({ error: 'Fel.', error_en: 'An error.' }, 500, 'en'),
|
|
).toBe('An error.')
|
|
})
|
|
})
|