* feat(api): test-mode API keys force dry-run on the v1 REST API A key created with mode='test' (prefix gnubok_sk_test_) binds to the real company, but the v1 wrapper forces dry_run on every write so nothing is persisted or sent. Mutations on endpoints that can't be simulated (dryRunSupported=false or unregistered) are refused with 403 TEST_KEY_WRITE_BLOCKED — fail-closed. Reads pass through unchanged and every test-key response carries X-Gnubok-Mode: test. Live keys are unaffected (mode defaults to 'live'). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(invoices): company default "Vår referens" + per-line sales-account override Add company_settings.default_our_reference (settings form, schema, type); the invoice editor pre-fills our_reference from it on new invoices only, never overwriting an edited draft. Separately, add an optional per-line försäljningskonto (class-3) override in the editor — left blank, the engine still derives the revenue account from the VAT rate, and reverse-charge/export lines ignore the override. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(invoices): render a Swish payment QR on invoice PDFs Build the Swish "Type C" QR payload offline (no Swish API call) and embed it as a PNG in the invoice PDF payment box when Swish display is enabled, the invoice is in SEK, and the amount is positive. Also surface the invoice number in the payment box. Wired through every PDF render path: send, mark-sent and pdf routes (both legacy and v1), the recurring-schedule sender, and the staged-send commit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(bookkeeping): draft exclusion + correction-chain collapse on verifikationslista Extend list_fiscal_period_entries_with_related with two opt-in params: p_exclude_draft (keep drafts off the committed list — they get their own surface) and p_collapse_corrections (render a correction group as the single live correction, hiding the mechanical storno and the reversed original). Both default false; nothing is deleted, every voucher keeps its number, and a "show all" toggle exposes the full chain. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(reports): link multi-year SIE periods so resultatrapport shows the prior year SIE import now sets fiscal_periods.previous_period_id in both directions when creating a period, so multi-year files chain correctly regardless of #RAR order. A backfill migration repairs periods imported before this (idempotent; only touches NULL links on first-of-month periods). generateResultatrapport falls back to the date-adjacent prior period when the chain is still null, so the comparison column works for legacy data too. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(articles): hide the VAT field for non-momsregistrerade companies The article form reads company_settings.vat_registered and, when false, hides the moms field and forces vat_rate to 0 on submit — mirroring the invoice editor so a non-VAT-registered company never sets a rate it can't charge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(import): allow file-based imports in the sandbox Bank-file, CSV/Excel and SIE imports run entirely on uploaded data with no external service, so they're now reachable in the sandbox. Only the API-backed options that need live third-party credentials (PSD2 bank connection, provider migration) stay disabled. Updates the sandbox notice copy to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(bookkeeping): add edit draft functionality for journal entries * feat(database): add default "Vår referens" column to company_settings for invoicing * fix(tests): set SHOW_SWISH_ON_INVOICE to false in PDF template mocks * @ fix(payments): use roundOre for Swish amount formatting Replace naive Math.round(x*100)/100 with roundOre from @/lib/money to satisfy the antipattern guard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> @ --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
405 lines
15 KiB
TypeScript
405 lines
15 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
||
import {
|
||
createMockRequest,
|
||
parseJsonResponse,
|
||
createMockRouteParams,
|
||
createQueuedMockSupabase,
|
||
makeInvoice,
|
||
makeCustomer,
|
||
makeCompanySettings,
|
||
} from '@/tests/helpers'
|
||
import { eventBus } from '@/lib/events'
|
||
|
||
const { supabase: mockSupabase, enqueue, reset } = createQueuedMockSupabase()
|
||
vi.mock('@/lib/supabase/server', () => ({
|
||
createClient: () => Promise.resolve(mockSupabase),
|
||
}))
|
||
|
||
vi.mock('@/lib/init', () => ({
|
||
ensureInitialized: vi.fn(),
|
||
}))
|
||
|
||
vi.mock('@/lib/company/context', () => ({
|
||
requireCompanyId: vi.fn().mockResolvedValue('company-1'),
|
||
getActiveCompanyId: vi.fn().mockResolvedValue('company-1'),
|
||
}))
|
||
|
||
vi.mock('@/lib/auth/require-write', () => ({
|
||
requireWritePermission: vi.fn().mockResolvedValue({ ok: true }),
|
||
}))
|
||
|
||
const mockRenderToBuffer = vi.fn()
|
||
vi.mock('@react-pdf/renderer', () => ({
|
||
renderToBuffer: (...args: unknown[]) => mockRenderToBuffer(...args),
|
||
Document: vi.fn(),
|
||
Page: vi.fn(),
|
||
Text: vi.fn(),
|
||
View: vi.fn(),
|
||
StyleSheet: { create: (s: unknown) => s },
|
||
}))
|
||
|
||
vi.mock('@/lib/invoices/pdf-template', () => ({
|
||
InvoicePDF: vi.fn().mockReturnValue('mock-pdf-element'),
|
||
brandingFromCompanySettings: vi.fn().mockReturnValue({}),
|
||
SHOW_SWISH_ON_INVOICE: false,
|
||
}))
|
||
import { InvoicePDF } from '@/lib/invoices/pdf-template'
|
||
|
||
const mockSendEmail = vi.fn()
|
||
const mockIsConfigured = vi.fn()
|
||
vi.mock('@/lib/email/service', () => ({
|
||
getEmailService: () => ({
|
||
sendEmail: (...args: unknown[]) => mockSendEmail(...args),
|
||
isConfigured: () => mockIsConfigured(),
|
||
}),
|
||
}))
|
||
|
||
vi.mock('@/lib/email/invoice-templates', () => ({
|
||
generateInvoiceEmailHtml: vi.fn().mockReturnValue('<html>Invoice</html>'),
|
||
generateInvoiceEmailText: vi.fn().mockReturnValue('Invoice text'),
|
||
generateInvoiceEmailSubject: vi.fn().mockReturnValue('Faktura F-2024001'),
|
||
}))
|
||
|
||
const mockCreateInvoiceJournalEntry = vi.fn()
|
||
vi.mock('@/lib/bookkeeping/invoice-entries', () => ({
|
||
createInvoiceJournalEntry: (...args: unknown[]) =>
|
||
mockCreateInvoiceJournalEntry(...args),
|
||
}))
|
||
|
||
// The sandbox guard issues a company_settings query at the top of the route;
|
||
// short-circuit it in tests since the queued mock-supabase is shaped for the
|
||
// route's existing fetch chain, not an extra pre-flight read.
|
||
vi.mock('@/lib/sandbox/guard', () => ({
|
||
guardSandbox: vi.fn().mockResolvedValue(null),
|
||
isSandboxCompany: vi.fn().mockResolvedValue(false),
|
||
sandboxBlockedResponse: vi.fn(),
|
||
}))
|
||
|
||
import { POST } from '../route'
|
||
|
||
describe('POST /api/invoices/[id]/send', () => {
|
||
const mockUser = { id: 'user-1', email: 'test@test.se' }
|
||
const customer = makeCustomer({ id: 'cust-1', email: 'kund@test.se' })
|
||
const company = makeCompanySettings({ accounting_method: 'accrual' })
|
||
const invoice = makeInvoice({
|
||
id: 'inv-1',
|
||
status: 'draft',
|
||
customer,
|
||
items: [
|
||
{
|
||
id: 'item-1',
|
||
invoice_id: 'inv-1',
|
||
sort_order: 0,
|
||
description: 'Consulting',
|
||
quantity: 10,
|
||
unit: 'tim',
|
||
unit_price: 1000,
|
||
line_total: 10000,
|
||
vat_rate: 25,
|
||
vat_amount: 2500,
|
||
created_at: '2024-06-15T14:30:00Z',
|
||
},
|
||
],
|
||
})
|
||
|
||
beforeEach(() => {
|
||
vi.clearAllMocks()
|
||
reset()
|
||
eventBus.clear()
|
||
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: mockUser } })
|
||
mockIsConfigured.mockReturnValue(true)
|
||
mockRenderToBuffer.mockResolvedValue(Buffer.from('fake-pdf'))
|
||
})
|
||
|
||
it('returns 401 when not authenticated', async () => {
|
||
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: null } })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse(response)
|
||
|
||
expect(status).toBe(401)
|
||
expect(body).toEqual({ error: 'Unauthorized' })
|
||
})
|
||
|
||
it('returns 503 when email service is not configured', async () => {
|
||
mockIsConfigured.mockReturnValue(false)
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status } = await parseJsonResponse(response)
|
||
|
||
expect(status).toBe(503)
|
||
})
|
||
|
||
it('returns 404 when invoice not found', async () => {
|
||
enqueue({ data: null, error: { message: 'Not found' } })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse<{ error: string }>(response)
|
||
|
||
expect(status).toBe(404)
|
||
expect((body.error as unknown as { code: string }).code).toBe('INVOICE_PAID_NOT_FOUND')
|
||
})
|
||
|
||
it('returns 400 when invoice is cancelled (makulerad)', async () => {
|
||
const cancelledInvoice = makeInvoice({
|
||
id: 'inv-1',
|
||
status: 'cancelled',
|
||
invoice_number: 'F-2026001',
|
||
items: [],
|
||
})
|
||
enqueue({ data: cancelledInvoice, error: null })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse<{ error: string }>(response)
|
||
|
||
expect(status).toBe(400)
|
||
expect((body.error as unknown as { code: string }).code).toBe('INVOICE_SEND_CANCELLED')
|
||
})
|
||
|
||
it('returns 400 when customer has no email', async () => {
|
||
const noEmailInvoice = makeInvoice({
|
||
id: 'inv-1',
|
||
customer: makeCustomer({ email: null }),
|
||
items: [],
|
||
})
|
||
enqueue({ data: noEmailInvoice, error: null })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse<{ error: string }>(response)
|
||
|
||
expect(status).toBe(400)
|
||
expect((body.error as unknown as { code: string }).code).toBe('INVOICE_SEND_NO_CUSTOMER_EMAIL')
|
||
})
|
||
|
||
it('returns 404 when company settings not found', async () => {
|
||
enqueue({ data: invoice, error: null })
|
||
enqueue({ data: null, error: { message: 'Not found' } })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse<{ error: string }>(response)
|
||
|
||
expect(status).toBe(404)
|
||
expect((body.error as unknown as { code: string }).code).toBe('INVOICE_SEND_COMPANY_SETTINGS_MISSING')
|
||
})
|
||
|
||
it('sends invoice email, updates status, creates journal entry for accrual', async () => {
|
||
// Fetch invoice
|
||
enqueue({ data: invoice, error: null })
|
||
// Fetch company settings
|
||
enqueue({ data: company, error: null })
|
||
|
||
mockSendEmail.mockResolvedValue({ success: true, messageId: 'msg-1' })
|
||
mockCreateInvoiceJournalEntry.mockResolvedValue({ id: 'je-1' })
|
||
|
||
// Update invoice status to 'sent'
|
||
enqueue({ data: null, error: null })
|
||
// Update invoice with journal_entry_id
|
||
enqueue({ data: null, error: null })
|
||
|
||
const emitSpy = vi.spyOn(eventBus, 'emit')
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse<{
|
||
success: boolean
|
||
messageId: string
|
||
}>(response)
|
||
|
||
expect(status).toBe(200)
|
||
expect(body.success).toBe(true)
|
||
expect(body.messageId).toBe('msg-1')
|
||
expect(mockSendEmail).toHaveBeenCalledWith(
|
||
expect.objectContaining({
|
||
to: 'kund@test.se',
|
||
subject: 'Faktura F-2024001',
|
||
})
|
||
)
|
||
expect(mockCreateInvoiceJournalEntry).toHaveBeenCalledWith(
|
||
expect.anything(),
|
||
'company-1',
|
||
'user-1',
|
||
expect.objectContaining({ id: 'inv-1' }),
|
||
'enskild_firma'
|
||
)
|
||
expect(emitSpy).toHaveBeenCalledWith(
|
||
expect.objectContaining({ type: 'invoice.sent' })
|
||
)
|
||
})
|
||
|
||
it('skips journal entry for cash method', async () => {
|
||
const cashCompany = makeCompanySettings({ accounting_method: 'cash' })
|
||
enqueue({ data: invoice, error: null })
|
||
enqueue({ data: cashCompany, error: null })
|
||
|
||
mockSendEmail.mockResolvedValue({ success: true, messageId: 'msg-2' })
|
||
|
||
// Update invoice status
|
||
enqueue({ data: null, error: null })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse<{ success: boolean }>(response)
|
||
|
||
expect(status).toBe(200)
|
||
expect(body.success).toBe(true)
|
||
expect(mockCreateInvoiceJournalEntry).not.toHaveBeenCalled()
|
||
})
|
||
|
||
it('does not fail when journal entry creation fails (non-blocking)', async () => {
|
||
enqueue({ data: invoice, error: null })
|
||
enqueue({ data: company, error: null })
|
||
|
||
mockSendEmail.mockResolvedValue({ success: true, messageId: 'msg-3' })
|
||
mockCreateInvoiceJournalEntry.mockRejectedValue(new Error('Period locked'))
|
||
|
||
// Update invoice status
|
||
enqueue({ data: null, error: null })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse<{ success: boolean }>(response)
|
||
|
||
expect(status).toBe(200)
|
||
expect(body.success).toBe(true)
|
||
})
|
||
|
||
it('assigns an invoice number when sending a draft with no number', async () => {
|
||
const draftWithoutNumber = makeInvoice({
|
||
id: 'inv-1',
|
||
status: 'draft',
|
||
invoice_number: null,
|
||
customer,
|
||
items: invoice.items,
|
||
})
|
||
|
||
// Fetch invoice (no number)
|
||
enqueue({ data: draftWithoutNumber, error: null })
|
||
// Fetch company settings
|
||
enqueue({ data: company, error: null })
|
||
// ensureInvoiceNumber: rpc generate_invoice_number (RPC now persists internally)
|
||
enqueue({ data: 'F-2026010', error: null })
|
||
|
||
mockSendEmail.mockResolvedValue({ success: true, messageId: 'msg-99' })
|
||
mockCreateInvoiceJournalEntry.mockResolvedValue({ id: 'je-1' })
|
||
|
||
// Update status to 'sent'
|
||
enqueue({ data: null, error: null })
|
||
// Update with journal_entry_id
|
||
enqueue({ data: null, error: null })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse<{ success: boolean }>(response)
|
||
|
||
expect(status).toBe(200)
|
||
expect(body.success).toBe(true)
|
||
expect(mockSupabase.rpc).toHaveBeenCalledWith('generate_invoice_number', {
|
||
p_company_id: 'company-1',
|
||
p_invoice_id: 'inv-1',
|
||
p_document_type: 'invoice',
|
||
})
|
||
// The journal entry should see the freshly-assigned number
|
||
expect(mockCreateInvoiceJournalEntry).toHaveBeenCalledWith(
|
||
expect.anything(),
|
||
'company-1',
|
||
'user-1',
|
||
expect.objectContaining({ invoice_number: 'F-2026010' }),
|
||
'enskild_firma'
|
||
)
|
||
})
|
||
|
||
it('does not re-assign number when draft already has one (idempotency)', async () => {
|
||
enqueue({ data: invoice, error: null })
|
||
enqueue({ data: company, error: null })
|
||
|
||
mockSendEmail.mockResolvedValue({ success: true, messageId: 'msg-100' })
|
||
mockCreateInvoiceJournalEntry.mockResolvedValue({ id: 'je-2' })
|
||
|
||
enqueue({ data: null, error: null })
|
||
enqueue({ data: null, error: null })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status } = await parseJsonResponse(response)
|
||
|
||
expect(status).toBe(200)
|
||
expect(mockSupabase.rpc).not.toHaveBeenCalledWith('generate_invoice_number', expect.anything())
|
||
})
|
||
|
||
it('does NOT consume an invoice number when PDF render fails (preflight)', async () => {
|
||
const draftWithoutNumber = makeInvoice({
|
||
id: 'inv-1',
|
||
status: 'draft',
|
||
invoice_number: null,
|
||
customer,
|
||
items: invoice.items,
|
||
})
|
||
|
||
enqueue({ data: draftWithoutNumber, error: null })
|
||
enqueue({ data: company, error: null })
|
||
|
||
// First render call (the preflight) throws.
|
||
mockRenderToBuffer.mockRejectedValueOnce(new Error('PDF render exploded'))
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse<{ error: string }>(response)
|
||
|
||
expect(status).toBe(500)
|
||
expect((body.error as unknown as { code: string }).code).toBe('INVOICE_SEND_PDF_RENDER_FAILED')
|
||
// Critical: counter must not have advanced.
|
||
expect(mockSupabase.rpc).not.toHaveBeenCalledWith('generate_invoice_number', expect.anything())
|
||
// Email must not have been attempted.
|
||
expect(mockSendEmail).not.toHaveBeenCalled()
|
||
})
|
||
|
||
it('returns 500 when email sending fails', async () => {
|
||
enqueue({ data: invoice, error: null })
|
||
enqueue({ data: company, error: null })
|
||
|
||
mockSendEmail.mockResolvedValue({ success: false, error: 'SMTP error' })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status, body } = await parseJsonResponse<{ error: string }>(response)
|
||
|
||
// Provider errors map to 502 PROVIDER_FAILED with the provider message in details.
|
||
expect(status).toBe(502)
|
||
expect((body.error as unknown as { code: string }).code).toBe('INVOICE_SEND_PROVIDER_FAILED')
|
||
expect(
|
||
(body.error as unknown as { details?: { providerError?: string } }).details?.providerError,
|
||
).toContain('SMTP error')
|
||
})
|
||
|
||
it('renders the final PDF as if already sent (no UTKAST banner)', async () => {
|
||
enqueue({ data: invoice, error: null })
|
||
enqueue({ data: company, error: null })
|
||
|
||
mockSendEmail.mockResolvedValue({ success: true, messageId: 'msg-banner' })
|
||
mockCreateInvoiceJournalEntry.mockResolvedValue({ id: 'je-1' })
|
||
|
||
enqueue({ data: null, error: null })
|
||
enqueue({ data: null, error: null })
|
||
|
||
const request = createMockRequest('/api/invoices/inv-1/send', { method: 'POST' })
|
||
const response = await POST(request, createMockRouteParams({ id: 'inv-1' }))
|
||
const { status } = await parseJsonResponse(response)
|
||
|
||
expect(status).toBe(200)
|
||
// Final render: invoice already has an invoice_number on the fixture, so
|
||
// preflight is skipped and InvoicePDF is called exactly once. The status
|
||
// passed in must be 'sent' — otherwise pdf-template.tsx renders the
|
||
// "UTKAST – inte en giltig faktura" banner on the customer's PDF.
|
||
expect(vi.mocked(InvoicePDF)).toHaveBeenCalledTimes(1)
|
||
const renderArgs = vi.mocked(InvoicePDF).mock.calls[0][0]
|
||
expect(renderArgs.invoice.status).toBe('sent')
|
||
expect(renderArgs.invoice.invoice_number).toBe('F-2024001')
|
||
})
|
||
})
|