* feat(parties): Kontakter register, suggestion queue, dossier and merge Phase 1's two surfaces on top of the parties substrate: - /parties page: one list with the five-way switch (Alla, Kunder, Leverantörer, Förslag, Bara i bokföringen), search, a 12-month/all period picker, and at most one attention line. Confirmed rows show roles as muted text, rhythm, underlag, dominant account and money. Observed rows are computed and never stored; a generic band keeps unattributed spend visible. - Suggestion queue: a reason per row, hard-key rows pre-ticked, bulk confirm behind one dialog, dismiss on hover, undo on the toast. - Dossier slide-over: Pengar, Bokföring, Vad Accounted vet (facts and identities with source and count), Underlag och verifikat, Historik. - Merge dialog with a visible, swappable survivor and undo. - API: GET /api/parties, GET /api/parties/[id], POST suggest, decide, decide/undo, merge, merge/undo (withRouteContext, Zod, 15 tests). - Migration 20260903090000: decide_parties snapshots the reason it clears; undo_party_decisions reverses confirm/dismiss within 30 days; decision kind 'undo'. - The pipeline runs after SIE import and provider migration (non-blocking) so a migrant's register is full on arrival. - Nav entry under Register; sv/en strings. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): pass explicit interpolation values to next-intl next build's type check rejects a typed interface where the translator wants an index-signature record. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): retry label on the load-failed state Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): hard keys for companies without org number, readable names, look-alikes at read time - get_ledger_key_evidence dropped every document for a company whose own org number is NULL (the self check compared against NULL). Replaced in 20260903100000 with a coalesced comparison; pg test covers it. - Display names come from the printed name on documents, otherwise from the voucher text with the AP/AR prefix and supplier number removed. - Look-alike parties (same core, or one core extending the other by whole words: Fortnox / Fortnox Finans) are detected when the register is read, never stored, and feed the Dubblett? chip and the merge dialog. - Queue shows Intäkt beside Kostnad; dossier hides zero money rows and formats bankgiro/plusgiro; merge dialog cancels with Avbryt; no synchronous setState inside effects. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(parties): link every new supplier and customer to a party on write The backfill covered the rows that existed on 2026-09-02; 108 rows created since had no party and never reached the register. A BEFORE INSERT/UPDATE trigger on customers and suppliers now calls ensure_party on every write path at once: find-or-create by org number inside the company, never by name; a private customer gets a kind=person party without any number; a nameless row stays unlinked; a foreign party id is refused with the same error as the composite foreign key; a link to a merged party follows the chain to the survivor; the clear that ON DELETE SET NULL performs is kept. ensure_party lets the trigger act for the row's owner (pg_trigger_depth() > 0); the RPC path is unchanged. The migration also links the rows created since the backfill. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): dossier hides dismissed parties and follows merges to the survivor The register hid archived parties while the dossier still served them by id, and a merged party's dossier pointed at a dead row. Superagent P2 on #2206; three unit tests. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * chore(parties): move the role-link migration past main's 20260903110000 Two files with one version would collide in schema_migrations. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(parties): confirm suggestions into Leverantörer and Kunder, no third noun Founder decision after the walkthrough: users know two words. The page becomes the queue 'Förslag från bokföringen' with 'Bara i bokföringen' beside it; the Kontakter nav entry and the Alla/Kunder/Leverantörer views go. Each suggestion shows what it becomes (Blir), read from the ledger side and changeable per row; confirming calls promote_parties, which creates the supplier and/or customer row from the party's facts, never a duplicate, and is undoable for 30 days through undo_party_promotions (the created rows are archived, the party returns to the queue). Leverantörer and Kunder carry the one attention line that leads here. The dossier offers Lägg upp som leverantör / som kund. Migration 20260903130000, 5 pg tests, route and unit tests updated. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): write bankgiro and plusgiro the way the supplier form does Identities are stored as digits; suppliers carry 5317-0900. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(parties): fetch registry facts from SCB into the dossier SCB granted API access today (certificate + password, layouts Je and Ae). This adds the first registry enricher of phase 3: - lib/parties/scb: config from env (SCB_API_CERT_PFX_BASE64, SCB_API_CERT_PASSWORD), an mTLS transport on node:https, the mapping of every documented Je variable to a labelled fact, and a client whose wire format sits in one file because SCB replaces the API this month. Legal persons only: a sole trader's org number is a personnummer. - Migration 20260903150000: record_party_facts(company, user, party, source, facts, fetched_at) refreshes unchanged values, supersedes changed ones, never touches other sources. pg test. - POST /api/parties/[id]/enrich: 503 when not configured, 400 for a sole trader, 502 when SCB fails, fills an empty legal name. 7 tests. - Dossier: 'Hämta uppgifter' button (gated on configuration) and the registry rows with 'SCB · datum' as their source line. - scripts/scb/discover.ts prints the live variable list, code tables and one lookup so the request shape is checked against the real API. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): SCB client on the live wire format, mapper on the real Je row Verified against the API on 2026-09-03: an identity lookup is one filter (Variabel 'OrgNr (10 siffror)', Operator ArLikaMed) without status keys, and the row carries '<name>, kod' beside SCB's own text. The mapper now reads those columns, prefers SCB's text, and adds turnover band, seat names and Skatteverket registration. The AB Volvo row is the fixture. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): registry legal name outranks the document one, never a person's Survivorship from the plan: user > registry > document. The dossier's legal-name row now carries 'SCB · datum' when the registry is the source. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): VAT number from the moms flag, one primary action, one source line Founder review of the SCB dossier: - A Swedish company registered for moms has VAT number SE + org number + 01 by construction, so the registry's moms flag yields the number; it fills an empty vat_number on the party and shows in the Momsnr row instead of 'Saknas'. - The 'Registrerad hos Skatteverket' row said nothing (true for every legal person) and is gone. - Five buttons became one primary (the role the ledger suggests) and a menu with the rest; the per-row 'SCB · datum' notes became one group line 'Från SCB · hämtat datum'. - A postal-code-only address (large companies) is labelled as such. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): do not repeat the county when it equals the municipality Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * feat(parties): SCB picker for parties without an org number 'Hitta i företagsregistret' in the dossier menu opens a picker: SCB is searched on the party's name (prefix first, contains as fallback, counts before rows, capped at 25, natural persons and estates excluded, active companies first). The user chooses; the org number is recorded as a fact with source 'user' and set on the party, then the normal fetch runs, so every later fetch is by number. A number another live party holds is refused with a pointer to it. One match is still shown, never auto-picked. The transport retries once on a dropped connection (seen live). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): a picked org number shows in the queue's reason and counts as a hard key Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(parties): SCB search tightened after a batch of real supplier names Twenty-five prod supplier names and twenty org numbers across every legal form went through the search and the lookup: - total is what the picker can offer, not SCB's raw count (Eismann counted one row and offered none, a natural person); - foreign legal forms stay in the query: they are part of the registered name and dropping them floods (Schmidt GmbH became 167 Schmidts); - a fusion or delning in progress is no longer a warning (Fortnox AB and Avanza Bank trade normally under 'Fusion pågår'); distress and disappearance codes still are. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * chore(parties): move the four queue migrations past main's 20260903170000 Main merged 20260903120000_skattekonto_transactions_realtime_publication with the same version as the role-link trigger; the preview database refused the duplicate key. All four now sit after main's newest so the set applies in one ordered run on prod. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * chore(parties): move record_party_facts after the queue migrations Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * chore(parties): move record_party_facts to a version after tonight's collisions Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
148 lines
6.2 KiB
TypeScript
148 lines
6.2 KiB
TypeScript
import type { ScbConfig } from './config'
|
|
import { factsFromScbCompany, type ScbCompanyRow, type ScbFact } from './map'
|
|
import { isLegalPersonOrgNumber, toPeOrgNr } from './org-number'
|
|
import { scbJson } from './transport'
|
|
|
|
/**
|
|
* The wire format of the current SokPaVar API, checked against the live
|
|
* service on 2026-09-03 (scripts/scb/discover.ts, help page at
|
|
* <base>/help). A search is a list of variable filters; an identity lookup
|
|
* is one filter on "OrgNr (10 siffror)" with operator ArLikaMed, and
|
|
* without Företagsstatus/Registreringsstatus so a deregistered company is
|
|
* still returned (an empty string there is rejected with 400). The row
|
|
* comes back with every purchased column, codes and texts side by side.
|
|
*/
|
|
export const SCB_ORG_VARIABLE = 'OrgNr (10 siffror)'
|
|
|
|
export interface ScbLookupResult {
|
|
found: boolean
|
|
peOrgNr: string
|
|
row: ScbCompanyRow | null
|
|
facts: ScbFact[]
|
|
fetchedAt: string
|
|
}
|
|
|
|
export interface ScbCandidate {
|
|
orgNumber: string
|
|
name: string
|
|
city: string | null
|
|
industry: string | null
|
|
legalForm: string | null
|
|
/** SCB's own status text; active is Företagsstatus code 1. */
|
|
status: string | null
|
|
active: boolean
|
|
}
|
|
|
|
export interface ScbSearchResult {
|
|
query: string
|
|
/** How SCB was asked: a prefix match first, a contains match as fallback. */
|
|
mode: 'starts_with' | 'contains'
|
|
/** Rows SCB counted before the cap; above the cap the list is cut and the user should refine. */
|
|
total: number
|
|
truncated: boolean
|
|
candidates: ScbCandidate[]
|
|
}
|
|
|
|
export interface ScbClient {
|
|
variables(): Promise<unknown>
|
|
categories(): Promise<unknown>
|
|
lookupByOrgNumber(orgNumber: string): Promise<ScbLookupResult>
|
|
searchByName(query: string): Promise<ScbSearchResult>
|
|
}
|
|
|
|
/** Candidates shown per search; SCB can return thousands for a short word. */
|
|
export const SCB_SEARCH_CAP = 25
|
|
/** Legal forms never offered in the picker: natural persons and estates. */
|
|
const NON_COMPANY_LEGAL_FORMS = new Set(['10', '91'])
|
|
|
|
/**
|
|
* What we send SCB for a name: the AP prefix, supplier numbers and a
|
|
* trailing legal form are noise ("Levfakt Telia Sverige AB (17)" becomes
|
|
* "Telia Sverige"). SCB's name filter refuses an apostrophe.
|
|
*/
|
|
export function nameQuery(raw: string): string {
|
|
return raw
|
|
.replace(/^(levfakt|levfkt|lev\.?fakt\.?|leverantörsfaktura från\s*\d*|leverantörsfaktura|levbet\.?|kundbet\.?|kundfaktura|faktura från|faktura|kvitto|utgift|inköp)\s+/i, '')
|
|
.replace(/[(),]/g, ' ')
|
|
.replace(/\b\d{1,6}\b/g, ' ')
|
|
.replace(/\s+(ab|aktiebolag|hb|kb|publ|\(publ\))\.?\s*$/i, '')
|
|
.replace(/'/g, '')
|
|
.replace(/\s+/g, ' ')
|
|
.trim()
|
|
}
|
|
|
|
export function nameSearchBody(query: string, mode: 'starts_with' | 'contains') {
|
|
return {
|
|
Variabler: [{ Variabel: 'Namn', Operator: mode === 'starts_with' ? 'BorjarPa' : 'Innehaller', Varde1: query, Varde2: '' }],
|
|
Kategorier: [],
|
|
}
|
|
}
|
|
|
|
function candidateFrom(row: ScbCompanyRow): ScbCandidate | null {
|
|
const org = String(row.OrgNr ?? '').replace(/[^0-9]/g, '')
|
|
const legalFormCode = String(row['Juridisk form, kod'] ?? '').trim()
|
|
if (org.length !== 10 || NON_COMPANY_LEGAL_FORMS.has(legalFormCode)) return null
|
|
const str = (k: string) => {
|
|
const v = row[k]
|
|
const t = v === null || v === undefined ? '' : String(v).trim()
|
|
return t === '' ? null : t
|
|
}
|
|
return {
|
|
orgNumber: org,
|
|
name: str('Företagsnamn') ?? org,
|
|
city: str('PostOrt'),
|
|
industry: str('Bransch_1'),
|
|
legalForm: str('Juridisk form'),
|
|
status: str('Företagsstatus'),
|
|
active: String(row['Företagsstatus, kod'] ?? '').trim() === '1',
|
|
}
|
|
}
|
|
|
|
export function identityLookupBody(orgNumber10: string) {
|
|
return {
|
|
Variabler: [{ Variabel: SCB_ORG_VARIABLE, Operator: 'ArLikaMed', Varde1: orgNumber10, Varde2: '' }],
|
|
Kategorier: [],
|
|
}
|
|
}
|
|
|
|
export function createScbClient(config: ScbConfig, deps: { json?: typeof scbJson } = {}): ScbClient {
|
|
const json = deps.json ?? scbJson
|
|
return {
|
|
variables: () => json(config, 'GET', '/api/Je/Variabler'),
|
|
categories: () => json(config, 'GET', '/api/Je/KategorierMedKodtabeller'),
|
|
async lookupByOrgNumber(orgNumber) {
|
|
if (!isLegalPersonOrgNumber(orgNumber)) {
|
|
throw new Error('SCB-uppslag görs bara på organisationsnummer för juridiska personer.')
|
|
}
|
|
const org10 = orgNumber.replace(/[^0-9]/g, '')
|
|
const peOrgNr = toPeOrgNr(org10)
|
|
const fetchedAt = new Date().toISOString()
|
|
const rows = await json<ScbCompanyRow[]>(config, 'POST', '/api/Je/HamtaForetag', identityLookupBody(org10))
|
|
const list = Array.isArray(rows) ? rows : []
|
|
const row = list.find((r) => String(r.OrgNr ?? r.PeOrgNr ?? '').replace(/[^0-9]/g, '').endsWith(org10)) ?? null
|
|
return { found: Boolean(row), peOrgNr, row, facts: row ? factsFromScbCompany(row) : [], fetchedAt }
|
|
},
|
|
async searchByName(raw) {
|
|
const query = nameQuery(raw)
|
|
if (query.length < 2) return { query, mode: 'starts_with', total: 0, truncated: false, candidates: [] }
|
|
// Count first: a short word can match thousands and we never pull those.
|
|
const run = async (mode: 'starts_with' | 'contains'): Promise<ScbSearchResult> => {
|
|
const body = nameSearchBody(query, mode)
|
|
const total = Number(await json<number | string>(config, 'POST', '/api/Je/RaknaForetag', body)) || 0
|
|
if (total === 0) return { query, mode, total, truncated: false, candidates: [] }
|
|
if (total > SCB_SEARCH_CAP * 4) return { query, mode, total, truncated: true, candidates: [] }
|
|
const rows = await json<ScbCompanyRow[]>(config, 'POST', '/api/Je/HamtaForetag', body)
|
|
const all = (Array.isArray(rows) ? rows : []).map(candidateFrom).filter((c): c is ScbCandidate => c !== null)
|
|
// Active companies first, then by name; the cap keeps the picker a picker.
|
|
all.sort((a, b) => Number(b.active) - Number(a.active) || a.name.localeCompare(b.name, 'sv'))
|
|
// total is what the picker can offer: SCB's count minus the natural
|
|
// persons and estates we never show ("Eismann" counted 1, offered 0).
|
|
return { query, mode, total: all.length, truncated: all.length > SCB_SEARCH_CAP, candidates: all.slice(0, SCB_SEARCH_CAP) }
|
|
}
|
|
const first = await run('starts_with')
|
|
if (first.total > 0 || first.truncated || query.length < 4) return first
|
|
return run('contains')
|
|
},
|
|
}
|
|
}
|