* feat: optimize migration process with bulk reads and chunked inserts to improve performance * feat: add SIE-import requirement banner for specific providers in migration workflow * feat: enhance error handling in TIC API integration with structured HTTP responses * Update components/extensions/general/ArcimMigrationWorkspace.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
193 lines
6.4 KiB
TypeScript
193 lines
6.4 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
// Mock the tic-client functions
|
|
vi.mock('../lib/tic-client', () => ({
|
|
searchCompanyByOrgNumber: vi.fn(),
|
|
getBankAccounts: vi.fn(),
|
|
getSNICodes: vi.fn(),
|
|
getEmails: vi.fn(),
|
|
getPhones: vi.fn(),
|
|
}))
|
|
|
|
import { ticExtension } from '../index'
|
|
import {
|
|
searchCompanyByOrgNumber,
|
|
getBankAccounts,
|
|
getSNICodes,
|
|
getEmails,
|
|
getPhones,
|
|
} from '../lib/tic-client'
|
|
import { TICAPIError } from '../lib/tic-types'
|
|
import type { TICCompanyDocument } from '../lib/tic-types'
|
|
|
|
const mockSearch = vi.mocked(searchCompanyByOrgNumber)
|
|
const mockBank = vi.mocked(getBankAccounts)
|
|
const mockSNI = vi.mocked(getSNICodes)
|
|
const mockEmails = vi.mocked(getEmails)
|
|
const mockPhones = vi.mocked(getPhones)
|
|
|
|
function makeRequest(orgNumber?: string): Request {
|
|
const url = orgNumber
|
|
? `http://localhost/api/extensions/ext/tic/lookup?org_number=${encodeURIComponent(orgNumber)}`
|
|
: 'http://localhost/api/extensions/ext/tic/lookup'
|
|
return new Request(url)
|
|
}
|
|
|
|
const lookupHandler = ticExtension.apiRoutes![0].handler
|
|
|
|
const mockDoc: TICCompanyDocument = {
|
|
companyId: 42,
|
|
registrationNumber: '5560360793',
|
|
names: [
|
|
{ nameOrIdentifier: 'Registered Name', companyNamingType: 'registeredName' },
|
|
{ nameOrIdentifier: 'Test AB', companyNamingType: 'name' },
|
|
],
|
|
legalEntityType: 'AB',
|
|
registrationDate: 0,
|
|
mostRecentRegisteredAddress: {
|
|
street: 'Storgatan 1',
|
|
postalCode: '111 22',
|
|
city: 'Stockholm',
|
|
},
|
|
isRegisteredForFTax: true,
|
|
isRegisteredForVAT: true,
|
|
activityStatus: 'active',
|
|
}
|
|
|
|
describe('TIC lookup route', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
it('returns 400 when org_number is missing', async () => {
|
|
const res = await lookupHandler(makeRequest())
|
|
expect(res.status).toBe(400)
|
|
})
|
|
|
|
it('returns 404 when company not found', async () => {
|
|
mockSearch.mockResolvedValue(null)
|
|
|
|
const res = await lookupHandler(makeRequest('000000-0000'))
|
|
expect(res.status).toBe(404)
|
|
})
|
|
|
|
it('returns full lookup result on happy path', async () => {
|
|
mockSearch.mockResolvedValue(mockDoc)
|
|
mockBank.mockResolvedValue([
|
|
{ bankAccountType: 1, accountNumber: '123-456', swift_BIC: undefined },
|
|
])
|
|
mockSNI.mockResolvedValue([
|
|
{ sni_2007Code: '62010', sni_2007Name: 'Dataprogrammering' },
|
|
])
|
|
mockEmails.mockResolvedValue([{ emailAddress: 'info@test.se' }])
|
|
mockPhones.mockResolvedValue([{ phoneNumber: '08-1234567' }])
|
|
|
|
const res = await lookupHandler(makeRequest('556036-0793'))
|
|
expect(res.status).toBe(200)
|
|
|
|
const { data } = await res.json()
|
|
expect(data.companyName).toBe('Test AB')
|
|
expect(data.isCeased).toBe(false)
|
|
expect(data.address).toEqual({
|
|
street: 'Storgatan 1',
|
|
postalCode: '111 22',
|
|
city: 'Stockholm',
|
|
})
|
|
expect(data.registration).toEqual({ fTax: true, vat: true })
|
|
expect(data.bankAccounts).toEqual([
|
|
{ type: 'bankgiro', accountNumber: '123-456', bic: null },
|
|
])
|
|
expect(data.sniCodes).toEqual([{ code: '62010', name: 'Dataprogrammering' }])
|
|
expect(data.email).toBe('info@test.se')
|
|
expect(data.phone).toBe('08-1234567')
|
|
})
|
|
|
|
it('prefers name type over other naming types', async () => {
|
|
mockSearch.mockResolvedValue(mockDoc)
|
|
mockBank.mockResolvedValue(null)
|
|
mockSNI.mockResolvedValue(null)
|
|
mockEmails.mockResolvedValue(null)
|
|
mockPhones.mockResolvedValue(null)
|
|
|
|
const res = await lookupHandler(makeRequest('556036-0793'))
|
|
const { data } = await res.json()
|
|
expect(data.companyName).toBe('Test AB')
|
|
})
|
|
|
|
it('handles partial Phase 2 failures gracefully', async () => {
|
|
mockSearch.mockResolvedValue(mockDoc)
|
|
mockBank.mockRejectedValue(new Error('timeout'))
|
|
mockSNI.mockResolvedValue([{ sni_2007Code: '62010', sni_2007Name: 'Dataprogrammering' }])
|
|
mockEmails.mockRejectedValue(new Error('timeout'))
|
|
mockPhones.mockResolvedValue(null)
|
|
|
|
const res = await lookupHandler(makeRequest('556036-0793'))
|
|
expect(res.status).toBe(200)
|
|
|
|
const { data } = await res.json()
|
|
expect(data.companyName).toBe('Test AB')
|
|
expect(data.bankAccounts).toEqual([])
|
|
expect(data.sniCodes).toHaveLength(1)
|
|
expect(data.email).toBeNull()
|
|
expect(data.phone).toBeNull()
|
|
})
|
|
|
|
it('detects ceased companies', async () => {
|
|
mockSearch.mockResolvedValue({ ...mockDoc, activityStatus: 'ceased' })
|
|
mockBank.mockResolvedValue(null)
|
|
mockSNI.mockResolvedValue(null)
|
|
mockEmails.mockResolvedValue(null)
|
|
mockPhones.mockResolvedValue(null)
|
|
|
|
const res = await lookupHandler(makeRequest('556036-0793'))
|
|
const { data } = await res.json()
|
|
expect(data.isCeased).toBe(true)
|
|
})
|
|
|
|
it('returns 503 when TIC is not configured', async () => {
|
|
mockSearch.mockRejectedValue(
|
|
new TICAPIError('TIC_API_PROXY_URL is not configured', undefined, 'NOT_CONFIGURED')
|
|
)
|
|
const res = await lookupHandler(makeRequest('556036-0793'))
|
|
expect(res.status).toBe(503)
|
|
})
|
|
|
|
it('returns 429 when TIC rate-limits us', async () => {
|
|
mockSearch.mockRejectedValue(
|
|
new TICAPIError('Rate limit exceeded', 429, 'RATE_LIMIT_EXCEEDED')
|
|
)
|
|
const res = await lookupHandler(makeRequest('556036-0793'))
|
|
expect(res.status).toBe(429)
|
|
})
|
|
|
|
it('returns 504 when TIC times out', async () => {
|
|
mockSearch.mockRejectedValue(new TICAPIError('Request timeout', undefined, 'TIMEOUT'))
|
|
const res = await lookupHandler(makeRequest('556036-0793'))
|
|
expect(res.status).toBe(504)
|
|
})
|
|
|
|
it('returns 400 when upstream rejects the org number (4xx)', async () => {
|
|
mockSearch.mockRejectedValue(new TICAPIError('TIC API error: Bad Request', 400))
|
|
const res = await lookupHandler(makeRequest('1234567-1234'))
|
|
expect(res.status).toBe(400)
|
|
})
|
|
|
|
it('returns 502 when upstream returns 5xx', async () => {
|
|
mockSearch.mockRejectedValue(new TICAPIError('TIC API error: Bad Gateway', 502))
|
|
const res = await lookupHandler(makeRequest('556036-0793'))
|
|
expect(res.status).toBe(502)
|
|
})
|
|
|
|
it('returns 502 when fetch fails (network error)', async () => {
|
|
mockSearch.mockRejectedValue(new TICAPIError('Failed to fetch from TIC: ECONNRESET'))
|
|
const res = await lookupHandler(makeRequest('556036-0793'))
|
|
expect(res.status).toBe(502)
|
|
})
|
|
|
|
it('returns 500 for non-TICAPIError unexpected errors', async () => {
|
|
mockSearch.mockRejectedValue(new Error('boom'))
|
|
const res = await lookupHandler(makeRequest('556036-0793'))
|
|
expect(res.status).toBe(500)
|
|
})
|
|
})
|