Mattsson
a1a816b4a5
* Implement company and account deletion features - Add event types for company and account deletion to CoreEvent. - Enhance Supabase middleware to handle company context resolution and cookie management for archived companies. - Create API routes for deleting accounts and companies, including necessary validations and event emissions. - Implement tests for account and company deletion endpoints to ensure proper functionality and error handling. - Add retention notice component to inform users about bookkeeping data retention during destructive actions. - Create database migrations to support soft deletion of companies and anonymization of user accounts, ensuring compliance with retention laws. * feat: enhance account deletion process and update user notifications * Add service client for onboarding completion check and update escape hatch visibility * Enhance invite flow and email handling for company members * Refactor company context and RLS policies for active company isolation - Update `switchCompany` to remove unnecessary revalidation as client handles navigation. - Revise `getActiveCompanyId` to prioritize `user_preferences` and validate against non-archived memberships. - Modify `setActiveCompany` to ensure `user_preferences` is the authoritative source while maintaining cookie compatibility. - Enhance middleware to resolve active company using `user_preferences` and fallback to first non-archived membership. - Introduce new API route `/api/company/current` to fetch the active company ID for cross-tab synchronization. - Implement `CompanyTabSync` component for real-time active company enforcement across tabs. - Create migration for RLS policies to enforce single-active-company isolation using `current_active_company_id()`. * feat: implement viewer role enforcement for write permissions - Added `useCanWrite` hook to determine if the current user has write permissions based on their role in the active company. - Updated various components (JournalEntryForm, CustomerForm, DeadlineForm, etc.) to disable write actions and show a lock icon with a tooltip for users without write permissions. - Introduced `requireWritePermission` function to enforce write permissions at the API level, returning a 403 response for viewers. - Created tests to verify the behavior of the viewer role and write permissions. - Added database migration to enforce read-only access for viewers at the database level.
120 lines
4.7 KiB
TypeScript
120 lines
4.7 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import {
|
|
parseJsonResponse,
|
|
createMockRouteParams,
|
|
createQueuedMockSupabase,
|
|
makeTransaction,
|
|
} from '@/tests/helpers'
|
|
|
|
const { supabase: mockSupabase, enqueue, reset } = createQueuedMockSupabase()
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createClient: () => Promise.resolve(mockSupabase),
|
|
}))
|
|
|
|
vi.mock('@/lib/company/context', () => ({
|
|
requireCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
getActiveCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
}))
|
|
|
|
vi.mock('@/lib/auth/require-write', () => ({
|
|
requireWritePermission: vi.fn().mockResolvedValue({ ok: true }),
|
|
}))
|
|
|
|
import { DELETE } from '../route'
|
|
|
|
describe('DELETE /api/transactions/[id]', () => {
|
|
const mockUser = { id: 'user-1', email: 'test@test.se' }
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
reset()
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: mockUser } })
|
|
})
|
|
|
|
it('returns 401 when not authenticated', async () => {
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: null } })
|
|
|
|
const request = new Request('http://localhost/api/transactions/tx-1', { method: 'DELETE' })
|
|
const response = await DELETE(request, createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse(response)
|
|
|
|
expect(status).toBe(401)
|
|
expect(body).toEqual({ error: 'Unauthorized' })
|
|
})
|
|
|
|
it('returns 404 when transaction not found', async () => {
|
|
enqueue({ data: null, error: { message: 'Not found' } })
|
|
|
|
const request = new Request('http://localhost/api/transactions/tx-1', { method: 'DELETE' })
|
|
const response = await DELETE(request, createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse(response)
|
|
|
|
expect(status).toBe(404)
|
|
expect(body).toEqual({ error: 'Transaction not found' })
|
|
})
|
|
|
|
it('returns 409 when transaction has a journal entry', async () => {
|
|
const tx = makeTransaction({ journal_entry_id: 'je-1', bank_connection_id: null, import_source: null })
|
|
enqueue({ data: tx, error: null })
|
|
|
|
const request = new Request('http://localhost/api/transactions/tx-1', { method: 'DELETE' })
|
|
const response = await DELETE(request, createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse<{ error: string }>(response)
|
|
|
|
expect(status).toBe(409)
|
|
expect(body.error).toContain('booked')
|
|
})
|
|
|
|
it('allows deleting unbooked bank-synced transactions', async () => {
|
|
const tx = makeTransaction({ bank_connection_id: 'bc-1', journal_entry_id: null, import_source: null })
|
|
enqueue({ data: tx, error: null }) // fetch
|
|
enqueue({ data: null, error: null }) // delete
|
|
|
|
const request = new Request('http://localhost/api/transactions/tx-1', { method: 'DELETE' })
|
|
const response = await DELETE(request, createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse(response)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body).toEqual({ success: true })
|
|
})
|
|
|
|
it('allows deleting unbooked imported transactions', async () => {
|
|
const tx = makeTransaction({ import_source: 'csv_nordea', journal_entry_id: null, bank_connection_id: null })
|
|
enqueue({ data: tx, error: null }) // fetch
|
|
enqueue({ data: null, error: null }) // delete
|
|
|
|
const request = new Request('http://localhost/api/transactions/tx-1', { method: 'DELETE' })
|
|
const response = await DELETE(request, createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse(response)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body).toEqual({ success: true })
|
|
})
|
|
|
|
it('deletes a manually added unbooked transaction', async () => {
|
|
const tx = makeTransaction({ journal_entry_id: null, bank_connection_id: null, import_source: null })
|
|
enqueue({ data: tx, error: null }) // fetch
|
|
enqueue({ data: null, error: null }) // delete
|
|
|
|
const request = new Request('http://localhost/api/transactions/tx-1', { method: 'DELETE' })
|
|
const response = await DELETE(request, createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse(response)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body).toEqual({ success: true })
|
|
})
|
|
|
|
it('returns 500 when deletion fails', async () => {
|
|
const tx = makeTransaction({ journal_entry_id: null, bank_connection_id: null, import_source: null })
|
|
enqueue({ data: tx, error: null }) // fetch
|
|
enqueue({ data: null, error: { message: 'DB error' } }) // delete fails
|
|
|
|
const request = new Request('http://localhost/api/transactions/tx-1', { method: 'DELETE' })
|
|
const response = await DELETE(request, createMockRouteParams({ id: 'tx-1' }))
|
|
const { status, body } = await parseJsonResponse(response)
|
|
|
|
expect(status).toBe(500)
|
|
expect(body).toEqual({ error: 'Failed to delete transaction' })
|
|
})
|
|
})
|