* fix(underlag): a verifikat a customer invoice points at is backed by it; PS follows the invoice link (#2298) The invoice-to-verifikat link is written on the invoice side only (invoices.journal_entry_id, invoice_payments.journal_entry_id), while the missing-underlag predicate and the periodisk sammanstallning resolved the invoice from the entry's own source columns. A SIE-imported sale matched to its invoice afterwards therefore kept warning "Underlag saknas" and was left out of the EU sales list, although the account-based momsdeklaration showed it and the verifikat page already listed the invoice as its underlag. - verifikat_without_documents / transactions_without_documents: customer- invoice hanvisning arm (BFL 5 kap 7 §), tenant-scoped on the link row; new migration 20260906135702, pinned by a pg-real test. - getInvoiceReferencesForJournalEntries(): one TS mirror of that arm, used by the journal-list filter and bulk exempt, /api/documents/counts (new invoice_references map) and the transactions list; the push cron mirrors it with its global reads. - Journal list: no "Underlag saknas" chip for a covered entry, matching the engine's own invoice rows and the verifikat detail page. - Periodisk sammanstallning: entries fetched by their EU-revenue lines and attributed through every link (engine source_id, invoices.journal_entry_id, invoice_payments.journal_entry_id); kontantmetod invoice_cash_payment entries are filed too, which the old source_type filter dropped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019SaJfqNi4VmsG8FMKq99G6 * fix(underlag): issued invoices only, blocking mixed-customer settlements in PS, chunk-level degrade (#2298 review) - The customer-invoice hanvisning arms (RPCs, both TS resolvers, push cron) now require an ISSUED invoice: status not in ('draft', 'cancelled'), the schema's own definition (migration 20260427150000). NON_ISSUED_INVOICE_ STATUSES in lib/invoices/matchable-statuses.ts is the shared constant; the pg test pins a draft-linked and a cancelled-payment entry as still missing. - Periodisk sammanstallning: one verifikat linked to invoices of different customers is no longer attributed to the first invoice; it is left out of the accumulators and reported once as a blocking MIXED_CUSTOMER_SETTLEMENT naming the voucher, the customer count and the amount. Same-customer settlements are filed in full. - Transactions list: a failed invoice-reference lookup leaves that chunk's verdict unknown (no badges) and continues with the remaining chunks instead of abandoning them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
164 lines
7.3 KiB
TypeScript
164 lines
7.3 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { parseJsonResponse, createQueuedMockSupabase } from '@/tests/helpers'
|
|
import { NextResponse } from 'next/server'
|
|
|
|
const { supabase: mockSupabase, enqueue, reset } = createQueuedMockSupabase()
|
|
|
|
vi.mock('@/lib/auth/require-auth', () => ({ requireAuth: vi.fn() }))
|
|
vi.mock('@/lib/company/context', () => ({ getActiveCompanyId: vi.fn() }))
|
|
vi.mock('@/lib/auth/require-write', () => ({ requireWritePermission: vi.fn() }))
|
|
|
|
import { POST } from '../route'
|
|
import { requireAuth } from '@/lib/auth/require-auth'
|
|
import { getActiveCompanyId } from '@/lib/company/context'
|
|
import { requireWritePermission } from '@/lib/auth/require-write'
|
|
|
|
const mockUser = { id: 'user-1', email: 't@t.se' }
|
|
|
|
function makeReq(body: unknown) {
|
|
return new Request('http://localhost/api/bookkeeping/no-doc-required/bulk-missing', {
|
|
method: 'POST',
|
|
headers: { 'content-type': 'application/json' },
|
|
body: JSON.stringify(body),
|
|
})
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
reset()
|
|
;(requireAuth as ReturnType<typeof vi.fn>).mockResolvedValue({ user: mockUser, supabase: mockSupabase })
|
|
;(getActiveCompanyId as ReturnType<typeof vi.fn>).mockResolvedValue('company-1')
|
|
;(requireWritePermission as ReturnType<typeof vi.fn>).mockResolvedValue({ ok: true })
|
|
})
|
|
|
|
describe('POST /api/bookkeeping/no-doc-required/bulk-missing', () => {
|
|
it('returns 401 when not authenticated', async () => {
|
|
;(requireAuth as ReturnType<typeof vi.fn>).mockResolvedValue({
|
|
error: NextResponse.json({ error: 'Unauthorized' }, { status: 401 }),
|
|
})
|
|
const res = await POST(makeReq({}))
|
|
expect((await parseJsonResponse(res)).status).toBe(401)
|
|
})
|
|
|
|
it('returns 403 for read-only members', async () => {
|
|
;(requireWritePermission as ReturnType<typeof vi.fn>).mockResolvedValue({
|
|
ok: false,
|
|
response: NextResponse.json({ error: 'forbidden' }, { status: 403 }),
|
|
})
|
|
const res = await POST(makeReq({}))
|
|
expect((await parseJsonResponse(res)).status).toBe(403)
|
|
})
|
|
|
|
it('returns 400 for a non-uuid period_id', async () => {
|
|
const res = await POST(makeReq({ period_id: 'not-a-uuid' }))
|
|
expect((await parseJsonResponse(res)).status).toBe(400)
|
|
})
|
|
|
|
it('returns 400 for a shaped-but-invalid date', async () => {
|
|
const res = await POST(makeReq({ date_from: '9999-99-99' }))
|
|
expect((await parseJsonResponse(res)).status).toBe(400)
|
|
})
|
|
|
|
it('returns 400 for an invalid series filter', async () => {
|
|
const res = await POST(makeReq({ series: 'all' }))
|
|
expect((await parseJsonResponse(res)).status).toBe(400)
|
|
})
|
|
|
|
// Queue order per candidate chunk mirrors resolveMissingUnderlagEntries:
|
|
// documents, SI references, SI payment-row references, exemptions, then the
|
|
// customer-invoice resolver (invoices by journal_entry_id, invoice_payments).
|
|
it('dry_run counts only entries that are missing AND not exempt', async () => {
|
|
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }], error: null }) // candidates
|
|
enqueue({ data: [{ journal_entry_id: 'a' }], error: null }) // a has a document
|
|
enqueue({ data: [], error: null }) // no SI references with docs
|
|
enqueue({ data: [], error: null }) // no SI payment-row references
|
|
enqueue({ data: [{ journal_entry_id: 'b' }], error: null }) // b already exempt
|
|
enqueue({ data: [], error: null }) // no invoices pointing at the entries
|
|
enqueue({ data: [], error: null }) // no invoice payment rows
|
|
const res = await POST(makeReq({ dry_run: true }))
|
|
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
|
|
expect(status).toBe(200)
|
|
expect(body.data.count).toBe(1) // only c
|
|
})
|
|
|
|
it('dry_run excludes entries covered by a supplier-invoice reference with an anchored doc', async () => {
|
|
// a: covered via supplier_invoices.registration_journal_entry_id
|
|
// b: covered via a supplier_invoice_payments row whose SI has an anchored doc
|
|
// c: genuinely missing
|
|
// d: SI reference exists but its doc is UNANCHORED (deletable) → still missing
|
|
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }, { id: 'd' }], error: null }) // candidates
|
|
enqueue({ data: [], error: null }) // no direct documents
|
|
enqueue({
|
|
data: [
|
|
{
|
|
registration_journal_entry_id: 'a',
|
|
payment_journal_entry_id: null,
|
|
document: { journal_entry_id: 'a' },
|
|
},
|
|
{
|
|
registration_journal_entry_id: 'd',
|
|
payment_journal_entry_id: null,
|
|
document: { journal_entry_id: null },
|
|
},
|
|
],
|
|
error: null,
|
|
})
|
|
enqueue({
|
|
data: [
|
|
{
|
|
journal_entry_id: 'b',
|
|
supplier_invoice: { document_id: 'doc-1', document: { journal_entry_id: 'x' } },
|
|
},
|
|
],
|
|
error: null,
|
|
})
|
|
enqueue({ data: [], error: null }) // no exemptions
|
|
enqueue({ data: [], error: null }) // no invoices pointing at the entries
|
|
enqueue({ data: [], error: null }) // no invoice payment rows
|
|
const res = await POST(makeReq({ dry_run: true }))
|
|
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
|
|
expect(status).toBe(200)
|
|
expect(body.data.count).toBe(2) // c and d
|
|
})
|
|
|
|
it('dry_run excludes entries a customer invoice points at (#2298)', async () => {
|
|
// a: the invoice register links it directly (invoices.journal_entry_id)
|
|
// b: a SIE-imported voucher matched to an invoice (invoice_payments row)
|
|
// c: genuinely missing
|
|
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }], error: null }) // candidates
|
|
enqueue({ data: [], error: null }) // no direct documents
|
|
enqueue({ data: [], error: null }) // no SI references
|
|
enqueue({ data: [], error: null }) // no SI payment-row references
|
|
enqueue({ data: [], error: null }) // no exemptions
|
|
enqueue({ data: [{ id: 'inv-1', journal_entry_id: 'a' }], error: null })
|
|
enqueue({ data: [{ id: 'pay-1', invoice_id: 'inv-2', journal_entry_id: 'b' }], error: null })
|
|
const res = await POST(makeReq({ dry_run: true }), { params: Promise.resolve({}) })
|
|
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
|
|
expect(status).toBe(200)
|
|
expect(body.data.count).toBe(1) // only c
|
|
})
|
|
|
|
it('marks the missing entries and returns the count', async () => {
|
|
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }], error: null }) // candidates
|
|
enqueue({ data: [], error: null }) // no documents
|
|
enqueue({ data: [], error: null }) // no SI references with docs
|
|
enqueue({ data: [], error: null }) // no SI payment-row references
|
|
enqueue({ data: [{ journal_entry_id: 'a' }], error: null }) // a already exempt
|
|
enqueue({ data: [], error: null }) // no invoices pointing at the entries
|
|
enqueue({ data: [], error: null }) // no invoice payment rows
|
|
enqueue({ error: null }) // helper upsert
|
|
const res = await POST(makeReq({ period_id: null, reason: 'Importerad' }))
|
|
const { status, body } = await parseJsonResponse<{ data: { exempted: number } }>(res)
|
|
expect(status).toBe(200)
|
|
expect(body.data.exempted).toBe(2) // b and c
|
|
})
|
|
|
|
it('short-circuits to 0 when no candidates match the filters', async () => {
|
|
enqueue({ data: [], error: null }) // no candidates
|
|
const res = await POST(makeReq({ dry_run: true }))
|
|
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
|
|
expect(status).toBe(200)
|
|
expect(body.data.count).toBe(0)
|
|
})
|
|
})
|