Files
accounted/extensions/general/enable-banking/components/AccountPickerDialog.tsx
T
Jakob WennbergandClaude Sonnet 5 ec27228a8e style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)
Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.

Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.

Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.

Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-04 15:58:06 +02:00

654 lines
25 KiB
TypeScript

'use client'
import { useEffect, useMemo, useState } from 'react'
import Link from 'next/link'
import {
Dialog,
DialogContent,
DialogDescription,
DialogFooter,
DialogHeader,
DialogTitle,
} from '@/components/ui/dialog'
import { Button } from '@/components/ui/button'
import { Checkbox } from '@/components/ui/checkbox'
import { Input } from '@/components/ui/input'
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from '@/components/ui/select'
import { useToast } from '@/components/ui/use-toast'
import { Loader2 } from 'lucide-react'
import { createClient } from '@/lib/supabase/client'
import { useCompany } from '@/contexts/CompanyContext'
import {
getCurrentFiscalYearStart,
getPreviousFiscalYearStart,
daysBetween,
} from '@/lib/company/fiscal-year'
import type { CompanySettings } from '@/types'
import type { StoredAccount } from '../types'
import {
BankSyncProgressDialog,
type SyncProgressState,
} from './BankSyncProgressDialog'
interface AccountPickerDialogProps {
open: boolean
onOpenChange: (open: boolean) => void
connectionId: string
bankName: string
accounts: StoredAccount[]
// True when the connection is still in pending_selection: closing without
// saving is allowed but the user is reminded that no sync runs until they
// confirm.
isInitialSelection: boolean
onSaved: () => void
}
interface ChartAccount {
account_number: string
account_name: string
}
type LookbackMode = 'fast' | 'fiscal-year' | 'custom'
type CustomSubMode = 'date' | 'previous-fiscal-year'
// Suggested BAS account per currency. The mapping engine falls back to 1930
// when ledger_account is unset, so the SEK case is just an explicit hint.
// Foreign-currency accounts default to the BAS-recommended numbers; if the
// company hasn't created them yet, the user must pick or seed them first.
const CURRENCY_DEFAULTS: Record<string, string> = {
SEK: '1930',
EUR: '1932',
USD: '1933',
GBP: '1934',
}
export function AccountPickerDialog({
open,
onOpenChange,
connectionId,
bankName,
accounts,
isInitialSelection,
onSaved,
}: AccountPickerDialogProps) {
const { toast } = useToast()
// Memoise so the client has a stable reference across re-renders. Without this,
// listing `supabase` in the SIE-fetch effect's deps would re-fire that query on
// every checkbox tick or parent re-render.
const supabase = useMemo(() => createClient(), [])
const { company } = useCompany()
const [selected, setSelected] = useState<Set<string>>(new Set())
const [isSaving, setIsSaving] = useState(false)
const [sieLastDate, setSieLastDate] = useState<string | null>(null)
const [chartAccounts, setChartAccounts] = useState<ChartAccount[]>([])
const [ledgerByUid, setLedgerByUid] = useState<Record<string, string>>({})
const [companySettings, setCompanySettings] = useState<Pick<CompanySettings, 'fiscal_year_start_month' | 'entity_type'> | null>(null)
const [lookbackMode, setLookbackMode] = useState<LookbackMode>('fiscal-year')
const [customSubMode, setCustomSubMode] = useState<CustomSubMode>('date')
const [customDate, setCustomDate] = useState<string>('')
const [progressOpen, setProgressOpen] = useState(false)
const [progressState, setProgressState] = useState<SyncProgressState>({ kind: 'syncing' })
useEffect(() => {
if (open) {
const initial = new Set<string>(
accounts.filter(a => a.enabled !== false).map(a => a.uid)
)
setSelected(initial)
setLookbackMode('fiscal-year')
setCustomSubMode('date')
setCustomDate('')
// Pre-populate ledger picks from existing StoredAccount values, falling
// back to currency-based suggestions for accounts the user hasn't mapped yet.
const initialLedger: Record<string, string> = {}
for (const a of accounts) {
const fromStored = a.ledger_account
const fromDefault = CURRENCY_DEFAULTS[a.currency] ?? ''
initialLedger[a.uid] = fromStored ?? fromDefault
}
setLedgerByUid(initialLedger)
}
}, [open, accounts])
// Load fiscal_year_start_month + entity_type so "Sedan räkenskapsårets början"
// resolves to the right date for non-calendar fiscal years.
useEffect(() => {
if (!open || !company?.id) return
let cancelled = false
;(async () => {
const { data } = await supabase
.from('company_settings')
.select('fiscal_year_start_month, entity_type')
.eq('company_id', company.id)
.maybeSingle()
if (cancelled) return
setCompanySettings((data as { fiscal_year_start_month?: number; entity_type?: CompanySettings['entity_type'] } | null) as Pick<CompanySettings, 'fiscal_year_start_month' | 'entity_type'> | null)
})()
return () => { cancelled = true }
}, [open, company?.id, supabase])
// Fetch the latest SIE import end date so we can offer "day after last SIE entry"
// as a one-click escape from the default fiscal-year start. Only matters on the
// initial activation flow: selection edits don't re-run sync.
useEffect(() => {
if (!open || !isInitialSelection || !company?.id) {
setSieLastDate(null)
return
}
let cancelled = false
;(async () => {
const { data } = await supabase
.from('sie_imports')
.select('fiscal_year_end')
.eq('company_id', company.id)
.eq('status', 'completed')
.order('fiscal_year_end', { ascending: false })
.limit(1)
.maybeSingle()
if (cancelled) return
setSieLastDate((data as { fiscal_year_end?: string } | null)?.fiscal_year_end || null)
})()
return () => { cancelled = true }
}, [open, isInitialSelection, company?.id, supabase])
// Load 19xx accounts from the chart for the per-account ledger combobox.
// Class 19 = bank/cash on the BAS chart.
useEffect(() => {
if (!open || !company?.id) return
let cancelled = false
;(async () => {
const { data } = await supabase
.from('chart_of_accounts')
.select('account_number, account_name')
.eq('company_id', company.id)
.like('account_number', '19%')
.order('account_number', { ascending: true })
if (cancelled) return
setChartAccounts((data as ChartAccount[] | null) || [])
})()
return () => { cancelled = true }
}, [open, company?.id, supabase])
const allSelected = accounts.length > 0 && selected.size === accounts.length
const noneSelected = selected.size === 0
const sortedAccounts = useMemo(
() => [...accounts].sort((a, b) => (a.name || a.iban || '').localeCompare(b.name || b.iban || '')),
[accounts]
)
// Detect cases where the user routed two enabled accounts with different
// currencies to the same BAS account, usually a mistake, but allowed.
const currencyConflicts = useMemo(() => {
const byLedger = new Map<string, Set<string>>()
for (const a of accounts) {
if (!selected.has(a.uid)) continue
const ledger = ledgerByUid[a.uid]
if (!ledger) continue
if (!byLedger.has(ledger)) byLedger.set(ledger, new Set())
byLedger.get(ledger)!.add(a.currency)
}
return Array.from(byLedger.entries())
.filter(([, currencies]) => currencies.size > 1)
.map(([ledger, currencies]) => ({ ledger, currencies: Array.from(currencies) }))
}, [accounts, selected, ledgerByUid])
function toggle(uid: string) {
setSelected(prev => {
const next = new Set(prev)
if (next.has(uid)) next.delete(uid)
else next.add(uid)
return next
})
}
function selectAll() {
setSelected(new Set(accounts.map(a => a.uid)))
}
function selectNone() {
setSelected(new Set())
}
async function handleSave() {
if (noneSelected) {
toast({
title: 'Välj minst ett konto',
description: 'Avmarkera alla konton och koppla bort banken istället om inga konton ska synkas.',
variant: 'destructive',
})
return
}
// Block save when any enabled account has no ledger picked. The currency
// defaults cover SEK/EUR/USD/GBP; other currencies require an explicit pick.
const missingLedger = accounts.filter(a => selected.has(a.uid) && !ledgerByUid[a.uid])
if (missingLedger.length > 0) {
toast({
title: 'Välj bokföringskonto',
description: `Saknar bokföringskonto för: ${missingLedger.map(a => a.name || a.iban || a.uid).join(', ')}`,
variant: 'destructive',
})
return
}
// Block save when the user picked "Anpassat datum" but left the date blank.
// Without this guard, lookback.body is null and the PATCH would silently
// fall back to the backend's 120-day default, not what the user asked for.
if (
isInitialSelection &&
lookbackMode === 'custom' &&
customSubMode === 'date' &&
!lookback.body
) {
toast({
title: 'Ange startdatum',
description: 'Välj ett datum för att hämta historik, eller välj ett annat alternativ.',
variant: 'destructive',
})
return
}
setIsSaving(true)
// For the initial-selection path, open the progress modal up-front so the
// user has visible feedback during the 30-60s backfill. Selection edits
// (no backfill) keep the existing toast-only feedback.
if (isInitialSelection) {
setProgressState({ kind: 'syncing' })
setProgressOpen(true)
onOpenChange(false)
}
try {
// Send a mapping entry per selected account. Account_mappings doesn't
// include disabled accounts: their existing ledger_account stays untouched.
const account_mappings = Array.from(selected).map(uid => ({
uid,
ledger_account: ledgerByUid[uid] || null,
}))
const response = await fetch('/api/extensions/ext/enable-banking/accounts', {
method: 'PATCH',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
connection_id: connectionId,
enabled_uids: Array.from(selected),
account_mappings,
...(isInitialSelection && lookback.body ? lookback.body : {}),
}),
})
const data = await response.json()
if (!response.ok) {
throw new Error(data.error || 'Kunde inte spara kontoval')
}
if (isInitialSelection && data.initial_sync) {
setProgressState({ kind: 'done', summary: data.initial_sync })
} else if (isInitialSelection && data.initial_sync_error) {
setProgressState({
kind: 'failed',
error: { message: 'Vi sparade kontovalet men kunde inte hämta transaktioner just nu. Vi försöker igen vid nästa körning.' },
})
} else {
toast({
title: 'Kontoval sparat',
description: `${data.enabled_count} av ${data.total_count} konton kommer synkas.`,
})
onOpenChange(false)
}
onSaved()
} catch (error) {
const message = error instanceof Error ? error.message : 'Kunde inte spara kontoval'
if (isInitialSelection) {
setProgressState({ kind: 'failed', error: { message } })
} else {
toast({
title: 'Fel',
description: message,
variant: 'destructive',
})
}
} finally {
setIsSaving(false)
}
}
const dayAfterSie = useMemo(() => {
if (!sieLastDate) return null
const d = new Date(sieLastDate)
d.setDate(d.getDate() + 1)
return d.toISOString().split('T')[0]
}, [sieLastDate])
const fiscalYearStart = useMemo(
() => getCurrentFiscalYearStart(companySettings),
[companySettings],
)
const previousFiscalYearStart = useMemo(
() => getPreviousFiscalYearStart(companySettings),
[companySettings],
)
// Resolve mode → concrete request payload and a "resolved from-date" for display.
const lookback = useMemo(() => {
if (lookbackMode === 'fast') {
return { body: { initial_lookback_days: 90 }, fromDate: null as string | null, days: 90 }
}
if (lookbackMode === 'fiscal-year') {
return { body: { initial_lookback_from_date: fiscalYearStart }, fromDate: fiscalYearStart, days: daysBetween(fiscalYearStart) }
}
// custom
const date = customSubMode === 'previous-fiscal-year' ? previousFiscalYearStart : customDate
if (date && /^\d{4}-\d{2}-\d{2}$/.test(date)) {
return { body: { initial_lookback_from_date: date }, fromDate: date, days: daysBetween(date) }
}
return { body: null as Record<string, string | number> | null, fromDate: null as string | null, days: 0 }
}, [lookbackMode, customSubMode, customDate, fiscalYearStart, previousFiscalYearStart])
const showLongRangeHelper = lookback.days > 90
return (
<>
<BankSyncProgressDialog
open={progressOpen}
onOpenChange={(next) => {
setProgressOpen(next)
// When the user closes the summary, propagate the saved/refresh
// signal to the parent (it would have been emitted on success earlier;
// this just guards the failure case where we still want a refresh).
if (!next) onSaved()
}}
bankName={bankName}
accounts={accounts.filter((a) => selected.has(a.uid))}
state={progressState}
/>
<Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="max-w-2xl">
<DialogHeader>
<DialogTitle>Välj konton att synka: {bankName}</DialogTitle>
<DialogDescription>
{isInitialSelection
? 'Banken har gett åtkomst till följande konton. Avmarkera de konton du inte vill synka transaktioner från, och välj vilket bokföringskonto varje konto ska bokföras mot. Inga transaktioner hämtas innan du sparar.'
: 'Justera vilka konton som ska synkas och vilka bokföringskonton de bokförs mot. Konton du avmarkerar slutar synkas från nästa körning; redan importerade transaktioner ligger kvar.'}
</DialogDescription>
</DialogHeader>
{isInitialSelection && (
<div className="space-y-3 rounded-lg border border-border bg-muted/30 p-4 text-sm">
<div>
<label className="block text-xs font-medium uppercase tracking-wider text-muted-foreground">
Hämta historik från
</label>
<p className="mt-1 text-xs text-muted-foreground">
Vi börjar hämta transaktioner från det datum du väljer. Du behöver inte tänka i dagar.
</p>
</div>
{sieLastDate && dayAfterSie && (
<div className="flex items-start justify-between gap-3 rounded-md border border-border bg-background/60 p-3">
<p className="text-xs text-muted-foreground">
Senaste SIE-importen täcker till{' '}
<span className="font-medium tabular-nums text-foreground">{sieLastDate}</span>.
Vi föreslår{' '}
<span className="font-medium tabular-nums text-foreground">{dayAfterSie}</span>{' '}
som startdatum så inget överlappar din bokföring.
</p>
<button
type="button"
className="shrink-0 text-xs text-foreground underline underline-offset-2"
onClick={() => {
setLookbackMode('custom')
setCustomSubMode('date')
setCustomDate(dayAfterSie)
}}
disabled={isSaving}
>
Använd detta datum
</button>
</div>
)}
<div className="space-y-2">
<label className="flex cursor-pointer items-start gap-2">
<input
type="radio"
name="lookback-mode"
value="fast"
checked={lookbackMode === 'fast'}
onChange={() => setLookbackMode('fast')}
disabled={isSaving}
className="mt-1"
/>
<span>
<span className="block">Senaste 90 dagar <span className="text-muted-foreground">(snabbt)</span></span>
</span>
</label>
<label className="flex cursor-pointer items-start gap-2">
<input
type="radio"
name="lookback-mode"
value="fiscal-year"
checked={lookbackMode === 'fiscal-year'}
onChange={() => setLookbackMode('fiscal-year')}
disabled={isSaving}
className="mt-1"
/>
<span>
<span className="block">Sedan räkenskapsårets början</span>
<span className="text-xs text-muted-foreground tabular-nums">
från {fiscalYearStart}
</span>
</span>
</label>
<label className="flex cursor-pointer items-start gap-2">
<input
type="radio"
name="lookback-mode"
value="custom"
checked={lookbackMode === 'custom'}
onChange={() => setLookbackMode('custom')}
disabled={isSaving}
className="mt-1"
/>
<span className="flex-1">
<span className="block">Anpassat datum</span>
{lookbackMode === 'custom' && (
<div className="mt-2 space-y-2">
<Select
value={customSubMode}
onValueChange={(v) => setCustomSubMode(v as CustomSubMode)}
disabled={isSaving}
>
<SelectTrigger className="w-full">
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectItem value="date">Specifikt datum</SelectItem>
<SelectItem value="previous-fiscal-year">
Föregående räkenskapsårets start ({previousFiscalYearStart})
</SelectItem>
</SelectContent>
</Select>
{customSubMode === 'date' && (
<Input
type="date"
value={customDate}
onChange={(e) => setCustomDate(e.target.value)}
max={new Date().toISOString().split('T')[0]}
min={new Date(Date.now() - 365 * 24 * 60 * 60 * 1000).toISOString().split('T')[0]}
disabled={isSaving}
className="tabular-nums"
/>
)}
</div>
)}
</span>
</label>
</div>
{showLongRangeHelper && (
<p className="text-xs text-muted-foreground">
Din bank returnerar oftast max 90 dagar. Behöver du äldre transaktioner kan du{' '}
<Link
href="/import?mode=sie"
className="text-foreground underline underline-offset-2"
>
importera via SIE eller bankfil
</Link>
. Vi visar exakt vad banken returnerade efter sparat val.
</p>
)}
</div>
)}
<div className="flex items-center justify-between text-xs text-muted-foreground">
<span>
{selected.size} av {accounts.length} valda
</span>
<div className="flex gap-2">
<button
type="button"
onClick={selectAll}
disabled={allSelected || isSaving}
className="underline-offset-2 hover:underline disabled:opacity-50 disabled:no-underline"
>
Markera alla
</button>
<span aria-hidden>·</span>
<button
type="button"
onClick={selectNone}
disabled={noneSelected || isSaving}
className="underline-offset-2 hover:underline disabled:opacity-50 disabled:no-underline"
>
Avmarkera alla
</button>
</div>
</div>
{currencyConflicts.length > 0 && (
<div className="rounded-lg border border-border bg-muted/30 p-3 text-xs text-muted-foreground">
Varning: samma bokföringskonto används för flera valutor:
{currencyConflicts.map(c => ` ${c.ledger} (${c.currencies.join(', ')})`).join(';')}.
Det fungerar tekniskt men gör årsskifte med valutaomvärdering svårare.
</div>
)}
<div className="max-h-[50vh] overflow-y-auto rounded-lg border border-border divide-y divide-border">
{sortedAccounts.map(account => {
const isChecked = selected.has(account.uid)
const ledger = ledgerByUid[account.uid] || ''
const ledgerExistsInChart = chartAccounts.some(c => c.account_number === ledger)
return (
<div
key={account.uid}
className="flex items-center gap-3 p-3 hover:bg-muted/50"
>
{/* Toggle area: label + Checkbox (a Radix Checkbox renders as
its own <button role="checkbox">, so wrapping it in another
<button> would be nested interactive elements: invalid HTML
that browsers silently flatten and breaks event routing). */}
<label className="flex flex-1 min-w-0 cursor-pointer items-center gap-3">
<Checkbox
checked={isChecked}
onCheckedChange={() => toggle(account.uid)}
disabled={isSaving}
/>
<div className="flex-1 min-w-0">
<p className="text-sm font-medium truncate">
{account.name || account.iban || 'Okänt konto'}
<span className="ml-2 text-xs font-normal text-muted-foreground">
{account.currency}
</span>
</p>
{account.iban && (
<p className="text-xs text-muted-foreground tabular-nums">
{account.iban.replace(/(.{4})/g, '$1 ').trim()}
</p>
)}
</div>
{account.balance !== undefined && (
<p className="text-sm font-medium tabular-nums shrink-0">
{new Intl.NumberFormat('sv-SE', {
style: 'currency',
currency: account.currency,
}).format(account.balance)}
</p>
)}
</label>
{/* Ledger picker is a sibling of the label, not inside it:
otherwise clicking the Select would also toggle the checkbox. */}
<div className="w-44 shrink-0">
{isChecked && (
<Select
value={ledger}
onValueChange={(v) => setLedgerByUid(prev => ({ ...prev, [account.uid]: v }))}
disabled={isSaving}
>
<SelectTrigger className="w-full">
<SelectValue placeholder="Välj konto…" />
</SelectTrigger>
<SelectContent>
{/* Surface a non-existent default so the user can see/correct it. */}
{ledger && !ledgerExistsInChart && (
<SelectItem value={ledger} disabled>
{ledger}: finns ej i kontoplan
</SelectItem>
)}
{chartAccounts.map(acc => (
<SelectItem key={acc.account_number} value={acc.account_number}>
<span className="tabular-nums">{acc.account_number}</span> {acc.account_name}
</SelectItem>
))}
</SelectContent>
</Select>
)}
</div>
</div>
)
})}
</div>
<DialogFooter>
<Button
type="button"
variant="outline"
onClick={() => onOpenChange(false)}
disabled={isSaving}
>
Avbryt
</Button>
<Button type="button" onClick={handleSave} disabled={isSaving || noneSelected}>
{isSaving ? (
<>
<Loader2 className="mr-2 h-4 w-4 animate-spin" />
{isInitialSelection ? 'Sparar och hämtar transaktioner…' : 'Sparar…'}
</>
) : (
'Spara val'
)}
</Button>
</DialogFooter>
</DialogContent>
</Dialog>
</>
)
}