* feat(onboarding): minimal input: orgnr + moms period is the whole ask
Two fixes from the third E2E attempt (2026-08-26):
1. accounting_method is now optional in CompanySetupSchema and defaults by
form in planCompanySetup: aktiebolag = accrual (the norm), enskild
firma = cash (the common small-EF choice; legal under 3 MSEK, BFL 4
kap 4 paragraf). The plan flags the default (resolved.accountingMethodDefaulted)
and gnubok_create_company's preview carries accounting_method_defaulted
so the readback names it and the user overrides in the same 'ja'.
Never silent: the preview is the checkpoint. Applies to the MCP tool
and POST /api/v1/companies (additive; response shows the resolved
value). The lookup tool's still_to_ask no longer lists it.
2. The agent refused a real orgnr because the user said 'nytt bolag' and
the registry showed an established company ('Stopp. Numret matchar
inte ett nytt bolag'): lookup instructions now state that an
established company with F-skatt/VAT is the NORMAL case (new = new to
Accounted) and the orgnr is never second-guessed for looking
established.
Skill + plugin (v1.2.1) updated; API skill regenerated; DECISIONS.md entry.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(onboarding): surface the kontantmetod 3-MSEK condition on the defaulted cash method
Compliance-review finding on #1952: the EF cash default carries a legal
eligibility condition (turnover normally under 3 MSEK, BFL 4 kap 4 §)
that a client not reading the onboarding skill would never see. The
create preview now carries accounting_method_note with the condition
whenever cash was defaulted, and the v1 pitfall states it for API
integrators. The registry cannot verify turnover, so the confirm-time
human check is the gate; the default itself stays (a brand-new EF has
zero turnover by definition).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
149 lines
5.9 KiB
TypeScript
149 lines
5.9 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { TOOL_SCOPE_MAP } from '@/lib/auth/api-keys'
|
|
import { eventBus } from '@/lib/events/bus'
|
|
|
|
const mocks = vi.hoisted(() => ({
|
|
createCompanyCore: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/company/create-company', () => ({
|
|
createCompanyCore: (...args: unknown[]) => mocks.createCompanyCore(...args),
|
|
}))
|
|
|
|
import { tools } from '../server'
|
|
import { isCompanyDependentTool } from '../company-routing'
|
|
|
|
const tool = tools.find((t) => t.name === 'gnubok_create_company')!
|
|
const TEAM_ID = '44444444-4444-4444-8444-444444444444'
|
|
const COMPANY_ID = '55555555-5555-4555-8555-555555555555'
|
|
|
|
function supabaseWithTeam(teamId: string | null) {
|
|
const chain: Record<string, ReturnType<typeof vi.fn>> = {
|
|
select: vi.fn(() => chain),
|
|
eq: vi.fn(() => chain),
|
|
order: vi.fn(() => chain),
|
|
limit: vi.fn(() => chain),
|
|
maybeSingle: vi.fn().mockResolvedValue({ data: teamId ? { team_id: teamId } : null, error: null }),
|
|
}
|
|
return {
|
|
from: vi.fn(() => chain),
|
|
rpc: vi.fn().mockResolvedValue({ data: COMPANY_ID, error: null }),
|
|
}
|
|
}
|
|
|
|
const setup = {
|
|
name: 'Testbolaget AB',
|
|
entity_type: 'aktiebolag',
|
|
org_number: '556000-0001',
|
|
vat_registered: true,
|
|
moms_period: 'quarterly',
|
|
accounting_method: 'accrual',
|
|
f_skatt: true,
|
|
}
|
|
|
|
describe('gnubok_create_company', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
eventBus.clear()
|
|
})
|
|
|
|
it('is a companies:write, company-independent write tool', () => {
|
|
expect(tool).toBeDefined()
|
|
expect(TOOL_SCOPE_MAP.gnubok_create_company).toBe('companies:write')
|
|
expect(isCompanyDependentTool('gnubok_create_company')).toBe(false)
|
|
expect(tool.annotations.readOnlyHint).toBe(false)
|
|
expect(tool.annotations.destructiveHint).toBe(false)
|
|
})
|
|
|
|
it('defaults an omitted accounting_method by form and flags it in the preview', async () => {
|
|
const supabase = supabaseWithTeam(TEAM_ID)
|
|
const { accounting_method: _dropped, ...withoutMethod } = setup
|
|
const result = (await tool.execute(withoutMethod, '', 'user-1', supabase as never)) as Record<string, unknown>
|
|
|
|
expect(result.created).toBe(false)
|
|
const preview = result.preview as Record<string, unknown>
|
|
expect(preview.accounting_method).toBe('accrual')
|
|
expect(preview.accounting_method_defaulted).toBe(true)
|
|
})
|
|
|
|
it('does not flag an explicitly chosen accounting_method as defaulted', async () => {
|
|
const supabase = supabaseWithTeam(TEAM_ID)
|
|
const result = (await tool.execute(setup, '', 'user-1', supabase as never)) as Record<string, unknown>
|
|
const preview = result.preview as Record<string, unknown>
|
|
expect(preview.accounting_method).toBe('accrual')
|
|
expect('accounting_method_defaulted' in preview).toBe(false)
|
|
})
|
|
|
|
it('previews without creating when confirm is not true', async () => {
|
|
const supabase = supabaseWithTeam(TEAM_ID)
|
|
const result = (await tool.execute(setup, '', 'user-1', supabase as never)) as Record<string, unknown>
|
|
|
|
expect(result.created).toBe(false)
|
|
expect(result.requires_confirmation).toBe(true)
|
|
const preview = result.preview as Record<string, unknown>
|
|
expect(preview.org_number).toBe('5560000001')
|
|
expect(preview.vat_number).toBe('SE556000000101')
|
|
expect(preview.team_id).toBe(TEAM_ID)
|
|
expect(preview.fiscal_period).toMatchObject({ name: expect.stringContaining('Räkenskapsår') })
|
|
expect(mocks.createCompanyCore).not.toHaveBeenCalled()
|
|
expect(supabase.rpc).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('creates through the service-role RPC for the key user with confirm=true', async () => {
|
|
const supabase = supabaseWithTeam(TEAM_ID)
|
|
mocks.createCompanyCore.mockImplementation(
|
|
async (_client: unknown, _input: unknown, createRow: () => Promise<{ data: unknown; error: unknown }>) => {
|
|
const { data } = await createRow()
|
|
return { companyId: data as string }
|
|
}
|
|
)
|
|
|
|
const result = (await tool.execute(
|
|
{ ...setup, confirm: true },
|
|
'',
|
|
'user-1',
|
|
supabase as never
|
|
)) as Record<string, unknown>
|
|
|
|
expect(result.created).toBe(true)
|
|
expect(result.company_id).toBe(COMPANY_ID)
|
|
expect(supabase.rpc).toHaveBeenCalledWith('create_company_for_user', {
|
|
p_user_id: 'user-1',
|
|
p_name: 'Testbolaget AB',
|
|
p_entity_type: 'aktiebolag',
|
|
p_team_id: TEAM_ID,
|
|
})
|
|
const [, input] = mocks.createCompanyCore.mock.calls[0] as [unknown, Record<string, unknown>]
|
|
expect(input.settings).toMatchObject({ moms_period: 'quarterly', vat_registered: true, company_name: 'Testbolaget AB' })
|
|
expect((result.next as Record<string, unknown>).tool).toBe('gnubok_load_skill')
|
|
})
|
|
|
|
it('refuses a VAT-registered company without a moms period before touching the database', async () => {
|
|
const supabase = supabaseWithTeam(TEAM_ID)
|
|
await expect(
|
|
tool.execute({ ...setup, moms_period: undefined, confirm: true }, '', 'user-1', supabase as never)
|
|
).rejects.toMatchObject({ code: 'VALIDATION_ERROR', message: expect.stringContaining('moms_period') })
|
|
expect(supabase.rpc).not.toHaveBeenCalled()
|
|
expect(mocks.createCompanyCore).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('uses an explicit team_id over the default team', async () => {
|
|
const supabase = supabaseWithTeam(TEAM_ID)
|
|
const other = '66666666-6666-4666-8666-666666666666'
|
|
const result = (await tool.execute({ ...setup, team_id: other }, '', 'user-1', supabase as never)) as Record<
|
|
string,
|
|
unknown
|
|
>
|
|
expect((result.preview as Record<string, unknown>).team_id).toBe(other)
|
|
expect(supabase.from).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('surfaces a creation failure as a coded error', async () => {
|
|
const supabase = supabaseWithTeam(null)
|
|
mocks.createCompanyCore.mockResolvedValue({ error: 'Kunde inte skapa kontoplan. Försök igen.' })
|
|
await expect(
|
|
tool.execute({ ...setup, confirm: true }, '', 'user-1', supabase as never)
|
|
).rejects.toMatchObject({ code: 'COMPANY_CREATE_FAILED' })
|
|
})
|
|
})
|