* perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline
Two chunks rode along in the first-load JS of almost every dashboard route:
the full BAS 2026 chart (315 KB uncompressed, in 81 route manifests) and
the browser polyfill for Node's crypto/vm/Buffer (327 KB, in 26 routes
incl. login and register). Neither was needed on first paint; both got
there through static imports of helpers that happen to live next to code
that needs the data or the builtin.
Node polyfill (4 pure splits, behaviour unchanged, re-exported from the
original modules for server callers):
- lib/auth/bankid-flags.ts: isBankIdEnabled (login, register, security
settings imported it from bankid.ts, which imports crypto).
- lib/import/bank-file/formats.ts: the format registry + detection (the
import history imported getFormat from parser.ts, which hashes).
- lib/salary/personnummer-format.ts: parsing/validation/formatting (the
employee forms reached the encrypting personnummer.ts via tax-column).
- lib/auth/api-key-scopes.ts: scope catalogue, groups, tool map, helpers
(the API key panel imported STAGING_SCOPES from the key generator).
BAS chart:
- lib/bookkeeping/bas-lazy.ts + use-bas-reference.ts: the chart becomes a
dynamic import, fetched once per session after first paint; components
that show BAS names/descriptions call useBasReference() and re-render
when it lands. Until then (and on the server) only the hardcoded
account-descriptions answer, so SSR and hydration agree.
- lib/bookkeeping/bas-labels.ts: class/group labels out of bas-reference.ts
(account-descriptions needed a label and paid for the whole chart).
- lib/bookkeeping/bas-account-numbers.ts (generated, ~11 KB) +
scripts/generate-bas-account-numbers.ts (--check) + parity test:
isStandardBASAccountNumber for AddAccountDialog/ChartOfAccountsManager.
- lib/bookkeeping/account-classifier-{heuristic,client}.ts: the BAS-aligned
heuristic shared by the server classifier and a client variant that uses
the lazy chart.
- lib/bookkeeping/invoice-accounts.ts: INVOICE_FX_RATE_MISSING,
InvoiceFxRateMissingError, getRevenueAccount, getOutputVatAccount out of
invoice-entries.ts, whose engine import pulled account-backfill and the
chart into SendInvoiceDialog/PaymentBookingDialog.
- CorrectOpeningBalanceDialog re-seeds names when the chart lands;
OpeningBalanceRowEditor builds its Fuse indexes lazily; the
ChartOfAccountsManager BAS-katalog tab awaits the chunk.
Tooling:
- scripts/perf/client-import-closure.mjs: static import closure of every
'use client' module with the shortest chain to a target (file or bare
specifier); found every path above without a build.
- scripts/checks/client-node-builtin.mjs wired into check:guards: a client
module reaching a Node builtin is a hard failure (0 today).
Left as is: invoices/[id], its credit page and SendInvoiceDialog still
reach the chart through lib/invoices/issue-credit-note -> invoice-entries
-> engine -> account-backfill; splitting the engine is out of scope here.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(perf): unambiguous import-edge regex in the closure walker (CodeQL js/redos)
One quantifier per span: a greedy [^'"]* up to the specifier quote, which it
cannot cross, so a run of whitespace has a single parse. Same edges as
before (multi-line named imports, re-exports, side-effect imports; type-only
imports still skipped).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
119 lines
3.0 KiB
TypeScript
119 lines
3.0 KiB
TypeScript
'use client'
|
|
|
|
import { getAccountDescription, type AccountType } from '@/lib/bookkeeping/account-descriptions'
|
|
import { useBasReference } from '@/lib/bookkeeping/use-bas-reference'
|
|
import {
|
|
Tooltip,
|
|
TooltipTrigger,
|
|
TooltipContent,
|
|
} from '@/components/ui/info-tooltip'
|
|
import { cn } from '@/lib/utils'
|
|
|
|
const TYPE_COLORS: Record<AccountType, string> = {
|
|
asset: 'bg-success',
|
|
liability: 'bg-warning',
|
|
equity: 'bg-primary',
|
|
revenue: 'bg-muted-foreground',
|
|
expense: 'bg-destructive',
|
|
untaxed_reserves: 'bg-warning',
|
|
}
|
|
|
|
const TYPE_LABELS: Record<AccountType, string> = {
|
|
asset: 'Tillgång',
|
|
liability: 'Skuld',
|
|
equity: 'Eget kapital',
|
|
revenue: 'Intäkt',
|
|
expense: 'Kostnad',
|
|
untaxed_reserves: 'Obeskattade reserver',
|
|
}
|
|
|
|
interface AccountNumberProps {
|
|
number: string
|
|
name?: string
|
|
showName?: boolean
|
|
size?: 'sm' | 'default'
|
|
className?: string
|
|
}
|
|
|
|
export function AccountNumber({
|
|
number,
|
|
name,
|
|
showName,
|
|
size = 'default',
|
|
className,
|
|
}: AccountNumberProps) {
|
|
// Loads the BAS chart chunk after mount and re-renders once names and
|
|
// descriptions for non-hardcoded accounts are available.
|
|
useBasReference()
|
|
const desc = getAccountDescription(number)
|
|
const displayName = desc?.name ?? name
|
|
|
|
const numberElement = (
|
|
<span
|
|
className={cn(
|
|
'font-mono',
|
|
size === 'sm' ? 'text-xs' : 'text-sm',
|
|
className,
|
|
)}
|
|
>
|
|
{number}
|
|
</span>
|
|
)
|
|
|
|
if (!desc) {
|
|
return (
|
|
<>
|
|
{numberElement}
|
|
{showName && displayName && (
|
|
<span className="ml-1">{displayName}</span>
|
|
)}
|
|
</>
|
|
)
|
|
}
|
|
|
|
return (
|
|
<Tooltip>
|
|
<TooltipTrigger asChild>
|
|
<span
|
|
className={cn(
|
|
'inline-flex items-center gap-1 cursor-help',
|
|
'decoration-dotted underline underline-offset-4 decoration-muted-foreground/40',
|
|
)}
|
|
>
|
|
<span
|
|
className={cn(
|
|
'font-mono',
|
|
size === 'sm' ? 'text-xs' : 'text-sm',
|
|
className,
|
|
)}
|
|
>
|
|
{number}
|
|
</span>
|
|
{showName && displayName && (
|
|
<span className={size === 'sm' ? 'text-xs' : 'text-sm'}>
|
|
{displayName}
|
|
</span>
|
|
)}
|
|
</span>
|
|
</TooltipTrigger>
|
|
<TooltipContent side="top" className="max-w-xs p-3">
|
|
<div className="space-y-1.5">
|
|
<div className="flex items-center gap-2">
|
|
<span className={cn('h-2 w-2 rounded-full shrink-0', TYPE_COLORS[desc.type])} />
|
|
<span className="text-xs text-muted-foreground">
|
|
{desc.classLabel} · {TYPE_LABELS[desc.type]}
|
|
</span>
|
|
</div>
|
|
<div className="font-medium">
|
|
<span className="font-mono mr-1.5">{number}</span>
|
|
{desc.name}
|
|
</div>
|
|
<p className="text-xs text-muted-foreground leading-relaxed">
|
|
{desc.explanation}
|
|
</p>
|
|
</div>
|
|
</TooltipContent>
|
|
</Tooltip>
|
|
)
|
|
}
|