The first production run of the row-completion pass (#2291) wrote 345 Profilio invoices whose rows summed to the invoice GROSS with 25 % VAT computed on top, beside a header (Net / TotalVAT) that was right. Fortnox prices an invoice either excluding or including VAT and says which with the invoice-level VATIncluded flag; the mapper had always read the row Total and Price as net. Every such row set is 1.25 x its header net, to the öre, across all 345. - lib/providers/fortnox/mapper.ts: netOfVat() divides row Total and Price by (1 + rate) when VATIncluded is true; TotalExcludingVAT and PriceExcludingVAT are preferred when the payload carries them. A row without a rate cannot be split and keeps its amount. - complete-invoice-lines.ts: rows whose net or VAT disagree with the header the same payload established by more than 1 kr are reported as rowsMismatch and left untouched. Öresavrundning stays inside the tolerance; VAT-inside rows, header-level freight and discounts do not. Rows that contradict their own header are worse than no rows. - Cron summary carries rowsMismatch. None of the 345 is open or booked; a separate repair removes today's rows for them so the fixed pass refills them. Claude-Session: https://claude.ai/code/session_01DG5aYcshzKJ1EA7PPhGtVf Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
410 lines
17 KiB
TypeScript
410 lines
17 KiB
TypeScript
import { describe, it, expect, beforeEach, vi, type Mock } from 'vitest'
|
|
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
import type { SalesInvoiceDto } from '@/lib/providers/dto'
|
|
|
|
/**
|
|
* The follow-up pass for migrated sales invoices imported without rows
|
|
* (Fortnox, Briox and Björn Lundén ship none in a list payload, and the
|
|
* migration's detail hydration is budget-bounded). It must start from OUR
|
|
* row-less invoices, join strictly, hydrate only that subset, write rows only
|
|
* when the provider's total agrees with the stored one, and leave anything it
|
|
* could not reach for the next run rather than guessing.
|
|
*/
|
|
|
|
vi.mock('@/lib/providers/resolve-consent', () => ({
|
|
resolveConsent: vi.fn().mockResolvedValue({
|
|
consent: { provider: 'fortnox' },
|
|
accessToken: 'tok',
|
|
providerCompanyId: undefined,
|
|
}),
|
|
}))
|
|
|
|
vi.mock('@/lib/providers/provider-data-fetcher', () => ({
|
|
fetchSalesInvoicesDirect: vi.fn(),
|
|
hydrateSalesInvoices: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/supabase/fetch-all', () => ({ fetchAllRows: vi.fn() }))
|
|
|
|
import { resolveConsent } from '@/lib/providers/resolve-consent'
|
|
import { fetchAllRows } from '@/lib/supabase/fetch-all'
|
|
import { fetchSalesInvoicesDirect, hydrateSalesInvoices } from '@/lib/providers/provider-data-fetcher'
|
|
import { completeMigratedInvoiceLines } from '../complete-invoice-lines'
|
|
|
|
const mResolve = resolveConsent as Mock
|
|
const mFetchAll = fetchAllRows as Mock
|
|
const mList = fetchSalesInvoicesDirect as Mock
|
|
const mHydrate = hydrateSalesInvoices as Mock
|
|
|
|
const HYDRATION = { needed: 0, hydrated: 0, failed: 0, skippedForBudget: 0 }
|
|
|
|
const amount = (value: number, currencyCode = 'SEK') => ({ value, currencyCode })
|
|
|
|
/** A hydrated Fortnox-shaped invoice: 1 000 kr net, 25 % VAT, 1 250 kr total. */
|
|
function providerInvoice(overrides: Partial<SalesInvoiceDto> = {}): SalesInvoiceDto {
|
|
return {
|
|
id: '1001',
|
|
invoiceNumber: '1001',
|
|
issueDate: '2026-03-14',
|
|
currencyCode: 'SEK',
|
|
status: 'paid',
|
|
supplier: { name: 'Profilio Sweden AB', identifications: [] },
|
|
customer: { name: 'Kund AB', identifications: [] },
|
|
lines: [
|
|
{
|
|
id: '1',
|
|
description: 'Konsulttid',
|
|
quantity: 10,
|
|
unitCode: 'h',
|
|
unitPrice: amount(100),
|
|
lineExtensionAmount: amount(1000),
|
|
taxPercent: 25,
|
|
},
|
|
],
|
|
taxTotal: { taxAmount: amount(250) },
|
|
legalMonetaryTotal: {
|
|
lineExtensionAmount: amount(1000),
|
|
taxInclusiveAmount: amount(1250),
|
|
payableAmount: amount(1250),
|
|
},
|
|
paymentStatus: { paid: true, balance: amount(0) },
|
|
...overrides,
|
|
}
|
|
}
|
|
|
|
/** A stored row as the pre-#1745 import left it: 25 % label, 0 kr VAT, no rows. */
|
|
function storedRow(overrides: Record<string, unknown> = {}) {
|
|
return {
|
|
id: 'inv-1',
|
|
user_id: 'user-1',
|
|
customer_id: 'cust-1',
|
|
invoice_number: '1001',
|
|
invoice_date: '2026-03-14',
|
|
total: 1250,
|
|
subtotal: 1250,
|
|
vat_amount: 0,
|
|
vat_rate: 25,
|
|
currency: 'SEK',
|
|
exchange_rate: null,
|
|
invoice_items: [],
|
|
...overrides,
|
|
}
|
|
}
|
|
|
|
/** Every hydrated as given, in order, nothing left unhydrated. */
|
|
function hydratedAll(invoices: SalesInvoiceDto[], unhydratedIds: string[] = []) {
|
|
return {
|
|
invoices,
|
|
hydration: { ...HYDRATION, needed: invoices.length, hydrated: invoices.length - unhydratedIds.length },
|
|
unhydratedIds: new Set(unhydratedIds),
|
|
}
|
|
}
|
|
|
|
interface Call { table: string; method: string; args: unknown[] }
|
|
|
|
/**
|
|
* Thenable query-builder stand-in. Records every call; resolves with what
|
|
* `respond` returns for the table and the methods used on the chain.
|
|
*/
|
|
function makeSupabase(respond: (table: string, methods: string[], calls: Call[]) => unknown) {
|
|
const calls: Call[] = []
|
|
const from = vi.fn((table: string) => {
|
|
const chain: Call[] = []
|
|
const builder: Record<string, unknown> = {}
|
|
for (const method of ['select', 'in', 'insert', 'update', 'eq', 'neq', 'order', 'range']) {
|
|
builder[method] = (...args: unknown[]) => {
|
|
const call = { table, method, args }
|
|
chain.push(call)
|
|
calls.push(call)
|
|
return builder
|
|
}
|
|
}
|
|
builder.then = (resolve: (v: unknown) => void, reject: (e: unknown) => void) =>
|
|
Promise.resolve()
|
|
.then(() => respond(table, chain.map((c) => c.method), chain))
|
|
.then(resolve, reject)
|
|
return builder
|
|
})
|
|
return { supabase: { from } as unknown as SupabaseClient, calls }
|
|
}
|
|
|
|
const ok = { data: [], error: null }
|
|
|
|
function insertedRows(calls: Call[]): Record<string, unknown>[] {
|
|
return calls
|
|
.filter((c) => c.table === 'invoice_items' && c.method === 'insert')
|
|
.flatMap((c) => c.args[0] as Record<string, unknown>[])
|
|
}
|
|
|
|
function headerUpdates(calls: Call[]): Record<string, unknown>[] {
|
|
return calls
|
|
.filter((c) => c.table === 'invoices' && c.method === 'update')
|
|
.map((c) => c.args[0] as Record<string, unknown>)
|
|
}
|
|
|
|
describe('completeMigratedInvoiceLines', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mResolve.mockResolvedValue({ consent: { provider: 'fortnox' }, accessToken: 'tok', providerCompanyId: undefined })
|
|
})
|
|
|
|
it('writes the rows and fills a header that held no VAT evidence', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow()])
|
|
const dto = providerInvoice()
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({
|
|
candidates: 1, providerInvoices: 1, matched: 1, unmatched: 0,
|
|
completed: 1, headersUpdated: 1, remaining: 0, totalMismatch: 0, notHydrated: 0, failed: 0,
|
|
})
|
|
// Only the matched subset is hydrated, so the budget is never spent on
|
|
// invoices already complete on our side.
|
|
expect(mHydrate).toHaveBeenCalledTimes(1)
|
|
expect(mHydrate.mock.calls[0][3]).toEqual([dto])
|
|
|
|
const rows = insertedRows(calls)
|
|
expect(rows).toHaveLength(1)
|
|
expect(rows[0]).toMatchObject({
|
|
invoice_id: 'inv-1',
|
|
sort_order: 1,
|
|
description: 'Konsulttid',
|
|
quantity: 10,
|
|
unit: 'h',
|
|
unit_price: 100,
|
|
line_total: 1000,
|
|
vat_rate: 25,
|
|
vat_amount: 250,
|
|
})
|
|
|
|
const headers = headerUpdates(calls)
|
|
expect(headers).toHaveLength(1)
|
|
expect(headers[0]).toEqual({
|
|
subtotal: 1000,
|
|
subtotal_sek: 1000,
|
|
vat_amount: 250,
|
|
vat_amount_sek: 250,
|
|
vat_rate: 25,
|
|
vat_treatment: 'standard_25',
|
|
})
|
|
// Scoped to the company as well as the id: defense in depth on a
|
|
// service-role client.
|
|
const update = calls.find((c) => c.table === 'invoices' && c.method === 'update')!
|
|
const scope = calls.filter((c) => c.table === 'invoices' && c.method === 'eq' && calls.indexOf(c) > calls.indexOf(update))
|
|
expect(scope.map((c) => c.args)).toEqual([['id', 'inv-1'], ['company_id', 'co-1']])
|
|
// Never the total, status or payments.
|
|
expect(Object.keys(headers[0])).not.toContain('total')
|
|
expect(Object.keys(headers[0])).not.toContain('status')
|
|
})
|
|
|
|
it('writes the rows but leaves a header whose split is consistent (momsfri)', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow({ vat_rate: 0, vat_amount: 0, subtotal: 1250 })])
|
|
const dto = providerInvoice()
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ completed: 1, headersUpdated: 0 })
|
|
expect(insertedRows(calls)).toHaveLength(1)
|
|
expect(headerUpdates(calls)).toHaveLength(0)
|
|
})
|
|
|
|
it('fills a header whose rate is null (the post-#1745 "source did not say")', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow({ vat_rate: null, vat_amount: 0, subtotal: 1250 })])
|
|
const dto = providerInvoice()
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ completed: 1, headersUpdated: 1 })
|
|
expect(headerUpdates(calls)[0]).toMatchObject({ vat_rate: 25, vat_amount: 250, subtotal: 1000 })
|
|
})
|
|
|
|
it('derives the SEK twins from the rate the row already carries', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow({ currency: 'EUR', exchange_rate: 11.2, total: 1250 })])
|
|
const dto = providerInvoice({ currencyCode: 'EUR' })
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(headerUpdates(calls)[0]).toMatchObject({ subtotal: 1000, subtotal_sek: 11200, vat_amount: 250, vat_amount_sek: 2800 })
|
|
})
|
|
|
|
it('refuses rows that do not add up to the header the same payload established', async () => {
|
|
// The shape Profilio's 345 invoices took: rows priced with VAT inside,
|
|
// summing to the gross, beside a header that was right. Storing them
|
|
// would put a row list under the invoice that contradicts its totals.
|
|
mFetchAll.mockResolvedValue([storedRow()])
|
|
const dto = providerInvoice({
|
|
lines: [
|
|
{ id: '1', description: 'Mugg', quantity: 1, unitPrice: amount(1250), lineExtensionAmount: amount(1250), taxPercent: 25 },
|
|
],
|
|
})
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ matched: 1, completed: 0, rowsMismatch: 1, remaining: 1 })
|
|
expect(insertedRows(calls)).toHaveLength(0)
|
|
expect(headerUpdates(calls)).toHaveLength(0)
|
|
})
|
|
|
|
it('tolerates öresavrundning between the rows and the header', async () => {
|
|
// Fortnox rounds Total to whole kronor; the header net absorbs the öre.
|
|
mFetchAll.mockResolvedValue([storedRow({ total: 12263 })])
|
|
const dto = providerInvoice({
|
|
lines: [{ id: '1', description: 'Konsult', quantity: 1, unitPrice: amount(9810), lineExtensionAmount: amount(9810), taxPercent: 25 }],
|
|
taxTotal: { taxAmount: amount(2452.5) },
|
|
legalMonetaryTotal: { lineExtensionAmount: amount(9810.5), taxInclusiveAmount: amount(12263), payableAmount: amount(12263) },
|
|
})
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ completed: 1, rowsMismatch: 0 })
|
|
expect(insertedRows(calls)).toHaveLength(1)
|
|
})
|
|
|
|
it('leaves an invoice untouched when the provider total differs from the stored one', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow({ total: 1300, subtotal: 1300 })])
|
|
const dto = providerInvoice()
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ matched: 1, completed: 0, totalMismatch: 1, remaining: 1 })
|
|
expect(insertedRows(calls)).toHaveLength(0)
|
|
expect(headerUpdates(calls)).toHaveLength(0)
|
|
})
|
|
|
|
it('reverses the rows of a kreditfaktura the way the migration does', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow({ total: -1250, subtotal: -1250 })])
|
|
const dto = providerInvoice({ invoiceTypeCode: '381', status: 'credited' })
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ completed: 1, totalMismatch: 0 })
|
|
expect(insertedRows(calls)[0]).toMatchObject({ quantity: -10, unit_price: 100, line_total: -1000, vat_amount: -250 })
|
|
expect(headerUpdates(calls)[0]).toMatchObject({ subtotal: -1000, vat_amount: -250 })
|
|
})
|
|
|
|
it('leaves invoices the budget did not reach for the next run', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow(), storedRow({ id: 'inv-2', invoice_number: '1002' })])
|
|
const first = providerInvoice()
|
|
const second = providerInvoice({ id: '1002', invoiceNumber: '1002', lines: [] })
|
|
mList.mockResolvedValue([first, second])
|
|
// The second came back in list form only (no rows): the budget ran out.
|
|
mHydrate.mockResolvedValue(hydratedAll([first, second], ['1002']))
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ candidates: 2, matched: 2, completed: 1, notHydrated: 1, remaining: 1 })
|
|
expect(insertedRows(calls).map((r) => r.invoice_id)).toEqual(['inv-1'])
|
|
})
|
|
|
|
it('does not join an ambiguous key, and does not hydrate when nothing joined', async () => {
|
|
// Two stored rows with the same number and date: a wrong join would put
|
|
// one invoice's rows under the other.
|
|
mFetchAll.mockResolvedValue([storedRow(), storedRow({ id: 'inv-dup' })])
|
|
mList.mockResolvedValue([providerInvoice()])
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ candidates: 2, matched: 0, unmatched: 2, completed: 0, remaining: 2 })
|
|
expect(mHydrate).not.toHaveBeenCalled()
|
|
expect(insertedRows(calls)).toHaveLength(0)
|
|
})
|
|
|
|
it('costs one query and no provider call when the company has nothing to complete', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow({ invoice_items: [{ id: 'item-1' }] })])
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ candidates: 0, completed: 0, remaining: 0 })
|
|
expect(mResolve).not.toHaveBeenCalled()
|
|
expect(mList).not.toHaveBeenCalled()
|
|
expect(calls).toHaveLength(0)
|
|
})
|
|
|
|
it('skips an invoice that gained rows since the candidates were loaded', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow()])
|
|
const dto = providerInvoice()
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase, calls } = makeSupabase((table, methods) =>
|
|
table === 'invoice_items' && methods.includes('in') ? { data: [{ invoice_id: 'inv-1' }], error: null } : ok,
|
|
)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ completed: 0, failed: 0, remaining: 1 })
|
|
expect(insertedRows(calls)).toHaveLength(0)
|
|
expect(headerUpdates(calls)).toHaveLength(0)
|
|
})
|
|
|
|
it('retries per invoice when the batch insert fails, and counts the offender', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow(), storedRow({ id: 'inv-2', invoice_number: '1002' })])
|
|
const first = providerInvoice()
|
|
const second = providerInvoice({ id: '1002', invoiceNumber: '1002' })
|
|
mList.mockResolvedValue([first, second])
|
|
mHydrate.mockResolvedValue(hydratedAll([first, second]))
|
|
const { supabase, calls } = makeSupabase((table, methods, chain) => {
|
|
if (table !== 'invoice_items' || !methods.includes('insert')) return ok
|
|
const rows = chain[0].args[0] as { invoice_id: string }[]
|
|
if (rows.length > 1) return { data: null, error: { message: 'batch rejected' } }
|
|
return rows[0].invoice_id === 'inv-2' ? { data: null, error: { message: 'check violation' } } : ok
|
|
})
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1' })
|
|
|
|
expect(result).toMatchObject({ completed: 1, failed: 1, headersUpdated: 1, remaining: 1 })
|
|
expect(headerUpdates(calls)).toHaveLength(1)
|
|
})
|
|
|
|
it('dry run: reports the plan and writes nothing', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow()])
|
|
const dto = providerInvoice()
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase, calls } = makeSupabase(() => ok)
|
|
|
|
const result = await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1', dryRun: true })
|
|
|
|
expect(result).toMatchObject({ dryRun: true, completed: 1, headersUpdated: 1, remaining: 0 })
|
|
expect(calls).toHaveLength(0)
|
|
})
|
|
|
|
it('passes the budget through to the hydration', async () => {
|
|
mFetchAll.mockResolvedValue([storedRow()])
|
|
const dto = providerInvoice()
|
|
mList.mockResolvedValue([dto])
|
|
mHydrate.mockResolvedValue(hydratedAll([dto]))
|
|
const { supabase } = makeSupabase(() => ok)
|
|
|
|
await completeMigratedInvoiceLines({ supabase, companyId: 'co-1', consentId: 'c-1', budgetMs: 45_000 })
|
|
|
|
expect(mHydrate.mock.calls[0][4]).toBe(45_000)
|
|
})
|
|
})
|