MattssonandClaude Fable 5.1
1157ff1b66
* feat(onboarding): the orgnr field also accepts a company name The journey's first question kept asking for an organisationsnummer, and people who do not know theirs by heart left to look it up. The same field now takes either: digits (with dashes or spaces) run the existing orgnr lookup unchanged; anything else with three or more characters runs a free-text name search against the same TIC index. One hit continues exactly as a typed orgnr would; several hits render as a chip row "Name / orgnr / city" inside the same question, and the pick applies the hit's already-fetched lookup result. No hits stays on the step with a note to refine or type the number. The screen, placeholder and hint are otherwise untouched; only the mobile keyboard changes from numeric to text. Why the problem occurred: the lookup was keyed on the one identifier the user is least likely to remember, while the provider index behind it is a full-text index that already answers names. What was removed or simplified: nothing new is stored. The TIC search document carries every field /lookup returns, so a name hit is mapped by the same mapper and a picked hit costs no second provider call. The reducer gained one shared "TIC answered" transition (applyLookupFound) that the typed-orgnr path, the single-hit path and the pick path all use, instead of three copies of the fact-to-settings mapping. Why this shape and not the proposed one: search-as-you-type autocomplete would burn the 3000/mo TIC budget in days, so the search fires on Enter only, like the orgnr lookup. Taking the top hit blind on several matches was rejected: name ranking is fuzzy and common names or sole-trader surnames would land on a stranger's company; a five-chip pick row is the smallest thing that keeps the user in control. The route answers 400 under three characters, 404 in the handler's own "Company not found" shape so the client's existing dispatcher-vs-handler mapping applies, and every TIC failure code maps through the same handler as /lookup. Fixes #2418 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKHTqmnvBJAgdW4V7wZsAW * fix(onboarding): reduce Lens registration numbers to the 10-digit form for name-search hits Skeptic pass on 1d70716a8 (issue #2418). A sole trader found by name got Lens's 16-digit registration number (century-prefixed personnummer plus a 4-digit serial) stored as org_number; createCompany refuses anything normalizeOrgNumber rejects, so the journey dead-ended at the last step and the returned orgnr step could only shake. The typed-orgnr path never stored Lens's number, so this was the first place it reached settings. - searchCompaniesForLookup derives orgNumber through the new lensRegistrationToOrgNumber (16-prefixed 12 digits and the 16-digit enskild-firma form reduce to the 10-digit key; hits that do not normalize are dropped, never dead-ended). - Sole-trader chips show "Enskild firma" and city instead of the number, which is the owner's personnummer. - The name path resets the duplicate note on submit, so an earlier orgnr's "you already have X" no longer sits above the chip row. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKHTqmnvBJAgdW4V7wZsAW * fix(onboarding): keep the typed name in the field after a search pick Compliance swarm on PR #2421: writing the picked hit's org number into the visible input printed a sole trader's personnummer in plain text on Back, the one thing the chip row masks. The field now keeps the name the user typed; Back re-searches it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FKHTqmnvBJAgdW4V7wZsAW --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
76 lines
2.9 KiB
TypeScript
76 lines
2.9 KiB
TypeScript
/**
|
|
* A person's role/position in a Swedish company, from BankID enrichment.
|
|
* Defined in core so onboarding components can import it without
|
|
* violating the CI constraint (no core → @/extensions/ imports).
|
|
*/
|
|
export interface EnrichmentCompanyRole {
|
|
companyId: number
|
|
companyRegistrationNumber: string
|
|
legalName: string
|
|
legalEntityType: string
|
|
positionTypes: string[]
|
|
positionDescriptions: string[]
|
|
positionStart: string
|
|
positionEnd: string | null
|
|
companyStatus: string
|
|
signatureDescription?: string
|
|
}
|
|
|
|
/**
|
|
* Generic company lookup result: provider-agnostic.
|
|
* Defined in core so onboarding components can import it without
|
|
* violating the CI constraint (no core → @/extensions/ imports).
|
|
*
|
|
* `fiscalYear` carries the current fiscal-year configuration when the
|
|
* provider reports one: used by onboarding to skip manual MM-DD entry.
|
|
* Always optional: providers that don't return it (or that fail
|
|
* partially) must still produce a valid result.
|
|
*/
|
|
export interface CompanyLookupResult {
|
|
companyName: string
|
|
isCeased: boolean
|
|
address: { street: string | null; postalCode: string | null; city: string | null } | null
|
|
registration: { fTax: boolean; vat: boolean }
|
|
bankAccounts: { type: string; accountNumber: string; bic: string | null }[]
|
|
email: string | null
|
|
phone: string | null
|
|
sniCodes: { code: string; name: string }[]
|
|
fiscalYear?: { startMonthDay: string | null; endMonthDay: string | null } | null
|
|
/**
|
|
* Bolagsverket legal entity type code: "AB", "EF", "HB", "KB", etc.
|
|
* Onboarding maps the supported codes to `EntityType` ('aktiebolag',
|
|
* 'enskild_firma') to pre-select Step 1's radio for deep-link users.
|
|
* Optional: providers without this info or for unsupported types leave
|
|
* it null and the user picks manually.
|
|
*/
|
|
legalEntityType?: string | null
|
|
/**
|
|
* Company registration date as a millisecond epoch. TIC's search API
|
|
* natively returns Unix seconds; the TIC extension converts to ms at the
|
|
* boundary so consumers can feed this straight into `new Date()`.
|
|
* Onboarding Step 3 uses this to infer `is_first_fiscal_year`: when the
|
|
* company was registered less than 12 months ago, we pre-check the
|
|
* first-year toggle and seed `first_year_start` from the registration
|
|
* month. Optional: null when TIC didn't return it.
|
|
*/
|
|
registrationDate?: number | null
|
|
}
|
|
|
|
/**
|
|
* One hit from a free-text company search (onboarding's orgnr field also
|
|
* accepts a name). Carries the org number the hit resolves to alongside the
|
|
* same lookup result `/lookup` would return for it, so picking a hit costs
|
|
* no second provider call.
|
|
*/
|
|
export interface CompanySearchHit {
|
|
orgNumber: string
|
|
result: CompanyLookupResult
|
|
}
|
|
|
|
/**
|
|
* Shortest free-text query the search accepts. Shared by the client (which
|
|
* shakes the field instead of calling) and the TIC route (which answers 400)
|
|
* so the two never disagree on what is worth a provider call.
|
|
*/
|
|
export const COMPANY_SEARCH_MIN_CHARS = 3
|