Files
accounted/lib/salary/opening-balances.ts
T
MattssonandClaude Fable 5 b6332e9ff4 Fix/skv connection flow (#1015)
* feat(salary): one-click AGI submission with filing state machine and success feedback

The AGI panel required users to know that "Ladda ner AGI-fil" was the
generate step, then click submit, signing link, and kvittens manually.
A nollkorning filing stalled on "AGI-XML saknas" pointing at a UI path
that does not exist.

- New primary button "Lamna in till Skatteverket" chains the existing
  endpoints client-side: generate XML if missing, POST underlag, poll
  kontrollresultat, create signing link, open Mina Sidor in a tab opened
  synchronously at click (popup-blocker safe). Inline stepper shows each
  step; the four old buttons become collapsed advanced/recovery actions,
  auto-expanded in stale-draft and rejected states. XML download stays
  visible and free for manual filing.
- deriveAgiFilingState() + useAgiSubmission() lift the per-period
  submission record to the run page: the progress rail and salary hero
  now render the real state machine (generated, underlag inskickat,
  vantar pa BankID-signatur, inlamnad med kvittensnummer) instead of
  telling users to "lamna in" an already-submitted declaration.
- Success card with kvittensnummer and signature metadata once signed,
  plus a toast when a poll flips the state while the page is open.
- AGI kvittens cron every 15 min instead of every 2 h so filings signed
  on another device get stamped and emailed promptly.
- Advanced submit also auto-generates, and the stale "Lon -> AGI ->
  Generera" error text now points at the real buttons.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(enable-banking): instant OAuth callback feedback and dead-attempt cleanup

The bank redirect landed on a blank page for the several seconds the
callback spent exchanging the PSD2 session and mirroring accounts, and
every failed connect attempt left a status='error' row that rendered
forever as an "Atgard kravs" card next to a successful retry, showing
duplicate connections to the same bank.

- Stream a branded "Slutfor bankanslutningen" progress page from the
  callback: the shell flushes before the session exchange starts and a
  script/meta redirect follows when the work completes, with a 30s
  slow-work escape hatch. Fast outcomes (denial, bad params, unknown
  state) keep their plain redirects.
- Delete never-activated connection rows (no session_id, no
  accounts_data) on denial or exchange failure, and sweep leftovers for
  the same bank on the next connect. Established connections keep their
  "Atgard krävs" card via the accounts_data guard; FKs are ON DELETE
  SET NULL so deletion has no dependents.
- Show "Banken ar ansluten: hamtar dina konton" while the settings
  panel loads after the callback instead of an anonymous spinner.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): reject re-send of issued invoices and gate bookkeeping on the sent flip

A direct POST to /api/invoices/[id]/send against an already-issued
invoice re-emailed the customer and posted a second revenue verifikat
(createInvoiceJournalEntry has no dedup), overwriting journal_entry_id
and orphaning the first entry. Only the UI hid the button; the v1 route
and the MCP commit executor already rejected non-drafts.

- Non-draft invoices now return 409 INVOICE_ALREADY_SENT.
- The draft to sent status flip is an optimistic lock (status guard plus
  row-count check); journal entry, accrual schedules, PDF archival and
  the invoice.sent event only run for the request that won the flip.
- On a flip failure the journal entry is deferred: the row stays draft
  and a retry re-runs the pipeline, ending with exactly one verifikat.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): payment links, failure visibility and sandbox guard for recurring auto-send

- sendInvoiceFromSchedule now auto-creates an online payment link via
  applyPaymentLinkToInvoice before rendering and passes the payment
  link QR to the PDF: parity with the dashboard and v1 send routes,
  which recurring invoices silently lacked.
- The recurring cron persists last_run_warning both when a claimed run
  throws (hourly retries stay visible on the schedule) and when a stale
  schedule is rolled forward, so a deterministic failure can no longer
  skip a month silently.
- Auto-send is blocked for sandbox companies at the email chokepoint
  (freeze-and-retain: the invoice is still generated as a draft),
  covering both the cron and the run-now route with one guard.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(salary): close the Fortnox payroll API gaps (phases 1-4)

Payroll now runs end-to-end through the open API, including onboarding a
client from another payroll system, with every write staged for approval.

- v1: per-employee payslips (list/detail/PDF), payslip line writes,
  run roster attach/remove, absence ranges (per-day storage), jamkning
  fields, cutover opening balances (single + atomic bulk PUT), vacation
  balance + vacation-year-close. PUT added to the wrapper's idempotency/
  test-key set (test keys could otherwise write through PUT).
- MCP: 10 new tools (get_employee/get_payslip/list_absence/
  get_vacation_balance reads + staged update_payslip_line,
  register_absence, create_employee, update_employee,
  set_employee_opening_balances, close_vacation_year), executors, risk
  tiers, op-type CHECK expansions. create_employee encrypts personnummer
  at staging: pending_operations never holds plaintext.
- Scope-map audit retrofit: 11 formerly unmapped tools now scoped;
  BREAKING for keys that relied on the 4 default-allow writes.
- Cutover: employee_opening_balances (derived lock trigger, self-unlocks
  on run correction), engine YTD/karens/liability integration,
  Ingaende saldon section in the employee editor.
- Arbetsschema-lite: employees.hours_per_week/workdays_per_week drive the
  hourly/daily divisors; legacy 173/21 preserved exactly at defaults so
  existing pay math is byte-identical.
- Vacation ledger + semesterberedning/arsavslut: recomputed per-year day
  balances (synced on book/correct, non-fatal), year-close with the
  min-20 floor, 5-year sparade-dagar expiry to forced payout, and a
  2920/2940 drift adjustment via the bookkeeping engine; Semester
  dashboard card with preview-then-confirm dialog.
- Fix: Zod 4 defaults leak through .partial(), which made every sparse
  employee PATCH fail validation and reset defaulted columns.

Migrations 20260713100000/101000/110000/121000/122000 (applied to
staging with version rows; prod via merge). vacation_ledger renamed from
20260713120000 to avoid colliding with vat_declaration_totals_rpc.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* perf: cut dashboard page-load latency (region, round trips, caching, VAT RPC)

The dominant cost was infrastructure: Vercel functions ran in iad1
(Washington D.C.) while Supabase (DB + auth) lives in eu-north-1
(Stockholm), so every request paid 4-5 transatlantic round trips of
auth + company resolution before doing any real work (measured
530-1900ms for single-query GETs in prod logs). Pin functions to arn1
and cut the redundant work on top:

- vercel.json: functions to arn1, same city as the database
- getActiveCompanyId: preference + first-membership queries run in
  parallel; the fallback result doubles as validation in the common
  single-company case (one round trip instead of two sequential)
- withRouteContext: Server-Timing header and authMs/companyMs/handlerMs
  in the op-completed log, so latency is attributable per phase
- dashboard layout: nav badge counts off the critical path; DashboardNav
  loads them client-side via the new use-worklist-badges SWR hook with
  debounced realtime revalidation
- swr (new dependency, approved): global provider; useCompanySettings
  shares one cache entry across consumers and renders from cache on
  back-navigation instead of re-showing skeletons
- /pending: realtime refetch debounced; bulk operations previously
  fired 4 requests per row-change event
- VAT declaration: new get_vat_declaration_totals RPC returns
  per-account totals, settlement-shape detection (#984) and
  source_type counts in ONE round trip instead of paging every
  entry+line through PostgREST. Account lists stay TS-side parameters
  so ACCOUNT_RUTA remains the single source of truth. Shape-exclusion
  coverage moved to tests/pg/vat-declaration-totals-rpc.pg.test.ts;
  DDL already applied to staging.
- bundle: CommandPalette lazy-mounts on first Ctrl/Cmd+K, AgentChat
  dynamic-imports the markdown parser, @vercel/speed-insights (new
  dependency, approved) added for real-user timings

The /salary fetch-waterfall fix from the same effort already landed
inside 2084a756.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): settle öre-rounded payments from the mark-paid flow

An invoice with öresavrundning shows a rounded "Att betala" on the PDF;
the customer pays that amount (up to 50 öre off the stored öre total) and
the invoice-page mark-paid flow rejected it with
MATCH_AMOUNT_EXCEEDS_REMAINING: a dead end, while the bank-transaction
match flow already absorbed the residual to 3740.

- PaymentBookingDialog now proposes the rounded bank leg plus the 3740
  residual line (credit when rounded up, debit when rounded down),
  resolved via getDisplayTotal from the per-invoice override and
  company_settings.ore_rounding.
- settleInvoicePayment and the v1 mark-paid route absorb the sub-krona
  residual, gated by planInvoicePaymentForLines: absorption applies ONLY
  when the caller lines carry the exact residual on 3740; otherwise the
  strict plan applies (sub-krona partials stay partial, no-3740
  overshoots keep the 400), so the GL can never diverge from the AR
  sub-ledger.
- planInvoicePayment absorb-band boundary tightened to >= 1 kr: an
  exactly-1-kr overshoot used to slip past both the guard and the absorb
  branch and silently over-record paid_amount (pre-existing on the
  bank-match path).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(security): resolve all 7 PR compliance findings

- ASVS V3.3: per-request CSP nonce on the enable-banking finalize page
  (mirrors the mcp-oauth consent page); inline scripts are nonce-bound
- ASVS V16: decouple callback finalize work from the response stream
  (eager promise + next/server after()) so a client disconnect cannot
  drop session persistence or the consent_granted audit emit
- ISO 27001 A.8.15: failed audit-event emits log through the structured
  logger with a stable message for log-based alerting
- ASVS V2.3: recurring-invoice cron and run-now routes resolve
  isSandboxCompany themselves and pass an explicit suppressAutoSend flag
  (defence in depth around the email chokepoint, freeze-and-retain kept)
- ISO 27001 A.8.11: stagePendingOperation rejects plaintext
  personnummer-bearing keys in params/preview_data (key-based guard;
  EF org numbers make value-matching unsafe)
- ASVS V4.5: employee PATCH body is truly sparse; cleared number fields
  are omitted instead of resetting DB values to hardcoded fallbacks
- ASVS V8.2.1: route-level tests pin the v1 cross-company deny (404 by
  convention, not 403) on the payslip PDF endpoint

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: implement vacation-year basis change validation and error handling

- Added tests to block vacation-year basis changes when open balances exist.
- Implemented error handling for open-balances guard query failures in the settings route.
- Enhanced absence route to reject reversed date ranges with a validation error.
- Updated absence handling to use atomic upserts instead of delete+insert for better performance and reliability.
- Refactored salary calculation logic to correctly handle age-based avgifter rates according to Skatteverket's rules.
- Improved error messaging for vacation year closure adjustments.
- Adjusted employee opening balances handling to preserve audit information during upserts.

* feat(settings): add validation to block vacation-year basis change with open balances

feat(absence): reject reversed date ranges in absence queries

fix(absence): update absence handling to use atomic upserts instead of delete+insert

fix(employee): improve validation for jamkning dates in employee updates

fix(opening-balances): ensure created_by field is preserved during upserts

test(absence): enhance tests for absence range and date validations

test(calculation): add tests for age-based avgifter rates and edge cases

test(semesterberedning): validate vacation year closure adjustments and error handling

test(employee-opening-balances): update tests to reflect changes in salary_run_employees schema

* fix(migrations): implement NOT VALID constraints for pending_operations and add validation migration

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-13 22:54:33 +02:00

315 lines
10 KiB
TypeScript

/**
* Employee opening balances (payroll cutover) commands.
*
* Shared by the v1 REST routes, the internal UI route, and the MCP
* staged-operation executor (set_employee_opening_balances). See migration
* 20260713101000 for the data model rationale.
*
* Lifecycle: one row per (company, employee), full-replace upsert, editable
* until the employee appears in a BOOKED salary run. The lock is derived
* (checked here for a clean 409; the DB trigger is the all-paths backstop).
*
* Bulk semantics are ATOMIC all-or-nothing: byrå onboarding wants "all
* imported or fix the file"; partial success would force callers to diff.
*/
import type { SupabaseClient } from '@supabase/supabase-js'
import { roundOre } from '@/lib/money'
export type OpeningBalancesResult<T> =
| { ok: true; data: T }
| { ok: false; code: string; details?: Record<string, unknown> }
export interface OpeningBalancesInput {
employee_id: string
cutover_date: string
ytd_gross: number
ytd_tax: number
ytd_net: number
vacation_paid_days_remaining: number
vacation_saved_days_by_year: Record<string, number>
opening_semester_liability: number
opening_semester_liability_avgifter: number
karens_periods_adjustment: number
}
export interface OpeningBalancesRow extends OpeningBalancesInput {
employee_opening_balances_id: string
locked: boolean
locked_by_run_id: string | null
created_at: string
updated_at: string
}
const ROW_COLUMNS =
'id, employee_id, cutover_date, ytd_gross, ytd_tax, ytd_net, ' +
'vacation_paid_days_remaining, vacation_saved_days_by_year, ' +
'opening_semester_liability, opening_semester_liability_avgifter, ' +
'karens_periods_adjustment, created_at, updated_at'
/** Booked-run lock lookup for a set of employees. Returns a map of
* employee_id -> blocking booked run id (absent = unlocked). */
export async function getLockingRuns(
supabase: SupabaseClient,
companyId: string,
employeeIds: string[],
): Promise<OpeningBalancesResult<Map<string, string>>> {
if (employeeIds.length === 0) return { ok: true, data: new Map() }
const { data, error } = await supabase
.from('salary_run_employees')
.select('employee_id, salary_run:salary_runs!inner(id, status)')
.eq('company_id', companyId)
.eq('salary_run.status', 'booked')
.in('employee_id', employeeIds)
if (error) {
return { ok: false, code: 'INTERNAL_ERROR', details: { message: error.message } }
}
const locks = new Map<string, string>()
for (const row of (data ?? []) as unknown as Array<{
employee_id: string
salary_run: { id: string; status: string } | null
}>) {
if (row.salary_run && !locks.has(row.employee_id)) {
locks.set(row.employee_id, row.salary_run.id)
}
}
return { ok: true, data: locks }
}
function toRow(
raw: Record<string, unknown>,
locks: Map<string, string>,
): OpeningBalancesRow {
const { id, ...rest } = raw as { id: string } & Record<string, unknown>
const employeeId = rest.employee_id as string
return {
...(rest as unknown as OpeningBalancesInput),
employee_opening_balances_id: id,
locked: locks.has(employeeId),
locked_by_run_id: locks.get(employeeId) ?? null,
created_at: raw.created_at as string,
updated_at: raw.updated_at as string,
}
}
export async function getOpeningBalances(
supabase: SupabaseClient,
args: { companyId: string; employeeId: string },
): Promise<OpeningBalancesResult<OpeningBalancesRow | null>> {
const { data: employee, error: empErr } = await supabase
.from('employees')
.select('id')
.eq('id', args.employeeId)
.eq('company_id', args.companyId)
.maybeSingle()
if (empErr) {
return { ok: false, code: 'INTERNAL_ERROR', details: { message: empErr.message } }
}
if (!employee) {
return { ok: false, code: 'EMPLOYEE_NOT_FOUND' }
}
const { data, error } = await supabase
.from('employee_opening_balances')
.select(ROW_COLUMNS)
.eq('company_id', args.companyId)
.eq('employee_id', args.employeeId)
.maybeSingle()
if (error) {
return { ok: false, code: 'INTERNAL_ERROR', details: { message: error.message } }
}
if (!data) {
return { ok: true, data: null }
}
const locks = await getLockingRuns(supabase, args.companyId, [args.employeeId])
if (!locks.ok) return locks
return { ok: true, data: toRow(data as unknown as Record<string, unknown>, locks.data) }
}
export interface BulkItemError {
index: number
employee_id: string
code: string
message: string
}
/**
* Atomic bulk upsert. Validates EVERY item against live state first
* (employee exists + active, employment_start <= cutover_date, not locked);
* any failure returns the full per-item error list with ZERO writes.
*/
export async function setOpeningBalancesBulk(
supabase: SupabaseClient,
args: {
companyId: string
userId: string
items: OpeningBalancesInput[]
/** Validate everything, return the would-be rows, write nothing. */
dryRun?: boolean
},
): Promise<
OpeningBalancesResult<{ count: number; rows: OpeningBalancesRow[] }> & {
itemErrors?: BulkItemError[]
}
> {
if (args.items.length === 0) {
return { ok: true, data: { count: 0, rows: [] } }
}
const employeeIds = args.items.map((i) => i.employee_id)
const duplicateIds = employeeIds.filter((id, idx) => employeeIds.indexOf(id) !== idx)
if (duplicateIds.length > 0) {
return {
ok: false,
code: 'VALIDATION_ERROR',
details: { message: 'Duplicate employee_id in items', duplicates: duplicateIds },
}
}
const { data: employees, error: empErr } = await supabase
.from('employees')
.select('id, employment_start, is_active')
.eq('company_id', args.companyId)
.in('id', employeeIds)
if (empErr) {
return { ok: false, code: 'INTERNAL_ERROR', details: { message: empErr.message } }
}
const employeeById = new Map(
((employees ?? []) as Array<{ id: string; employment_start: string; is_active: boolean }>).map(
(e) => [e.id, e],
),
)
const locks = await getLockingRuns(supabase, args.companyId, employeeIds)
if (!locks.ok) return locks
const itemErrors: BulkItemError[] = []
args.items.forEach((item, index) => {
const employee = employeeById.get(item.employee_id)
if (!employee) {
itemErrors.push({
index,
employee_id: item.employee_id,
code: 'EMPLOYEE_NOT_FOUND',
message: 'Employee not found in this company.',
})
return
}
if (!employee.is_active) {
itemErrors.push({
index,
employee_id: item.employee_id,
code: 'EMPLOYEE_NOT_FOUND',
message: 'Employee is inactive; opening balances are for active employees.',
})
return
}
if (employee.employment_start > item.cutover_date) {
itemErrors.push({
index,
employee_id: item.employee_id,
code: 'VALIDATION_ERROR',
message: `cutover_date must be on or after employment_start (${employee.employment_start}).`,
})
return
}
if (locks.data.has(item.employee_id)) {
itemErrors.push({
index,
employee_id: item.employee_id,
code: 'OPENING_BALANCES_LOCKED',
message: `Locked by booked salary run ${locks.data.get(item.employee_id)}.`,
})
}
})
if (itemErrors.length > 0) {
return {
ok: false,
code: 'VALIDATION_ERROR',
details: { item_errors: itemErrors },
itemErrors,
}
}
const rows = args.items.map((item) => ({
company_id: args.companyId,
employee_id: item.employee_id,
cutover_date: item.cutover_date,
ytd_gross: roundOre(item.ytd_gross),
ytd_tax: roundOre(item.ytd_tax),
ytd_net: roundOre(item.ytd_net),
vacation_paid_days_remaining: item.vacation_paid_days_remaining,
vacation_saved_days_by_year: item.vacation_saved_days_by_year,
opening_semester_liability: roundOre(item.opening_semester_liability),
opening_semester_liability_avgifter: roundOre(item.opening_semester_liability_avgifter),
karens_periods_adjustment: item.karens_periods_adjustment,
updated_by: args.userId,
}))
if (args.dryRun) {
return {
ok: true,
data: {
count: rows.length,
rows: rows.map((r) =>
toRow(
{
id: null as unknown as string,
...r,
created_at: null as unknown as string,
updated_at: null as unknown as string,
},
locks.data,
),
),
},
}
}
// created_by is an audit column: it must survive a re-upsert of an
// existing row, so carry the stored value forward and only stamp the
// caller on genuinely new rows.
const { data: existingRows, error: existingErr } = await supabase
.from('employee_opening_balances')
.select('employee_id, created_by')
.eq('company_id', args.companyId)
.in('employee_id', employeeIds)
if (existingErr) {
return { ok: false, code: 'INTERNAL_ERROR', details: { message: existingErr.message } }
}
const createdByByEmployee = new Map(
((existingRows ?? []) as Array<{ employee_id: string; created_by: string | null }>).map(
(r) => [r.employee_id, r.created_by],
),
)
// Single multi-row upsert on the natural key: atomic by construction.
const { data: upserted, error } = await supabase
.from('employee_opening_balances')
.upsert(
rows.map((r) => ({
...r,
created_by: createdByByEmployee.get(r.employee_id) ?? args.userId,
})),
{ onConflict: 'company_id,employee_id' },
)
.select(ROW_COLUMNS)
if (error) {
// The DB lock trigger is the all-paths backstop for the race where a run
// books between our pre-flight and the write.
if (error.code === '23514' || error.message?.includes('låsta')) {
return { ok: false, code: 'OPENING_BALANCES_LOCKED', details: { message: error.message } }
}
return { ok: false, code: 'INTERNAL_ERROR', details: { message: error.message } }
}
const resultRows = ((upserted ?? []) as unknown as Array<Record<string, unknown>>).map((r) =>
toRow(r, locks.data),
)
return { ok: true, data: { count: resultRows.length, rows: resultRows } }
}