* feat: add Accounted MCP namespace * fix(bookkeeping): stop flagging verifikat whose underlag lives on a referenced supplier invoice The missing-underlag surfaces only accepted a document directly linked to the entry, so payment verifikat for supplier invoices (doc on the registration entry per design) and entries whose doc was pinned to the bank transaction before matching were falsely flagged; opening the entry showed the referenced doc and cleared the warning client-side, and it came back on reload. - verifikat_without_documents + transactions_without_documents now treat an entry as covered when a supplier invoice referencing it (registration or payment FK, or a supplier_invoice_payments row) carries a document anchored to a journal entry (BFL 5 kap 7 paragraf hänvisning till underlag; anchoring required because the WORM deletion guards key on document_attachments.journal_entry_id) - match-supplier-invoice routes (dashboard + v1) propagate the transaction's pinned document onto the payment verifikat, mirroring the categorize route; migration backfills rows already written (open unlocked periods, company-guarded, never steals a linked doc) - /api/documents/counts, the transactions-page badges, the bulk "Inget underlag krävs" count and the push-notification scheduler share the same reference-aware predicate, so every surface agrees with the RPC - counts route validates journal_entry_ids as UUIDs (they are interpolated into a PostgREST or-filter) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(transactions): align table columns flush with page edges Collapse the checkbox gutter column to zero width and hang the hover-revealed checkbox/expand chevron in the page margins, drop the outer padding so DATUM sits flush left and STATUS flush right, and tuck the overflow-menu dots under the middle of the STATUS header. Applied to both the inbox and history tables so they stay identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(arsredovisning): tie anlaggningstillgangar note to booked depreciation The ARL 5:8 roll-forward note recomputed depreciation from its own day-based linear formula (365.25/12 month length, non-inclusive day count, linear only), drifting ~20 kr per year per asset from the ledger-driven resultat- and balansrakning and misstating non-linear methods entirely. Note figures now come from posted depreciation_schedules rows (the same source disposeAsset reverses), falling back to the engine's computeAnnualDepreciation when nothing is posted; pre-onboarding opening balances iterate prior years through the engine. Adds a note-vs-trial-balance tie-out warning (accounts 1000-1299, over 1 kr) surfaced before download. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(stripe): move connect and sync surface from settings to import page Stripe's transaction feed is a continuous import source in the same category as the PSD2 bank connection, so its connect/sync surface now lives on the import page as a source card (mode=stripe), gated "kommer snart" on hosted like before; self-hosted keeps the full panel. - Import page: Stripe card after Koppla bank, renders the existing StripeSettingsPanel via the settings-panel registry - OAuth callback and panel cleanup return to /import?mode=stripe - Settings > Betalningar retired: nav item removed, route redirects, PaymentsSettingsContent deleted, legacy ?tab=payments mapped - New import.stripe_* strings in sv+en; dead settings_nav.payments removed Crons and sync logic unchanged; payment-link settings stay in the invoicing section. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(underlag): paginate missing-underlag cron and harden doc-surface queries Resolve PR review findings on bug/invalid-imports: - notification-scheduler: fetchAllRows on all 5 global reads; past 1000 rows the capped reads produced false "saknade underlag" notifications - bulk-missing: LOOKUP_CHUNK 300->150 so the twice-embedded .or() id list stays under the PostgREST URL limit - bulk-missing + transactions page: UUID-guard the .or()-interpolated id lists, matching documents/counts - match-supplier-invoice (dashboard + v1): log documentId/journalEntryId on the non-fatal doc-link warning - well-known/oauth-protected-resource: document the tool_namespace allow-list - messages/en: reword stripe_description - DECISIONS.md: record the asset ibAck tie-out and Tailwind !important calls Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(tic): convert registrationDate from Unix seconds to millisecond epoch in lookup and profile tests --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
233 lines
8.3 KiB
TypeScript
233 lines
8.3 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import {
|
|
computeAssetNoteFigures,
|
|
type PostedScheduleRow,
|
|
type PeriodLike,
|
|
} from '../asset-note-figures'
|
|
import type { Asset } from '@/types'
|
|
|
|
const FP2023: PeriodLike = { id: 'fp2023', period_start: '2023-01-01', period_end: '2023-12-31' }
|
|
const FP2024: PeriodLike = { id: 'fp2024', period_start: '2024-01-01', period_end: '2024-12-31' }
|
|
const FP2025: PeriodLike = { id: 'fp2025', period_start: '2025-01-01', period_end: '2025-12-31' }
|
|
const ALL_PERIODS = [FP2023, FP2024, FP2025]
|
|
|
|
function makeAsset(overrides: Partial<Asset> = {}): Asset {
|
|
return {
|
|
id: 'asset-1',
|
|
user_id: 'user-1',
|
|
company_id: 'company-1',
|
|
name: 'Testinventarie',
|
|
category: 'equipment',
|
|
acquisition_date: '2024-01-01',
|
|
acquisition_cost: 146_000,
|
|
salvage_value: 0,
|
|
useful_life_months: 60,
|
|
depreciation_method: 'linear',
|
|
bas_asset_account: '1220',
|
|
bas_accumulated_account: '1229',
|
|
bas_expense_account: '7832',
|
|
restvarde_target: null,
|
|
disposed_at: null,
|
|
disposed_proceeds: null,
|
|
disposed_proceeds_vat: 0,
|
|
disposed_vat_treatment: null,
|
|
jamkning_amount: 0,
|
|
jamkning_remaining_months: null,
|
|
jamkning_total_months: null,
|
|
jamkning_original_input_vat: null,
|
|
k3_components: null,
|
|
notes: null,
|
|
created_at: '2024-01-01T00:00:00Z',
|
|
updated_at: '2024-01-01T00:00:00Z',
|
|
...overrides,
|
|
} as Asset
|
|
}
|
|
|
|
function posted(
|
|
assetId: string,
|
|
periodId: string,
|
|
amount: number | string,
|
|
): PostedScheduleRow {
|
|
return {
|
|
asset_id: assetId,
|
|
fiscal_period_id: periodId,
|
|
planned_depreciation: amount,
|
|
journal_entry_id: `je-${assetId}-${periodId}`,
|
|
}
|
|
}
|
|
|
|
function figuresFor(
|
|
asset: Asset,
|
|
schedules: PostedScheduleRow[],
|
|
periods: PeriodLike[] = ALL_PERIODS,
|
|
currentPeriodId = 'fp2025',
|
|
) {
|
|
const map = computeAssetNoteFigures({
|
|
assets: [asset],
|
|
postedSchedules: schedules,
|
|
fiscalPeriods: periods,
|
|
currentPeriodId,
|
|
})
|
|
return map.get(asset.id)
|
|
}
|
|
|
|
describe('computeAssetNoteFigures', () => {
|
|
it('uses posted schedule amounts verbatim (regression: 20 kr note drift)', () => {
|
|
// 146,000 kr over 60 months books round(146000 * 12/60) = 29,200/year.
|
|
// The old theoretical formula (base * 365 / (60 * 30.4375)) gave 29,180:
|
|
// the exact 20 kr inconsistency reported against the ledger-driven RR/BR.
|
|
const asset = makeAsset()
|
|
const f = figuresFor(asset, [
|
|
posted('asset-1', 'fp2024', 29_200),
|
|
posted('asset-1', 'fp2025', 29_200),
|
|
])
|
|
expect(f).toEqual({ ibAck: 29_200, aretsAvskrivning: 29_200, avgaendeAck: 0 })
|
|
})
|
|
|
|
it('falls back to the booking engine for the current year when nothing is posted', () => {
|
|
const asset = makeAsset()
|
|
const f = figuresFor(asset, [posted('asset-1', 'fp2024', 29_200)])
|
|
// Engine full-year linear: round(146000 * 12/60) = 29,200, not 29,180.
|
|
expect(f).toEqual({ ibAck: 29_200, aretsAvskrivning: 29_200, avgaendeAck: 0 })
|
|
})
|
|
|
|
it('iterates synthetic prior years through the engine for pre-onboarding assets', () => {
|
|
// Acquired 2023-01-01 but only the current fiscal period exists in the
|
|
// DB and nothing was ever posted: two synthetic 12-month windows.
|
|
const asset = makeAsset({ acquisition_date: '2023-01-01' })
|
|
const f = figuresFor(asset, [], [FP2025])
|
|
expect(f).toEqual({ ibAck: 58_400, aretsAvskrivning: 29_200, avgaendeAck: 0 })
|
|
})
|
|
|
|
it('caps the engine-iterated fallback at the depreciable base after useful life', () => {
|
|
const asset = makeAsset({ acquisition_date: '2010-01-01' })
|
|
const f = figuresFor(asset, [], [FP2025])
|
|
expect(f).toEqual({ ibAck: 146_000, aretsAvskrivning: 0, avgaendeAck: 0 })
|
|
})
|
|
|
|
it('applies declining_balance_30 on the posted book value', () => {
|
|
const asset = makeAsset({
|
|
acquisition_date: '2024-01-01',
|
|
acquisition_cost: 100_000,
|
|
depreciation_method: 'declining_balance_30',
|
|
})
|
|
const f = figuresFor(asset, [posted('asset-1', 'fp2024', 30_000)])
|
|
// Book value 70,000 * 30% = 21,000
|
|
expect(f).toEqual({ ibAck: 30_000, aretsAvskrivning: 21_000, avgaendeAck: 0 })
|
|
})
|
|
|
|
it('floors restvardesavskrivning_25 at the restvarde target', () => {
|
|
const asset = makeAsset({
|
|
acquisition_date: '2024-01-01',
|
|
acquisition_cost: 100_000,
|
|
depreciation_method: 'restvardesavskrivning_25',
|
|
restvarde_target: 50_000,
|
|
})
|
|
const f = figuresFor(asset, [posted('asset-1', 'fp2024', 50_000)])
|
|
expect(f).toEqual({ ibAck: 50_000, aretsAvskrivning: 0, avgaendeAck: 0 })
|
|
})
|
|
|
|
it('sums K3 component depreciation via the engine fallback', () => {
|
|
const asset = makeAsset({
|
|
acquisition_date: '2025-01-01',
|
|
acquisition_cost: 100_000,
|
|
k3_components: [
|
|
{ name: 'Stomme', cost: 80_000, useful_life_months: 120 },
|
|
{ name: 'Tak', cost: 20_000, useful_life_months: 60, salvage_value: 0 },
|
|
],
|
|
})
|
|
const f = figuresFor(asset, [])
|
|
// round(80000 * 12/120) + round(20000 * 12/60) = 8,000 + 4,000
|
|
expect(f).toEqual({ ibAck: 0, aretsAvskrivning: 12_000, avgaendeAck: 0 })
|
|
})
|
|
|
|
it('ignores draft schedules (journal_entry_id null) everywhere', () => {
|
|
const asset = makeAsset()
|
|
const drafts: PostedScheduleRow[] = [
|
|
{ asset_id: 'asset-1', fiscal_period_id: 'fp2024', planned_depreciation: 999, journal_entry_id: null },
|
|
{ asset_id: 'asset-1', fiscal_period_id: 'fp2025', planned_depreciation: 999, journal_entry_id: null },
|
|
]
|
|
const f = figuresFor(asset, drafts)
|
|
// Both fall back to the engine: 2024 via prior-year iteration, 2025 live.
|
|
expect(f).toEqual({ ibAck: 29_200, aretsAvskrivning: 29_200, avgaendeAck: 0 })
|
|
})
|
|
|
|
it('mirrors disposeAsset for in-period disposals: all posted rows reversed, nothing new charged', () => {
|
|
const asset = makeAsset({
|
|
acquisition_date: '2023-01-01',
|
|
disposed_at: '2025-06-30',
|
|
disposed_proceeds: 10_000,
|
|
})
|
|
const f = figuresFor(asset, [
|
|
posted('asset-1', 'fp2023', 29_200),
|
|
posted('asset-1', 'fp2024', 29_200),
|
|
])
|
|
// disposeAsset reversed sumPostedDepreciation() = 58,400; no current-year
|
|
// charge was ever booked, so the note must not invent one.
|
|
expect(f).toEqual({ ibAck: 58_400, aretsAvskrivning: 0, avgaendeAck: 58_400 })
|
|
})
|
|
|
|
it('includes a posted current-year row in the disposal reversal so the asset nets to zero', () => {
|
|
const asset = makeAsset({
|
|
acquisition_date: '2023-01-01',
|
|
disposed_at: '2025-06-30',
|
|
disposed_proceeds: 10_000,
|
|
})
|
|
const f = figuresFor(asset, [
|
|
posted('asset-1', 'fp2023', 29_200),
|
|
posted('asset-1', 'fp2024', 29_200),
|
|
posted('asset-1', 'fp2025', 29_200),
|
|
])
|
|
expect(f).toEqual({ ibAck: 58_400, aretsAvskrivning: 29_200, avgaendeAck: 87_600 })
|
|
expect(f!.ibAck + f!.aretsAvskrivning - f!.avgaendeAck).toBe(0)
|
|
})
|
|
|
|
it('previews engine amounts for disposals with no posted schedules at all', () => {
|
|
const asset = makeAsset({
|
|
acquisition_date: '2023-01-01',
|
|
disposed_at: '2025-06-30',
|
|
disposed_proceeds: 10_000,
|
|
})
|
|
const f = figuresFor(asset, [])
|
|
// Fallback ibAck = 2 full engine years = 58,400. Current year clamps at
|
|
// the disposal date: round(29200 * 181/365) = 14,480. The reversal takes
|
|
// the asset's accumulated depreciation back to zero.
|
|
expect(f).toEqual({ ibAck: 58_400, aretsAvskrivning: 14_480, avgaendeAck: 72_880 })
|
|
})
|
|
|
|
it('coerces NUMERIC string amounts from PostgREST', () => {
|
|
const asset = makeAsset()
|
|
const f = figuresFor(asset, [
|
|
posted('asset-1', 'fp2024', '29200.00'),
|
|
posted('asset-1', 'fp2025', '29200.00'),
|
|
])
|
|
expect(f).toEqual({ ibAck: 29_200, aretsAvskrivning: 29_200, avgaendeAck: 0 })
|
|
})
|
|
|
|
it('omits assets disposed before the period', () => {
|
|
const asset = makeAsset({
|
|
acquisition_date: '2023-01-01',
|
|
disposed_at: '2024-12-31',
|
|
disposed_proceeds: 0,
|
|
})
|
|
const map = computeAssetNoteFigures({
|
|
assets: [asset],
|
|
postedSchedules: [],
|
|
fiscalPeriods: ALL_PERIODS,
|
|
currentPeriodId: 'fp2025',
|
|
})
|
|
expect(map.has('asset-1')).toBe(false)
|
|
})
|
|
|
|
it('throws when the current period is missing from the period list', () => {
|
|
expect(() =>
|
|
computeAssetNoteFigures({
|
|
assets: [makeAsset()],
|
|
postedSchedules: [],
|
|
fiscalPeriods: [FP2024],
|
|
currentPeriodId: 'fp2025',
|
|
}),
|
|
).toThrow('Current fiscal period not found')
|
|
})
|
|
})
|