7448490fb7
* fix(underlag): a verifikat a customer invoice points at is backed by it; PS follows the invoice link (#2298) The invoice-to-verifikat link is written on the invoice side only (invoices.journal_entry_id, invoice_payments.journal_entry_id), while the missing-underlag predicate and the periodisk sammanstallning resolved the invoice from the entry's own source columns. A SIE-imported sale matched to its invoice afterwards therefore kept warning "Underlag saknas" and was left out of the EU sales list, although the account-based momsdeklaration showed it and the verifikat page already listed the invoice as its underlag. - verifikat_without_documents / transactions_without_documents: customer- invoice hanvisning arm (BFL 5 kap 7 §), tenant-scoped on the link row; new migration 20260906135702, pinned by a pg-real test. - getInvoiceReferencesForJournalEntries(): one TS mirror of that arm, used by the journal-list filter and bulk exempt, /api/documents/counts (new invoice_references map) and the transactions list; the push cron mirrors it with its global reads. - Journal list: no "Underlag saknas" chip for a covered entry, matching the engine's own invoice rows and the verifikat detail page. - Periodisk sammanstallning: entries fetched by their EU-revenue lines and attributed through every link (engine source_id, invoices.journal_entry_id, invoice_payments.journal_entry_id); kontantmetod invoice_cash_payment entries are filed too, which the old source_type filter dropped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019SaJfqNi4VmsG8FMKq99G6 * fix(underlag): issued invoices only, blocking mixed-customer settlements in PS, chunk-level degrade (#2298 review) - The customer-invoice hanvisning arms (RPCs, both TS resolvers, push cron) now require an ISSUED invoice: status not in ('draft', 'cancelled'), the schema's own definition (migration 20260427150000). NON_ISSUED_INVOICE_ STATUSES in lib/invoices/matchable-statuses.ts is the shared constant; the pg test pins a draft-linked and a cancelled-payment entry as still missing. - Periodisk sammanstallning: one verifikat linked to invoices of different customers is no longer attributed to the first invoice; it is left out of the accumulators and reported once as a blocking MIXED_CUSTOMER_SETTLEMENT naming the voucher, the customer count and the amount. Same-customer settlements are filed in full. - Transactions list: a failed invoice-reference lookup leaves that chunk's verdict unknown (no badges) and continues with the remaining chunks instead of abandoning them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
89 lines
3.2 KiB
TypeScript
89 lines
3.2 KiB
TypeScript
/**
|
|
* Invoice statuses a bank transaction can still be matched against.
|
|
*
|
|
* These mirror the CAS guards the match routes actually enforce:
|
|
* app/api/transactions/[id]/match-invoice/route.ts (.in('status', ...))
|
|
* app/api/transactions/[id]/match-supplier-invoice/route.ts (.in('status', ...))
|
|
*
|
|
* Every surface that offers a match (suggestion lists, the match dialog, the
|
|
* batch-allocation picker) must filter on the same lists. Offering a target
|
|
* outside them produces a confirm button that can only ever fail with
|
|
* MATCH_INVOICE_ALREADY_PAID / MATCH_SI_ALREADY_PAID.
|
|
*
|
|
* Dependency-free on purpose: client components import this too.
|
|
*/
|
|
export const MATCHABLE_INVOICE_STATUSES = ['sent', 'overdue', 'partially_paid'] as const
|
|
|
|
export const MATCHABLE_SUPPLIER_INVOICE_STATUSES = [
|
|
'registered',
|
|
'approved',
|
|
'overdue',
|
|
'partially_paid',
|
|
] as const
|
|
|
|
export type InvoiceMatchTargetState = 'matchable' | 'settled' | 'not_open'
|
|
|
|
type MatchCandidate = {
|
|
status?: string | null
|
|
remaining_amount?: number | null
|
|
}
|
|
|
|
function getMatchTargetState(
|
|
candidate: MatchCandidate | null | undefined,
|
|
matchableStatuses: readonly string[],
|
|
): InvoiceMatchTargetState {
|
|
if (!candidate?.status) return 'not_open'
|
|
|
|
const hasMatchableStatus = matchableStatuses.includes(candidate.status)
|
|
if (!hasMatchableStatus) {
|
|
return candidate.status === 'paid' ? 'settled' : 'not_open'
|
|
}
|
|
|
|
return (candidate.remaining_amount ?? 0) > 0 ? 'matchable' : 'settled'
|
|
}
|
|
|
|
export function getInvoiceMatchTargetState(
|
|
candidate: MatchCandidate | null | undefined,
|
|
): InvoiceMatchTargetState {
|
|
return getMatchTargetState(candidate, MATCHABLE_INVOICE_STATUSES)
|
|
}
|
|
|
|
export function getSupplierInvoiceMatchTargetState(
|
|
candidate: MatchCandidate | null | undefined,
|
|
): InvoiceMatchTargetState {
|
|
return getMatchTargetState(candidate, MATCHABLE_SUPPLIER_INVOICE_STATUSES)
|
|
}
|
|
|
|
/**
|
|
* A candidate is matchable when its status is still open AND it has an
|
|
* outstanding balance. Both columns are NOT NULL in the schema (migrations
|
|
* 20240101000025 / 20260323120001), so a missing value cannot silently hide a
|
|
* legitimate suggestion here.
|
|
*/
|
|
export function isMatchableInvoice(
|
|
candidate: MatchCandidate | null | undefined,
|
|
): boolean {
|
|
return getInvoiceMatchTargetState(candidate) === 'matchable'
|
|
}
|
|
|
|
export function isMatchableSupplierInvoice(
|
|
candidate: MatchCandidate | null | undefined,
|
|
): boolean {
|
|
return getSupplierInvoiceMatchTargetState(candidate) === 'matchable'
|
|
}
|
|
|
|
/**
|
|
* Statuses under which an invoice has NOT been issued: no document exists that
|
|
* could serve as underlag for a verifikat. The schema says the same thing from
|
|
* the other side (migration 20260427150000: an invoice outside these statuses
|
|
* must carry an invoice_number). Every reader that treats a customer invoice
|
|
* pointing at a verifikat as its underlag (BFL 5 kap 7 § hänvisning) must
|
|
* exclude these, in step with the SQL arm in verifikat_without_documents /
|
|
* transactions_without_documents (migration 20260906135702, #2298).
|
|
*/
|
|
export const NON_ISSUED_INVOICE_STATUSES = ['draft', 'cancelled'] as const
|
|
|
|
/** PostgREST `not.in` literal for {@link NON_ISSUED_INVOICE_STATUSES}. */
|
|
export const NON_ISSUED_INVOICE_STATUSES_FILTER =
|
|
'(' + NON_ISSUED_INVOICE_STATUSES.map((s) => `"${s}"`).join(',') + ')'
|