MattssonandClaude Fable 5.1
51f05ffeba
CodeQL / Analyze (javascript-typescript) (push) Failing after 10m53s
CodeQL / Analyze (actions) (push) Failing after 10m43s
Build and Push Docker Image / Build linux/arm64 (push) Has been cancelled
Build and Push Docker Image / Merge, sign and scan (push) Has been cancelled
Build and Push Docker Image / Build linux/amd64 (push) Failing after 3m4s
Workflow audit (zizmor) / Audit workflows (push) Failing after 5m54s
* feat(dashboard): dismissible system notice banner for every signed-in user
Operator-set banner ("high load right now, some pages may respond slowly
or fail") rendered under the dashboard chrome for every signed-in user
while NEXT_PUBLIC_SYSTEM_NOTICE_UNTIL (ISO timestamp with offset) is in
the future. Closing it stores the deadline in localStorage, so each
browser sees it once; the banner hides itself at the deadline in open
tabs and is not rendered at all after it.
Why the problem occurred: there was no way to tell every user something
about the system itself. The existing banners are all per-company state
(sandbox, seat grace), so an operator notice had no home.
What was removed or simplified instead: no notices table, no migration,
no admin UI. One public env var carries both the on/off switch and the
expiry, and the same value is the dismiss key, so a later notice re-shows
once without any code change. No DB read, which matters because the
first use is a DB restart window.
Why this over the proposed shape: the request was a banner "until 23:00
tonight". Hardcoding that in code would need a second PR to switch off
or reuse; a DB-backed notice would read the database that is about to
go down. The env var expires on its own, and unset means gone.
Fixes #2463
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fs9PfHL7KpdidvUdxVkHXF
* fix(dashboard): system notice survives long deadlines, blocked storage, and every layout shell
Skeptic findings on 839a255f3:
- setTimeout clamps delays above 2^31-1 ms to ~1 ms, so a deadline more
than 24.8 days out hid the banner instantly. Wait in bounded steps and
re-check the clock.
- window.localStorage is a throwing property access when a browser blocks
site data; read it behind a try so the dashboard never crashes over a
notice.
- The close button was a hand-rolled 22px icon button; design.md requires
the shadcn icon Button (40px target).
- The byrå-consultant shell and the stale-cookie shell rendered no banner,
so "every signed-in user" was not true. The banner is now computed once,
before the shell branches, and mounted in all three.
Refs #2463
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fs9PfHL7KpdidvUdxVkHXF
* fix(dashboard): system notice deadline requires a UTC offset
A date-time without Z or a numeric offset parses as local time, which is
UTC on Vercel and the operator's zone locally, so the same value would
mean different instants. Reject it instead (CodeRabbit on #2464).
Declined: scoping the dismissal key by user id. The notice is about the
system, not the account; per-browser dismissal is the sandbox banner's
semantics and keeps identity out of layout chrome.
Refs #2463
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Fs9PfHL7KpdidvUdxVkHXF
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
86 lines
3.1 KiB
TypeScript
86 lines
3.1 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import {
|
|
SYSTEM_NOTICE_STORAGE_KEY,
|
|
dismissSystemNotice,
|
|
isSystemNoticeDismissed,
|
|
parseSystemNoticeUntil,
|
|
} from '../system-notice'
|
|
|
|
const NOW = Date.parse('2026-09-10T12:00:00+02:00')
|
|
|
|
function memoryStorage(initial: Record<string, string> = {}) {
|
|
const map = new Map(Object.entries(initial))
|
|
return {
|
|
getItem: (k: string) => map.get(k) ?? null,
|
|
setItem: (k: string, v: string) => {
|
|
map.set(k, v)
|
|
},
|
|
map,
|
|
}
|
|
}
|
|
|
|
describe('parseSystemNoticeUntil', () => {
|
|
it('returns the deadline while it is in the future', () => {
|
|
expect(parseSystemNoticeUntil('2026-09-10T23:00:00+02:00', NOW)).toBe(
|
|
Date.parse('2026-09-10T23:00:00+02:00'),
|
|
)
|
|
expect(parseSystemNoticeUntil(' 2026-09-10T23:00:00+02:00 ', NOW)).not.toBeNull()
|
|
})
|
|
|
|
it('returns null once the deadline has passed, or at the exact instant', () => {
|
|
expect(parseSystemNoticeUntil('2026-09-10T11:00:00+02:00', NOW)).toBeNull()
|
|
expect(parseSystemNoticeUntil('2026-09-10T12:00:00+02:00', NOW)).toBeNull()
|
|
})
|
|
|
|
it('accepts Z and compact offsets, rejects a date-time without any offset', () => {
|
|
expect(parseSystemNoticeUntil('2026-09-10T21:00:00Z', NOW)).toBe(
|
|
Date.parse('2026-09-10T23:00:00+02:00'),
|
|
)
|
|
expect(parseSystemNoticeUntil('2026-09-10T23:00:00+0200', NOW)).toBe(
|
|
Date.parse('2026-09-10T23:00:00+02:00'),
|
|
)
|
|
// Local-time parse would differ between Vercel (UTC) and a laptop.
|
|
expect(parseSystemNoticeUntil('2026-09-10T23:00:00', NOW)).toBeNull()
|
|
expect(parseSystemNoticeUntil('2026-09-10', NOW)).toBeNull()
|
|
})
|
|
|
|
it('returns null for unset, blank, or unparseable values', () => {
|
|
expect(parseSystemNoticeUntil(undefined, NOW)).toBeNull()
|
|
expect(parseSystemNoticeUntil(null, NOW)).toBeNull()
|
|
expect(parseSystemNoticeUntil('', NOW)).toBeNull()
|
|
expect(parseSystemNoticeUntil(' ', NOW)).toBeNull()
|
|
expect(parseSystemNoticeUntil('tonight', NOW)).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('dismissal', () => {
|
|
const until = Date.parse('2026-09-10T23:00:00+02:00')
|
|
|
|
it('is not dismissed until the user closes it, then stays closed for that deadline', () => {
|
|
const storage = memoryStorage()
|
|
expect(isSystemNoticeDismissed(storage, until)).toBe(false)
|
|
dismissSystemNotice(storage, until)
|
|
expect(storage.map.get(SYSTEM_NOTICE_STORAGE_KEY)).toBe(String(until))
|
|
expect(isSystemNoticeDismissed(storage, until)).toBe(true)
|
|
})
|
|
|
|
it('shows a later notice again: the dismissal is keyed by deadline', () => {
|
|
const storage = memoryStorage({ [SYSTEM_NOTICE_STORAGE_KEY]: String(until) })
|
|
expect(isSystemNoticeDismissed(storage, until + 86_400_000)).toBe(false)
|
|
})
|
|
|
|
it('treats missing or throwing storage as not dismissed', () => {
|
|
expect(isSystemNoticeDismissed(null, until)).toBe(false)
|
|
const throwing = {
|
|
getItem: () => {
|
|
throw new Error('blocked')
|
|
},
|
|
setItem: () => {
|
|
throw new Error('blocked')
|
|
},
|
|
}
|
|
expect(isSystemNoticeDismissed(throwing, until)).toBe(false)
|
|
expect(() => dismissSystemNotice(throwing, until)).not.toThrow()
|
|
})
|
|
})
|