Files
accounted/components/bookkeeping/accrual-k2-hint.ts
T
MattssonandClaude Fable 5.1 26e29f47bc feat(company): ideell förening as a third legal form, behind a flag (#2072 step 1) (#2423)
* feat(company): ideell förening as a third legal form, behind a flag (#2072 step 1)

Why the problem occurred: the legal form was modelled as a binary flag in
~300 files. `EntityType` was a two-member union, but nothing dispatched on it
exhaustively: 28 sites defaulted `?? 'enskild_firma'` (invoice, categorize,
match, stripe, invoice-inbox) or `?? 'aktiebolag'` (year-end, bokslut,
MCP), and every form-dependent choice was an `=== 'aktiebolag' ? A : B`
ternary. Widening the union compiled everywhere and changed nothing, so a
förening would have booked as an enskild firma in the app and as an
aktiebolag in bokslut and MCP, with no error anywhere. The lookup refused
föreningar at the door (mapEntityType returned null), which is what the
tester hit.

What was removed or simplified: the silent defaults. One module,
lib/company/entity-type.ts, now holds the list (ENTITY_TYPES), the parser
(never defaults), the resolver (settings hint, then companies.entity_type,
then throw) and `byEntityType`, whose Record arms make the compiler refuse
the next widening until each site has an answer. The form-dependent facts
(closing account, owner settlement account, calendar-year lock, default
method, K1/K2 label, personnummer vs 16-prefix) live there once instead of
in the ternaries. On the SQL side supported_entity_types() replaces four
copies of the literal list in the create RPCs.

Why this shape and not the proposed one: the tracker asked for the enum
widening plus a chart; that alone was the dangerous version (compiles, books
wrong). Bundling stiftelse was considered and dropped: identical plumbing but
no chart block. Creation sits behind NEXT_PUBLIC_IDEELL_FORENING_ENABLED so
the CHECK, RPCs and seed can ship now and the first partner is switched on
without a migration; the flag goes when Phase 2 (packs, INK3, årsbokslut,
Swish) lands on the tracker.

Domain choices (DECISIONS.md 2026-09-08, verify with an accountant before
Phase 2): result closes to 2069 with 2068 as prior-year carry; no owner
accounts, member settlement on 2890; accrual default; brutet räkenskapsår
allowed; K1 label for the 5 000 kr accrual threshold (BFNAR 2010:1); org
number gets the 16 prefix.

Migration 20260908110835 widens the three CHECK constraints, adds
supported_entity_types(), re-creates the three create RPCs with the widened
guard and adds the förening block to seed_chart_of_accounts. Applied to
staging and covered by ideell-forening-entity-type.pg.test.ts.

Part of #2072

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PdGafpUA7jVV1oYjkwfQCh

* fix(company): close the förening paths the skeptic refuted (#2072)

Five refutations from the /skeptic pass on 7a05c54d2, each fixed at the
shared definition rather than the reported site:

1. Privately paid supplier invoices and the utlägg dialog resolved the owner
   account in lib/expenses/payer.ts with its own AB/EF ternary, so a förening
   member's invoice was built on 2893 and then refused by the expense-claim
   service (which already said 2890), burning an ankomstnummer. The helper now
   uses ownerSettlementAccount.
2. Booking templates substitute their `_ab` accounts only for an aktiebolag;
   the `private_expense` template kept its base 2013 for a förening. Template
   accounts now resolve through templateAccountForForm: EF base, AB override,
   förening base with owner accounts translated to 2890 (booking-templates.ts
   and proposal-lines.ts share it).
3. A VAT-registered förening with helårsmoms got no momsdeklaration deadline:
   the annual VAT rule bailed on anything but AB/EF. A förening is a juridisk
   person and follows the räkenskapsår schedule (SFL 26 kap 33 §), so the rule
   now keys on fiscalYearLockedToCalendar instead of the two literals; same in
   the MCP VAT report.
4. 2069 would have accumulated across years: the year-open omföring was
   AB-only with 2099/2098 hard-coded. planResultAppropriation now takes the
   pair from resultClosingAccounts (AB 2099 -> 2098, förening 2069 -> 2068)
   and skips forms with no carry (EF).
5. With the flag off, a registry lookup that returned "Ideell förening" was
   prefilled into the onboarding journey, the form picker was skipped and the
   create step answered "Ogiltig företagsform" with no way back. The
   journey, the BankID picker, the onboarding page and the MCP lookup now use
   mapSetupEntityType, which maps only creatable forms, so a flagged-off form
   falls through to the picker as before.

Also: form picker keeps its AB-first order; tests for each fix.

Part of #2072

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PdGafpUA7jVV1oYjkwfQCh

* chore(migrations): move ideell förening migration after main's latest version (20260908143051)

Two migrations landed on main after the branch forked; a lower version
would be skipped by the merge-time apply. Staging history row renamed to
match.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PdGafpUA7jVV1oYjkwfQCh

* chore(skills): regenerate accounted-api reference for the widened entity_type enum

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PdGafpUA7jVV1oYjkwfQCh

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-08 14:47:50 +02:00

97 lines
3.7 KiB
TypeScript

/**
* K2 vasentlighetsgrans for periodisering, extracted as a pure helper so it
* can be unit-tested (this repo's Vitest runs in a node environment and does
* not render components).
*
* K2 (BFNAR 2016:10) lets a smaller company skip accruing individual
* recurring costs below 5 000 kr that do not fluctuate more than 20 % year
* over year; personnel costs must always be accrued. It is a simplification
* the company MAY use, never an obligation, so the UI copy it drives is
* advisory only. That is exactly why it must not fire on an amount we cannot
* express in kronor: an advisory nudge based on the wrong unit is worse than
* no nudge at all.
*
* The invoice editors hold line amounts in the invoice's currency. A 500 EUR
* line is roughly 5 750 kr and therefore ABOVE the threshold, but a naive
* `amount < 5000` reads it as below (and a 400 USD line reads the reverse
* way once the rate moves). Converting needs an FX rate. The supplier-invoice
* form has one (Riksbanken-fetched or hand-typed); the customer-invoice
* editor has none. When no rate is available we return null and the caller
* shows nothing, rather than guessing a branch.
*/
/** BFNAR 2016:10: the K2 accrual simplification ceiling, in SEK. */
import type { EntityType } from '@/types'
import { simplifiedYearEndRegelverk } from '@/lib/company/entity-type'
export const K2_ACCRUAL_THRESHOLD_SEK = 5000
export interface AccrualAmountInput {
/** Net line amount, expressed in `currency`. */
amount: number
/** ISO currency code of `amount`. Missing/empty is treated as SEK. */
currency?: string | null
/** SEK per one unit of `currency`. Required to convert anything non-SEK. */
exchangeRate?: number | null
}
/**
* The line amount in SEK, or null when it cannot be determined.
*
* Deliberately NOT `resolveSekAmount()` from `@/lib/bookkeeping/currency-utils`:
* that helper falls back to returning the foreign amount untouched, which is
* the silent wrong-unit branch this helper exists to avoid.
*/
export function resolveAccrualAmountSek({
amount,
currency,
exchangeRate,
}: AccrualAmountInput): number | null {
if (typeof amount !== 'number' || !Number.isFinite(amount)) return null
const code = (currency ?? '').trim().toUpperCase()
if (code === '' || code === 'SEK') {
return Math.round(amount * 100) / 100
}
if (
typeof exchangeRate !== 'number' ||
!Number.isFinite(exchangeRate) ||
exchangeRate <= 0
) {
return null
}
return Math.round(amount * exchangeRate * 100) / 100
}
/**
* Whether to show the "below 5 000 kr need not be deferred" hint.
*
* False whenever the SEK value is unknown: no hint beats a hint measured in
* the wrong currency.
*/
export function shouldShowK2AccrualHint(input: AccrualAmountInput): boolean {
const amountSek = resolveAccrualAmountSek(input)
if (amountSek === null) return false
return amountSek > 0 && amountSek < K2_ACCRUAL_THRESHOLD_SEK
}
/**
* Which `accruals.*` message key carries the materiality hint for the given
* entity type. An enskild firma normally closes under K1 (BFNAR 2006:1,
* förenklat årsbokslut), which relieves posts below 5 000 kr; citing K2
* (BFNAR 2016:10) at a sole trader names a regelverk that does not apply to
* it. There is no stored förenklat-vs-full-årsbokslut flag, so entity_type
* is a proxy and the copy stays advisory ("behöver normalt inte").
*
* Unknown/missing entity keeps the K2 wording: it is the historical default
* and correct for every aktiebolag.
*/
export function accrualHintKey(
entityType?: EntityType | null,
): 'k1_hint' | 'k2_hint' {
if (!entityType) return 'k2_hint'
return simplifiedYearEndRegelverk(entityType) === 'K1' ? 'k1_hint' : 'k2_hint'
}