Files
accounted/app/api/bookkeeping/no-doc-required/bulk-missing/__tests__/route.test.ts
T
MattssonandClaude Fable 5.1 2f787a2b3c fix(bookkeeping): send each missing-underlag lookup chunk once per URL (#2430)
* fix(bookkeeping): send each missing-underlag lookup chunk once per URL

The "verifikat utan underlag" filter (/bookkeeping?missingUnderlag=true)
failed with "Verifikaten kunde inte hamtas" on a self-hosted instance as
soon as the candidate set passed one chunk of 150 ids.

Why it occurred: resolveMissingUnderlagEntries issues four lookups per
chunk. Three carry the id list once; the supplier_invoices lookup
interpolated the same chunk twice into a single .or() over
registration_journal_entry_id and payment_journal_entry_id. That URL
alone crossed the 8 KB header buffer nginx/Kong ship with, so the
gateway answered 414 before PostgREST saw the request. Hosted sits at
roughly half of Cloudflare's 16 KB ceiling on the same query. The
LOOKUP_CHUNK docblock acknowledged the doubling without sizing for it.

What was removed: the runtime-built .or() string, the chunkInList
helper and its uuid guard (the .in() array filter is injection-safe on
its own). The supplier-invoice lookup is now two .in() queries, one per
FK column, merged into the same set, so every request carries the chunk
exactly once and the proxy limit stops being a dependency rather than
moving. LOOKUP_CHUNK stays 150 and its comment is now true. The
literal filter also leaves the phantom-column scanner's unresolvable
budget.

Two secondary defects from the same report: MissingUnderlagQueryError
now carries the raw driver error as `cause` and the journal-entries
route logs it, while the response keeps the Swedish text (the log used
to say only "Nagot gick fel", hiding the 414). The "Visa saknade
underlag" badge renders the total of the last successful filtered fetch
and hides on failure, instead of borrowing the list count (0 on a
failed first load, the whole ledger after a toggle).

Alternatives: halving LOOKUP_CHUNK moves the wall instead of removing
it. Pushing the list filters into the verifikat_without_documents RPC
and deleting the TS mirror leaves one predicate instead of two, but
moves search, series, date and sort into SQL; recorded in DECISIONS.md
as the intended next step for the surface owner.

Fixes #2395

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q4kpVfYooLp8CWeUguRVpQ

* fix(bookkeeping): hide the underlag badge on network failure, log the bulk route's cause

Skeptic findings on aacb17634. The badge contract is "no honest source,
no badge": the non-OK branch cleared missingCount but the network-level
catch (offline, aborted body, JSON parse rejection) did not, so a period
or series change that failed at that level kept the previous filtered
total next to the toggle. The bulk "Inget underlag kravs" route had the
same log gap as the list route: it returned the mapped text without
logging the driver error, so a gateway 414 on that path stayed
invisible.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Q4kpVfYooLp8CWeUguRVpQ

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-08 16:35:41 +02:00

194 lines
8.8 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest'
import { parseJsonResponse, createQueuedMockSupabase } from '@/tests/helpers'
import { NextResponse } from 'next/server'
const { supabase: mockSupabase, enqueue, reset } = createQueuedMockSupabase()
vi.mock('@/lib/auth/require-auth', () => ({ requireAuth: vi.fn() }))
vi.mock('@/lib/company/context', () => ({ getActiveCompanyId: vi.fn() }))
vi.mock('@/lib/auth/require-write', () => ({ requireWritePermission: vi.fn() }))
const { mockLogError } = vi.hoisted(() => ({ mockLogError: vi.fn() }))
vi.mock('@/lib/logger', () => {
const logger = {
info: vi.fn(),
warn: vi.fn(),
error: mockLogError,
child: (): unknown => logger,
}
return { createLogger: () => logger }
})
import { POST } from '../route'
import { requireAuth } from '@/lib/auth/require-auth'
import { getActiveCompanyId } from '@/lib/company/context'
import { requireWritePermission } from '@/lib/auth/require-write'
const mockUser = { id: 'user-1', email: 't@t.se' }
function makeReq(body: unknown) {
return new Request('http://localhost/api/bookkeeping/no-doc-required/bulk-missing', {
method: 'POST',
headers: { 'content-type': 'application/json' },
body: JSON.stringify(body),
})
}
beforeEach(() => {
vi.clearAllMocks()
reset()
;(requireAuth as ReturnType<typeof vi.fn>).mockResolvedValue({ user: mockUser, supabase: mockSupabase })
;(getActiveCompanyId as ReturnType<typeof vi.fn>).mockResolvedValue('company-1')
;(requireWritePermission as ReturnType<typeof vi.fn>).mockResolvedValue({ ok: true })
})
describe('POST /api/bookkeeping/no-doc-required/bulk-missing', () => {
it('returns 401 when not authenticated', async () => {
;(requireAuth as ReturnType<typeof vi.fn>).mockResolvedValue({
error: NextResponse.json({ error: 'Unauthorized' }, { status: 401 }),
})
const res = await POST(makeReq({}))
expect((await parseJsonResponse(res)).status).toBe(401)
})
it('returns 403 for read-only members', async () => {
;(requireWritePermission as ReturnType<typeof vi.fn>).mockResolvedValue({
ok: false,
response: NextResponse.json({ error: 'forbidden' }, { status: 403 }),
})
const res = await POST(makeReq({}))
expect((await parseJsonResponse(res)).status).toBe(403)
})
it('returns 400 for a non-uuid period_id', async () => {
const res = await POST(makeReq({ period_id: 'not-a-uuid' }))
expect((await parseJsonResponse(res)).status).toBe(400)
})
it('returns 400 for a shaped-but-invalid date', async () => {
const res = await POST(makeReq({ date_from: '9999-99-99' }))
expect((await parseJsonResponse(res)).status).toBe(400)
})
it('returns 400 for an invalid series filter', async () => {
const res = await POST(makeReq({ series: 'all' }))
expect((await parseJsonResponse(res)).status).toBe(400)
})
// Queue order per candidate chunk mirrors resolveMissingUnderlagEntries:
// documents, SI references (registration FK, then payment FK), SI payment-row
// references, exemptions, then the
// customer-invoice resolver (invoices by journal_entry_id, invoice_payments).
it('dry_run counts only entries that are missing AND not exempt', async () => {
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }], error: null }) // candidates
enqueue({ data: [{ journal_entry_id: 'a' }], error: null }) // a has a document
enqueue({ data: [], error: null }) // no SI references with docs (registration FK)
enqueue({ data: [], error: null }) // no SI references with docs (payment FK)
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [{ journal_entry_id: 'b' }], error: null }) // b already exempt
enqueue({ data: [], error: null }) // no invoices pointing at the entries
enqueue({ data: [], error: null }) // no invoice payment rows
const res = await POST(makeReq({ dry_run: true }))
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
expect(status).toBe(200)
expect(body.data.count).toBe(1) // only c
})
it('dry_run excludes entries covered by a supplier-invoice reference with an anchored doc', async () => {
// a: covered via supplier_invoices.registration_journal_entry_id
// b: covered via a supplier_invoice_payments row whose SI has an anchored doc
// c: genuinely missing
// d: SI reference exists but its doc is UNANCHORED (deletable) → still missing
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }, { id: 'd' }], error: null }) // candidates
enqueue({ data: [], error: null }) // no direct documents
enqueue({
data: [
{
registration_journal_entry_id: 'a',
payment_journal_entry_id: null,
document: { journal_entry_id: 'a' },
},
{
registration_journal_entry_id: 'd',
payment_journal_entry_id: null,
document: { journal_entry_id: null },
},
],
error: null,
})
enqueue({ data: [], error: null }) // no SI references via payment FK
enqueue({
data: [
{
journal_entry_id: 'b',
supplier_invoice: { document_id: 'doc-1', document: { journal_entry_id: 'x' } },
},
],
error: null,
})
enqueue({ data: [], error: null }) // no exemptions
enqueue({ data: [], error: null }) // no invoices pointing at the entries
enqueue({ data: [], error: null }) // no invoice payment rows
const res = await POST(makeReq({ dry_run: true }))
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
expect(status).toBe(200)
expect(body.data.count).toBe(2) // c and d
})
it('dry_run excludes entries a customer invoice points at (#2298)', async () => {
// a: the invoice register links it directly (invoices.journal_entry_id)
// b: a SIE-imported voucher matched to an invoice (invoice_payments row)
// c: genuinely missing
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }], error: null }) // candidates
enqueue({ data: [], error: null }) // no direct documents
enqueue({ data: [], error: null }) // no SI references (registration FK)
enqueue({ data: [], error: null }) // no SI references (payment FK)
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [], error: null }) // no exemptions
enqueue({ data: [{ id: 'inv-1', journal_entry_id: 'a' }], error: null })
enqueue({ data: [{ id: 'pay-1', invoice_id: 'inv-2', journal_entry_id: 'b' }], error: null })
const res = await POST(makeReq({ dry_run: true }), { params: Promise.resolve({}) })
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
expect(status).toBe(200)
expect(body.data.count).toBe(1) // only c
})
it('marks the missing entries and returns the count', async () => {
enqueue({ data: [{ id: 'a' }, { id: 'b' }, { id: 'c' }], error: null }) // candidates
enqueue({ data: [], error: null }) // no documents
enqueue({ data: [], error: null }) // no SI references with docs (registration FK)
enqueue({ data: [], error: null }) // no SI references with docs (payment FK)
enqueue({ data: [], error: null }) // no SI payment-row references
enqueue({ data: [{ journal_entry_id: 'a' }], error: null }) // a already exempt
enqueue({ data: [], error: null }) // no invoices pointing at the entries
enqueue({ data: [], error: null }) // no invoice payment rows
enqueue({ error: null }) // helper upsert
const res = await POST(makeReq({ period_id: null, reason: 'Importerad' }))
const { status, body } = await parseJsonResponse<{ data: { exempted: number } }>(res)
expect(status).toBe(200)
expect(body.data.exempted).toBe(2) // b and c
})
it('logs the driver error and answers with the mapped text when a lookup fails (#2395)', async () => {
enqueue({ data: [{ id: 'a' }], error: null }) // candidates
enqueue({ data: [], error: null }) // no documents
const driverError = { message: 'Request-URI Too Large', code: '414', details: null, hint: null }
enqueue({ data: null, error: driverError }) // SI by registration FK: gateway refused the URL
const res = await POST(makeReq({ dry_run: true }), { params: Promise.resolve({}) })
const { status, body } = await parseJsonResponse<{ error: string }>(res)
expect(status).toBe(400)
expect(typeof body.error).toBe('string')
const call = mockLogError.mock.calls.find(([msg]) => msg === 'failed to resolve missing-underlag entries')
expect(call).toBeDefined()
expect(call![2]).toEqual({ cause: driverError })
})
it('short-circuits to 0 when no candidates match the filters', async () => {
enqueue({ data: [], error: null }) // no candidates
const res = await POST(makeReq({ dry_run: true }))
const { status, body } = await parseJsonResponse<{ data: { count: number } }>(res)
expect(status).toBe(200)
expect(body.data.count).toBe(0)
})
})