Files
accounted/lib/salary/payment/bank-account.ts
T
MattssonandClaude Fable 5 98d0c7f2d0 Add/stripe skv (#1004)
* fix(salary): align pain.001 salary file with the Swedish domestic bank dialect

Verified against the Swedish Common Interpretation of ISO 20022
(Bankforeningen, Common Payment Types in Sweden, Appendix 1 Example 4:
Salaries) and Nordea Corporate Access pain.001 examples v2.6 (2026-06-22),
and XSD-validated against the official pain.001.001.03 schema:

- drop SvcLvl SEPA (SEPA credit transfers are EUR-only; omitting SvcLvl
  gets the domestic NURG default)
- drop RmtInf (not allowed for SALA salary payments; the beneficiary
  statement text comes from the Dataclearing LON code)
- address employees domestically: clearing as CdtrAgt ClrSysMmbId SESBA,
  account WITHOUT clearing as CdtrAcct Othr with SchmeNm BBAN
- share the clearing/account split (Swedbank 5-digit shift, Nordea
  personkonto prefix dedup) between the LB and pain.001 generators via
  splitDomesticBankAccount, fixing pain.001 duplicating the personkonto
  clearing
- clamp MsgId/PmtInfId/InstrId/EndToEndId to Max35Text with the per-tx
  counter surviving truncation; carry the org number on Dbtr
- return 400 from the pain001 route on an invalid clearing instead of
  emitting a broken file

Also includes two unrelated decision-log lines from the parallel
revisor-review session (DECISIONS.md is a shared append-only log).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(nav): surface the year-end chain in the sidebar

Add Periodiseringar, Arsredovisning (aktiebolag only) and
Inkomstdeklaration (INK2 for AB, NE-bilaga for EF) to the Skatt &
bokslut group, in workflow order. Entity gating via a new entityOnly
flag on NavItem; isActive carve-outs extended so exactly one row
lights up for the new routes. Driven by an external revisor review
that concluded these features did not exist because none of them
were reachable from the nav.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(stripe): Stripe Connect integration behind config gate

Connect OAuth per company (only the acct_ id is stored), automatic
single-use Payment Links on invoice send, deterministic payment
settlement against 1686 (BAS moved acquirer receivables 1580 -> 1686),
payout booking with reverse-charge fees (6570 + 4535/4598 + 2645/2614),
and a 15-minute sync cron. Non-deterministic events land as
needs_review, never guessed at.

Fully dark without STRIPE_CONNECT_CLIENT_ID: connect returns 503, the
send hook and cron no-op, and the settings page shows 'Kommer snart'
(hosted) until the Connect platform is verified. Self-hosted keeps the
honest not-configured message.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(deadlines): add shared completeTaxDeadline and fix dead AGI deadline auto-complete

generate-declaration.ts has updated non-existent columns (type/period/
status) since inception, so the arbetsgivardeklaration deadline was
never auto-completed. Replace with a shared helper targeting the real
schema (tax_deadline_type/tax_period/is_completed), also used by the
kvittens crons and moms handlers in the follow-up commit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(rot-rut): import Skatteverket beslutsfil and record decisions on payout requests

Parse the beslutsfil JSON from Skatteverkets rot/rut e-tjanst and record
godkant belopp on the matching begaran: matched by stored
skv_referensnummer first, then exact name among active undecided
requests; arenden by fakturanummer then personnummer, exactly-one or the
beslut errors (all-or-nothing). Never auto-settles: recording the beslut
and booking the payout are separate acts. Exposed as an API route and
the gnubok_import_rot_rut_beslut MCP tool.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(skatteverket): system auth for background reads, one-click VAT submit, kvittens notifications

Hybrid auth program: system CCG (org certificate) for background reads
while personal BankID stays for interactive submissions, since SKV
per-flow refresh tokens live 65 min and crons structurally cannot run
on them. All system-auth code sits behind SKATTEVERKET_SYSTEM_AUTH_MODE
(default off) with a stub transport until the Expisoft cert and CCG
avtal land; auth resolution is centralized in resolve-auth.ts.

Also in this change:
- One-click VAT submit chaining kontrollera -> utkast -> las
  server-side with a stage discriminator; step-by-step buttons demoted
  to the overflow menu.
- Kvittens crons (AGI + new VAT schedule) with email-only
  notifications, deduped in notification_log under the new
  skv_kvittens type.
- Ombud grant probe + verification UI in the connect panel, and a
  dashboard promo card for unconnected companies.
- skatteverket_company_connections table with pg-real coverage.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(salary): auto-settle AGI tax payment from skattekonto and surface SKV reconnect on the tax card

The "Skatt att betala" card only cleared via the manual mark-paid button
on the run detail page; the promised automatic flip from the Skattekonto
sync was never implemented, so paid periods stayed red.

- settleAgiTaxPayments: during every skattekonto sync, a booked
  "Arbetsgivardeklaration YYYYMM" debit row settles the matching
  agi_declarations.tax_paid_at, but only when the amount equals the
  declared total to the ore and the account is not in deficit
  (deterministic; drift or deficit falls back to manual).
- Salary overview card: reconnect hint when the SKV token needs
  re-consent (link to /settings/tax, silent when the extension is off),
  plus an inline "Markera som betald" button reusing the existing
  endpoint and salary_payments strings.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Add cloud backup scheduling and alerting features

- Implement unit tests for scheduling logic in `schedule.test.ts`, covering various scenarios for determining if a backup schedule is due.
- Create a new module `backup-alert.ts` to handle failure alerts for cloud backup auto-sync, including email notifications for reauthentication and repeated failures.
- Introduce `schedule.ts` to manage scheduling logic, including handling local time zones and converting between local and UTC hours.
- Add CSV report generation functions in `archive-csv.ts` for trial balance, income statement, balance sheet, and general ledger, ensuring compatibility with Swedish Excel formats.
- Create a README generator for the archive structure in `archive-readme.ts`, providing clear documentation for users accessing backup files.
- Implement tests for CSV report generation in `archive-csv.test.ts`, ensuring correct formatting and content.
- Establish a full-archive coverage contract test in `full-archive-coverage.pg.test.ts` to ensure all company-scoped tables are properly classified for backup.

* fix(stripe): correct invoice clearing reference and improve type safety in sync logic

* fix(invoices): narrow accountingMethod before resolveInvoicePaymentSourceType

settleInvoicePayment takes accountingMethod as a raw settings string, but
resolveInvoicePaymentSourceType requires the 'accrual' | 'cash' union.
Normalize at the call site (anything but 'cash' books as accrual), matching
the existing useCashEntry semantics.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix: address CodeRabbit review findings and nitpicks on PR #1004

Review findings:
- backup settings redirect: always force view=export over incoming params
- AGI/VAT kvittens crons: isolate best-effort post-submit calls, check the
  signed-state persist error, guard recovery calls in catch blocks so one
  company cannot abort the rest; surface grant_revoked in the run summary
- kvittens notifications: atomic claim-first dedup with a partial unique
  index; map non-uuid reference keys to deterministic uuids
- grant probe: record the actual 2xx status; mTLS transport: handle
  response-stream errors
- stripe: amount-aware idempotency keys for payment links; emit
  stripe.disconnected on upstream revocations
- ROT/RUT beslut import: mutate in-memory request state after apply, move
  item + header writes into an atomic apply_rot_rut_beslut RPC, add
  rot_rut_payout to JournalEntrySourceTypeSchema
- migrations: use NOT VALID + VALIDATE CONSTRAINT for CHECK constraints on
  journal_entries, notification_log and rot_rut_payout_requests
- cloud backup: hour_utc-only schedule updates clear stale hour_local

Nitpicks:
- stripe sync: enforce the cron time budget inside per-connection event
  processing with idempotent cursor progress; maybeSingle for settings;
  honest partial-customer DTO shared with the settlement boundary
- shared applyPaymentLinkToInvoice helper for both invoice send routes,
  v1 docblock documents step 6b and PAYMENT_LINK_FAILED
- settings panel: drop redundant decodeURIComponent
- cloud backup: document worst-case archive memory headroom

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-12 19:14:12 +02:00

248 lines
11 KiB
TypeScript

/**
* Swedish employee bank-account validation (clearing + kontonummer).
*
* This is the single source of truth for validating the bank details entered
* on the "Anställda" employee form, shared by the client forms and the server
* Zod schema / API routes. It mirrors what the payout layer
* (`bg-lb-generator.ts` `encodeReceiverAccount`) can actually encode, so a
* typo is caught at data entry instead of surfacing ~20 steps later when the
* Bankgirot LB file is generated (or never, on the SEPA/pain.001 path).
*
* Scope (deliberately structural, per the product decision):
* - Clearing must be 4 digits, OR 5 digits starting with 8 (Swedbank/
* Sparbanken are the only 5-digit clearings in the Swedish system).
* - Account number must be 5-11 digits (covers ordinary accounts through the
* 11-digit Nordea personkonto that the generator special-cases).
* - Both fields are optional together (bank details may be filled in before
* the first salary run), but a clearing without an account (or vice versa)
* cannot be paid out and is rejected.
*
* Per-bank mod10/mod11 checksum validation is intentionally NOT done here: it
* requires the official per-bank clearing-range table, and getting that table
* slightly wrong produces false rejections of valid accounts. It is planned as
* a separate, non-blocking "soft warning" follow-up once the data is vetted.
*/
import { validateSwedishAccountChecksum, type AccountChecksumResult } from '@/lib/bankgiro/account-number'
export type { AccountChecksumResult }
/** Strip spaces and hyphens so "8327-9" / "1234 5678" become plain digits. */
export function normalizeBankNumber(input: string | null | undefined): string {
return (input ?? '').replace(/[\s-]/g, '')
}
/**
* Non-blocking check-digit ("kontrollsiffra") result for an employee's
* clearing/account pair. 'invalid' surfaces an advisory warning in the form,
* but never blocks saving: the check digit catches typos, it does not prove
* the account exists. Unrecognised clearings return 'unknown' (no warning).
*/
export function checkEmployeeAccountChecksum(
clearing: string | null | undefined,
account: string | null | undefined,
): AccountChecksumResult {
return validateSwedishAccountChecksum(clearing, account)
}
/** Advisory (non-blocking) message shown when the check digit looks wrong. */
export const BANK_CHECKSUM_WARNING_SV =
'Kontrollsiffran verkar inte stämma. Dubbelkolla numret, du kan spara ändå.'
/** 4-digit clearing, or a 5-digit Swedbank/Sparbanken clearing starting with 8. */
export function isValidClearing(clearing: string): boolean {
return /^(\d{4}|8\d{4})$/.test(clearing)
}
/** Account number: 5-11 digits (through Nordea personkonto's 11 digits). */
export function isValidAccount(account: string): boolean {
return /^\d{5,11}$/.test(account)
}
export type BankIssueCode =
| 'clearing_format'
| 'account_format'
| 'account_required'
| 'clearing_required'
export interface BankIssue {
/** Matches the form field name and the Zod path for this issue. */
field: 'clearing_number' | 'bank_account_number'
code: BankIssueCode
/** Swedish message (used server-side and by the hardcoded-Swedish dialog). */
message: string
}
/**
* Swedish issue messages. The i18n edit page maps `code` to its own
* `salary_employee.bank_error_*` keys; the create dialog and the server use
* these strings directly (schema messages in this repo are Swedish literals).
*/
export const BANK_ISSUE_MESSAGES_SV: Record<BankIssueCode, string> = {
clearing_format:
'Clearingnummer måste vara 4 siffror (eller 5 siffror som börjar med 8 för Swedbank)',
account_format: 'Kontonummer måste vara 5-11 siffror',
account_required: 'Kontonummer krävs när clearingnummer har angetts',
clearing_required: 'Clearingnummer krävs när kontonummer har angetts',
}
function issue(field: BankIssue['field'], code: BankIssueCode): BankIssue {
return { field, code, message: BANK_ISSUE_MESSAGES_SV[code] }
}
/**
* Validate a clearing/account pair. Returns an empty array when valid (which
* includes both fields being empty). Inputs may contain spaces/hyphens; they
* are normalized before checking.
*/
export function validateEmployeeBankAccount(
clearingRaw: string | null | undefined,
accountRaw: string | null | undefined,
): BankIssue[] {
const clearing = normalizeBankNumber(clearingRaw)
const account = normalizeBankNumber(accountRaw)
// Both empty: bank details are optional until a salary run is approved.
if (!clearing && !account) return []
const issues: BankIssue[] = []
if (clearing && !isValidClearing(clearing)) {
issues.push(issue('clearing_number', 'clearing_format'))
}
if (account && !isValidAccount(account)) {
issues.push(issue('bank_account_number', 'account_format'))
}
// Both-or-neither: a lone clearing or a lone account cannot be paid out.
if (clearing && !account) issues.push(issue('bank_account_number', 'account_required'))
if (account && !clearing) issues.push(issue('clearing_number', 'clearing_required'))
return issues
}
export interface DomesticBankAccountParts {
/** 4-digit clearing: the Bankgirot LB clearing field and the pain.001 SESBA member id. */
clearing4: string
/** Account digits without the clearing prefix (see the special cases below). */
accountDigits: string
}
/**
* Split an employee's clearing/account pair into the 4-digit clearing and the
* account digits used by BOTH payout formats. This is the single source of
* truth: the Bankgirot LB file (fixed 4-digit clearing field, TK 54) and the
* pain.001 file (CdtrAgt ClrSysMmbId SESBA + CdtrAcct BBAN without clearing)
* must present identical routing for the same employee, or one format pays a
* different account than the other.
*
* Special cases, per the Bankgirot LB spec and kept format-identical here:
* - Swedbank 5-digit clearings (8xxx-y): the first 4 digits are the clearing,
* the 5th digit is carried as the leading digit of the account field.
* - Nordea personkonto entered as an 11-digit account that repeats the
* 4-digit clearing as its prefix: the redundant prefix is stripped so the
* account field holds only the account itself.
*/
export function splitDomesticBankAccount(
clearingInput: string,
accountInput: string
): DomesticBankAccountParts {
const clearing = (clearingInput ?? '').replace(/\D/g, '')
const account = (accountInput ?? '').replace(/\D/g, '')
if (clearing.length === 4) {
if (account.length === 11 && account.startsWith(clearing)) {
return { clearing4: clearing, accountDigits: account.slice(4) }
}
return { clearing4: clearing, accountDigits: account }
}
if (clearing.length === 5 && clearing.startsWith('8')) {
return {
clearing4: clearing.slice(0, 4),
accountDigits: clearing.slice(4) + account,
}
}
throw new Error(
`Ogiltigt clearingnummer: ${clearingInput} (förväntat 4 siffror, eller 5 siffror som börjar med 8 för Swedbank)`
)
}
/**
* Conservative clearing-number -> bank-name lookup, for reassurance next to the
* field. Only the major, long-stable, unambiguous ranges are included; any
* clearing not in this table returns null (show nothing) rather than a guessed
* name. The full authoritative table lands with the checksum follow-up.
*
* Ranges are matched on the leading 4 digits, so a 5-digit Swedbank clearing
* (8xxxx) maps via its 8xxx prefix.
*/
const BANK_CLEARING_RANGES: ReadonlyArray<{ min: number; max: number; bank: string; bic: string }> = [
{ min: 1100, max: 1199, bank: 'Nordea', bic: 'NDEASESS' },
{ min: 1200, max: 1399, bank: 'Danske Bank', bic: 'DABASESX' },
{ min: 1400, max: 2099, bank: 'Nordea', bic: 'NDEASESS' },
{ min: 2400, max: 2499, bank: 'Danske Bank', bic: 'DABASESX' },
{ min: 3000, max: 3399, bank: 'Nordea', bic: 'NDEASESS' },
{ min: 5000, max: 5999, bank: 'SEB', bic: 'ESSESESS' },
{ min: 6000, max: 6999, bank: 'Handelsbanken', bic: 'HANDSESS' },
{ min: 7000, max: 7999, bank: 'Swedbank', bic: 'SWEDSESS' },
{ min: 8000, max: 8999, bank: 'Swedbank/Sparbanken', bic: 'SWEDSESS' },
{ min: 9500, max: 9549, bank: 'Nordea (Plusgirot)', bic: 'NDEASESS' },
{ min: 9960, max: 9969, bank: 'Nordea (Plusgirot)', bic: 'NDEASESS' },
]
/** Bank name for a (partial) clearing number, or null when not confidently known. */
export function lookupBankByClearing(clearingRaw: string | null | undefined): string | null {
const clearing = normalizeBankNumber(clearingRaw)
if (clearing.length < 4) return null
const first4 = Number.parseInt(clearing.slice(0, 4), 10)
if (Number.isNaN(first4)) return null
const hit = BANK_CLEARING_RANGES.find((r) => first4 >= r.min && first4 <= r.max)
return hit ? hit.bank : null
}
/**
* Bank BIC (SWIFT) for a clearing number, or null when the clearing is not in
* the table above. Used to fill the debtor agent (DbtrAgt) in the pain.001
* salary payment file without asking the company to type its BIC by hand: the
* clearing number it already entered for the debtor account deterministically
* identifies the bank. Only confidently-known, long-stable ranges are covered;
* an unknown clearing returns null so the caller can fall back or fail loudly
* rather than emit a guessed BIC into a real payment instruction.
*/
export function lookupBicByClearing(clearingRaw: string | null | undefined): string | null {
const clearing = normalizeBankNumber(clearingRaw)
if (clearing.length < 4) return null
const first4 = Number.parseInt(clearing.slice(0, 4), 10)
if (Number.isNaN(first4)) return null
const hit = BANK_CLEARING_RANGES.find((r) => first4 >= r.min && first4 <= r.max)
return hit ? hit.bic : null
}
/**
* Fallback BIC lookup by the free-text bank name saved in company settings, for
* the (rare) banks not covered by the clearing ranges above (e.g.
* Länsförsäkringar, Skandiabanken). Matched on a normalized substring so
* "Danske Bank Sverige" still resolves. Only BICs we are confident about are
* listed; anything else returns null. Never guess a BIC for a real payment.
*/
const BANK_NAME_BIC: ReadonlyArray<{ match: string; bic: string }> = [
{ match: 'handelsbanken', bic: 'HANDSESS' },
{ match: 'länsförsäkringar', bic: 'ELLFSESS' },
{ match: 'lansforsakringar', bic: 'ELLFSESS' },
{ match: 'skandia', bic: 'SKIASESS' },
{ match: 'swedbank', bic: 'SWEDSESS' },
{ match: 'sparbank', bic: 'SWEDSESS' },
{ match: 'danske', bic: 'DABASESX' },
{ match: 'nordea', bic: 'NDEASESS' },
{ match: 'seb', bic: 'ESSESESS' },
]
export function lookupBicByBankName(nameRaw: string | null | undefined): string | null {
const name = (nameRaw ?? '').trim().toLowerCase()
if (!name) return null
const hit = BANK_NAME_BIC.find((b) => name.includes(b.match))
return hit ? hit.bic : null
}