MattssonandClaude Opus 4.8
0ca9c25aba
* feat(bookkeeping): make blocked fiscal-year creation actionable When creating a new räkenskapsår is blocked because a prior period is still open, the "Skapa räkenskapsår" dialog no longer dead-ends on an English toast. The API now returns the canonical bilingual error envelope with the blocking periods (id/name/dates) under details, and the dialog renders a Swedish panel that locks them inline (reversible locked_at) via the existing /lock endpoint and retries creation. The guard rule is unchanged and remains BFL-compliant: BFL 6 kap allows löpande bokföring of the new year in parallel with the prior year's bokslut, so a lock (not a full close) is sufficient and reversible. - Add PERIOD_CREATE_BLOCKED_BY_OPEN_PERIODS structured error code - Return envelope + details.blockingPeriods from the 409 (was English string) - CreatePeriodDialog: inline "lås och skapa" panel + lock-and-retry - Update route tests for the new envelope shape Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(ui): prevent mouse wheel from mutating number inputs A focused <input type="number"> would change its value on scroll, silently turning e.g. a 20000 salary into 19998. Blur number inputs on wheel so the page scrolls instead of editing the value. Applied at the Input primitive so all number fields are protected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(salary): auto-derive skattetabell and kolumn for employees Replace the opaque manual "Skattetabell (29-42)" and "Kolumn (1-6)" inputs on the employee form with a self-deriving flow: the user picks their folkbokföringskommun from a searchable dropdown and the tax table fills itself in, while the column derives from the personnummer we already collect. - Add a searchable municipality picker (MunicipalityCombobox) backed by a new cached GET /api/salary/tax-tables/kommuner endpoint. - Wrap the whole "Skatt" card in a self-contained EmployeeTaxCard used by both the create and edit pages, with InfoTooltips and named column options. - deriveTaxColumn(): auto-select column 1 for under-66 employees; leave the ambiguous 66+ case (pension vs working senior) to a clearly-named manual choice. - Fix fetchKommunTaxRates() to page through all ~1300 församling rows instead of a single 500-row page (which silently dropped ~200 kommuner, incl. Göteborg) and normalize the uppercase names to title case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(import): correct CSV amount-column guess and surface skipped rows Manual CSV column-mapping auto-guess walked each data row right-to-left and picked the first numeric cell as the amount, so on the common ...;Belopp;Saldo layout it grabbed the trailing running-balance column. Extract the guess into a pure, tested suggestColumnMapping(): match header labels first (belopp/amount -> amount, saldo/balance -> balance), auto-fill the balance field, and fall back to value heuristics that skip the balance column and prefer a column carrying negative values. Also surface stats.skipped_rows + parse warnings in BankFileConfirmStep - the manual-mapping path skips the preview step that was the only place they showed, so skipped rows were silently dropped from view. Add a unit test reproducing the Saldo-as-amount regression. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: add "Save as draft" functionality for invoices - Implemented a new feature to allow users to save invoices as unnumbered drafts without generating an invoice number until finalized. - Added a `save_as_draft` flag to the CreateInvoiceInput schema to handle draft saving logic. - Updated the invoice creation API to skip number allocation when saving as a draft. - Introduced a new endpoint for finalizing drafts, which allocates an invoice number and emits an `invoice.created` event. - Enhanced the UI to include a "Save as draft" button, with loading states and tooltips. - Updated tests to cover the new draft saving and finalization logic, including race conditions for concurrent modifications. - Added relevant error handling for draft finalization and deletion scenarios. * feat(employee): add employment start and end date fields to employee forms * feat: enhance invoice and salary run handling with improved validation and event logging --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
58 lines
2.1 KiB
TypeScript
58 lines
2.1 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { deriveTaxColumn, getTaxColumnOption, TAX_COLUMN_OPTIONS } from '../tax-column'
|
|
|
|
describe('deriveTaxColumn', () => {
|
|
it('returns column 1 for an employee comfortably under 66', () => {
|
|
// Born 1990 → 36 in 2026
|
|
expect(deriveTaxColumn('199003151234', 2026)).toBe(1)
|
|
})
|
|
|
|
it('returns column 1 at the exact under-66 boundary (born 1960 for 2026)', () => {
|
|
// "född 1960 eller senare" = kolumn 1 för inkomståret 2026
|
|
expect(deriveTaxColumn('196006151234', 2026)).toBe(1)
|
|
})
|
|
|
|
it('returns null (manual) for the 66+ group (born 1959 for 2026)', () => {
|
|
// Column 2 (pension) vs 3 (working senior) can't be inferred from age.
|
|
expect(deriveTaxColumn('195906151234', 2026)).toBeNull()
|
|
})
|
|
|
|
it('returns null for a clearly senior employee', () => {
|
|
expect(deriveTaxColumn('194001011234', 2026)).toBeNull()
|
|
})
|
|
|
|
it('tracks the boundary with the income year', () => {
|
|
// Born 1959: under-66 group for 2025 (year - 66 = 1959), 66+ group for 2026.
|
|
expect(deriveTaxColumn('195906151234', 2025)).toBe(1)
|
|
expect(deriveTaxColumn('195906151234', 2026)).toBeNull()
|
|
})
|
|
|
|
it('works from a masked personnummer (YYYYMMDD-XXXX)', () => {
|
|
expect(deriveTaxColumn('19900315-XXXX', 2026)).toBe(1)
|
|
})
|
|
|
|
it('returns null when there is not enough of a birthdate to decide', () => {
|
|
expect(deriveTaxColumn('', 2026)).toBeNull()
|
|
expect(deriveTaxColumn('1990', 2026)).toBeNull()
|
|
expect(deriveTaxColumn('199003', 2026)).toBeNull()
|
|
})
|
|
|
|
it('returns null for an implausible birth year', () => {
|
|
expect(deriveTaxColumn('180003151234', 2026)).toBeNull()
|
|
// birth year after the income year
|
|
expect(deriveTaxColumn('203003151234', 2026)).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('TAX_COLUMN_OPTIONS', () => {
|
|
it('covers all six Skatteverket columns in order', () => {
|
|
expect(TAX_COLUMN_OPTIONS.map((o) => o.value)).toEqual([1, 2, 3, 4, 5, 6])
|
|
})
|
|
|
|
it('looks up an option by value', () => {
|
|
expect(getTaxColumnOption(1)?.label).toContain('under 66')
|
|
expect(getTaxColumnOption(3)?.label).toContain('66+')
|
|
expect(getTaxColumnOption(99)).toBeUndefined()
|
|
})
|
|
})
|