Files
accounted/lib/invoices/invoice-deliveries.ts
T
Mattsson 466e55a015 Fix/invoice delivery and payment accounts (#1116)
* fix: reconcile annual reports with final closing entries

* test: cover annual report depreciation and VAT balances

* Merge remote-tracking branch 'origin/main' into fix/usr-fdbck-ch

* fix: show exact invoice delivery details

* fix: use currency account in invoice emails

* fix: address invoice delivery review feedback

* fix: harden invoice delivery and payment accounts

* test: assert RLS-denied zero-row updates

* fix: close remaining invoice compliance gaps

* fix: harden invoice archive authorization

* fix: close invoice delivery review findings

* fix: verify delivery finalization results

* fix: cap combined invoice email recipients

* fix: close final invoice compliance findings

* fix: prevent stale payment account saves

* test: prove invoice delivery isolation

* fix: close invoice privacy review findings

* test: normalize delivery retention dates
2026-07-23 09:54:02 +02:00

251 lines
7.2 KiB
TypeScript

import type { SupabaseClient } from '@supabase/supabase-js'
import type { EmailService, SendEmailOptions, SendEmailResult } from '@/lib/email/service'
import { deleteDocument, uploadDocument } from '@/lib/core/documents/document-service'
import { createServiceClient } from '@/lib/supabase/server'
import type { InvoiceDelivery } from '@/types'
const PDF_CONTENT_TYPE = 'application/pdf'
export class InvoiceDeliverySnapshotError extends Error {
constructor(message: string) {
super(message)
this.name = 'InvoiceDeliverySnapshotError'
}
}
export interface TrackedInvoiceEmailInput {
supabase: SupabaseClient
emailService: EmailService
companyId: string
userId: string
invoiceId: string
deliveryId: string
to: string | string[]
cc?: string | string[]
bcc?: string | string[]
replyTo?: string
fromName?: string
subject: string
html: string
text: string
filename: string
pdfBuffer: Buffer
}
export interface TrackedInvoiceEmailResult extends SendEmailResult {
deliveryId: string
documentId: string
trackingWarning?: 'finalize_failed' | 'failure_record_failed' | 'failure_cleanup_failed'
}
function addresses(value?: string | string[]): string[] {
if (!value) return []
return Array.isArray(value) ? value : [value]
}
/**
* Persist a reusable delivery attempt before allocating an invoice number.
* The unique preparing row is also the concurrency lock for one invoice send.
* The stateless service-role client is only transport for the service-only RPC:
* the RPC re-authorizes userId as a writable member of companyId and scopes the
* invoice row to the same company before it can write anything.
*/
export async function reserveInvoiceDelivery(args: {
supabase: SupabaseClient
companyId: string
userId: string
invoiceId: string
}): Promise<string> {
const { data, error } = await createServiceClient().rpc('reserve_invoice_delivery', {
p_company_id: args.companyId,
p_invoice_id: args.invoiceId,
p_actor_user_id: args.userId,
})
if (!error && typeof data === 'string') return data
throw new InvoiceDeliverySnapshotError(
`Failed to reserve invoice delivery: ${error?.message || 'unknown error'}`,
)
}
export async function sendTrackedInvoiceEmail(
input: TrackedInvoiceEmailInput,
): Promise<TrackedInvoiceEmailResult> {
const {
supabase,
emailService,
companyId,
userId,
invoiceId,
deliveryId,
to,
cc,
bcc,
replyTo,
fromName,
subject,
html,
text,
filename,
pdfBuffer,
} = input
const pdfArrayBuffer = new Uint8Array(pdfBuffer).buffer as ArrayBuffer
const document = await uploadDocument(
supabase,
userId,
companyId,
{
name: filename,
buffer: pdfArrayBuffer,
type: PDF_CONTENT_TYPE,
},
{ upload_source: 'system' },
)
// These service-only RPCs re-authorize userId against companyId and bind
// every transition to the reserved invoice, so no caller-supplied tenant or
// actor identifier is trusted merely because this client bypasses RLS.
const deliveryWriter = createServiceClient()
const { data: capturedDeliveryId, error: deliveryError } = await deliveryWriter.rpc(
'capture_invoice_delivery_payload',
{
p_delivery_id: deliveryId,
p_company_id: companyId,
p_invoice_id: invoiceId,
p_actor_user_id: userId,
p_to_addresses: addresses(to),
p_cc_addresses: addresses(cc),
p_bcc_addresses: addresses(bcc),
p_reply_to: replyTo || null,
p_from_name: fromName || null,
p_subject: subject,
p_body_text: text,
p_body_html: html,
p_document_attachment_id: document.id,
p_attachment_filename: filename,
p_attachment_content_type: PDF_CONTENT_TYPE,
p_attachment_sha256: document.sha256_hash,
},
)
if (deliveryError || capturedDeliveryId !== deliveryId) {
try {
await deleteDocument(supabase, companyId, document.id)
} catch {
// Best-effort cleanup only. The send must remain blocked even if the
// unlinked archive cannot be removed after a snapshot insert failure.
}
throw new InvoiceDeliverySnapshotError(
`Failed to persist invoice delivery snapshot: ${deliveryError?.message || 'unknown error'}`,
)
}
const emailOptions: SendEmailOptions = {
to,
cc,
bcc,
subject,
html,
text,
replyTo,
fromName,
attachments: [
{
filename,
content: pdfBuffer,
contentType: PDF_CONTENT_TYPE,
},
],
}
const result = await emailService.sendEmail(emailOptions)
if (!result.success) {
const { data: failedDeliveryId, error: failureRecordError } = await deliveryWriter.rpc(
'finalize_invoice_delivery',
{
p_delivery_id: deliveryId,
p_company_id: companyId,
p_actor_user_id: userId,
p_status: 'failed',
p_provider: result.provider || null,
p_provider_message_id: null,
p_error_code: 'provider_failed',
},
)
const failureRecorded = !failureRecordError && failedDeliveryId === deliveryId
let cleanupFailed = false
if (failureRecorded) {
try {
const cleanup = await deleteDocument(supabase, companyId, document.id)
cleanupFailed = !cleanup.ok
} catch {
cleanupFailed = true
}
}
return {
...result,
deliveryId,
documentId: document.id,
...(!failureRecorded
? { trackingWarning: 'failure_record_failed' as const }
: cleanupFailed
? { trackingWarning: 'failure_cleanup_failed' as const }
: {}),
}
}
const { data: finalizedDeliveryId, error: finalizeError } = await deliveryWriter.rpc(
'finalize_invoice_delivery',
{
p_delivery_id: deliveryId,
p_company_id: companyId,
p_actor_user_id: userId,
p_status: 'sent',
p_provider: result.provider || null,
p_provider_message_id: result.messageId || null,
p_error_code: null,
},
)
// Delivery is irreversible once the provider succeeds. A failed terminal
// transition is returned as a reconciliation warning; each caller still
// advances the invoice to sent, and ordinary send routes reject non-drafts,
// so a pending evidence row never becomes permission to send a duplicate.
// Pending rows are outside the preparing-only reservation lock, so retained
// evidence also cannot block a later explicitly authorized resend.
const finalized = !finalizeError && finalizedDeliveryId === deliveryId
return {
...result,
deliveryId,
documentId: document.id,
...(!finalized ? { trackingWarning: 'finalize_failed' as const } : {}),
}
}
export async function recordManualInvoiceDelivery(args: {
supabase: SupabaseClient
companyId: string
userId: string
invoiceId: string
sentAt?: string
}): Promise<InvoiceDelivery> {
const { data, error } = await createServiceClient().rpc('record_manual_invoice_delivery', {
p_company_id: args.companyId,
p_invoice_id: args.invoiceId,
p_actor_user_id: args.userId,
p_sent_at: args.sentAt || null,
})
if (error || !data) {
throw new InvoiceDeliverySnapshotError(
`Failed to persist manual invoice delivery: ${error?.message || 'unknown error'}`,
)
}
return data as InvoiceDelivery
}