Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
54 lines
2.2 KiB
TypeScript
54 lines
2.2 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { escapeLikePattern, normalizeOcrReference } from '../duplicate-payment-guard'
|
|
|
|
describe('escapeLikePattern', () => {
|
|
// These cases lock in that a user-supplied needle reaches an ILIKE pattern with
|
|
// its LIKE metacharacters neutralised: each of `%`, `_`, `\` must match only
|
|
// itself and never expand as a wildcard (compliance A.8.28 / ASVS V1.2.5).
|
|
it('escapes a literal percent so it matches only itself', () => {
|
|
expect(escapeLikePattern('50% rabatt')).toBe('50\\% rabatt')
|
|
})
|
|
|
|
it('escapes a literal underscore so it is not a single-char wildcard', () => {
|
|
expect(escapeLikePattern('konto_1930')).toBe('konto\\_1930')
|
|
})
|
|
|
|
it('escapes a literal backslash so it does not consume the next char', () => {
|
|
expect(escapeLikePattern('a\\b')).toBe('a\\\\b')
|
|
})
|
|
|
|
it('escapes backslash, percent and underscore together without double-escaping', () => {
|
|
// Backslash is escaped FIRST, so the escapes added for % and _ are not
|
|
// themselves re-escaped. Each special char maps to exactly "\\" + itself.
|
|
expect(escapeLikePattern('a\\b%c_d')).toBe('a\\\\b\\%c\\_d')
|
|
})
|
|
|
|
it('leaves ordinary text untouched', () => {
|
|
expect(escapeLikePattern('Faktura 2026-0042')).toBe('Faktura 2026-0042')
|
|
})
|
|
|
|
it('caps the needle at 200 characters to bound DB work on oversized input', () => {
|
|
const escaped = escapeLikePattern('a'.repeat(250))
|
|
expect(escaped).toBe('a'.repeat(200))
|
|
expect(escaped.length).toBe(200)
|
|
})
|
|
|
|
it('truncates BEFORE escaping, so the source length is the bound', () => {
|
|
// 250 percent signs → truncated to 200 source chars, each escaped to "\%".
|
|
expect(escapeLikePattern('%'.repeat(250))).toBe('\\%'.repeat(200))
|
|
})
|
|
})
|
|
|
|
describe('normalizeOcrReference', () => {
|
|
it('keeps only digits regardless of separators', () => {
|
|
expect(normalizeOcrReference('2026-0042')).toBe('20260042')
|
|
expect(normalizeOcrReference('2026 / 0042')).toBe('20260042')
|
|
})
|
|
|
|
it('returns an empty string for nullish or empty input', () => {
|
|
expect(normalizeOcrReference(null)).toBe('')
|
|
expect(normalizeOcrReference(undefined)).toBe('')
|
|
expect(normalizeOcrReference('')).toBe('')
|
|
})
|
|
})
|