Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
32 lines
1.1 KiB
TypeScript
32 lines
1.1 KiB
TypeScript
import type { CashAccount } from '@/types'
|
|
|
|
export interface ResolvedAccount {
|
|
account: string
|
|
fallback: boolean
|
|
}
|
|
|
|
/**
|
|
* Resolve the BAS ledger account number for a bank transaction.
|
|
*
|
|
* Resolution order:
|
|
* 1. cash_account_id is set → return that cash account's ledger_account.
|
|
* 2. Exactly one enabled account for the transaction currency → return it.
|
|
* 3. Give up → return '1930' with fallback=true.
|
|
*/
|
|
export function resolveAccount(
|
|
cashAccounts: CashAccount[],
|
|
cashAccountId: string | null,
|
|
currency: string,
|
|
): ResolvedAccount {
|
|
if (cashAccountId) {
|
|
const bound = cashAccounts.find((a) => a.id === cashAccountId)
|
|
// If an explicit ID was given but not found, skip the currency fallback and
|
|
// return 1930 with fallback=true: the missing link is a data integrity signal.
|
|
if (bound) return { account: bound.ledger_account, fallback: false }
|
|
return { account: '1930', fallback: true }
|
|
}
|
|
const sameCurrency = cashAccounts.filter((a) => a.enabled && a.currency === currency)
|
|
if (sameCurrency.length === 1) return { account: sameCurrency[0].ledger_account, fallback: false }
|
|
return { account: '1930', fallback: true }
|
|
}
|