Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
123 lines
4.2 KiB
TypeScript
123 lines
4.2 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import type { CreateJournalEntryInput } from '@/types'
|
|
|
|
vi.mock('../engine', () => ({
|
|
findFiscalPeriod: vi.fn().mockResolvedValue('period-1'),
|
|
createJournalEntry: vi.fn().mockImplementation(
|
|
async (_supabase: unknown, _companyId: string, _userId: string, input: CreateJournalEntryInput) => ({
|
|
id: 'entry-reminder-fee-1',
|
|
...input,
|
|
lines: input.lines,
|
|
}),
|
|
),
|
|
}))
|
|
|
|
const { createJournalEntry, findFiscalPeriod } = await import('../engine')
|
|
const { createReminderFeeEntry } = await import('../reminder-fee-entries')
|
|
|
|
const mockedCreateEntry = vi.mocked(createJournalEntry)
|
|
const mockedFindFiscalPeriod = vi.mocked(findFiscalPeriod)
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mockedFindFiscalPeriod.mockResolvedValue('period-1')
|
|
mockedCreateEntry.mockImplementation(
|
|
async (_supabase: unknown, _companyId: string, _userId: string, input: CreateJournalEntryInput) => ({
|
|
id: 'entry-reminder-fee-1',
|
|
...input,
|
|
lines: input.lines,
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
}) as any,
|
|
)
|
|
})
|
|
|
|
describe('createReminderFeeEntry', () => {
|
|
it('books a balanced entry: debit 1510, credit 3990', async () => {
|
|
const result = await createReminderFeeEntry({} as never, {
|
|
invoiceId: 'inv-1',
|
|
invoiceNumber: 'F2026001',
|
|
companyId: 'company-1',
|
|
userId: 'user-1',
|
|
feeAmount: 60,
|
|
asOfDate: '2026-05-26',
|
|
})
|
|
|
|
expect(result?.journal_entry_id).toBe('entry-reminder-fee-1')
|
|
expect(mockedCreateEntry).toHaveBeenCalledTimes(1)
|
|
|
|
const callArgs = mockedCreateEntry.mock.calls[0]
|
|
const input = callArgs[3] as CreateJournalEntryInput
|
|
|
|
expect(input.source_type).toBe('reminder_fee')
|
|
expect(input.source_id).toBe('inv-1')
|
|
expect(input.fiscal_period_id).toBe('period-1')
|
|
expect(input.entry_date).toBe('2026-05-26')
|
|
expect(input.description).toBe('Påminnelseavgift faktura F2026001')
|
|
|
|
expect(input.lines).toHaveLength(2)
|
|
const debitLine = input.lines.find((l) => l.account_number === '1510')
|
|
const creditLine = input.lines.find((l) => l.account_number === '3990')
|
|
expect(debitLine?.debit_amount).toBe(60)
|
|
expect(debitLine?.credit_amount).toBe(0)
|
|
expect(creditLine?.debit_amount).toBe(0)
|
|
expect(creditLine?.credit_amount).toBe(60)
|
|
})
|
|
|
|
it('rounds the fee to 2 decimals (defense in depth, caller should already round)', async () => {
|
|
await createReminderFeeEntry({} as never, {
|
|
invoiceId: 'inv-1',
|
|
invoiceNumber: 'F2026001',
|
|
companyId: 'company-1',
|
|
userId: 'user-1',
|
|
feeAmount: 59.999,
|
|
asOfDate: '2026-05-26',
|
|
})
|
|
|
|
const input = mockedCreateEntry.mock.calls[0][3] as CreateJournalEntryInput
|
|
const debit = input.lines.find((l) => l.account_number === '1510')!
|
|
const credit = input.lines.find((l) => l.account_number === '3990')!
|
|
expect(debit.debit_amount).toBe(60)
|
|
expect(credit.credit_amount).toBe(60)
|
|
})
|
|
|
|
it('returns null and does not call the engine when feeAmount is 0', async () => {
|
|
const result = await createReminderFeeEntry({} as never, {
|
|
invoiceId: 'inv-1',
|
|
invoiceNumber: 'F2026001',
|
|
companyId: 'company-1',
|
|
userId: 'user-1',
|
|
feeAmount: 0,
|
|
asOfDate: '2026-05-26',
|
|
})
|
|
expect(result).toBeNull()
|
|
expect(mockedCreateEntry).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('returns null and does not call the engine when feeAmount is negative', async () => {
|
|
const result = await createReminderFeeEntry({} as never, {
|
|
invoiceId: 'inv-1',
|
|
invoiceNumber: 'F2026001',
|
|
companyId: 'company-1',
|
|
userId: 'user-1',
|
|
feeAmount: -1,
|
|
asOfDate: '2026-05-26',
|
|
})
|
|
expect(result).toBeNull()
|
|
expect(mockedCreateEntry).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('returns null when no open fiscal period is found', async () => {
|
|
mockedFindFiscalPeriod.mockResolvedValueOnce(null)
|
|
const result = await createReminderFeeEntry({} as never, {
|
|
invoiceId: 'inv-1',
|
|
invoiceNumber: 'F2026001',
|
|
companyId: 'company-1',
|
|
userId: 'user-1',
|
|
feeAmount: 60,
|
|
asOfDate: '2026-05-26',
|
|
})
|
|
expect(result).toBeNull()
|
|
expect(mockedCreateEntry).not.toHaveBeenCalled()
|
|
})
|
|
})
|