Files
accounted/lib/bookkeeping/__tests__/own-account-detector.test.ts
T
Jakob WennbergandClaude Sonnet 5 ec27228a8e style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)
Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.

Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.

Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.

Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-04 15:58:06 +02:00

161 lines
4.8 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import { createQueuedMockSupabase } from '@/tests/helpers'
import { detectOwnAccountTransfer } from '../own-account-detector'
import type { Transaction } from '@/types'
function makeTx(overrides: Partial<Transaction> = {}): Transaction {
return {
id: 'tx-1',
user_id: 'user-1',
company_id: 'company-1',
bank_connection_id: 'conn-sek',
external_id: 'eb_sek_1',
date: '2026-06-12',
description: 'Överföring till EUR-konto',
original_description: 'Överföring till EUR-konto',
title_edited_at: null,
amount: -1000,
currency: 'SEK',
amount_sek: -1000,
exchange_rate: null,
exchange_rate_date: null,
category: 'uncategorized',
is_business: null,
invoice_id: null,
supplier_invoice_id: null,
potential_invoice_id: null,
potential_supplier_invoice_id: null,
journal_entry_id: null,
mcc_code: null,
merchant_name: null,
receipt_id: null,
document_id: null,
reconciliation_method: null,
is_ignored: false,
import_source: 'enable_banking',
reference: null,
counterparty_iban: 'SE9550000000054910000003',
counterparty_account: null,
notes: null,
created_at: '2026-06-12T00:00:00Z',
updated_at: '2026-06-12T00:00:00Z',
...overrides,
}
}
describe('detectOwnAccountTransfer', () => {
it('returns null when transaction has no counterparty_iban', async () => {
const { supabase } = createQueuedMockSupabase()
const result = await detectOwnAccountTransfer(
supabase as never,
'company-1',
makeTx({ counterparty_iban: null }),
)
expect(result).toBeNull()
})
it('returns null when IBAN does not match any cash account for the company', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: null }) // findByIban miss
const result = await detectOwnAccountTransfer(
supabase as never,
'company-1',
makeTx({ counterparty_iban: 'NORANDOMVALUE' }),
)
expect(result).toBeNull()
})
it('matches IBAN and returns counter ledger account when present', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
// findByIban hit
enqueue({
data: {
id: 'ca-eur',
company_id: 'company-1',
bank_connection_id: 'conn-eur',
currency: 'EUR',
ledger_account: '1932',
iban: 'SE9550000000054910000003',
is_primary: false,
enabled: true,
source: 'enable_banking',
},
})
// pair candidate lookup: find the matching EUR-side leg
enqueue({
data: [{ id: 'tx-eur-leg', amount: 90.50, date: '2026-06-12' }],
})
const result = await detectOwnAccountTransfer(
supabase as never,
'company-1',
makeTx({ amount: -1000, counterparty_iban: 'SE9550000000054910000003' }),
)
expect(result).not.toBeNull()
expect(result!.counterLedgerAccount).toBe('1932')
expect(result!.counterCurrency).toBe('EUR')
expect(result!.pairTransactionId).toBe('tx-eur-leg')
})
it('returns pairTransactionId: null when the other leg has not been ingested yet', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({
data: {
id: 'ca-eur',
company_id: 'company-1',
bank_connection_id: 'conn-eur',
currency: 'EUR',
ledger_account: '1932',
iban: 'SE9550000000054910000003',
is_primary: false,
enabled: true,
source: 'enable_banking',
},
})
enqueue({ data: [] }) // pair not present yet
const result = await detectOwnAccountTransfer(
supabase as never,
'company-1',
makeTx({ counterparty_iban: 'SE9550000000054910000003' }),
)
expect(result).not.toBeNull()
expect(result!.pairTransactionId).toBeNull()
expect(result!.counterLedgerAccount).toBe('1932')
})
it('refuses to pair when the counter ledger code is outside the cash class (19xx)', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({
data: {
id: 'ca-bad',
company_id: 'company-1',
bank_connection_id: null,
currency: 'SEK',
ledger_account: '6991', // not a cash account
iban: 'SE9550000000054910000003',
is_primary: false,
enabled: true,
source: 'manual',
},
})
const result = await detectOwnAccountTransfer(
supabase as never,
'company-1',
makeTx({ counterparty_iban: 'SE9550000000054910000003' }),
)
expect(result).toBeNull()
})
it('does not fall back to amount-only heuristics when IBAN missing: null instead', async () => {
const { supabase } = createQueuedMockSupabase()
const result = await detectOwnAccountTransfer(
supabase as never,
'company-1',
makeTx({ counterparty_iban: '' }),
)
expect(result).toBeNull()
})
})