Files
accounted/lib/bokslut/arsredovisning/asset-note-figures.ts
T
MattssonandClaude Opus 4.8 53e343ee92 Bug/invalid imports (#1146)
* feat: add Accounted MCP namespace

* fix(bookkeeping): stop flagging verifikat whose underlag lives on a referenced supplier invoice

The missing-underlag surfaces only accepted a document directly linked to
the entry, so payment verifikat for supplier invoices (doc on the
registration entry per design) and entries whose doc was pinned to the
bank transaction before matching were falsely flagged; opening the entry
showed the referenced doc and cleared the warning client-side, and it
came back on reload.

- verifikat_without_documents + transactions_without_documents now treat
  an entry as covered when a supplier invoice referencing it (registration
  or payment FK, or a supplier_invoice_payments row) carries a document
  anchored to a journal entry (BFL 5 kap 7 paragraf hänvisning till
  underlag; anchoring required because the WORM deletion guards key on
  document_attachments.journal_entry_id)
- match-supplier-invoice routes (dashboard + v1) propagate the
  transaction's pinned document onto the payment verifikat, mirroring the
  categorize route; migration backfills rows already written (open
  unlocked periods, company-guarded, never steals a linked doc)
- /api/documents/counts, the transactions-page badges, the bulk "Inget
  underlag krävs" count and the push-notification scheduler share the
  same reference-aware predicate, so every surface agrees with the RPC
- counts route validates journal_entry_ids as UUIDs (they are
  interpolated into a PostgREST or-filter)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(transactions): align table columns flush with page edges

Collapse the checkbox gutter column to zero width and hang the
hover-revealed checkbox/expand chevron in the page margins, drop the
outer padding so DATUM sits flush left and STATUS flush right, and
tuck the overflow-menu dots under the middle of the STATUS header.
Applied to both the inbox and history tables so they stay identical.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(arsredovisning): tie anlaggningstillgangar note to booked depreciation

The ARL 5:8 roll-forward note recomputed depreciation from its own
day-based linear formula (365.25/12 month length, non-inclusive day
count, linear only), drifting ~20 kr per year per asset from the
ledger-driven resultat- and balansrakning and misstating non-linear
methods entirely. Note figures now come from posted
depreciation_schedules rows (the same source disposeAsset reverses),
falling back to the engine's computeAnnualDepreciation when nothing is
posted; pre-onboarding opening balances iterate prior years through
the engine. Adds a note-vs-trial-balance tie-out warning (accounts
1000-1299, over 1 kr) surfaced before download.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(stripe): move connect and sync surface from settings to import page

Stripe's transaction feed is a continuous import source in the same
category as the PSD2 bank connection, so its connect/sync surface now
lives on the import page as a source card (mode=stripe), gated
"kommer snart" on hosted like before; self-hosted keeps the full panel.

- Import page: Stripe card after Koppla bank, renders the existing
  StripeSettingsPanel via the settings-panel registry
- OAuth callback and panel cleanup return to /import?mode=stripe
- Settings > Betalningar retired: nav item removed, route redirects,
  PaymentsSettingsContent deleted, legacy ?tab=payments mapped
- New import.stripe_* strings in sv+en; dead settings_nav.payments removed

Crons and sync logic unchanged; payment-link settings stay in the
invoicing section.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(underlag): paginate missing-underlag cron and harden doc-surface queries

Resolve PR review findings on bug/invalid-imports:
- notification-scheduler: fetchAllRows on all 5 global reads; past 1000 rows
  the capped reads produced false "saknade underlag" notifications
- bulk-missing: LOOKUP_CHUNK 300->150 so the twice-embedded .or() id list
  stays under the PostgREST URL limit
- bulk-missing + transactions page: UUID-guard the .or()-interpolated id
  lists, matching documents/counts
- match-supplier-invoice (dashboard + v1): log documentId/journalEntryId on
  the non-fatal doc-link warning
- well-known/oauth-protected-resource: document the tool_namespace allow-list
- messages/en: reword stripe_description
- DECISIONS.md: record the asset ibAck tie-out and Tailwind !important calls

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(tic): convert registrationDate from Unix seconds to millisecond epoch in lookup and profile tests

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-24 15:03:50 +02:00

204 lines
7.6 KiB
TypeScript

/**
* Per-asset depreciation figures for the anläggningstillgångar roll-forward
* note (ÅRL 5:8 §), anchored to what was actually BOOKED.
*
* The note must reconcile with the balansräkning, which is ledger-driven.
* Posted `depreciation_schedules` rows are the source of truth: they carry
* the exact amounts the engine committed to the journal, and they are also
* exactly what `disposeAsset()` reverses via `sumPostedDepreciation()`.
*
* Fallbacks (only when nothing is posted for the relevant span) reuse the
* booking engine's `computeAnnualDepreciation` so the note previews the
* same amount that WOULD be booked: never a parallel formula. For years
* before the company's fiscal periods exist in the DB (pre-onboarding
* assets), synthetic 12-month windows are stepped back from the earliest
* known period start; irregular pre-onboarding years are approximated,
* which the balansräkning tie-out warning in build-data surfaces.
*/
import type { SupabaseClient } from '@supabase/supabase-js'
import { computeAnnualDepreciation } from '@/lib/bokslut/assets/depreciation-engine'
import { fetchAllRows } from '@/lib/supabase/fetch-all'
import type { Asset } from '@/types'
export interface AssetDepreciationFigures {
/** Accumulated depreciation on the books at period start. */
ibAck: number
/** Depreciation charged during the period (posted schedule, else engine). */
aretsAvskrivning: number
/** Accumulated depreciation reversed on in-period disposal. */
avgaendeAck: number
}
export interface PostedScheduleRow {
asset_id: string
fiscal_period_id: string
/** NUMERIC arrives as string from PostgREST. */
planned_depreciation: number | string
journal_entry_id: string | null
}
export interface PeriodLike {
id: string
period_start: string
period_end: string
}
const round2 = (n: number) => Math.round(n * 100) / 100
/** Posted (journal-linked) schedule rows for the whole company, paginated. */
export async function loadPostedSchedules(
supabase: SupabaseClient,
companyId: string,
): Promise<PostedScheduleRow[]> {
return fetchAllRows<PostedScheduleRow>(({ from, to }) =>
supabase
.from('depreciation_schedules')
.select('asset_id, fiscal_period_id, planned_depreciation, journal_entry_id')
.eq('company_id', companyId)
.not('journal_entry_id', 'is', null)
.order('id')
.range(from, to),
)
}
function isoAddDays(iso: string, days: number): string {
const d = new Date(`${iso}T00:00:00Z`)
d.setUTCDate(d.getUTCDate() + days)
return d.toISOString().slice(0, 10)
}
/** Shift an ISO date by whole years, clamping Feb 29 to Feb 28. */
function isoShiftYears(iso: string, deltaYears: number): string {
const d = new Date(`${iso}T00:00:00Z`)
const year = d.getUTCFullYear() + deltaYears
const month = d.getUTCMonth()
const lastDay = new Date(Date.UTC(year, month + 1, 0)).getUTCDate()
return new Date(Date.UTC(year, month, Math.min(d.getUTCDate(), lastDay)))
.toISOString()
.slice(0, 10)
}
/**
* Accumulated depreciation at period start for an asset with NO posted
* prior schedules. Iterates prior years chronologically through the
* engine (declining methods compound, so order matters): real DB fiscal
* periods where they exist, synthetic 12-month windows stepped back from
* the earliest known period start for the pre-onboarding years before.
*/
function fallbackAccumulatedBefore(
asset: Asset,
currentPeriodStart: string,
fiscalPeriods: PeriodLike[],
): number {
const priorPeriods = fiscalPeriods
.filter((p) => p.period_start < currentPeriodStart)
.sort((a, b) => a.period_start.localeCompare(b.period_start))
const anchorStart =
priorPeriods.length > 0 ? priorPeriods[0].period_start : currentPeriodStart
const synthetic: { period_start: string; period_end: string }[] = []
let windowEnd = isoAddDays(anchorStart, -1)
let windowStart = isoShiftYears(anchorStart, -1)
while (windowEnd >= asset.acquisition_date) {
synthetic.unshift({ period_start: windowStart, period_end: windowEnd })
windowEnd = isoAddDays(windowStart, -1)
windowStart = isoShiftYears(windowStart, -1)
}
let accumulated = 0
for (const window of [...synthetic, ...priorPeriods]) {
if (window.period_end < asset.acquisition_date) continue
const { amount } = computeAnnualDepreciation(asset, window, accumulated)
accumulated = round2(accumulated + amount)
}
return accumulated
}
/**
* Resolve booked-anchored figures for every asset alive in the period.
* Assets disposed before the period are omitted (the note skips them).
*/
export function computeAssetNoteFigures(params: {
assets: Asset[]
postedSchedules: PostedScheduleRow[]
fiscalPeriods: PeriodLike[]
currentPeriodId: string
}): Map<string, AssetDepreciationFigures> {
const { assets, postedSchedules, fiscalPeriods, currentPeriodId } = params
const currentPeriod = fiscalPeriods.find((p) => p.id === currentPeriodId)
if (!currentPeriod) {
throw new Error('Current fiscal period not found in fiscal period list')
}
const periodStartById = new Map(fiscalPeriods.map((p) => [p.id, p.period_start]))
const byAsset = new Map<string, PostedScheduleRow[]>()
for (const row of postedSchedules) {
if (row.journal_entry_id == null) continue
const list = byAsset.get(row.asset_id)
if (list) list.push(row)
else byAsset.set(row.asset_id, [row])
}
const figures = new Map<string, AssetDepreciationFigures>()
for (const asset of assets) {
if (asset.disposed_at && asset.disposed_at < currentPeriod.period_start) continue
const rows = byAsset.get(asset.id) ?? []
const currentPosted = rows.find((r) => r.fiscal_period_id === currentPeriodId)
const priorPosted = rows.filter((r) => {
const start = periodStartById.get(r.fiscal_period_id)
return start != null && start < currentPeriod.period_start
})
let ibAck: number
if (priorPosted.length > 0) {
ibAck = round2(
priorPosted.reduce((sum, r) => sum + (Number(r.planned_depreciation) || 0), 0),
)
} else if (asset.acquisition_date >= currentPeriod.period_start) {
ibAck = 0
} else {
ibAck = fallbackAccumulatedBefore(asset, currentPeriod.period_start, fiscalPeriods)
}
const disposedDuringPeriod =
asset.disposed_at != null &&
asset.disposed_at >= currentPeriod.period_start &&
asset.disposed_at <= currentPeriod.period_end
let aretsAvskrivning: number
let avgaendeAck = 0
if (disposedDuringPeriod) {
const hasAnyPosted = rows.length > 0
if (hasAnyPosted) {
// Mirror sumPostedDepreciation()/disposeAsset(): the ledger reversed
// exactly the sum of all posted rows, and the current year's charge
// is whatever was posted for this period (often nothing).
aretsAvskrivning = currentPosted
? Number(currentPosted.planned_depreciation) || 0
: 0
avgaendeAck = round2(
rows.reduce((sum, r) => sum + (Number(r.planned_depreciation) || 0), 0),
)
} else {
// Nothing ever posted: preview what the engine would have booked so
// the disposed asset still nets out of the roll-forward.
aretsAvskrivning = computeAnnualDepreciation(asset, currentPeriod, ibAck).amount
avgaendeAck = round2(ibAck + aretsAvskrivning)
}
} else if (currentPosted) {
aretsAvskrivning = Number(currentPosted.planned_depreciation) || 0
} else {
aretsAvskrivning = computeAnnualDepreciation(asset, currentPeriod, ibAck).amount
}
figures.set(asset.id, {
ibAck,
aretsAvskrivning: round2(aretsAvskrivning),
avgaendeAck,
})
}
return figures
}