Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
33 lines
1.5 KiB
TypeScript
33 lines
1.5 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { boundToolResultText, MAX_TOOL_RESULT_CHARS } from '../run-turn'
|
|
|
|
// Tool results re-enter the model context on every later loop iteration and are
|
|
// persisted as a 'tool' message that loadConversationMessages replays on every
|
|
// future turn. An unbounded read (gnubok_get_document_content returns full
|
|
// OCR/PDF text) would therefore re-introduce the context rot we keep out of the
|
|
// system prompt. boundToolResultText caps the serialized payload.
|
|
|
|
describe('boundToolResultText: tool-return discipline', () => {
|
|
it('passes small results through unchanged', () => {
|
|
const small = JSON.stringify({ rows: [{ account: '1930', amount: 1000 }] })
|
|
expect(boundToolResultText(small)).toBe(small)
|
|
})
|
|
|
|
it('passes a result exactly at the ceiling through unchanged', () => {
|
|
const exact = 'x'.repeat(MAX_TOOL_RESULT_CHARS)
|
|
expect(boundToolResultText(exact)).toBe(exact)
|
|
})
|
|
|
|
it('truncates an oversized result to the ceiling and appends a steer', () => {
|
|
const huge = 'x'.repeat(MAX_TOOL_RESULT_CHARS + 50_000)
|
|
const out = boundToolResultText(huge)
|
|
// The body is capped at the ceiling…
|
|
expect(out.startsWith('x'.repeat(MAX_TOOL_RESULT_CHARS))).toBe(true)
|
|
expect(out.length).toBeLessThan(huge.length)
|
|
// …and the marker tells the model it was cut and how to narrow.
|
|
expect(out).toContain('avkortat')
|
|
expect(out).toContain(String(huge.length))
|
|
expect(out.toLowerCase()).toMatch(/smalare|limit|datumintervall/)
|
|
})
|
|
})
|