* fix(tic): allow BankID link/unlink without a company context /bankid/link and /bankid/unlink are user-level actions, but the extension dispatcher resolved an active company for them, so a zero-company user (fresh BankID signup, pre-onboarding) got a 500 'No company context' when managing the connection from /settings/account. Mark both routes skipCompanyContext and resolve the caller in-handler via requireAuth(), which preserves the dispatcher's MFA/AAL2 enforcement. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(tic): return 409 account_exists instead of 500 on BankID signup with taken email The signup guard pre-checked profiles.email, but the authoritative store is auth.users: anonymized account tombstones (and any profile drift) hold the email in auth.users while profiles.email is NULL. The guard missed, createUser failed with email_exists (422), and the route surfaced a dead-end 500 'Kunde inte skapa kontot. Forsok igen.' where retrying can never succeed. Drop the profiles pre-check and let createUser's own uniqueness check be the guard: map email_exists to the existing 409 account_exists response (Swedish message), which the register page already handles with a toast and a redirect to login. Also removes the TOCTOU window between the old pre-check and createUser. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(account): actually scrub auth.users metadata on account deletion The delete route passed user_metadata: {} / app_metadata: {} to auth.admin.updateUserById assuming replace semantics, but GoTrue MERGES metadata maps, so the wipe was a silent no-op: the ~100-year tombstone kept the user's full name in raw_user_meta_data (verified on production 2026-07-24). Move the scrub into anonymize_user_account (migration 20260724150000): raw_user_meta_data is cleared entirely, raw_app_meta_data drops the app-specific keys (bankid_linked, has_password) while GoTrue's provider/providers stay, and auth.users.email is still retained as the documented legitimate-interest tombstone. The migration also repairs existing tombstones (guarded by profiles.anonymized_at). The route keeps only the ban, which the DB function cannot set. Migration content already applied to staging; pg-real test extended. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: log BankID signup guard decision Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(account): address PR review findings on anonymize scrub - anonymize_user_account now rejects repeat invocations against an already-anonymized tombstone (SQLSTATE P0002) instead of re-churning the scrubbed row - note that the tombstone repair UPDATE runs atomically inside the migration transaction - tic signup failure log hashes the email (sha256 prefix, matching the pnrHashPrefix pattern) instead of logging the raw address - pg-real test for the double-invocation guard Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(anonymization): ensure raw_app_meta_data is not null before scrubbing keys --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
256 lines
8.4 KiB
TypeScript
256 lines
8.4 KiB
TypeScript
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
|
|
import { NextResponse } from 'next/server'
|
|
import { createMockRequest, parseJsonResponse } from '@/tests/helpers'
|
|
|
|
vi.mock('../lib/bankid-client', () => ({
|
|
startBankIdAuth: vi.fn(),
|
|
pollBankIdSession: vi.fn(),
|
|
collectBankIdResult: vi.fn(),
|
|
cancelBankIdSession: vi.fn(),
|
|
requestEnrichment: vi.fn().mockResolvedValue({ status: 'failed', completedTypes: [] }),
|
|
fetchEnrichmentData: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createServiceClient: vi.fn(),
|
|
createClient: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/auth/require-auth', () => ({
|
|
requireAuth: vi.fn(),
|
|
}))
|
|
|
|
import { collectBankIdResult } from '../lib/bankid-client'
|
|
import { createServiceClient } from '@/lib/supabase/server'
|
|
import { requireAuth } from '@/lib/auth/require-auth'
|
|
import { ticExtension } from '../index'
|
|
|
|
const TEST_KEY = 'a'.repeat(64)
|
|
|
|
function findRoute(method: string, path: string) {
|
|
const route = ticExtension.apiRoutes!.find((r) => r.method === method && r.path === path)
|
|
if (!route) throw new Error(`${method} ${path} route not found in ticExtension.apiRoutes`)
|
|
return route
|
|
}
|
|
|
|
function findHandler(method: string, path: string) {
|
|
return findRoute(method, path).handler
|
|
}
|
|
|
|
function mockAuthenticated(userId = 'user-1') {
|
|
vi.mocked(requireAuth).mockResolvedValue({
|
|
user: { id: userId },
|
|
supabase: {},
|
|
error: null,
|
|
} as unknown as Awaited<ReturnType<typeof requireAuth>>)
|
|
}
|
|
|
|
function mockUnauthenticated() {
|
|
vi.mocked(requireAuth).mockResolvedValue({
|
|
user: null,
|
|
supabase: {},
|
|
error: NextResponse.json({ error: 'Unauthorized' }, { status: 401 }),
|
|
} as unknown as Awaited<ReturnType<typeof requireAuth>>)
|
|
}
|
|
|
|
type QueuedResult = { data?: unknown; error?: unknown }
|
|
|
|
/** Minimal chainable service-client mock (same pattern as bankid-complete.test.ts). */
|
|
function mockServiceClient(fromResults: QueuedResult[], appMetadata: Record<string, unknown>) {
|
|
const queue = [...fromResults]
|
|
|
|
const chain = (): unknown => {
|
|
const result = queue.shift() ?? { data: null, error: null }
|
|
const handler: ProxyHandler<object> = {
|
|
get(_t, prop) {
|
|
if (prop === 'then') return (resolve: (v: unknown) => void) => resolve(result)
|
|
return () => chain2(result)
|
|
},
|
|
}
|
|
return new Proxy({}, handler)
|
|
}
|
|
const chain2 = (result: QueuedResult): unknown => {
|
|
const handler: ProxyHandler<object> = {
|
|
get(_t, prop) {
|
|
if (prop === 'then') return (resolve: (v: unknown) => void) => resolve(result)
|
|
return () => chain2(result)
|
|
},
|
|
}
|
|
return new Proxy({}, handler)
|
|
}
|
|
|
|
const admin = {
|
|
updateUserById: vi.fn().mockResolvedValue({ data: {}, error: null }),
|
|
getUserById: vi.fn().mockResolvedValue({
|
|
data: { user: { id: 'user-1', app_metadata: appMetadata } },
|
|
}),
|
|
}
|
|
|
|
const client = {
|
|
from: vi.fn().mockImplementation(() => chain()),
|
|
auth: { admin },
|
|
}
|
|
|
|
vi.mocked(createServiceClient).mockReturnValue(
|
|
client as unknown as ReturnType<typeof createServiceClient>
|
|
)
|
|
|
|
return { admin, client }
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
vi.stubEnv('BANKID_ENCRYPTION_KEY', TEST_KEY)
|
|
})
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllEnvs()
|
|
})
|
|
|
|
describe('route flags', () => {
|
|
// These routes are user-level: a zero-company user (fresh BankID signup,
|
|
// pre-onboarding) must be able to manage the connection from settings.
|
|
// Without skipCompanyContext the dispatcher throws 'No company context'.
|
|
it('link and unlink skip company context', () => {
|
|
expect(findRoute('POST', '/bankid/link').skipCompanyContext).toBe(true)
|
|
expect(findRoute('POST', '/bankid/unlink').skipCompanyContext).toBe(true)
|
|
})
|
|
|
|
it('link and unlink still require auth', () => {
|
|
expect(findRoute('POST', '/bankid/link').skipAuth).toBeUndefined()
|
|
expect(findRoute('POST', '/bankid/unlink').skipAuth).toBeUndefined()
|
|
})
|
|
})
|
|
|
|
describe('POST /bankid/unlink', () => {
|
|
it('returns 401 when unauthenticated', async () => {
|
|
mockUnauthenticated()
|
|
mockServiceClient([], {})
|
|
const req = createMockRequest('/api/extensions/ext/tic/bankid/unlink', { method: 'POST' })
|
|
const { status } = await parseJsonResponse(await findHandler('POST', '/bankid/unlink')(req))
|
|
expect(status).toBe(401)
|
|
})
|
|
|
|
it('merges app_metadata instead of replacing it: has_password must survive unlink', async () => {
|
|
// A BankID-only user: has_password false. Wiping it would make
|
|
// userHasPassword() infer TRUE (bankid_linked false ⇒ password assumed),
|
|
// hiding the set-password escape hatch from a user with no login method.
|
|
mockAuthenticated()
|
|
const { admin } = mockServiceClient(
|
|
[{ error: null }], // bankid_identities delete OK
|
|
{ has_password: false, bankid_linked: true, provider: 'email' }
|
|
)
|
|
|
|
const req = createMockRequest('/api/extensions/ext/tic/bankid/unlink', { method: 'POST' })
|
|
const { status, body } = await parseJsonResponse<{ data?: { unlinked?: boolean } }>(
|
|
await findHandler('POST', '/bankid/unlink')(req)
|
|
)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body.data?.unlinked).toBe(true)
|
|
expect(admin.updateUserById).toHaveBeenCalledWith('user-1', {
|
|
app_metadata: { has_password: false, provider: 'email', bankid_linked: false },
|
|
})
|
|
})
|
|
|
|
it('returns 500 when the identity delete fails and does not touch app_metadata', async () => {
|
|
mockAuthenticated()
|
|
const { admin } = mockServiceClient(
|
|
[{ error: { message: 'delete boom', code: 'XX000' } }],
|
|
{ has_password: false, bankid_linked: true }
|
|
)
|
|
|
|
const req = createMockRequest('/api/extensions/ext/tic/bankid/unlink', { method: 'POST' })
|
|
const { status } = await parseJsonResponse(
|
|
await findHandler('POST', '/bankid/unlink')(req)
|
|
)
|
|
|
|
expect(status).toBe(500)
|
|
expect(admin.updateUserById).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
|
|
describe('POST /bankid/link', () => {
|
|
function makeSession() {
|
|
return {
|
|
sessionId: 'test-session',
|
|
status: 'complete',
|
|
user: {
|
|
personalNumber: '199001011234',
|
|
givenName: 'Anna',
|
|
surname: 'Andersson',
|
|
name: 'Anna Andersson',
|
|
},
|
|
} as unknown as Awaited<ReturnType<typeof collectBankIdResult>>
|
|
}
|
|
|
|
it('returns 401 when unauthenticated', async () => {
|
|
mockUnauthenticated()
|
|
mockServiceClient([], {})
|
|
const req = createMockRequest('/api/extensions/ext/tic/bankid/link', {
|
|
method: 'POST',
|
|
body: { sessionId: 'test-session' },
|
|
})
|
|
const { status } = await parseJsonResponse(await findHandler('POST', '/bankid/link')(req))
|
|
expect(status).toBe(401)
|
|
})
|
|
|
|
it('returns 400 when sessionId is missing', async () => {
|
|
mockAuthenticated()
|
|
mockServiceClient([], {})
|
|
const req = createMockRequest('/api/extensions/ext/tic/bankid/link', {
|
|
method: 'POST',
|
|
body: {},
|
|
})
|
|
const { status } = await parseJsonResponse(await findHandler('POST', '/bankid/link')(req))
|
|
expect(status).toBe(400)
|
|
})
|
|
|
|
it('merges app_metadata so an existing has_password: true survives linking', async () => {
|
|
mockAuthenticated()
|
|
vi.mocked(collectBankIdResult).mockResolvedValue(makeSession())
|
|
const { admin } = mockServiceClient(
|
|
[
|
|
{ data: null }, // pnr lookup → not linked anywhere
|
|
{ error: null }, // bankid_identities insert OK
|
|
],
|
|
{ has_password: true }
|
|
)
|
|
|
|
const req = createMockRequest('/api/extensions/ext/tic/bankid/link', {
|
|
method: 'POST',
|
|
body: { sessionId: 'test-session' },
|
|
})
|
|
const { status, body } = await parseJsonResponse<{ data?: { linked?: boolean } }>(
|
|
await findHandler('POST', '/bankid/link')(req)
|
|
)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body.data?.linked).toBe(true)
|
|
expect(admin.updateUserById).toHaveBeenCalledWith('user-1', {
|
|
app_metadata: { has_password: true, bankid_linked: true },
|
|
})
|
|
})
|
|
|
|
it('returns 409 already_linked when the personnummer belongs to another user', async () => {
|
|
mockAuthenticated()
|
|
vi.mocked(collectBankIdResult).mockResolvedValue(makeSession())
|
|
const { admin } = mockServiceClient(
|
|
[{ data: { user_id: 'someone-else' } }],
|
|
{ has_password: true }
|
|
)
|
|
|
|
const req = createMockRequest('/api/extensions/ext/tic/bankid/link', {
|
|
method: 'POST',
|
|
body: { sessionId: 'test-session' },
|
|
})
|
|
const { status, body } = await parseJsonResponse<{ error?: string }>(
|
|
await findHandler('POST', '/bankid/link')(req)
|
|
)
|
|
|
|
expect(status).toBe(409)
|
|
expect(body.error).toBe('already_linked')
|
|
expect(admin.updateUserById).not.toHaveBeenCalled()
|
|
})
|
|
})
|