Jakob WennbergandClaude Sonnet 5
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
63 lines
2.0 KiB
TypeScript
63 lines
2.0 KiB
TypeScript
'use client'
|
|
|
|
import { useTranslations } from 'next-intl'
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
} from '@/components/ui/dialog'
|
|
import NewSupplierInvoiceForm from '@/components/supplier-invoices/NewSupplierInvoiceForm'
|
|
|
|
interface Props {
|
|
open: boolean
|
|
onOpenChange: (open: boolean) => void
|
|
/** Invoice-inbox item to convert; prefills the form from its AI extraction. */
|
|
inboxItemId?: string | null
|
|
/**
|
|
* Fired after a successful create. Hosts close the dialog and either
|
|
* navigate to the invoice detail (id given) or refresh their list in place.
|
|
*/
|
|
onCreated: (invoiceId?: string) => void
|
|
}
|
|
|
|
/**
|
|
* "Registrera leverantörsfaktura" as a modal: mirrors NewJournalEntryDialog.
|
|
* Wraps the bare NewSupplierInvoiceForm; the form's own review/confirm,
|
|
* supplier-create, bank-picker, and conflict dialogs stack on top of this one.
|
|
*/
|
|
export default function NewSupplierInvoiceDialog({
|
|
open,
|
|
onOpenChange,
|
|
inboxItemId,
|
|
onCreated,
|
|
}: Props) {
|
|
const t = useTranslations('supplier_invoice_editor')
|
|
|
|
return (
|
|
<Dialog open={open} onOpenChange={onOpenChange}>
|
|
<DialogContent
|
|
className="sm:max-w-4xl max-h-[95dvh] sm:max-h-[90vh] overflow-y-auto"
|
|
// A half-typed invoice must survive an accidental backdrop click or a
|
|
// stray Escape (nested comboboxes and date pickers portal outside the
|
|
// dialog). Closing is explicit: the header X or Avbryt. Same
|
|
// convention as NewJournalEntryDialog.
|
|
onEscapeKeyDown={(e) => e.preventDefault()}
|
|
onPointerDownOutside={(e) => e.preventDefault()}
|
|
onInteractOutside={(e) => e.preventDefault()}
|
|
>
|
|
<DialogHeader>
|
|
<DialogTitle>{t('page_title')}</DialogTitle>
|
|
</DialogHeader>
|
|
<NewSupplierInvoiceForm
|
|
key={inboxItemId ?? 'fresh'}
|
|
bare
|
|
inboxItemId={inboxItemId}
|
|
onCreated={onCreated}
|
|
onCancel={() => onOpenChange(false)}
|
|
/>
|
|
</DialogContent>
|
|
</Dialog>
|
|
)
|
|
}
|