Files
accounted/app/api/rot-rut/payout-requests/[id]/settle/route.ts
T
Jakob WennbergandClaude Sonnet 5 ec27228a8e style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890)
Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.

Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.

Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.

Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-04 15:58:06 +02:00

163 lines
5.9 KiB
TypeScript

import { NextResponse } from 'next/server'
import { withRouteContext } from '@/lib/api/with-route-context'
import { validateBody } from '@/lib/api/validate'
import { RotRutSettleSchema } from '@/lib/api/schemas'
import { errorResponse, errorResponseFromCode } from '@/lib/errors/get-structured-error'
import { createRotRutPayoutEntry } from '@/lib/bookkeeping/rot-rut-entries'
/**
* POST /api/rot-rut/payout-requests/[id]/settle
*
* Books Skatteverkets utbetalning for a begäran:
*
* Debit 19xx bank account (default 1930) [amount]
* Credit 1513 Skattereduktion rot/rut [amount]
*
* The journal entry IS the accounting record here, so engine failure blocks
* the operation (see .claude/skills/erp-api-route, payment entries block).
* amount defaults to decided_total, falling back to requested_total. If the
* amount equals requested_total the request completes as 'paid'; anything
* lower records 'partially_paid' with decided_total = amount.
*/
export const POST = withRouteContext<{ params: Promise<{ id: string }> }>(
'rot_rut.requests.settle',
async (request, ctx, { params }) => {
const { user, supabase, companyId, log, requestId } = ctx
const { id } = await params
const validation = await validateBody(request, RotRutSettleSchema)
if (!validation.success) return validation.response
const input = validation.data
const { data: payoutRequest, error: fetchError } = await supabase
.from('rot_rut_payout_requests')
.select('*')
.eq('company_id', companyId!)
.eq('id', id)
.maybeSingle()
if (fetchError) {
log.error('failed to fetch rot/rut payout request', fetchError)
return errorResponse(fetchError, log, { requestId })
}
if (!payoutRequest) {
return errorResponseFromCode('ROT_RUT_REQUEST_NOT_FOUND', log, { requestId })
}
const settleable =
!payoutRequest.settlement_journal_entry_id &&
!['cancelled', 'rejected'].includes(payoutRequest.status)
if (!settleable) {
return errorResponseFromCode('ROT_RUT_SETTLE_INVALID_STATE', log, {
requestId,
details: {
status: payoutRequest.status,
already_settled: !!payoutRequest.settlement_journal_entry_id,
},
})
}
const amount =
input.amount ?? Number(payoutRequest.decided_total ?? payoutRequest.requested_total)
// A partial settlement must follow a recorded beslut: without this guard a
// settle with amount < requested_total on an undecided request would flip
// it to partially_paid while bypassing the PATCH lifecycle rule that
// partially_paid requires decided_total: the beslut would never be
// recorded and later PATCH calls would be blocked by ALLOWED_TRANSITIONS.
if (amount < Number(payoutRequest.requested_total) && payoutRequest.decided_total == null) {
return errorResponseFromCode('ROT_RUT_SETTLE_INVALID_STATE', log, {
requestId,
details: {
status: payoutRequest.status,
reason:
'Delutbetalning kräver att Skatteverkets beslut registreras först (decided_total via PATCH).',
},
})
}
// The voucher is the accounting record: engine failure must block.
let journalEntryId: string
try {
const entry = await createRotRutPayoutEntry(supabase, companyId!, user.id, {
requestId: payoutRequest.id,
requestName: payoutRequest.name,
deductionType: payoutRequest.deduction_type,
paymentDate: input.payment_date,
amount,
bankAccount: input.bank_account,
})
journalEntryId = entry.id
} catch (engineError) {
log.error('failed to book rot/rut payout entry', engineError as Error)
return errorResponse(engineError, log, { requestId })
}
const fullyPaid = amount >= Number(payoutRequest.requested_total)
const update: Record<string, unknown> = {
settlement_journal_entry_id: journalEntryId,
status: fullyPaid ? 'paid' : 'partially_paid',
decided_total: payoutRequest.decided_total ?? amount,
}
if (!payoutRequest.decided_at) {
update.decided_at = new Date().toISOString()
}
const { data: updated, error: updateError } = await supabase
.from('rot_rut_payout_requests')
.update(update)
.eq('company_id', companyId!)
.eq('id', id)
.select(
'id, name, deduction_type, status, requested_total, decided_total, decided_at, settlement_journal_entry_id',
)
.single()
if (updateError) {
// The voucher exists (immutable per BFL) but the request row didn't
// absorb the link: surface loudly, do NOT try to unbook.
log.error('rot/rut payout entry booked but request update failed', updateError, {
journalEntryId,
payoutRequestId: id,
})
return errorResponse(updateError, log, { requestId })
}
if (fullyPaid) {
const { data: items, error: itemsFetchError } = await supabase
.from('rot_rut_payout_request_items')
.select('id, requested_amount')
.eq('request_id', id)
if (itemsFetchError) {
log.warn('failed to fetch items for decided_amount mirror', {
payoutRequestId: id,
message: itemsFetchError.message,
})
}
for (const item of items ?? []) {
const { error: mirrorError } = await supabase
.from('rot_rut_payout_request_items')
.update({ decided_amount: item.requested_amount })
.eq('id', item.id)
if (mirrorError) {
log.warn('failed to mirror decided_amount onto item', {
itemId: item.id,
message: mirrorError.message,
})
}
}
}
log.info('rot/rut payout settled', {
userId: user.id,
payoutRequestId: id,
journalEntryId,
amount,
fullyPaid,
})
return NextResponse.json({ data: { request: updated, journal_entry_id: journalEntryId } })
},
{ requireWrite: true },
)