* feat(bookkeeping): make blocked fiscal-year creation actionable When creating a new räkenskapsår is blocked because a prior period is still open, the "Skapa räkenskapsår" dialog no longer dead-ends on an English toast. The API now returns the canonical bilingual error envelope with the blocking periods (id/name/dates) under details, and the dialog renders a Swedish panel that locks them inline (reversible locked_at) via the existing /lock endpoint and retries creation. The guard rule is unchanged and remains BFL-compliant: BFL 6 kap allows löpande bokföring of the new year in parallel with the prior year's bokslut, so a lock (not a full close) is sufficient and reversible. - Add PERIOD_CREATE_BLOCKED_BY_OPEN_PERIODS structured error code - Return envelope + details.blockingPeriods from the 409 (was English string) - CreatePeriodDialog: inline "lås och skapa" panel + lock-and-retry - Update route tests for the new envelope shape Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(ui): prevent mouse wheel from mutating number inputs A focused <input type="number"> would change its value on scroll, silently turning e.g. a 20000 salary into 19998. Blur number inputs on wheel so the page scrolls instead of editing the value. Applied at the Input primitive so all number fields are protected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(salary): auto-derive skattetabell and kolumn for employees Replace the opaque manual "Skattetabell (29-42)" and "Kolumn (1-6)" inputs on the employee form with a self-deriving flow: the user picks their folkbokföringskommun from a searchable dropdown and the tax table fills itself in, while the column derives from the personnummer we already collect. - Add a searchable municipality picker (MunicipalityCombobox) backed by a new cached GET /api/salary/tax-tables/kommuner endpoint. - Wrap the whole "Skatt" card in a self-contained EmployeeTaxCard used by both the create and edit pages, with InfoTooltips and named column options. - deriveTaxColumn(): auto-select column 1 for under-66 employees; leave the ambiguous 66+ case (pension vs working senior) to a clearly-named manual choice. - Fix fetchKommunTaxRates() to page through all ~1300 församling rows instead of a single 500-row page (which silently dropped ~200 kommuner, incl. Göteborg) and normalize the uppercase names to title case. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(import): correct CSV amount-column guess and surface skipped rows Manual CSV column-mapping auto-guess walked each data row right-to-left and picked the first numeric cell as the amount, so on the common ...;Belopp;Saldo layout it grabbed the trailing running-balance column. Extract the guess into a pure, tested suggestColumnMapping(): match header labels first (belopp/amount -> amount, saldo/balance -> balance), auto-fill the balance field, and fall back to value heuristics that skip the balance column and prefer a column carrying negative values. Also surface stats.skipped_rows + parse warnings in BankFileConfirmStep - the manual-mapping path skips the preview step that was the only place they showed, so skipped rows were silently dropped from view. Add a unit test reproducing the Saldo-as-amount regression. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat: add "Save as draft" functionality for invoices - Implemented a new feature to allow users to save invoices as unnumbered drafts without generating an invoice number until finalized. - Added a `save_as_draft` flag to the CreateInvoiceInput schema to handle draft saving logic. - Updated the invoice creation API to skip number allocation when saving as a draft. - Introduced a new endpoint for finalizing drafts, which allocates an invoice number and emits an `invoice.created` event. - Enhanced the UI to include a "Save as draft" button, with loading states and tooltips. - Updated tests to cover the new draft saving and finalization logic, including race conditions for concurrent modifications. - Added relevant error handling for draft finalization and deletion scenarios. * feat(employee): add employment start and end date fields to employee forms * feat: enhance invoice and salary run handling with improved validation and event logging --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
173 lines
5.6 KiB
TypeScript
173 lines
5.6 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import {
|
|
createMockRequest,
|
|
createMockRouteParams,
|
|
parseJsonResponse,
|
|
createQueuedMockSupabase,
|
|
makeInvoice,
|
|
makeCustomer,
|
|
} from '@/tests/helpers'
|
|
import { eventBus } from '@/lib/events'
|
|
|
|
const { supabase: mockSupabase, enqueue, reset } = createQueuedMockSupabase()
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createClient: () => Promise.resolve(mockSupabase),
|
|
}))
|
|
|
|
vi.mock('@/lib/init', () => ({
|
|
ensureInitialized: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/company/context', () => ({
|
|
requireCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
getActiveCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
}))
|
|
|
|
vi.mock('@/lib/auth/require-write', () => ({
|
|
requireWritePermission: vi.fn().mockResolvedValue({ ok: true }),
|
|
}))
|
|
|
|
import { POST } from '../route'
|
|
|
|
describe('POST /api/invoices/[id]/finalize ("Granska & skapa")', () => {
|
|
const mockUser = { id: 'user-1', email: 'test@test.se' }
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
reset()
|
|
eventBus.clear()
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: mockUser } })
|
|
})
|
|
|
|
it('finalizes an unnumbered draft: allocates a number and emits invoice.created', async () => {
|
|
const customer = makeCustomer({ id: 'cust-1' })
|
|
const draft = makeInvoice({
|
|
id: 'inv-1',
|
|
invoice_number: null,
|
|
status: 'draft',
|
|
document_type: 'invoice',
|
|
})
|
|
|
|
// Fetch the draft
|
|
enqueue({ data: draft, error: null })
|
|
// ensureInvoiceNumber → generate_invoice_number RPC
|
|
enqueue({ data: '2026001', error: null })
|
|
// Fetch the complete invoice
|
|
enqueue({ data: { ...draft, invoice_number: '2026001', customer, items: [] }, error: null })
|
|
|
|
const emitSpy = vi.spyOn(eventBus, 'emit')
|
|
|
|
const response = await POST(
|
|
createMockRequest('/api/invoices/inv-1/finalize', { method: 'POST' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ data: { invoice_number: string | null } }>(response)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body.data.invoice_number).toBe('2026001')
|
|
expect(emitSpy).toHaveBeenCalledWith(
|
|
expect.objectContaining({ type: 'invoice.created' })
|
|
)
|
|
})
|
|
|
|
it('returns 404 INVOICE_NOT_FOUND when the invoice does not exist', async () => {
|
|
enqueue({ data: null, error: { message: 'not found' } })
|
|
|
|
const response = await POST(
|
|
createMockRequest('/api/invoices/inv-1/finalize', { method: 'POST' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(response)
|
|
|
|
expect(status).toBe(404)
|
|
expect(body.error.code).toBe('INVOICE_NOT_FOUND')
|
|
})
|
|
|
|
it('rejects a draft that already has a number with INVOICE_FINALIZE_NOT_DRAFT', async () => {
|
|
const numbered = makeInvoice({
|
|
id: 'inv-1',
|
|
invoice_number: 'F-2026001',
|
|
status: 'draft',
|
|
document_type: 'invoice',
|
|
})
|
|
enqueue({ data: numbered, error: null })
|
|
|
|
const response = await POST(
|
|
createMockRequest('/api/invoices/inv-1/finalize', { method: 'POST' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(response)
|
|
|
|
expect(status).toBe(409)
|
|
expect(body.error.code).toBe('INVOICE_FINALIZE_NOT_DRAFT')
|
|
})
|
|
|
|
it('rejects a non-draft invoice with INVOICE_FINALIZE_NOT_DRAFT', async () => {
|
|
const sent = makeInvoice({
|
|
id: 'inv-1',
|
|
invoice_number: null,
|
|
status: 'sent',
|
|
document_type: 'invoice',
|
|
})
|
|
enqueue({ data: sent, error: null })
|
|
|
|
const response = await POST(
|
|
createMockRequest('/api/invoices/inv-1/finalize', { method: 'POST' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(response)
|
|
|
|
expect(status).toBe(409)
|
|
expect(body.error.code).toBe('INVOICE_FINALIZE_NOT_DRAFT')
|
|
})
|
|
|
|
it('rejects a self-billed draft (counterparty document, no F-number allocation)', async () => {
|
|
const selfBilled = makeInvoice({
|
|
id: 'inv-1',
|
|
invoice_number: null,
|
|
status: 'draft',
|
|
document_type: 'invoice',
|
|
is_self_billed: true,
|
|
})
|
|
enqueue({ data: selfBilled, error: null })
|
|
|
|
const emitSpy = vi.spyOn(eventBus, 'emit')
|
|
|
|
const response = await POST(
|
|
createMockRequest('/api/invoices/inv-1/finalize', { method: 'POST' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(response)
|
|
|
|
expect(status).toBe(409)
|
|
expect(body.error.code).toBe('INVOICE_FINALIZE_NOT_DRAFT')
|
|
expect(emitSpy).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('returns 500 INVOICE_FINALIZE_INCOMPLETE (and emits nothing) when the re-read fails after numbering', async () => {
|
|
const draft = makeInvoice({
|
|
id: 'inv-1',
|
|
invoice_number: null,
|
|
status: 'draft',
|
|
document_type: 'invoice',
|
|
})
|
|
|
|
enqueue({ data: draft, error: null }) // fetch draft
|
|
enqueue({ data: '2026001', error: null }) // number allocation
|
|
enqueue({ data: null, error: { message: 'transient db error' } }) // re-read fails
|
|
|
|
const emitSpy = vi.spyOn(eventBus, 'emit')
|
|
|
|
const response = await POST(
|
|
createMockRequest('/api/invoices/inv-1/finalize', { method: 'POST' }),
|
|
createMockRouteParams({ id: 'inv-1' })
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(response)
|
|
|
|
expect(status).toBe(500)
|
|
expect(body.error.code).toBe('INVOICE_FINALIZE_INCOMPLETE')
|
|
// No invoice.created emitted with a hollow payload.
|
|
expect(emitSpy).not.toHaveBeenCalled()
|
|
})
|
|
})
|