Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
215 lines
8.3 KiB
TypeScript
215 lines
8.3 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import { eventBus } from '@/lib/events/bus'
|
|
import {
|
|
parseJsonResponse,
|
|
createMockRouteParams,
|
|
createQueuedMockSupabase,
|
|
} from '@/tests/helpers'
|
|
|
|
const { supabase: mockSupabase, enqueue, reset } = createQueuedMockSupabase()
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createClient: () => Promise.resolve(mockSupabase),
|
|
}))
|
|
|
|
vi.mock('@/lib/company/context', () => ({
|
|
requireCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
getActiveCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
}))
|
|
|
|
vi.mock('@/lib/auth/require-write', () => ({
|
|
requireWritePermission: vi.fn().mockResolvedValue({ ok: true }),
|
|
}))
|
|
|
|
vi.mock('@/lib/init', () => ({
|
|
ensureInitialized: vi.fn(),
|
|
}))
|
|
|
|
import { POST } from '../route'
|
|
import { requireWritePermission } from '@/lib/auth/require-write'
|
|
import { NextResponse } from 'next/server'
|
|
|
|
const mockUser = { id: 'user-1', email: 'test@test.se' }
|
|
|
|
// Body fields are uuid-validated (LinkDocumentSchema): request fixtures must
|
|
// be real UUIDs. The enqueue mock rows keep their short ids; the queued mock
|
|
// doesn't correlate request input with mocked output.
|
|
const JE_ID = '11111111-1111-4111-8111-111111111111'
|
|
const OTHER_JE_ID = '22222222-2222-4222-8222-222222222222'
|
|
const INBOX_ID = '33333333-3333-4333-8333-333333333333'
|
|
const TX_ID = '44444444-4444-4444-8444-444444444444'
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
reset()
|
|
eventBus.clear()
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: mockUser } })
|
|
vi.mocked(requireWritePermission).mockResolvedValue({ ok: true })
|
|
})
|
|
|
|
function makeReq(body: unknown) {
|
|
return new Request('http://localhost/api/documents/doc-1/link', {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify(body),
|
|
})
|
|
}
|
|
|
|
describe('POST /api/documents/[id]/link', () => {
|
|
it('returns 401 when not authenticated', async () => {
|
|
mockSupabase.auth.getUser.mockResolvedValue({ data: { user: null } })
|
|
const res = await POST(makeReq({ journal_entry_id: JE_ID }), createMockRouteParams({ id: 'doc-1' }))
|
|
const { status } = await parseJsonResponse(res)
|
|
expect(status).toBe(401)
|
|
})
|
|
|
|
it('returns 403 when caller has read-only role', async () => {
|
|
vi.mocked(requireWritePermission).mockResolvedValue({
|
|
ok: false,
|
|
response: NextResponse.json(
|
|
{ error: 'Du har endast läsbehörighet i detta företag.' },
|
|
{ status: 403 },
|
|
),
|
|
})
|
|
const res = await POST(makeReq({ journal_entry_id: JE_ID }), createMockRouteParams({ id: 'doc-1' }))
|
|
const { status } = await parseJsonResponse(res)
|
|
expect(status).toBe(403)
|
|
})
|
|
|
|
it('rejects a missing journal_entry_id', async () => {
|
|
const res = await POST(makeReq({}), createMockRouteParams({ id: 'doc-1' }))
|
|
const { body } = await parseJsonResponse<{ error: { code: string } }>(res)
|
|
expect(body.error.code).toBe('VALIDATION_ERROR')
|
|
})
|
|
|
|
it('rejects a non-uuid journal_entry_id', async () => {
|
|
const res = await POST(
|
|
makeReq({ journal_entry_id: 'not-a-uuid' }),
|
|
createMockRouteParams({ id: 'doc-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ error: { code: string } }>(res)
|
|
expect(status).toBe(400)
|
|
expect(body.error.code).toBe('VALIDATION_ERROR')
|
|
expect(mockSupabase.from).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('links the document and stamps the inbox item when inbox_item_id is given', async () => {
|
|
enqueue({ data: { id: 'je-1' } }) // journal entry company check
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1', file_name: 'x.pdf' } }) // link update
|
|
enqueue({ data: null }) // inbox stamp update
|
|
|
|
const res = await POST(
|
|
makeReq({ journal_entry_id: JE_ID, inbox_item_id: INBOX_ID }),
|
|
createMockRouteParams({ id: 'doc-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ data: { id: string } }>(res)
|
|
|
|
expect(status).toBe(200)
|
|
expect(body.data.id).toBe('doc-1')
|
|
expect(mockSupabase.from).toHaveBeenCalledWith('document_attachments')
|
|
expect(mockSupabase.from).toHaveBeenCalledWith('invoice_inbox_items')
|
|
})
|
|
|
|
it('does not touch the inbox when no inbox_item_id is given', async () => {
|
|
enqueue({ data: { id: 'je-1' } }) // journal entry company check
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1', file_name: 'x.pdf' } }) // link update
|
|
|
|
const res = await POST(
|
|
makeReq({ journal_entry_id: JE_ID }),
|
|
createMockRouteParams({ id: 'doc-1' }),
|
|
)
|
|
const { status } = await parseJsonResponse(res)
|
|
|
|
expect(status).toBe(200)
|
|
expect(mockSupabase.from).not.toHaveBeenCalledWith('invoice_inbox_items')
|
|
})
|
|
|
|
it('pins the document to the transaction when transaction_id is given', async () => {
|
|
enqueue({ data: { id: 'je-1' } }) // journal entry company check
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1', file_name: 'x.pdf' } }) // link update
|
|
enqueue({ data: null }) // transaction pin update
|
|
|
|
const res = await POST(
|
|
makeReq({ journal_entry_id: JE_ID, transaction_id: TX_ID }),
|
|
createMockRouteParams({ id: 'doc-1' }),
|
|
)
|
|
const { status } = await parseJsonResponse(res)
|
|
|
|
expect(status).toBe(200)
|
|
expect(mockSupabase.from).toHaveBeenCalledWith('transactions')
|
|
})
|
|
|
|
it('does not touch transactions when no transaction_id is given', async () => {
|
|
enqueue({ data: { id: 'je-1' } }) // journal entry company check
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1', file_name: 'x.pdf' } }) // link update
|
|
|
|
const res = await POST(
|
|
makeReq({ journal_entry_id: JE_ID }),
|
|
createMockRouteParams({ id: 'doc-1' }),
|
|
)
|
|
const { status } = await parseJsonResponse(res)
|
|
|
|
expect(status).toBe(200)
|
|
expect(mockSupabase.from).not.toHaveBeenCalledWith('transactions')
|
|
})
|
|
|
|
it('tolerates a failing transaction pin: the JE link is the primary effect', async () => {
|
|
enqueue({ data: { id: 'je-1' } }) // journal entry company check
|
|
enqueue({ data: { id: 'doc-1', journal_entry_id: 'je-1', file_name: 'x.pdf' } }) // link update
|
|
enqueue({ data: null, error: { message: 'rls denied' } }) // transaction pin fails
|
|
|
|
const res = await POST(
|
|
makeReq({ journal_entry_id: JE_ID, transaction_id: TX_ID }),
|
|
createMockRouteParams({ id: 'doc-1' }),
|
|
)
|
|
const { status, body } = await parseJsonResponse<{ data: { id: string } }>(res)
|
|
|
|
// The pin is row-level UX; its failure must not fail the (compliant) link.
|
|
expect(status).toBe(200)
|
|
expect(body.data.id).toBe('doc-1')
|
|
})
|
|
|
|
it('maps a period-lock trigger error to PERIOD_LOCKED', async () => {
|
|
enqueue({ data: { id: 'je-1' } }) // journal entry company check
|
|
enqueue({
|
|
data: null,
|
|
error: { message: 'new row violates ... locked/closed fiscal period' },
|
|
})
|
|
const res = await POST(
|
|
makeReq({ journal_entry_id: JE_ID, inbox_item_id: INBOX_ID }),
|
|
createMockRouteParams({ id: 'doc-1' }),
|
|
)
|
|
const { body } = await parseJsonResponse<{ error: { code: string } }>(res)
|
|
expect(body.error.code).toBe('PERIOD_LOCKED')
|
|
// The inbox stamp must not run when the link itself failed.
|
|
expect(mockSupabase.from).not.toHaveBeenCalledWith('invoice_inbox_items')
|
|
})
|
|
|
|
it('maps an already-linked error to DOC_LINK_ALREADY_LINKED', async () => {
|
|
enqueue({ data: { id: 'je-1' } }) // journal entry company check
|
|
enqueue({
|
|
data: null,
|
|
error: { message: 'document already linked to another entry' },
|
|
})
|
|
const res = await POST(
|
|
makeReq({ journal_entry_id: JE_ID }),
|
|
createMockRouteParams({ id: 'doc-1' }),
|
|
)
|
|
const { body } = await parseJsonResponse<{ error: { code: string } }>(res)
|
|
expect(body.error.code).toBe('DOC_LINK_ALREADY_LINKED')
|
|
})
|
|
|
|
it('rejects a journal entry outside the active company with DOC_LINK_ENTRY_NOT_FOUND', async () => {
|
|
// The company-scoped lookup finds no row: same result whether the id is
|
|
// bogus or belongs to another tenant. The document must never be updated.
|
|
enqueue({ data: null }) // journal entry company check → no match
|
|
const res = await POST(
|
|
makeReq({ journal_entry_id: OTHER_JE_ID }),
|
|
createMockRouteParams({ id: 'doc-1' }),
|
|
)
|
|
const { body } = await parseJsonResponse<{ error: { code: string } }>(res)
|
|
expect(body.error.code).toBe('DOC_LINK_ENTRY_NOT_FOUND')
|
|
expect(mockSupabase.from).not.toHaveBeenCalledWith('document_attachments')
|
|
expect(mockSupabase.from).not.toHaveBeenCalledWith('invoice_inbox_items')
|
|
})
|
|
})
|