* fix(auth): provision invitees server-side when signups are disabled Self-hosted installations with GoTrue disable_signup broke the invite flow silently: invitees without an account were routed to /register, where supabase.auth.signUp fails with "Signups not allowed for this instance", surfaced only as a generic toast. New server-only env flag AUTH_SIGNUPS_DISABLED (documented in .env.example) mirrors the GoTrue setting. When true, POST /api/company/members/invite checks check_email_exists and, for invitees without an account, provisions one via auth.admin.inviteUserByEmail with a redirect back to /invite/<token>, before the Resend email and before the invitation row is written so a provisioning failure leaves nothing half-created and the admin can retry. The response now carries user_provisioned alongside email_sent, and a provisioning failure returns 502 with a Swedish message mapped through getErrorMessage instead of a silently-successful invite. /auth/callback now routes type=invite verifications to /reset-password (the existing set-password surface) instead of dropping the passwordless user on the dashboard, and preserves the invite token from next=/invite/<token> as the pre-auth invite cookie so the existing reset-password invite handoff accepts the membership right after the password is saved. getErrorMessage learns two GoTrue patterns: "Signups not allowed" (account creation closed on this installation, contact your inviter or administrator) so the /register dead end is explained even for flows that bypass provisioning, and "Error sending ... email" (GoTrue SMTP not configured) so the 502 above is actionable. Hosted is untouched: the flag is unset there and every new code path is gated on it. Fixes #1335 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(auth): restore check_email_exists RPC and harden self-host invite config Adversarial review of #1404 found that the check_email_exists function the invite flow depends on does not exist anywhere: it shipped in PR #229 and was lost in the #244 migration consolidation before ever reaching prod (verified missing on the hosted production database directly). Today app/api/team/accept destructures only { data } from the RPC call, so alreadyHasAccount is silently null on every deployment and the invite page routes even existing-account invitees toward /register. - New migration 20260804140000 restores the function exactly as originally shipped: SECURITY DEFINER over auth.users, EXECUTE revoked from PUBLIC, anon and authenticated, granted to service_role only (prevents email enumeration). Fixes hosted prod behavior too once applied. - New tests/pg/check-email-exists.pg.test.ts locks in existence, case-insensitive matching, false-for-unknown, and the role grants. - .env.docker.example gains the AUTH_SIGNUPS_DISABLED block self-hosters actually use; both env templates now note that the GoTrue redirect URI allow-list must include /invite/* or the invite email redirect silently falls back to SITE_URL. - Invite route test for the existsError branch: RPC failure logs a warning and provisioning proceeds anyway (GoTrue is authoritative). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(auth): mask invitee email in provisioning-failure log (#1335) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
255 lines
9.1 KiB
TypeScript
255 lines
9.1 KiB
TypeScript
import { createServiceClient } from '@/lib/supabase/server'
|
|
import { NextResponse } from 'next/server'
|
|
import { z } from 'zod'
|
|
import { ensureInitialized } from '@/lib/init'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { validateBody } from '@/lib/api/validate'
|
|
import { generateInviteToken, getInviteExpiry } from '@/lib/auth/invite-tokens'
|
|
import { getErrorMessage } from '@/lib/errors/get-error-message'
|
|
import { getEmailService } from '@/lib/email/service'
|
|
import {
|
|
generateInviteEmailSubject,
|
|
generateInviteEmailHtml,
|
|
generateInviteEmailText,
|
|
} from '@/lib/email/invite-templates'
|
|
|
|
// Loads the email extension so getEmailService() returns the Resend
|
|
// implementation instead of the noop default. Without this, the invite email
|
|
// is silently skipped in dev whenever this route is hit before any other
|
|
// init'd route in the process.
|
|
ensureInitialized()
|
|
|
|
const InviteSchema = z.object({
|
|
email: z.string().trim().toLowerCase().pipe(z.string().email('Ogiltig e-postadress.')),
|
|
role: z.enum(['admin', 'member', 'viewer']).default('viewer'),
|
|
})
|
|
|
|
/**
|
|
* First local-part character + *** + domain, e.g. "j***@example.com".
|
|
* Keeps invitee PII out of the log record while leaving enough to tell
|
|
* WHICH invite failed. The logger's own redaction would otherwise replace
|
|
* a raw address with [REDACTED_EMAIL] (lib/observability/redact.ts); the
|
|
* masked form does not match that email pattern, so it survives intact.
|
|
*/
|
|
function maskEmail(email: string): string {
|
|
const at = email.indexOf('@')
|
|
if (at <= 0) return '***'
|
|
return `${email[0]}***${email.slice(at)}`
|
|
}
|
|
|
|
/**
|
|
* POST /api/company/members/invite
|
|
* Invite a user to the current company (e.g., a client as viewer).
|
|
* Only company owners and admins can invite.
|
|
*/
|
|
export const POST = withRouteContext(
|
|
'company_members.invite',
|
|
async (request, ctx) => {
|
|
const { companyId, user, log } = ctx
|
|
const serviceClient = await createServiceClient()
|
|
|
|
// Check caller has permission (owner/admin — stricter than requireWrite)
|
|
const { data: callerMembership } = await serviceClient
|
|
.from('company_members')
|
|
.select('role')
|
|
.eq('company_id', companyId)
|
|
.eq('user_id', user.id)
|
|
.single()
|
|
|
|
if (!callerMembership || !['owner', 'admin'].includes(callerMembership.role)) {
|
|
return NextResponse.json({ error: 'Behörighet saknas.' }, { status: 403 })
|
|
}
|
|
|
|
const validation = await validateBody(request, InviteSchema, {
|
|
log,
|
|
operation: 'company_members.invite',
|
|
})
|
|
if (!validation.success) return validation.response
|
|
const { email, role } = validation.data
|
|
|
|
// Check if email is already a member of this company
|
|
const { data: existingMembers } = await serviceClient
|
|
.from('company_members')
|
|
.select('id, user_id')
|
|
.eq('company_id', companyId)
|
|
|
|
if (existingMembers && existingMembers.length > 0) {
|
|
const memberUserIds = existingMembers.map((m) => m.user_id)
|
|
const { data: memberProfiles } = await serviceClient
|
|
.from('profiles')
|
|
.select('id, email')
|
|
.in('id', memberUserIds)
|
|
|
|
const alreadyMember = memberProfiles?.some(
|
|
(p) => p.email?.toLowerCase() === email
|
|
)
|
|
if (alreadyMember) {
|
|
return NextResponse.json({ error: 'Denna person är redan medlem.' }, { status: 409 })
|
|
}
|
|
}
|
|
|
|
// Check for existing pending invite
|
|
const { data: existingInvite } = await serviceClient
|
|
.from('company_invitations')
|
|
.select('id, status')
|
|
.eq('company_id', companyId)
|
|
.eq('email', email)
|
|
.single()
|
|
|
|
if (existingInvite && existingInvite.status === 'pending') {
|
|
return NextResponse.json({ error: 'En inbjudan har redan skickats till denna e-post.' }, { status: 409 })
|
|
}
|
|
|
|
// Get company name for the email
|
|
const { data: company } = await serviceClient
|
|
.from('companies')
|
|
.select('name')
|
|
.eq('id', companyId)
|
|
.single()
|
|
|
|
// Generate token
|
|
const { token, hash } = generateInviteToken()
|
|
const expiresAt = getInviteExpiry()
|
|
|
|
const appUrl = process.env.NEXT_PUBLIC_APP_URL || 'http://localhost:3000'
|
|
|
|
// Self-hosted installations that turn public signup off in GoTrue
|
|
// (disable_signup) set AUTH_SIGNUPS_DISABLED=true to mirror that config:
|
|
// GoTrue offers no clean server-side read of the setting. Without this,
|
|
// an invitee with no account is routed to /register, where
|
|
// supabase.auth.signUp is rejected with "Signups not allowed for this
|
|
// instance" and the invite dead-ends. Provision the account via the auth
|
|
// admin invite API instead. Hosted keeps the flag unset: nothing in this
|
|
// block runs and behavior is unchanged.
|
|
const signupsDisabled = process.env.AUTH_SIGNUPS_DISABLED === 'true'
|
|
let userProvisioned = false
|
|
if (signupsDisabled) {
|
|
const { data: emailExists, error: existsError } = await serviceClient.rpc(
|
|
'check_email_exists',
|
|
{ email_to_check: email },
|
|
)
|
|
if (existsError) {
|
|
// GoTrue is the authority: attempt provisioning anyway and let a
|
|
// duplicate surface there instead of silently skipping the invitee.
|
|
log.warn('check_email_exists failed; attempting provisioning anyway', {
|
|
message: existsError.message,
|
|
})
|
|
}
|
|
|
|
if (!emailExists) {
|
|
// Provision BEFORE the invitation row is written: a failure here
|
|
// leaves nothing half-created behind, so the admin can retry cleanly
|
|
// after fixing the cause (typically GoTrue SMTP configuration).
|
|
// The redirect lands the invitee back on the invite page with a
|
|
// session; /auth/callback routes type=invite verifications to the
|
|
// set-password surface first.
|
|
const { error: provisionError } = await serviceClient.auth.admin.inviteUserByEmail(
|
|
email,
|
|
{ redirectTo: `${appUrl}/invite/${token}` },
|
|
)
|
|
|
|
if (provisionError) {
|
|
const alreadyRegistered =
|
|
provisionError.code === 'email_exists' ||
|
|
/already been registered/i.test(provisionError.message)
|
|
if (!alreadyRegistered) {
|
|
// Never report a silently-successful invite when the invitee
|
|
// cannot actually get an account.
|
|
log.error('invitee auth provisioning failed', new Error(provisionError.message), {
|
|
to: maskEmail(email),
|
|
})
|
|
return NextResponse.json(
|
|
{ error: getErrorMessage(provisionError, { context: 'auth', statusCode: 502 }) },
|
|
{ status: 502 },
|
|
)
|
|
}
|
|
// The account exists after all (stale check_email_exists answer):
|
|
// proceed exactly as for an existing user.
|
|
} else {
|
|
userProvisioned = true
|
|
}
|
|
}
|
|
}
|
|
|
|
// Upsert invitation
|
|
if (existingInvite) {
|
|
const { error } = await serviceClient
|
|
.from('company_invitations')
|
|
.update({
|
|
token_hash: hash,
|
|
invited_by: user.id,
|
|
status: 'pending',
|
|
expires_at: expiresAt.toISOString(),
|
|
role,
|
|
})
|
|
.eq('id', existingInvite.id)
|
|
|
|
if (error) {
|
|
return NextResponse.json({ error: 'Kunde inte skapa inbjudan.' }, { status: 500 })
|
|
}
|
|
} else {
|
|
const { error } = await serviceClient
|
|
.from('company_invitations')
|
|
.insert({
|
|
company_id: companyId,
|
|
email,
|
|
role,
|
|
token_hash: hash,
|
|
invited_by: user.id,
|
|
status: 'pending',
|
|
expires_at: expiresAt.toISOString(),
|
|
})
|
|
|
|
if (error) {
|
|
return NextResponse.json({ error: 'Kunde inte skapa inbjudan.' }, { status: 500 })
|
|
}
|
|
}
|
|
|
|
// Send email. email_sent is surfaced in the response so the UI can tell
|
|
// the user when the invitation exists but the mail never went out:
|
|
// previously a send failure was invisible (invite looked sent).
|
|
const emailService = getEmailService()
|
|
let emailSent = false
|
|
if (emailService.isConfigured()) {
|
|
const inviteUrl = `${appUrl}/invite/${token}`
|
|
|
|
const emailData = {
|
|
companyName: company?.name || 'Företag',
|
|
inviterEmail: user.email || '',
|
|
inviteUrl,
|
|
}
|
|
|
|
const result = await emailService.sendEmail({
|
|
to: email,
|
|
subject: generateInviteEmailSubject(emailData),
|
|
html: generateInviteEmailHtml(emailData),
|
|
text: generateInviteEmailText(emailData),
|
|
})
|
|
|
|
if (result.success) {
|
|
emailSent = true
|
|
log.info('invite email sent', { to: email, messageId: result.messageId })
|
|
} else {
|
|
log.error('invite email send failed', new Error(result.error ?? 'unknown'), { to: email })
|
|
}
|
|
} else {
|
|
log.warn('email service not configured: invite email skipped', { to: email })
|
|
}
|
|
|
|
// In development, return the invite URL directly (no email service)
|
|
const isDev = process.env.NODE_ENV === 'development'
|
|
const devInviteUrl = isDev ? `${appUrl}/invite/${token}` : undefined
|
|
|
|
return NextResponse.json({
|
|
data: {
|
|
email,
|
|
status: 'pending',
|
|
email_sent: emailSent,
|
|
user_provisioned: userProvisioned,
|
|
...(isDev && { inviteUrl: devInviteUrl }),
|
|
},
|
|
})
|
|
},
|
|
{ requireWrite: true },
|
|
)
|