Files

T

Jakob WennbergandClaude Sonnet 5 ec27228a8e style: remove em/en dashes repo-wide, add CLAUDE.md rule against them (#890 )

Em dashes (—) and en dashes (–) had spread across comments, docs, tests,
and a few UI strings, reading as AI-generated boilerplate rather than
house style. Replaced each with punctuation matching its context: colon
for explanatory clauses, comma for asides, plain hyphen for numeric/legal
ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for
paired-dash asides. messages/en.json and messages/sv.json were fixed by
hand together to keep sv/en in sync.

Left untouched where the dash is the functional subject rather than
decorative punctuation: date-range-parser.ts's separator regex,
charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE
encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the
agent system-prompt files that already instruct against em dashes, and
a golden iXBRL test fixture compared byte-for-byte.

Also fixes two bugs surfaced along the way: an off-by-one in
ApiKeysPanel's scope-label split (a leftover from an earlier partial
pass), and a charset-repair test that had lost the literal en-dash it
exists to verify.

Regenerated the agent atom seed migration (skills:generate) since 27
SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes,
with an explicit carve-out for the functional-dash cases above.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

2026-07-04 15:58:06 +02:00

3.3 KiB

Raw Blame History

paths

app/**

components/**

messages/**

lib/email/**

lib/invoices/**

lib/reports/**

lib/salary/**

i18n

The app is Swedish-first and bilingual (Swedish + English) for UI chrome. Locale is per-user on user_preferences.locale ('sv' | 'en', default 'sv'), resolved server-side via next-intl. The user picker lives at /settings/account.

Pattern for new UI:

// Server component
import { getTranslations } from 'next-intl/server'
const t = await getTranslations('namespace')

// Client component
'use client'
import { useTranslations } from 'next-intl'
const t = useTranslations('namespace')

// In JSX
<button>{t('save')}</button>

Add new strings to both messages/sv.json and messages/en.json under the matching namespace (common, nav, auth, settings, empty, etc.). Never ship an English key without a Swedish counterpart: Swedish is the default and the fallback.

Locale-aware formatters:

formatCurrency(amount): stays SEK with sv-SE conventions in BOTH locales (Swedish accounting standard, not a UI string).
formatDate(date): ISO yyyy-MM-dd, locale-independent.
formatDateLong(date, locale): accepts locale. In client components use useFormat() (lib/hooks/use-format.ts) which pulls the active locale.

Error messages: getErrorMessage(err, { locale, context }) from lib/errors/get-error-message.ts is bilingual on the primary maps (Postgres codes, HTTP statuses, context fallbacks, generic fallback). The structured error envelope ({ error: { code, message, message_en } }) already carries both; the function picks the right one from locale. Pass useLocale() / getLocale() as the locale arg.

Stays Swedish: do NOT translate:

Surface	Reason
Invoice PDFs (`lib/invoices/pdf-template.tsx`)	Customer-facing: driven by `customer.language` (`sv` default, `en` opt-in). The template's chrome translates; statutory chapter refs (ML 17 kap 24§, ML 3 kap.) stay intact in both locales.
Customer email templates (`lib/email/invoice-templates.ts`, `reminder-templates.ts`)	Same: `customer.language` drives the output. `reminder-templates.ts` is still Swedish-only; mirror the PDF/invoice-templates approach if you add English here.
Year-end wizard (`app/(dashboard)/bookkeeping/year-end/page.tsx`)	Statutory bokslut terminology; English would be misleading
Journal entry editor (`app/(dashboard)/bookkeeping/[id]/page.tsx`)	Deeply regulatory (verifikat, voucher numbers, BAS)
INK2 / NE-bilaga / SRU (`lib/reports/ink2/`, `lib/reports/ne-bilaga/`, `lib/reports/sru-*`)	Skatteverket forms: field codes and labels are statutory
SIE export (`lib/reports/sie-export.ts`)	SIE format is Swedish-only by spec (#KONTO, #VER, etc.)
BAS chart names (`lib/bookkeeping/bas-data/**`)	Standardized Swedish account names per BAS 2026
VAT declaration ruta labels (`lib/reports/vat-declaration*.ts`)	Momsdeklaration field labels are Skatteverket form labels
Salary AGI / KU (`lib/salary/agi`, `lib/salary/ku`)	Skatteverket-bound forms
Bookkeeping engine domain errors ("Verifikationen balanserar inte", "Bokföringen är låst")	Regulatory concepts; English equivalents would be ambiguous

Anything in the table above stays Swedish in BOTH locales. If you find yourself reaching for t() inside one of these files, stop and reconsider.

3.3 KiB Raw Blame History

i18n

3.3 KiB

Raw Blame History