Files
accounted/lib/skatteverket/__tests__/skattekonto-link.test.ts
T
34ad1b1936 feat(reconciliation): manual N:1 matching: two-pane worksheet + group links (#1851)
'Matcha manuellt' as designed: outside rows on the left (multi-select),
verifikat without an outside row on the right (single-select), the
selection's arithmetic in the footer, and one Koppla that is enabled only
when the difference is 0. Mode lives in the URL (?mode=match).

Engine: a pair is now one OR MANY outside rows against one verifikat.
Bank groups link per transaction (manualLink allows N:1 by design, so
partial success is reported per row). Skattekonto groups go through the
new linkSkattekontoRows: the verifikat's 1630 side must settle the sum,
one guarded UPDATE links the whole group, and a partial hit is rolled
back as LINK_RACE. 1:M stays UNSUPPORTED_PAIR_SHAPE until the residual
link table (6c). v1 pitfalls + API skill regenerated.

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-24 16:24:07 +02:00

205 lines
11 KiB
TypeScript

import { describe, it, expect, beforeEach, vi } from 'vitest'
import { createQueuedMockSupabase } from '@/tests/helpers'
import {
entrySettlesAmount,
linkSkattekontoRow,
linkSkattekontoRows,
setSkattekontoRowIgnored,
SkattekontoLinkError,
unlinkSkattekontoRow,
} from '../skattekonto-link'
const COMPANY = 'company-1'
const ROW = 'row-1'
const ENTRY = 'entry-1'
function row(overrides: Record<string, unknown> = {}) {
return { id: ROW, belopp_skatteverket: 5000, journal_entry_id: null, is_ignored: false, status: 'booked', ...overrides }
}
function entry(lines: Array<{ account_number: string; debit_amount: number; credit_amount: number }>, status = 'posted') {
return { id: ENTRY, status, lines }
}
describe('entrySettlesAmount', () => {
it('matches a single line on the expected side', () => {
expect(entrySettlesAmount([{ account_number: '1630', debit_amount: 5000, credit_amount: 0 }], 5000)).toEqual({ ok: true, via: 'line' })
expect(entrySettlesAmount([{ account_number: '1630', debit_amount: 0, credit_amount: 5447 }], -5447)).toEqual({ ok: true, via: 'line' })
})
it('falls back to the entry net over several 1630 lines', () => {
expect(
entrySettlesAmount(
[
{ account_number: '1630', debit_amount: 3000, credit_amount: 0 },
{ account_number: '1630', debit_amount: 2000, credit_amount: 0 },
{ account_number: '1930', debit_amount: 0, credit_amount: 5000 },
],
5000,
),
).toEqual({ ok: true, via: 'entry_total' })
})
it('rejects the wrong side, a different amount, and entries without 1630 lines', () => {
expect(entrySettlesAmount([{ account_number: '1630', debit_amount: 0, credit_amount: 5000 }], 5000).ok).toBe(false)
expect(entrySettlesAmount([{ account_number: '1630', debit_amount: 4999, credit_amount: 0 }], 5000).ok).toBe(false)
expect(entrySettlesAmount([{ account_number: '1930', debit_amount: 5000, credit_amount: 0 }], 5000).ok).toBe(false)
})
})
describe('linkSkattekontoRow', () => {
beforeEach(() => vi.clearAllMocks())
it('links an open row to a posted entry with a matching 1630 line and clears the proposal', async () => {
const { supabase, enqueue, findCalls } = createQueuedMockSupabase()
enqueue({ data: row() })
enqueue({ data: entry([{ account_number: '1630', debit_amount: 5000, credit_amount: 0 }]) })
enqueue({ data: null }) // already-linked check
enqueue({ data: [{ id: ROW }] }) // update … select
const result = await linkSkattekontoRow(supabase as never, COMPANY, ROW, ENTRY)
expect(result).toEqual({ skattekonto_transaction_id: ROW, journal_entry_id: ENTRY, via: 'line' })
expect(findCalls('skattekonto_transactions', 'update')[0][0]).toEqual({
journal_entry_id: ENTRY,
suggested_journal_entry_id: null,
suggested_at: null,
})
expect(findCalls('skattekonto_transactions', 'is')).toContainEqual(['journal_entry_id', null])
})
it.each([
['TRANSACTION_NOT_FOUND', null, undefined],
['ALREADY_BOOKED', row({ journal_entry_id: 'other' }), undefined],
['ROW_IGNORED', row({ is_ignored: true }), undefined],
['INVALID_CANDIDATE', row({ status: 'upcoming' }), undefined],
['ENTRY_NOT_FOUND', row(), null],
['INVALID_CANDIDATE', row(), entry([{ account_number: '1630', debit_amount: 5000, credit_amount: 0 }], 'reversed')],
['INVALID_CANDIDATE', row(), entry([{ account_number: '1630', debit_amount: 4000, credit_amount: 0 }])],
])('refuses with %s', async (code, rowData, entryData) => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: rowData })
if (entryData !== undefined) enqueue({ data: entryData })
await expect(linkSkattekontoRow(supabase as never, COMPANY, ROW, ENTRY)).rejects.toMatchObject({ code })
})
it('refuses an entry already linked by another row', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: row() })
enqueue({ data: entry([{ account_number: '1630', debit_amount: 5000, credit_amount: 0 }]) })
enqueue({ data: { id: 'row-9' } })
await expect(linkSkattekontoRow(supabase as never, COMPANY, ROW, ENTRY)).rejects.toMatchObject({ code: 'ENTRY_ALREADY_LINKED' })
})
it('reports a lost race when the guarded update touches no row', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: row() })
enqueue({ data: entry([{ account_number: '1630', debit_amount: 5000, credit_amount: 0 }]) })
enqueue({ data: null })
enqueue({ data: [] })
await expect(linkSkattekontoRow(supabase as never, COMPANY, ROW, ENTRY)).rejects.toMatchObject({ code: 'LINK_RACE' })
})
})
describe('unlinkSkattekontoRow / setSkattekontoRowIgnored', () => {
it('clears the pointer and reports the previous entry', async () => {
const { supabase, enqueue, findCalls } = createQueuedMockSupabase()
enqueue({ data: { id: ROW, journal_entry_id: ENTRY } })
enqueue({ data: null })
const result = await unlinkSkattekontoRow(supabase as never, COMPANY, ROW)
expect(result).toEqual({ skattekonto_transaction_id: ROW, previous_journal_entry_id: ENTRY })
expect(findCalls('skattekonto_transactions', 'update')[0][0]).toEqual({ journal_entry_id: null })
})
it('refuses to unlink an unlinked row', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { id: ROW, journal_entry_id: null } })
await expect(unlinkSkattekontoRow(supabase as never, COMPANY, ROW)).rejects.toBeInstanceOf(SkattekontoLinkError)
})
it('refuses to ignore a linked row and is a no-op when already in the requested state', async () => {
const { supabase, enqueue, findCalls } = createQueuedMockSupabase()
enqueue({ data: { id: ROW, journal_entry_id: ENTRY, is_ignored: false } })
await expect(setSkattekontoRowIgnored(supabase as never, COMPANY, ROW, true)).rejects.toMatchObject({ code: 'ALREADY_BOOKED' })
enqueue({ data: { id: ROW, journal_entry_id: null, is_ignored: true } })
expect(await setSkattekontoRowIgnored(supabase as never, COMPANY, ROW, true)).toEqual({ skattekonto_transaction_id: ROW, is_ignored: true })
expect(findCalls('skattekonto_transactions', 'update')).toHaveLength(0)
})
it('ignoring clears the proposal too', async () => {
const { supabase, enqueue, findCalls } = createQueuedMockSupabase()
enqueue({ data: { id: ROW, journal_entry_id: null, is_ignored: false } })
enqueue({ data: null })
await setSkattekontoRowIgnored(supabase as never, COMPANY, ROW, true)
expect(findCalls('skattekonto_transactions', 'update')[0][0]).toEqual({
is_ignored: true,
suggested_journal_entry_id: null,
suggested_at: null,
})
})
})
describe('linkSkattekontoRows (N:1)', () => {
const ROW2 = 'row-2'
const { supabase, enqueue, reset, findCalls } = createQueuedMockSupabase()
beforeEach(() => {
vi.clearAllMocks()
reset()
})
it('links a group whose sum the verifikat settles, with one guarded update over all rows', async () => {
enqueue({ data: [row({ belopp_skatteverket: 3000 }), row({ id: ROW2, belopp_skatteverket: 2000 })] })
enqueue({ data: entry([{ account_number: '1630', debit_amount: 5000, credit_amount: 0 }]) })
enqueue({ data: [] }) // nothing outside the group linked to the entry
enqueue({ data: [{ id: ROW }, { id: ROW2 }] })
const result = await linkSkattekontoRows(supabase as never, COMPANY, [ROW, ROW2, ROW], ENTRY)
expect(result).toEqual({ journal_entry_id: ENTRY, via: 'line', skattekonto_transaction_ids: [ROW, ROW2] })
const updates = findCalls('skattekonto_transactions', 'update')
expect(updates).toHaveLength(1)
expect(updates[0][0]).toMatchObject({ journal_entry_id: ENTRY, suggested_journal_entry_id: null })
})
it('refuses a group where a row is already linked, ignored or upcoming', async () => {
enqueue({ data: [row(), row({ id: ROW2, journal_entry_id: 'other' })] })
await expect(linkSkattekontoRows(supabase as never, COMPANY, [ROW, ROW2], ENTRY)).rejects.toMatchObject({ code: 'ALREADY_BOOKED' })
reset()
enqueue({ data: [row(), row({ id: ROW2, is_ignored: true })] })
await expect(linkSkattekontoRows(supabase as never, COMPANY, [ROW, ROW2], ENTRY)).rejects.toMatchObject({ code: 'ROW_IGNORED' })
reset()
enqueue({ data: [row(), row({ id: ROW2, status: 'upcoming' })] })
await expect(linkSkattekontoRows(supabase as never, COMPANY, [ROW, ROW2], ENTRY)).rejects.toMatchObject({ code: 'INVALID_CANDIDATE' })
})
it('refuses when the sum does not settle the verifikat or nets to zero', async () => {
enqueue({ data: [row({ belopp_skatteverket: 3000 }), row({ id: ROW2, belopp_skatteverket: 2000 })] })
enqueue({ data: entry([{ account_number: '1630', debit_amount: 4999, credit_amount: 0 }]) })
await expect(linkSkattekontoRows(supabase as never, COMPANY, [ROW, ROW2], ENTRY)).rejects.toMatchObject({ code: 'INVALID_CANDIDATE' })
reset()
enqueue({ data: [row({ belopp_skatteverket: 3000 }), row({ id: ROW2, belopp_skatteverket: -3000 })] })
await expect(linkSkattekontoRows(supabase as never, COMPANY, [ROW, ROW2], ENTRY)).rejects.toMatchObject({ code: 'INVALID_CANDIDATE' })
})
it('refuses a verifikat already linked to a row outside the group', async () => {
enqueue({ data: [row({ belopp_skatteverket: 3000 }), row({ id: ROW2, belopp_skatteverket: 2000 })] })
enqueue({ data: entry([{ account_number: '1630', debit_amount: 5000, credit_amount: 0 }]) })
enqueue({ data: [{ id: 'row-elsewhere' }] })
await expect(linkSkattekontoRows(supabase as never, COMPANY, [ROW, ROW2], ENTRY)).rejects.toMatchObject({ code: 'ENTRY_ALREADY_LINKED' })
})
it('rolls a partial hit back and reports LINK_RACE', async () => {
enqueue({ data: [row({ belopp_skatteverket: 3000 }), row({ id: ROW2, belopp_skatteverket: 2000 })] })
enqueue({ data: entry([{ account_number: '1630', debit_amount: 5000, credit_amount: 0 }]) })
enqueue({ data: [] })
enqueue({ data: [{ id: ROW }] }) // only one of two rows was still free
enqueue({ data: null }) // the revert
await expect(linkSkattekontoRows(supabase as never, COMPANY, [ROW, ROW2], ENTRY)).rejects.toMatchObject({ code: 'LINK_RACE' })
const updates = findCalls('skattekonto_transactions', 'update')
expect(updates).toHaveLength(2)
expect(updates[1][0]).toEqual({ journal_entry_id: null })
})
it('refuses a missing row and an empty selection', async () => {
enqueue({ data: [row()] })
await expect(linkSkattekontoRows(supabase as never, COMPANY, [ROW, ROW2], ENTRY)).rejects.toMatchObject({ code: 'TRANSACTION_NOT_FOUND' })
await expect(linkSkattekontoRows(supabase as never, COMPANY, [], ENTRY)).rejects.toBeInstanceOf(SkattekontoLinkError)
})
})