6c64dd2312
* fix(whatsapp): make every silent disposition observable, stop pure silence for linked senders (#1552) Silence was a legitimate outcome in seven places and none left a trace a support question could be answered from. Now: - Unknown-sender declines (over quota, quota RPC failure, greeting throttle) persist content-free trace rows: wamid, phone hash, type, disposition. No body, media, raw payload, or profile name; capped at 20 rows per hash and day; deleted by the existing 30-day retention. The wamid dedupe also stops redelivered bad-code/greeting messages from earning a second reply. - Linked-sender deliberate silences (muted, stale tap, ignorable type) record their reason on the skipped row. - Non-policy silences reply: a row missing its media reference sends M18 through the link's reply address, a link revoked between arrival and processing sends the M1 unlinked copy (greeting-throttled). - Outbound rows keep WHY a send failed (Graph error detail), and Meta 'failed' delivery statuses store their error code and title. - The WhatsApp settings panel shows the last inbound event (closed enum, server-derived) and warns when the latest reply never left. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(whatsapp): include errorDetail in typed sendText mock results SendTextResult gained errorDetail; vi.mocked call sites must match the widened type or they raise fresh tsc errors over the repo baseline. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(whatsapp): review fixes: fail-closed greeting throttle, cap only declined traces From CodeRabbit's pass on #1563: - greetingThrottled fails closed when the throttle window cannot be read, matching the unknown-sender quota's stance. - The decline-trace day cap applies only to 'skipped' rows (the one unbounded path); 'done' traces always insert so the wamid dedupe keeps preventing duplicate M1/M2 replies even past the cap. Their volume is already bounded upstream by the greeting throttle and the pre-binding quota. - company-question test mocks match the widened SendTextResult. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
40 lines
1.8 KiB
TypeScript
40 lines
1.8 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { summarizeInboundEvent } from '@/extensions/general/whatsapp-inbox/lib/last-event'
|
|
import {
|
|
COMPANY_CHOICE_EXPIRED,
|
|
STAGED_AWAITING_COMPANY,
|
|
} from '@/extensions/general/whatsapp-inbox/lib/conversation'
|
|
|
|
function row(
|
|
processing_status: string,
|
|
error_message: string | null = null,
|
|
inbox_item_id: string | null = null,
|
|
) {
|
|
return { processing_status, error_message, inbox_item_id }
|
|
}
|
|
|
|
describe('summarizeInboundEvent', () => {
|
|
it('maps terminal statuses to the closed panel enum', () => {
|
|
expect(summarizeInboundEvent(row('done', null, 'item-1'))).toBe('filed')
|
|
expect(summarizeInboundEvent(row('done'))).toBe('handled')
|
|
expect(summarizeInboundEvent(row('received'))).toBe('processing')
|
|
expect(summarizeInboundEvent(row('processing'))).toBe('processing')
|
|
expect(summarizeInboundEvent(row('error', 'Media exceeds the size limit'))).toBe('failed')
|
|
})
|
|
|
|
it('splits skipped rows by their recorded reason', () => {
|
|
expect(summarizeInboundEvent(row('skipped', STAGED_AWAITING_COMPANY))).toBe('awaiting_company')
|
|
expect(summarizeInboundEvent(row('skipped', COMPANY_CHOICE_EXPIRED))).toBe('failed')
|
|
expect(summarizeInboundEvent(row('skipped', 'Duplicate document (sha256)'))).toBe('duplicate')
|
|
expect(summarizeInboundEvent(row('skipped', 'Rate limited'))).toBe('rate_limited')
|
|
expect(summarizeInboundEvent(row('skipped', 'Unsupported media type: video/mp4'))).toBe(
|
|
'unsupported',
|
|
)
|
|
expect(summarizeInboundEvent(row('skipped', 'Muted by stopp: message not read'))).toBe('muted')
|
|
expect(
|
|
summarizeInboundEvent(row('skipped', 'Stale interactive tap after the question closed')),
|
|
).toBe('declined')
|
|
expect(summarizeInboundEvent(row('skipped', null))).toBe('declined')
|
|
})
|
|
})
|