Files
accounted/extensions/general/skatteverket/__tests__/vat-submit.test.ts
T
18c20e68e6 fix(scoping): Skatteverket per företag + nåbara startkort + företags-scopade val (#1610)
* fix(scoping): skatteverket per company + true pristine gates + scoped dismissals

Skatteverket connections become per (user, company): the token table
carried BOTH UNIQUE(user_id) and UNIQUE(company_id) (two stacked half
migrations), so one connection leaked "connected" onto every company the
user belongs to, sync ran the token against the wrong orgnr (behorighet
403), and reconnecting from another company silently moved the row and
went dark on the first company's crons. Token reads/writes are now scoped
by company through the whole chain (token-store, api-client refresh
coalescing, skvRequest and its 21 call sites, resolve-auth, crons, MCP),
/skattekonto/saldo answers 401 NOT_CONNECTED for companies without their
own row (which is what the page's startkort keys on), and the dashboard
connect-nudge counts only the active company's row.

Bookkeeping's pristine start card now keys on all-years emptiness via a
count probe instead of "no active filters": the default fiscal-year
selection counted as a filter, which made the card unreachable on
brand-new companies (it showed "inga traffar" instead).

Two browser-global localStorage keys become company-scoped with legacy
fallbacks: the inbox onboarding dismissal (dismissing on one company hid
the card everywhere) and the periodisering auto-detect toggle.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(scoping): dedupe cron work per (user, company) + guard the ledger probe

CodeRabbit findings on #1610: the skattekonto sync cron still deduped
token rows by user_id alone, which would drop every company but one for
multi-company operators (the exact scenario the PR fixes); and the
all-years ledger probe could leave a stale false behind on a failed
refetch, letting the pristine card render unconfirmed. The probe now
resets to unknown in flight and carries the fetch generation guard.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-14 08:21:57 +02:00

167 lines
5.9 KiB
TypeScript

/**
* Tests for the shared VAT submit chain (kontrollera -> utkast -> lås).
* Covers the stage discriminator semantics that the one-click route and the
* pending-operations commit service both rely on: validation errors abort
* before any SKV write, draft failures are retry-safe, lock failures report
* that the draft survived in Eget utrymme.
*/
import { describe, it, expect, vi, beforeEach } from 'vitest'
const mockSkvRequest = vi.fn()
vi.mock('../lib/api-client', async (importOriginal) => {
const actual = (await importOriginal()) as Record<string, unknown>
return { ...actual, skvRequest: (...a: unknown[]) => mockSkvRequest(...a) }
})
const mockBuildMomsuppgift = vi.fn()
vi.mock('../lib/declaration-prep', async (importOriginal) => {
const actual = (await importOriginal()) as Record<string, unknown>
return { ...actual, buildMomsuppgift: (...a: unknown[]) => mockBuildMomsuppgift(...a) }
})
vi.mock('../lib/audit', () => ({ writeSkatteverketAudit: vi.fn() }))
import { submitVatDeclarationChain } from '../lib/vat-submit'
import type { ExtensionContext } from '@/lib/extensions/types'
const PARAMS = { periodType: 'monthly' as const, year: 2026, period: 6 }
function makeCtx() {
return {
supabase: {},
userId: 'user-1',
companyId: 'company-1',
settings: { set: vi.fn().mockResolvedValue(undefined) },
log: { info: vi.fn(), warn: vi.fn(), error: vi.fn() },
} as unknown as ExtensionContext
}
beforeEach(() => {
vi.clearAllMocks()
mockBuildMomsuppgift.mockResolvedValue({
redovisare: '165560000000',
redovisningsperiod: '202606',
momsuppgift: { summaMoms: 150 },
})
})
describe('submitVatDeclarationChain', () => {
it('validation ERRORs abort before any write at SKV', async () => {
mockSkvRequest.mockResolvedValueOnce({
ok: true,
status: 200,
json: async () => ({
kontrollResultat: {
status: 'ERROR',
resultat: [{ kod: '49', status: 'ERROR', beskrivning: 'Summan stämmer inte' }],
},
}),
})
const ctx = makeCtx()
const result = await submitVatDeclarationChain(ctx, PARAMS, { validate: true })
expect(result).toMatchObject({
ok: false,
stage: 'validation',
httpStatus: 422,
draftSaved: false,
})
// Only the kontrollera call: no utkast, no lås, no persisted state.
expect(mockSkvRequest).toHaveBeenCalledTimes(1)
expect(mockSkvRequest.mock.calls[0][4]).toBe('/kontrollera/165560000000/202606')
expect((ctx.settings.set as ReturnType<typeof vi.fn>)).not.toHaveBeenCalled()
})
it('validation warnings do not block: full chain runs to signing link', async () => {
mockSkvRequest
.mockResolvedValueOnce({
ok: true, status: 200,
json: async () => ({
kontrollResultat: {
status: 'WARNING',
resultat: [{ kod: '10', status: 'WARNING', beskrivning: 'Ovanligt belopp' }],
},
}),
}) // kontrollera
.mockResolvedValueOnce({
ok: true, status: 200,
json: async () => ({ kontrollResultat: { status: 'OK' } }),
}) // utkast
.mockResolvedValueOnce({
ok: true, status: 200,
json: async () => ({ signeringsLank: 'https://skv.test/sign/abc' }),
}) // lås
const ctx = makeCtx()
const result = await submitVatDeclarationChain(ctx, PARAMS, { validate: true })
expect(result).toMatchObject({ ok: true, signingUrl: 'https://skv.test/sign/abc' })
expect(mockSkvRequest).toHaveBeenCalledTimes(3)
// Locked state persisted with the picker params for the kvittens cron.
const setMock = ctx.settings.set as ReturnType<typeof vi.fn>
const lastState = JSON.parse(setMock.mock.calls.at(-1)![1] as string)
expect(lastState).toMatchObject({
status: 'draft_locked',
periodType: 'monthly',
year: 2026,
period: 6,
signeringsLank: 'https://skv.test/sign/abc',
})
})
it('skips kontrollera when validate is not requested', async () => {
mockSkvRequest
.mockResolvedValueOnce({ ok: true, status: 200, json: async () => ({}) }) // utkast
.mockResolvedValueOnce({
ok: true, status: 200,
json: async () => ({ signeringsLank: 'https://skv.test/sign/xyz' }),
}) // lås
const result = await submitVatDeclarationChain(makeCtx(), PARAMS)
expect(result).toMatchObject({ ok: true, signingUrl: 'https://skv.test/sign/xyz' })
expect(mockSkvRequest).toHaveBeenCalledTimes(2)
expect(mockSkvRequest.mock.calls[0][4]).toBe('/utkast/165560000000/202606')
})
it('utkast failure -> stage draft, nothing saved, retry-safe', async () => {
mockSkvRequest.mockResolvedValueOnce({
ok: false, status: 400, text: async () => 'bad rutor',
})
const ctx = makeCtx()
const result = await submitVatDeclarationChain(ctx, PARAMS)
expect(result).toMatchObject({
ok: false, stage: 'draft', httpStatus: 400, draftSaved: false,
})
expect(mockSkvRequest).toHaveBeenCalledTimes(1) // never reached /las
expect((ctx.settings.set as ReturnType<typeof vi.fn>)).not.toHaveBeenCalled()
})
it('lås failure -> stage lock with draftSaved: true', async () => {
mockSkvRequest
.mockResolvedValueOnce({ ok: true, status: 200, json: async () => ({}) }) // utkast
.mockResolvedValueOnce({ ok: false, status: 409, text: async () => 'redan låst' }) // lås
const result = await submitVatDeclarationChain(makeCtx(), PARAMS)
expect(result).toMatchObject({
ok: false, stage: 'lock', httpStatus: 409, draftSaved: true,
})
})
it('lås without signeringsLank -> stage lock 502 with draftSaved: true', async () => {
mockSkvRequest
.mockResolvedValueOnce({ ok: true, status: 200, json: async () => ({}) }) // utkast
.mockResolvedValueOnce({ ok: true, status: 200, json: async () => ({}) }) // lås, no link
const result = await submitVatDeclarationChain(makeCtx(), PARAMS)
expect(result).toMatchObject({
ok: false, stage: 'lock', httpStatus: 502, draftSaved: true,
})
})
})