Files
accounted/extensions/general/invoice-inbox/__tests__/sandbox-skip-extraction.test.ts
T
c7a75d069d feat(ai): job-shaped AI service with OpenAI-compatible backend, extraction-first; stop extracting every inbox document twice (#1740)
* feat(ai): job-shaped AI service with OpenAI-compatible backend, extraction-first; stop extracting every inbox document twice

Sovereign plan WS1 PR1 (#1406 Tier 2, extraction-first, aligned with the
AI surface audit).

lib/ai grows a job-shaped service (generateText / generateStructured /
extractFromDocument; no streaming members yet, see plan rule R3):
- services/anthropic-family delegates to the existing createAiClient()
  and sends the exact request literals the inbox extractor sent before
  (request-shape tests deep-equal them), so hosted Bedrock stays
  byte-identical.
- services/openai-compatible talks to any chat-completions endpoint
  (BYO Swedish provider) via Vercel AI SDK 6.x, exact-pinned and
  guarded: images as parts, PDFs rasterized with poppler (AI_PDF_MODE)
  or sent natively, AI_VISION / AI_STRICT_JSON declared, honest skips
  (ai_no_vision, pdf_rasterizer_missing) instead of fake failures.
- config.ts: AI_PROVIDER/AI_BASE_URL/AI_API_KEY/AI_MODEL and per-tier
  AI_*_MODEL with the legacy BEDROCK_* names kept as the same overrides;
  getAiStatus() is the single source of truth for "is AI wired up".
- provider.ts: openai-compatible in the auto-detect chain (after Bedrock
  and the direct API); createAiClient() refuses it loudly.

Document extraction moves onto the service and gets the audit's fixes:
- Inbox documents were extracted TWICE (pipeline A ran inside
  uploadDocument() before the inbox row existed, so its dedupe branch
  never fired; 3 707 + 1 666 calls / 30 d). The inbox now declares
  extractionOwner on the upload, the extension yields, and the inbox
  mirrors its single outcome onto document_attachments from every
  writer (sync, deferred, attach, retry, MCP).
- Every "no extraction will ever happen" outcome is stamped
  (skipped:no_ai_entitlement / ai_unconfigured / system_generated /
  ...); the status route maps the quiet ones to 'disabled' on the first
  poll instead of a 30 s client timeout. Prod showed 309 of the 327
  never-extracted uploads were the paywall working silently.
- Self-generated documents (our own invoice PDFs, payout files) are no
  longer OCR'd.
- Agent invoke answers 503 ai_unconfigured when the deployment has no
  assistant backend, distinct from the paywall.

Guard: new direct-ai-client antipattern check (shrink-only allowlist of
the pre-abstraction SDK callers) plus exact pins for @anthropic-ai/sdk,
ai and @ai-sdk/openai-compatible.

Verified: 15 958 unit tests green, guards, lint ratchet, typecheck, and a
live smoke against hosted Bedrock through the new service (ping, streamed
tool turn, thinking+cache, PDF extraction).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(ai): make AI_API_KEY optional for OpenAI-compatible endpoints (keyless local model servers)

A local model server (llama.cpp's server, Ollama /v1, LM Studio, vLLM)
usually has no auth. Before, the OpenAI-compatible backend required both
AI_BASE_URL and AI_API_KEY to count as configured, so running Accounted on a
local model meant setting a meaningless placeholder key.

- resolveAiProvider / hasAiCredentials: a base URL alone is now enough.
- services/openai-compatible: only send Authorization: Bearer when AI_API_KEY
  is set, so a keyless server is never handed an empty bearer; a hosted
  provider that needs a key still sets it.
- Docs (SELF-HOSTING Option 3: local-model example, key marked optional),
  DECISIONS.

Verified: with no AI_API_KEY, just AI_BASE_URL + AI_MODEL, getAiStatus()
reports configured=true / provider=openai-compatible (live). lib/ai suite
71 green; tsc, guards, lint clean. Bedrock/Anthropic logic unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-20 19:39:08 +02:00

377 lines
15 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest'
import { PDFDocument } from 'pdf-lib'
import { invoiceInboxExtension } from '@/extensions/general/invoice-inbox'
import {
createQueuedMockSupabase,
createMockRequest,
parseJsonResponse,
} from '@/tests/helpers'
import type { ExtensionContext } from '@/lib/extensions/types'
// Mock the Bedrock call. The whole point of this file is to assert it is
// never invoked on sandbox companies.
vi.mock('@/extensions/general/invoice-inbox/lib/extract-invoice-fields', async () => {
const actual = await vi.importActual<
typeof import('@/extensions/general/invoice-inbox/lib/extract-invoice-fields')
>('@/extensions/general/invoice-inbox/lib/extract-invoice-fields')
return {
...actual,
extractInvoiceFields: vi.fn(),
}
})
vi.mock('@/lib/core/documents/document-service', () => ({
uploadDocument: vi.fn().mockResolvedValue({ id: 'doc-1' }),
}))
// The staged (deferred) upload path only exists when AI is configured on this
// deployment: an unconfigured one skips synchronously (ai_unconfigured). These
// tests simulate a configured deployment; the model call itself is mocked.
vi.mock('@/lib/ai', () => ({
getAiStatus: () => ({
provider: 'bedrock',
configured: true,
reason: 'ok',
capabilities: { pdfNative: true, imageInput: true, toolUse: true, forcedToolChoice: true, strictJsonSchema: false },
models: { assistant: 'm', heavy: 'm', extraction: 'm' },
pdfMode: 'native',
assistantAvailable: true,
}),
}))
vi.mock('@/lib/rate-limits/inbox', () => ({
checkInboxUploadRateLimit: vi.fn().mockResolvedValue({ ok: true }),
}))
vi.mock('@/lib/processing-history/append', () => ({
appendProcessingHistory: vi.fn().mockResolvedValue(undefined),
}))
// Paid AI OCR gate: hasCapability('ai') decides whether Bedrock runs. Default
// to entitled (true) so the sandbox/page-count reasons are exercised; the
// no-AI tests below override to false. capabilityBlockedResponse stays real so
// the retry 403 envelope is genuine.
vi.mock('@/lib/entitlements/has-capability', async (importOriginal) => {
const actual = await importOriginal<typeof import('@/lib/entitlements/has-capability')>()
return { ...actual, hasCapability: vi.fn().mockResolvedValue(true) }
})
// The deferred extraction worker (staged upload) builds its own cookieless
// service client; route it to the same mock supabase so the flow is
// observable in the one test that reaches Bedrock.
vi.mock('@/lib/auth/api-keys', async (importOriginal) => {
const actual = await importOriginal<typeof import('@/lib/auth/api-keys')>()
return { ...actual, createServiceClientNoCookies: vi.fn() }
})
import { extractInvoiceFields } from '@/extensions/general/invoice-inbox/lib/extract-invoice-fields'
import { hasCapability } from '@/lib/entitlements/has-capability'
import { createServiceClientNoCookies } from '@/lib/auth/api-keys'
function findRoute(method: string, path: string) {
return invoiceInboxExtension.apiRoutes!.find(
(r) => r.method === method && r.path === path,
)!
}
const uploadRoute = findRoute('POST', '/upload')
const attachRoute = findRoute('POST', '/items/:id/attach-document')
const retryRoute = findRoute('POST', '/items/:id/retry-extraction')
function buildCtx(supabase: unknown): ExtensionContext {
return {
userId: 'user-1',
companyId: 'company-1',
extensionId: 'invoice-inbox',
supabase: supabase as ExtensionContext['supabase'],
emit: vi.fn(),
settings: { get: vi.fn(), set: vi.fn() },
storage: { from: vi.fn() } as unknown as ExtensionContext['storage'],
log: { info: vi.fn(), warn: vi.fn(), error: vi.fn(), debug: vi.fn() } as unknown as ExtensionContext['log'],
services: {},
} as ExtensionContext
}
async function makePdfBuffer(pageCount: number): Promise<Uint8Array> {
const pdf = await PDFDocument.create()
for (let i = 0; i < pageCount; i++) pdf.addPage([612, 792])
return pdf.save()
}
function makeMultipartRequest(form: FormData, path: string): Request {
return new Request(`http://localhost:3000${path}`, {
method: 'POST',
body: form,
})
}
// Supabase mock routed by table name. The /upload handler hits
// company_settings (sandbox check), invoice_inbox_items (insert), and
// suppliers (match) in that order via separate .from() chains.
function makeUploadSupabase(opts: {
isSandbox: boolean
captured: { row?: Record<string, unknown>; flip?: Record<string, unknown> }
}) {
const settingsChain = {
select: vi.fn().mockReturnThis(),
eq: vi.fn().mockReturnThis(),
maybeSingle: vi.fn().mockResolvedValue({ data: { is_sandbox: opts.isSandbox }, error: null }),
}
const supplierChain = {
select: vi.fn().mockReturnThis(),
eq: vi.fn().mockReturnThis(),
ilike: vi.fn().mockReturnThis(),
limit: vi.fn().mockReturnThis(),
maybeSingle: vi.fn().mockResolvedValue({ data: null }),
}
// The deferred worker's CAS flip: .update(p).eq().eq().select('id').
const updateChain = {
eq: vi.fn(() => updateChain),
select: vi.fn().mockResolvedValue({ data: [{ id: 'inbox-1' }], error: null }),
}
const inboxChain = {
insert: vi.fn((row: Record<string, unknown>) => {
opts.captured.row = row
return {
select: vi.fn().mockReturnValue({
single: vi.fn().mockResolvedValue({
data: { id: 'inbox-1', status: 'received', matched_supplier_id: null, ...row },
error: null,
}),
}),
}
}),
update: vi.fn((payload: Record<string, unknown>) => {
opts.captured.flip = payload
return updateChain
}),
}
return {
from: vi.fn((table: string) => {
if (table === 'company_settings') return settingsChain
if (table === 'invoice_inbox_items') return inboxChain
return supplierChain
}),
}
}
beforeEach(() => {
vi.clearAllMocks()
vi.mocked(hasCapability).mockResolvedValue(true)
})
describe('Sandbox companies skip Bedrock extraction', () => {
describe('POST /upload', () => {
it('skips extraction and reports skip_reason=sandbox', async () => {
const captured: { row?: Record<string, unknown> } = {}
const supabase = makeUploadSupabase({ isSandbox: true, captured })
const bytes = await makePdfBuffer(1)
const file = new File([bytes as BlobPart], 'receipt.pdf', { type: 'application/pdf' })
const form = new FormData()
form.set('file', file)
const res = await uploadRoute.handler(makeMultipartRequest(form, '/upload'), buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ data: Record<string, unknown> }>(res)
expect(status).toBe(200)
expect(extractInvoiceFields).not.toHaveBeenCalled()
expect(body.data.extraction_skipped).toBe(true)
expect(body.data.skip_reason).toBe('sandbox')
expect(captured.row?.extraction_skipped).toBe(true)
})
it('defers extraction for non-sandbox companies: responds processing, then flips', async () => {
const captured: { row?: Record<string, unknown>; flip?: Record<string, unknown> } = {}
const supabase = makeUploadSupabase({ isSandbox: false, captured })
vi.mocked(createServiceClientNoCookies).mockReturnValue(supabase as never)
vi.mocked(extractInvoiceFields).mockResolvedValueOnce({
data: {
supplier: { name: null, orgNumber: null, vatNumber: null, address: null, bankgiro: null, plusgiro: null },
invoice: { invoiceNumber: null, invoiceDate: null, dueDate: null, paymentReference: null, currency: 'SEK' },
lineItems: [],
totals: { subtotal: null, vatAmount: null, total: null },
vatBreakdown: [],
confidence: 0,
},
rawText: 'ok',
})
const bytes = await makePdfBuffer(1)
const file = new File([bytes as BlobPart], 'receipt.pdf', { type: 'application/pdf' })
const form = new FormData()
form.set('file', file)
const res = await uploadRoute.handler(makeMultipartRequest(form, '/upload'), buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ data: Record<string, unknown> }>(res)
// Staged upload: the response is the receipt ack, extraction runs after.
expect(status).toBe(200)
expect(body.data.status).toBe('processing')
expect(body.data.extracted_data).toBeNull()
expect(body.data.extraction_skipped).toBe(false)
expect(body.data.skip_reason).toBeNull()
expect(captured.row?.status).toBe('processing')
expect(captured.row?.extracted_data).toBeNull()
await vi.waitFor(() => expect(extractInvoiceFields).toHaveBeenCalledOnce())
await vi.waitFor(() => expect(captured.flip).toBeDefined())
expect(captured.flip?.status).toBe('received')
expect(captured.flip?.extraction_skipped).toBe(false)
})
})
describe('POST /items/:id/attach-document', () => {
it('skips extraction when company is a sandbox', async () => {
// Lookup order: item exists → upload doc → sandbox check → update row.
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({
data: {
id: 'item-1',
document_id: null,
status: 'received',
correlation_id: null,
created_supplier_invoice_id: null,
},
error: null,
})
// sandbox check inside the try block
enqueue({ data: { is_sandbox: true }, error: null })
// update row
enqueue({ data: null, error: null })
// uploadDocument is mocked at the module level; no need to enqueue.
const bytes = await makePdfBuffer(1)
const file = new File([bytes as BlobPart], 'attach.pdf', { type: 'application/pdf' })
const form = new FormData()
form.set('file', file)
const req = new Request('http://localhost:3000/items/item-1/attach-document?_id=item-1', {
method: 'POST',
body: form,
})
const res = await attachRoute.handler(req, buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ data: Record<string, unknown> }>(res)
expect(status).toBe(200)
expect(extractInvoiceFields).not.toHaveBeenCalled()
expect(body.data.extraction_skipped).toBe(true)
expect(body.data.skip_reason).toBe('sandbox')
})
})
describe('POST /items/:id/retry-extraction', () => {
it('returns 409 with a Swedish message when the company is a sandbox', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
// item lookup
enqueue({
data: { id: 'item-1', document_id: 'doc-1', correlation_id: null, created_supplier_invoice_id: null },
error: null,
})
// sandbox check → true
enqueue({ data: { is_sandbox: true }, error: null })
const req = createMockRequest('/items/item-1/retry-extraction', {
method: 'POST',
searchParams: { _id: 'item-1' },
})
const res = await retryRoute.handler(req, buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ error: string }>(res)
expect(status).toBe(409)
expect(body.error).toMatch(/sandlådan/i)
expect(extractInvoiceFields).not.toHaveBeenCalled()
})
})
})
// The paid-tier paywall: a free/manual-tier company (no `ai` capability) must
// never trigger Bedrock OCR. Upload + attach degrade gracefully (document is
// stored, extraction skipped with reason 'no_ai_entitlement'); retry is an
// explicit "run AI" action and hard-blocks with 403 capability_blocked.
describe('Free tier (no ai capability) does not run Bedrock extraction', () => {
it('POST /upload: skips extraction with skip_reason=no_ai_entitlement (highest priority)', async () => {
vi.mocked(hasCapability).mockResolvedValueOnce(false)
const captured: { row?: Record<string, unknown> } = {}
// Not a sandbox: proves the ai gate wins over a passing sandbox check.
const supabase = makeUploadSupabase({ isSandbox: false, captured })
const bytes = await makePdfBuffer(1)
const file = new File([bytes as BlobPart], 'receipt.pdf', { type: 'application/pdf' })
const form = new FormData()
form.set('file', file)
const res = await uploadRoute.handler(makeMultipartRequest(form, '/upload'), buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ data: Record<string, unknown> }>(res)
expect(status).toBe(200)
expect(extractInvoiceFields).not.toHaveBeenCalled()
expect(body.data.extraction_skipped).toBe(true)
expect(body.data.skip_reason).toBe('no_ai_entitlement')
expect(captured.row?.extraction_skipped).toBe(true)
})
it('POST /items/:id/attach-document: skips extraction when the company lacks ai', async () => {
vi.mocked(hasCapability).mockResolvedValueOnce(false)
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({
data: {
id: 'item-1',
document_id: null,
status: 'received',
correlation_id: null,
created_supplier_invoice_id: null,
},
error: null,
})
// sandbox check → false (so the ai gate, not sandbox, is what skips)
enqueue({ data: { is_sandbox: false }, error: null })
// update row
enqueue({ data: null, error: null })
const bytes = await makePdfBuffer(1)
const file = new File([bytes as BlobPart], 'attach.pdf', { type: 'application/pdf' })
const form = new FormData()
form.set('file', file)
const req = new Request('http://localhost:3000/items/item-1/attach-document?_id=item-1', {
method: 'POST',
body: form,
})
const res = await attachRoute.handler(req, buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ data: Record<string, unknown> }>(res)
expect(status).toBe(200)
expect(extractInvoiceFields).not.toHaveBeenCalled()
expect(body.data.extraction_skipped).toBe(true)
expect(body.data.skip_reason).toBe('no_ai_entitlement')
})
it('POST /items/:id/retry-extraction: hard-blocks with 403 capability_blocked', async () => {
vi.mocked(hasCapability).mockResolvedValueOnce(false)
const { supabase, enqueue } = createQueuedMockSupabase()
// item lookup: the ai gate fires immediately after, before the sandbox check
enqueue({
data: { id: 'item-1', document_id: 'doc-1', correlation_id: null, created_supplier_invoice_id: null },
error: null,
})
const req = createMockRequest('/items/item-1/retry-extraction', {
method: 'POST',
searchParams: { _id: 'item-1' },
})
const res = await retryRoute.handler(req, buildCtx(supabase))
const { status, body } = await parseJsonResponse<{ capability_blocked: boolean; capability: string }>(res)
expect(status).toBe(403)
expect(body.capability_blocked).toBe(true)
expect(body.capability).toBe('ai')
expect(extractInvoiceFields).not.toHaveBeenCalled()
})
})