Files
accounted/components/bookkeeping/BookingTemplatePicker.tsx
T
MattssonandClaude Fable 5 57d4359d1a feat(booking-templates): per-company opt-in hiding of system templates (#2004)
* feat(booking-templates): per-company opt-in hiding of system templates

Users cannot delete or hide the 26 standard konteringspaket, which clutter
the settings panel and every template picker. Deletion stays off the table
(shared global rows); instead a company can now hide individual system
templates for itself only.

- New booking_template_hidden table (insert=hide, delete=unhide), RLS gated
  on active company + write role; nothing hidden by default
- POST/DELETE /api/settings/booking-templates/[id]/hide (system templates
  only; company/team templates keep their real delete path)
- List route decorates rows with per-company is_hidden; pickers filter them
  out; the settings panel shows hidden ones in a collapsed restore section
  so hiding is never silent
- Classified in full-archive-export exclusions (UI preference, not
  rakenskapsinformation)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PU1KN431c9gp5zKvFaa1NL

* fix(booking-templates): idempotent re-hide, system-only RLS insert, hidden filter in bulk-book

Skeptic + CodeRabbit findings on #2004, one pass:

- hide upsert now passes ignoreDuplicates (DO NOTHING): the table has no
  UPDATE policy on purpose, so the DO UPDATE conflict arm turned a
  concurrent re-hide into an RLS 42501/500; pg test pins the conflict shape
- bth_insert policy additionally requires the referenced template to be an
  active system template (migration is unmerged, edited in place); negative
  pg test for company templates
- BulkBookDialog excludes templates hidden by the company (was reading the
  table directly and ignoring hides)
- panel shows the failure toast when the hide/unhide fetch itself rejects
- picker category chips built from the hidden-filtered list

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PU1KN431c9gp5zKvFaa1NL

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-28 12:12:47 +02:00

252 lines
9.8 KiB
TypeScript

'use client'
import { useState, useEffect, useMemo } from 'react'
import { useBookingTemplates } from '@/lib/reference-data/hooks'
import { Button } from '@/components/ui/button'
import { Input } from '@/components/ui/input'
import { useToast } from '@/components/ui/use-toast'
import {
Dialog,
DialogContent,
DialogHeader,
DialogTitle,
DialogTrigger,
} from '@/components/ui/dialog'
import { BookOpen, Search, Building2, Users, Globe } from 'lucide-react'
import { TEMPLATE_CATEGORY_LABELS, SCOPE_LABELS, getTemplateScope, applyTemplate } from '@/lib/bookkeeping/template-library'
import type { BookingTemplateCategory, EntityType } from '@/types'
import type { FormLine } from '@/components/bookkeeping/JournalEntryForm'
interface Props {
onApply: (lines: FormLine[], description: string, category?: BookingTemplateCategory) => void
entityType?: EntityType
/** Prefill the "total amount" field when the caller already knows it (e.g.
* booking from an underlag with a known total). The user can still edit it. */
defaultAmount?: number
}
const SCOPE_ICONS = {
system: Globe,
team: Users,
company: Building2,
} as const
export default function BookingTemplatePicker({ onApply, entityType, defaultAmount }: Props) {
const { toast } = useToast()
const [open, setOpen] = useState(false)
// Session-cached (lib/reference-data): the list is there on the first
// open and reopening costs no request; writes in the settings panel
// invalidate it.
const { templates, isLoading, error: templatesError } = useBookingTemplates()
const [search, setSearch] = useState('')
const [selectedCategory, setSelectedCategory] = useState<BookingTemplateCategory | 'all'>('all')
const [amount, setAmount] = useState('')
const [selectedId, setSelectedId] = useState<string | null>(null)
// Prefill the amount from the caller's known total each time the picker
// opens. Only when provided: callers without a known amount (e.g. the
// journal-entry form) keep the blank-then-type behaviour.
useEffect(() => {
if (open && defaultAmount != null && defaultAmount > 0) {
setAmount(String(Math.round(defaultAmount * 100) / 100))
}
}, [open, defaultAmount])
useEffect(() => {
if (open && templatesError) toast({ title: 'Kunde inte hämta mallar', variant: 'destructive' })
}, [open, templatesError, toast])
const filtered = useMemo(() => {
// Templates hidden for this company (opt-in via the settings panel)
// never surface in the picker; only settings shows them, for restore.
let result = templates.filter((t) => !t.is_hidden)
// Filter by entity type
if (entityType) {
result = result.filter((t) => t.entity_type === 'all' || t.entity_type === entityType)
}
// Filter by category
if (selectedCategory !== 'all') {
result = result.filter((t) => t.category === selectedCategory)
}
// Filter by search
if (search) {
const lower = search.toLowerCase()
result = result.filter(
(t) =>
t.name.toLowerCase().includes(lower) ||
t.description.toLowerCase().includes(lower),
)
}
return result
}, [templates, entityType, selectedCategory, search])
// Unique categories present in visible templates. Built from the
// hidden-filtered list so a category whose templates are all hidden does
// not render a chip that can only ever match nothing.
const availableCategories = useMemo(() => {
const cats = new Set(templates.filter((t) => !t.is_hidden).map((t) => t.category))
return Array.from(cats).sort()
}, [templates])
const selected = selectedId ? templates.find((t) => t.id === selectedId) : null
function handleApply() {
if (!selected) return
const totalAmount = parseFloat(amount)
if (!totalAmount || totalAmount <= 0) {
toast({ title: 'Ange belopp', description: 'Ange ett belopp för att använda mallen.', variant: 'destructive' })
return
}
const lines = applyTemplate(selected.lines, totalAmount)
// Fire-and-forget MRU bump so this template surfaces at the top next time.
fetch(`/api/settings/booking-templates/${selected.id}/touch`, { method: 'POST' }).catch(() => {})
onApply(lines, selected.name, selected.category)
setOpen(false)
setSelectedId(null)
setAmount('')
setSearch('')
}
return (
<Dialog open={open} onOpenChange={setOpen}>
<DialogTrigger asChild>
<Button variant="outline" size="sm" type="button">
<BookOpen className="h-3.5 w-3.5 mr-1.5" />
Använd mall
</Button>
</DialogTrigger>
<DialogContent className="max-w-2xl max-h-[80vh] flex flex-col">
<DialogHeader>
<DialogTitle>Bokföringsmallar</DialogTitle>
</DialogHeader>
{/* Search + category filter */}
<div className="flex flex-col gap-3">
<div className="relative">
<Search className="absolute left-3 top-1/2 -translate-y-1/2 h-4 w-4 text-muted-foreground" />
<Input
value={search}
onChange={(e) => setSearch(e.target.value)}
placeholder="Sök mall..."
className="pl-9"
autoFocus
/>
</div>
<div className="flex gap-1 flex-wrap">
<Button
variant={selectedCategory === 'all' ? 'default' : 'outline'}
size="sm"
onClick={() => setSelectedCategory('all')}
type="button"
>
Alla
</Button>
{availableCategories.map((cat) => (
<Button
key={cat}
variant={selectedCategory === cat ? 'default' : 'outline'}
size="sm"
onClick={() => setSelectedCategory(cat as BookingTemplateCategory)}
type="button"
>
{TEMPLATE_CATEGORY_LABELS[cat as BookingTemplateCategory]}
</Button>
))}
</div>
</div>
{/* Template list */}
<div className="flex-1 overflow-y-auto space-y-1 min-h-0">
{isLoading ? (
<p className="text-sm text-muted-foreground py-8 text-center">Laddar mallar...</p>
) : filtered.length === 0 ? (
<p className="text-sm text-muted-foreground py-8 text-center">Inga mallar hittades.</p>
) : (
filtered.map((t) => {
const scope = getTemplateScope(t)
const ScopeIcon = SCOPE_ICONS[scope]
const isSelected = selectedId === t.id
return (
<button
key={t.id}
type="button"
onClick={() => setSelectedId(isSelected ? null : t.id)}
className={`w-full text-left rounded-lg border p-3 transition-colors ${
isSelected
? 'border-primary bg-primary/5'
: 'border-border hover:border-primary/40 hover:bg-muted/50'
}`}
>
<div className="flex items-start justify-between gap-2">
<div className="flex-1 min-w-0">
<div className="font-medium text-sm">{t.name}</div>
<div className="flex items-center gap-1 text-[11px] text-muted-foreground mt-0.5">
<ScopeIcon className="h-3 w-3 shrink-0" />
<span>
{SCOPE_LABELS[scope]}
{t.entity_type !== 'all' &&
` · ${t.entity_type === 'enskild_firma' ? 'EF' : 'AB'}`}
</span>
</div>
{t.description && (
<p className="text-xs text-muted-foreground mt-0.5 line-clamp-2">
{t.description}
</p>
)}
</div>
</div>
{/* Show lines preview when selected */}
{isSelected && (
<div className="mt-2 pt-2 border-t space-y-1">
{t.lines.map((line, i) => (
<div key={i} className="flex items-center gap-2 text-xs font-mono text-muted-foreground">
<span className="w-10">{line.account}</span>
<span className="flex-1 truncate">{line.label}</span>
<span className={line.side === 'debit' ? 'text-foreground' : ''}>
{line.side === 'debit' ? (line.type === 'vat' && line.vat_rate ? `${(line.vat_rate * 100).toFixed(0)}% moms` : 'D') : ''}
</span>
<span className={line.side === 'credit' ? 'text-foreground' : ''}>
{line.side === 'credit' ? (line.type === 'vat' && line.vat_rate ? `${(line.vat_rate * 100).toFixed(0)}% moms` : 'K') : ''}
</span>
</div>
))}
</div>
)}
</button>
)
})
)}
</div>
{/* Apply section */}
{selected && (
<div className="flex items-end gap-3 pt-3 border-t">
<div className="flex-1">
<label className="text-xs font-medium text-muted-foreground mb-1 block">
Totalt belopp (inkl. moms)
</label>
<Input
type="number"
value={amount}
onChange={(e) => setAmount(e.target.value)}
placeholder="0,00"
min="0"
step="0.01"
inputMode="decimal"
autoFocus
/>
</div>
<Button onClick={handleApply} type="button">
Använd mall
</Button>
</div>
)}
</DialogContent>
</Dialog>
)
}