MattssonandClaude Fable 5
08440fed94
* feat(reconciliation): match migrated bank history against imported SIE verifikat A first-class Fortnox/SIE migrator path: after SIE import plus bank connect or bank CSV upload, historical bank rows are auto-matched (>= 0.9) or suggestion-matched (0.75-0.89, persisted for review) against the imported verifikat, with a guided review surface, instead of landing as anonymous "Att bokfora" rows. Phase 0: per-cash-account unattended sweep (fixes #1298 cross-account pooling); widen payment_match_log action CHECK with linked_to_existing_voucher (silently unlogged since March). Phase 1: potential_journal_entry_id/method/confidence on transactions with CHECK + invalidation triggers; persistSuggestions in runReconciliation; sweep after bank CSV import with SIE overlap (suppressing auto-categorization); sweep summaries stamped on bank_connections and bank_file_imports; POST /api/reconciliation/bank/confirm-suggestions with per-pair server-side revalidation (voucher consumption + bank-leg amount and direction). Phase 2: "Granska forslag" review tab on Transactions with chunked bulk confirm, per-row fallbacks, "Kor matchning igen" (all_accounts sweep mode, mutually exclusive with dry_run), attn line, pre-migration row marker. Phase 3: ImportResultStep dual CTA (bank connect + CSV), migrator variant of the account-picker #917 nudge, sweep outcome on the onboarding checklist bank step. Non-selection apply runs on /api/reconciliation/bank/run now floor at 0.9 and persist the review band instead of auto-committing fuzzy matches. Migrations already applied to staging under the same versions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): resolve PR review findings in one pass Swedish accounting review (both previously-deferred holes closed): - runReconciliation's >= 0.9 auto-apply now writes 'matched' to payment_match_log (behandlingshistorik, BFNAR 2013:2 kap 8); the bus event alone lands in the 30-day event_log and is not an audit record. - The three match-route storno-conflict branches detach reconciliation links via unlinkReconciliation instead of storno-reversing the linked verifikat: a reconciliation link points at an independent verifikat that may evidence other affarshandelser, and a wholesale reversal is an over-broad rattelse (BFL 5 kap 5 §). - Historical gap quantified on prod (read-only, recorded in DECISIONS): 762 unlogged manual links across 52 companies since 2026-03-23. CodeRabbit: - confirm-suggestions route: maxDuration 300 for full 500-item batches. - AccountPickerDialog: migrator-nudge buttons set lookbackTouched so the async gap-fill probe cannot override an explicit choice. - enable-banking post-backfill sweep: persistSuggestions so the review band is not dropped. - bank-file execute: sie_sweep stamp errors are logged, not swallowed. - ImportResultStep: sandbox keeps the CSV CTA (file import works there). - payment_match_log CHECK swap: NOT VALID + VALIDATE, no table scan under ACCESS EXCLUSIVE. - logMatchEvent calls awaited (serverless can freeze unawaited work). - DECISIONS.md stale version reference annotated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): defer reconciliation-link detach until the match commits Round-2 review findings: - CodeRabbit: the eager unlinkReconciliation call could orphan a transaction if the match flow failed after it. All three match routes now persist NOTHING up front: the final transaction update overwrites journal_entry_id and clears reconciliation_method in the same write, so any failure in between leaves the existing link intact. The release is logged as 'unmatched' after the commit. - Swedish review: the auto_suggested logMatchEvent in runReconciliation is now awaited like every other audit write. - DECISIONS entry split into compliance/CodeRabbit lines and updated to describe the deferred detach. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): literal reconciliation_method payloads for the phantom-column scanner The conditional spreads introduced with the deferred detach pushed the scanner's unresolvable-expression count past its ceiling (380 > 378). reconciliation_method: null is correct unconditionally on a confirmed invoice/supplier match (null is already the value on every row that was not reconciliation-linked), so the payloads become plain literals the guard can verify. No behavior change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
54 lines
2.0 KiB
TypeScript
54 lines
2.0 KiB
TypeScript
import { NextResponse } from 'next/server'
|
|
import { ensureInitialized } from '@/lib/init'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { validateBody } from '@/lib/api/validate'
|
|
import { ConfirmJeSuggestionsSchema } from '@/lib/api/schemas'
|
|
import {
|
|
confirmJournalEntrySuggestions,
|
|
rejectJournalEntrySuggestions,
|
|
} from '@/lib/reconciliation/suggestions'
|
|
|
|
ensureInitialized()
|
|
|
|
// A full 500-item batch runs sequentially with several queries per pair
|
|
// (revalidation is the point), which can exceed the platform's default
|
|
// function budget. Same 5-minute allowance as the bank-file and SIE imports.
|
|
export const maxDuration = 300
|
|
|
|
/**
|
|
* POST /api/reconciliation/bank/confirm-suggestions
|
|
*
|
|
* Bulk confirm (or reject) journal-entry match suggestions written by the
|
|
* SIE reconciliation sweep. Confirming links each transaction to its suggested
|
|
* verifikat via the ordinary manual-link path with full server-side
|
|
* revalidation per pair; pairs that went stale between suggestion and click
|
|
* (entry reversed, verifikat consumed by another row, row booked elsewhere)
|
|
* are skipped and reported rather than failing the batch.
|
|
*/
|
|
export const POST = withRouteContext(
|
|
'reconciliation.bank.confirm_suggestions',
|
|
async (request, { supabase, user, companyId }) => {
|
|
const validation = await validateBody(request, ConfirmJeSuggestionsSchema)
|
|
if (!validation.success) return validation.response
|
|
const { transaction_ids, action } = validation.data
|
|
|
|
const result =
|
|
action === 'confirm'
|
|
? await confirmJournalEntrySuggestions(supabase, companyId, user.id, transaction_ids)
|
|
: await rejectJournalEntrySuggestions(supabase, companyId, user.id, transaction_ids)
|
|
|
|
return NextResponse.json({
|
|
data: {
|
|
confirmed: result.confirmed,
|
|
rejected: result.rejected,
|
|
skipped: result.skipped.map((s) => ({
|
|
transaction_id: s.transactionId,
|
|
reason: s.reason,
|
|
message: s.message,
|
|
})),
|
|
},
|
|
})
|
|
},
|
|
{ requireWrite: true },
|
|
)
|