Files
accounted/app/api/reconciliation/bank/confirm-suggestions/__tests__/route.test.ts
T
MattssonandClaude Fable 5 08440fed94 feat(reconciliation): match migrated bank history against imported SIE verifikat (#1598)
* feat(reconciliation): match migrated bank history against imported SIE verifikat

A first-class Fortnox/SIE migrator path: after SIE import plus bank connect
or bank CSV upload, historical bank rows are auto-matched (>= 0.9) or
suggestion-matched (0.75-0.89, persisted for review) against the imported
verifikat, with a guided review surface, instead of landing as anonymous
"Att bokfora" rows.

Phase 0: per-cash-account unattended sweep (fixes #1298 cross-account
pooling); widen payment_match_log action CHECK with
linked_to_existing_voucher (silently unlogged since March).
Phase 1: potential_journal_entry_id/method/confidence on transactions with
CHECK + invalidation triggers; persistSuggestions in runReconciliation;
sweep after bank CSV import with SIE overlap (suppressing
auto-categorization); sweep summaries stamped on bank_connections and
bank_file_imports; POST /api/reconciliation/bank/confirm-suggestions with
per-pair server-side revalidation (voucher consumption + bank-leg amount
and direction).
Phase 2: "Granska forslag" review tab on Transactions with chunked bulk
confirm, per-row fallbacks, "Kor matchning igen" (all_accounts sweep mode,
mutually exclusive with dry_run), attn line, pre-migration row marker.
Phase 3: ImportResultStep dual CTA (bank connect + CSV), migrator variant
of the account-picker #917 nudge, sweep outcome on the onboarding
checklist bank step.

Non-selection apply runs on /api/reconciliation/bank/run now floor at 0.9
and persist the review band instead of auto-committing fuzzy matches.
Migrations already applied to staging under the same versions.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(reconciliation): resolve PR review findings in one pass

Swedish accounting review (both previously-deferred holes closed):
- runReconciliation's >= 0.9 auto-apply now writes 'matched' to
  payment_match_log (behandlingshistorik, BFNAR 2013:2 kap 8); the bus
  event alone lands in the 30-day event_log and is not an audit record.
- The three match-route storno-conflict branches detach reconciliation
  links via unlinkReconciliation instead of storno-reversing the linked
  verifikat: a reconciliation link points at an independent verifikat
  that may evidence other affarshandelser, and a wholesale reversal is
  an over-broad rattelse (BFL 5 kap 5 §).
- Historical gap quantified on prod (read-only, recorded in DECISIONS):
  762 unlogged manual links across 52 companies since 2026-03-23.

CodeRabbit:
- confirm-suggestions route: maxDuration 300 for full 500-item batches.
- AccountPickerDialog: migrator-nudge buttons set lookbackTouched so the
  async gap-fill probe cannot override an explicit choice.
- enable-banking post-backfill sweep: persistSuggestions so the review
  band is not dropped.
- bank-file execute: sie_sweep stamp errors are logged, not swallowed.
- ImportResultStep: sandbox keeps the CSV CTA (file import works there).
- payment_match_log CHECK swap: NOT VALID + VALIDATE, no table scan
  under ACCESS EXCLUSIVE.
- logMatchEvent calls awaited (serverless can freeze unawaited work).
- DECISIONS.md stale version reference annotated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(reconciliation): defer reconciliation-link detach until the match commits

Round-2 review findings:
- CodeRabbit: the eager unlinkReconciliation call could orphan a
  transaction if the match flow failed after it. All three match routes
  now persist NOTHING up front: the final transaction update overwrites
  journal_entry_id and clears reconciliation_method in the same write,
  so any failure in between leaves the existing link intact. The release
  is logged as 'unmatched' after the commit.
- Swedish review: the auto_suggested logMatchEvent in runReconciliation
  is now awaited like every other audit write.
- DECISIONS entry split into compliance/CodeRabbit lines and updated to
  describe the deferred detach.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(reconciliation): literal reconciliation_method payloads for the phantom-column scanner

The conditional spreads introduced with the deferred detach pushed the
scanner's unresolvable-expression count past its ceiling (380 > 378).
reconciliation_method: null is correct unconditionally on a confirmed
invoice/supplier match (null is already the value on every row that was
not reconciliation-linked), so the payloads become plain literals the
guard can verify. No behavior change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-13 23:12:27 +02:00

152 lines
5.3 KiB
TypeScript

/**
* Tests for POST /api/reconciliation/bank/confirm-suggestions.
*
* Exercises the route through the real withRouteContext wrapper, mocking only
* its auth/company/write dependencies plus the suggestions service. Covers:
* 401, 403 viewer, validation (400), and both actions' happy paths.
*/
import { describe, it, expect, vi, beforeEach } from 'vitest'
import { NextResponse } from 'next/server'
import { createQueuedMockSupabase, createMockRequest, parseJsonResponse } from '@/tests/helpers'
const { supabase, reset } = createQueuedMockSupabase()
const requireAuthMock = vi.fn()
vi.mock('@/lib/auth/require-auth', () => ({
requireAuth: (...args: unknown[]) => requireAuthMock(...args),
}))
vi.mock('@/lib/company/context', () => ({
getActiveCompanyId: vi.fn().mockResolvedValue('company-1'),
requireCompanyId: vi.fn().mockResolvedValue('company-1'),
}))
const requireWriteMock = vi.fn()
vi.mock('@/lib/auth/require-write', () => ({
requireWritePermission: (...args: unknown[]) => requireWriteMock(...args),
}))
vi.mock('@/lib/init', () => ({ ensureInitialized: vi.fn() }))
const confirmMock = vi.fn()
const rejectMock = vi.fn()
vi.mock('@/lib/reconciliation/suggestions', () => ({
confirmJournalEntrySuggestions: (...args: unknown[]) => confirmMock(...args),
rejectJournalEntrySuggestions: (...args: unknown[]) => rejectMock(...args),
}))
import { POST } from '../route'
const emptyParams = { params: Promise.resolve({}) }
const TX_1 = '11111111-1111-4111-8111-111111111111'
const TX_2 = '22222222-2222-4222-8222-222222222222'
describe('POST /api/reconciliation/bank/confirm-suggestions', () => {
beforeEach(() => {
vi.clearAllMocks()
reset()
requireAuthMock.mockResolvedValue({ user: { id: 'user-1' }, supabase })
requireWriteMock.mockResolvedValue({ ok: true })
confirmMock.mockResolvedValue({ confirmed: [TX_1], rejected: [], skipped: [] })
rejectMock.mockResolvedValue({ confirmed: [], rejected: [TX_1], skipped: [] })
})
it('returns 401 when unauthenticated', async () => {
requireAuthMock.mockResolvedValue({
user: null,
supabase,
error: NextResponse.json({ error: 'Unauthorized' }, { status: 401 }),
})
const request = createMockRequest('/api/reconciliation/bank/confirm-suggestions', {
method: 'POST',
body: { transaction_ids: [TX_1], action: 'confirm' },
})
const response = await POST(request, emptyParams)
expect(response.status).toBe(401)
expect(confirmMock).not.toHaveBeenCalled()
})
it('returns 403 for a viewer', async () => {
requireWriteMock.mockResolvedValue({
ok: false,
response: NextResponse.json({ error: 'Forbidden' }, { status: 403 }),
})
const request = createMockRequest('/api/reconciliation/bank/confirm-suggestions', {
method: 'POST',
body: { transaction_ids: [TX_1], action: 'confirm' },
})
const response = await POST(request, emptyParams)
expect(response.status).toBe(403)
expect(confirmMock).not.toHaveBeenCalled()
})
it('rejects an empty transaction_ids array with 400', async () => {
const request = createMockRequest('/api/reconciliation/bank/confirm-suggestions', {
method: 'POST',
body: { transaction_ids: [], action: 'confirm' },
})
const response = await POST(request, emptyParams)
expect(response.status).toBe(400)
expect(confirmMock).not.toHaveBeenCalled()
})
it('rejects an unknown action with 400', async () => {
const request = createMockRequest('/api/reconciliation/bank/confirm-suggestions', {
method: 'POST',
body: { transaction_ids: [TX_1], action: 'maybe' },
})
const response = await POST(request, emptyParams)
expect(response.status).toBe(400)
})
it('confirms suggestions and reports skipped pairs in snake_case', async () => {
confirmMock.mockResolvedValue({
confirmed: [TX_1],
rejected: [],
skipped: [{ transactionId: TX_2, reason: 'voucher_consumed' }],
})
const request = createMockRequest('/api/reconciliation/bank/confirm-suggestions', {
method: 'POST',
body: { transaction_ids: [TX_1, TX_2], action: 'confirm' },
})
const response = await POST(request, emptyParams)
const { status, body } = await parseJsonResponse<{
data: {
confirmed: string[]
skipped: Array<{ transaction_id: string; reason: string }>
}
}>(response)
expect(status).toBe(200)
expect(body.data.confirmed).toEqual([TX_1])
expect(body.data.skipped).toEqual([
{ transaction_id: TX_2, reason: 'voucher_consumed', message: undefined },
])
expect(confirmMock).toHaveBeenCalledWith(supabase, 'company-1', 'user-1', [TX_1, TX_2])
expect(rejectMock).not.toHaveBeenCalled()
})
it('routes action=reject to the reject service', async () => {
const request = createMockRequest('/api/reconciliation/bank/confirm-suggestions', {
method: 'POST',
body: { transaction_ids: [TX_1], action: 'reject' },
})
const response = await POST(request, emptyParams)
const { status, body } = await parseJsonResponse<{ data: { rejected: string[] } }>(response)
expect(status).toBe(200)
expect(body.data.rejected).toEqual([TX_1])
expect(rejectMock).toHaveBeenCalledWith(supabase, 'company-1', 'user-1', [TX_1])
expect(confirmMock).not.toHaveBeenCalled()
})
})