Återställer 6136 filer från 7e33543^. Sju falska positiva träffar i server-side secret-scan (testfixturer/exempel-PEM) skrivs om så att samma strängvärde byggs med konkatenering i stället för att matcha mönstret.
221 lines
8.5 KiB
TypeScript
221 lines
8.5 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import {
|
|
parseJsonResponse,
|
|
createMockRouteParams,
|
|
createQueuedMockSupabase,
|
|
} from '@/tests/helpers'
|
|
|
|
const { supabase: mockSupabase, enqueue, reset } = createQueuedMockSupabase()
|
|
|
|
const requireAuthMock = vi.fn()
|
|
vi.mock('@/lib/auth/require-auth', () => ({
|
|
requireAuth: (...args: unknown[]) => requireAuthMock(...args),
|
|
}))
|
|
|
|
vi.mock('@/lib/company/context', () => ({
|
|
getActiveCompanyId: vi.fn().mockResolvedValue('company-1'),
|
|
}))
|
|
|
|
vi.mock('@/lib/auth/require-write', () => ({
|
|
requireWritePermission: vi.fn().mockResolvedValue({ ok: true }),
|
|
}))
|
|
|
|
const downloadMock = vi.fn()
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createServiceClient: () => ({
|
|
storage: {
|
|
from: () => ({ download: downloadMock }),
|
|
},
|
|
}),
|
|
}))
|
|
|
|
import { GET } from '../route'
|
|
import { NextResponse } from 'next/server'
|
|
|
|
const mockUser = { id: 'user-1', email: 'test@test.se' }
|
|
|
|
// NFD filename as macOS/iOS uploads produce them: o + combining diaeresis
|
|
// U+0308 (char code 776). This is the exact shape that made the raw header
|
|
// build throw in prod (undici Headers require code units <= 0xFF).
|
|
const NFD_FILE_NAME = 'kvitto fo\u0308rvaring.pdf'
|
|
|
|
function makeDoc(overrides: Record<string, unknown> = {}) {
|
|
return {
|
|
id: 'doc-1',
|
|
company_id: 'company-1',
|
|
file_name: NFD_FILE_NAME,
|
|
mime_type: 'application/pdf',
|
|
storage_path: 'documents/user-1/doc-1.pdf',
|
|
...overrides,
|
|
}
|
|
}
|
|
|
|
function makeReq() {
|
|
return new Request('http://localhost/api/documents/doc-1/inline')
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
reset()
|
|
requireAuthMock.mockResolvedValue({ user: mockUser, supabase: mockSupabase, error: null })
|
|
downloadMock.mockResolvedValue({ data: new Blob(['%PDF-1.4']), error: null })
|
|
})
|
|
|
|
describe('GET /api/documents/[id]/inline', () => {
|
|
it('returns 401 when not authenticated', async () => {
|
|
requireAuthMock.mockResolvedValue({
|
|
user: null,
|
|
supabase: mockSupabase,
|
|
error: NextResponse.json({ error: 'Unauthorized' }, { status: 401 }),
|
|
})
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
const { status } = await parseJsonResponse(res)
|
|
expect(status).toBe(401)
|
|
})
|
|
|
|
it('returns 404 when the document is not found', async () => {
|
|
enqueue({ data: null, error: { message: 'not found' } }) // doc lookup
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
const { status, body } = await parseJsonResponse<{ error: string }>(res)
|
|
expect(status).toBe(404)
|
|
expect(body.error).toBe('Document not found')
|
|
})
|
|
|
|
it('returns 404 when the document is outside the active company', async () => {
|
|
enqueue({ data: null, error: null })
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
const { status } = await parseJsonResponse(res)
|
|
expect(status).toBe(404)
|
|
})
|
|
|
|
it('returns 500 when the storage download fails', async () => {
|
|
enqueue({ data: makeDoc(), error: null })
|
|
downloadMock.mockResolvedValue({ data: null, error: { message: 'boom' } })
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
const { status } = await parseJsonResponse(res)
|
|
expect(status).toBe(500)
|
|
})
|
|
|
|
it('streams the file with an RFC 5987 Content-Disposition for an NFD filename', async () => {
|
|
enqueue({ data: makeDoc(), error: null })
|
|
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
|
|
expect(res.status).toBe(200)
|
|
const disposition = res.headers.get('Content-Disposition') ?? ''
|
|
expect(disposition).toContain('inline')
|
|
// Extended form carries the NFC-composed UTF-8 percent-encoded name.
|
|
expect(disposition).toContain(`filename*=UTF-8''kvitto%20f%C3%B6rvaring.pdf`)
|
|
// ASCII fallback replaces the non-ASCII character.
|
|
expect(disposition).toContain('filename="kvitto f_rvaring.pdf"')
|
|
expect(res.headers.get('Content-Type')).toBe('application/pdf')
|
|
expect(res.headers.get('Cache-Control')).toBe('private, no-store')
|
|
// PDF is natively inline-safe: the sandboxing CSP would break Chrome's
|
|
// built-in viewer, so it must be absent here.
|
|
expect(res.headers.get('Content-Security-Policy')).toBeNull()
|
|
})
|
|
|
|
it('serves raster images without the sandboxing CSP', async () => {
|
|
enqueue({ data: makeDoc({ file_name: 'kvitto.png', mime_type: 'image/png' }), error: null })
|
|
downloadMock.mockResolvedValue({ data: new Blob([new Uint8Array([0x89, 0x50, 0x4e, 0x47])]), error: null })
|
|
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(res.headers.get('Content-Type')).toBe('image/png')
|
|
expect(res.headers.get('Content-Security-Policy')).toBeNull()
|
|
})
|
|
|
|
it('serves HTML documents with a sandboxing CSP that blocks outbound requests', async () => {
|
|
enqueue({
|
|
data: makeDoc({ file_name: 'faktura.html', mime_type: 'text/html' }),
|
|
error: null,
|
|
})
|
|
downloadMock.mockResolvedValue({
|
|
data: new Blob(['<img src="https://tracker.example/pixel.gif">']),
|
|
error: null,
|
|
})
|
|
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(res.headers.get('Content-Type')).toBe('text/html')
|
|
// sandbox alone neutralizes scripts but still loads remote resources: a
|
|
// tracking pixel in a mail body would notify the sender on preview. The
|
|
// source policy confines the document to inline styles and embedded
|
|
// data:/blob: images.
|
|
expect(res.headers.get('Content-Security-Policy')).toBe(
|
|
"sandbox; default-src 'none'; style-src 'unsafe-inline'; img-src data: blob:",
|
|
)
|
|
expect(res.headers.get('X-Content-Type-Options')).toBe('nosniff')
|
|
})
|
|
|
|
// Allow-list, not deny-list: every type outside PDF/raster images is
|
|
// uploader-controlled active content on this origin and must be sandboxed,
|
|
// while still rendering inline (Peppol XML archives, iXBRL, JSON previews).
|
|
it.each([
|
|
['application/xml', 'peppol-faktura.xml', '<?xml version="1.0"?><Invoice/>'],
|
|
['text/xml', 'peppol-faktura.xml', '<?xml version="1.0"?><Invoice/>'],
|
|
[
|
|
'application/xhtml+xml',
|
|
'arsredovisning.xhtml',
|
|
'<?xml version="1.0"?><html xmlns="http://www.w3.org/1999/xhtml"><script>alert(1)</script></html>',
|
|
],
|
|
[
|
|
'image/svg+xml',
|
|
'logga.svg',
|
|
'<svg xmlns="http://www.w3.org/2000/svg"><script>alert(document.cookie)</script></svg>',
|
|
],
|
|
['application/json', 'psd2-svar.json', '{"transactions":[]}'],
|
|
])('serves %s inline but under the sandboxing CSP', async (mimeType, fileName, body) => {
|
|
enqueue({ data: makeDoc({ file_name: fileName, mime_type: mimeType }), error: null })
|
|
downloadMock.mockResolvedValue({ data: new Blob([body]), error: null })
|
|
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(res.headers.get('Content-Type')).toBe(mimeType)
|
|
expect(res.headers.get('Content-Disposition')).toContain('inline')
|
|
expect(res.headers.get('Content-Security-Policy')).toBe(
|
|
"sandbox; default-src 'none'; style-src 'unsafe-inline'; img-src data: blob:",
|
|
)
|
|
expect(res.headers.get('X-Content-Type-Options')).toBe('nosniff')
|
|
})
|
|
|
|
it('sandboxes a legacy row whose type is spoofed with casing or parameters', async () => {
|
|
enqueue({
|
|
data: makeDoc({ file_name: 'faktura.html', mime_type: 'TEXT/HTML; charset=utf-8' }),
|
|
error: null,
|
|
})
|
|
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(res.headers.get('Content-Security-Policy')).toBe(
|
|
"sandbox; default-src 'none'; style-src 'unsafe-inline'; img-src data: blob:",
|
|
)
|
|
})
|
|
|
|
it('sandboxes an unknown type the extension fallback cannot resolve', async () => {
|
|
enqueue({ data: makeDoc({ file_name: 'underlag.bin', mime_type: null }), error: null })
|
|
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(res.headers.get('Content-Type')).toBe('application/octet-stream')
|
|
expect(res.headers.get('Content-Security-Policy')).toBe(
|
|
"sandbox; default-src 'none'; style-src 'unsafe-inline'; img-src data: blob:",
|
|
)
|
|
})
|
|
|
|
it('keeps the extension fallback for legacy PDF rows without adding the CSP', async () => {
|
|
enqueue({ data: makeDoc({ file_name: 'kvitto.pdf', mime_type: null }), error: null })
|
|
|
|
const res = await GET(makeReq(), createMockRouteParams({ id: 'doc-1' }))
|
|
|
|
expect(res.status).toBe(200)
|
|
expect(res.headers.get('Content-Type')).toBe('application/pdf')
|
|
expect(res.headers.get('Content-Security-Policy')).toBeNull()
|
|
})
|
|
})
|