Files
accounted/lib/invoices/__tests__/build-invoice-write.test.ts
T
MattssonandClaude Fable 5.1 1c82baf553 feat(invoices): offert (quote) document type with own OF-series, decisions, conversion, MCP and v1 (#2163)
* fix(invoices): reminders, AR ledger, AR reconciliation and deadlines only read fakturor

The overdue-reminder run, the kundreskontra, the 1510 reconciliation and the
deadlines page selected invoices by status alone. A sent proforma past its
due date was chased with a betalningspaminnelse and flipped to 'overdue',
and it appeared as a receivable. All four now filter document_type =
'invoice', which is also the precondition for adding quotes (offert): a
quote carries a date but never a receivable.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56

* feat(invoices): offert (quote) document type with its own OF-series, decisions and conversion

Adds document_type 'quote' with valid_until, quote_status (open / accepted /
declined; expired is derived from valid_until, never stored) and
quote_decided_at. Quotes are numbered OF-nnn at insert from
company_settings.next_quote_number via generate_quote_number(), the same
pattern as delivery notes, so a declined quote never leaves a hole in the
F-series the way a proforma does. The column next_quote_number already
existed on prod and staging without a migration; the migration adopts it.

Engine: build-invoice-write writes the quote columns and keeps
remaining_amount at 0; the draft editor refuses accepted or declined
quotes; PATCH refuses changing a quote's or delivery note's document type
since the number belongs to the series; mark-paid refuses quotes.

New POST /api/invoices/[id]/quote-status records the decision and locks
once an invoice exists. Conversion is extracted into
lib/invoices/convert-to-invoice.ts (one implementation for the route and
the MCP staged commit, which had drifted): a converted quote stays and
flips to accepted, the invoice links back via converted_from_id and gets
its due date from the customer's payment terms; a declined or already
invoiced quote is refused. next-number previews the OF-series for quotes.

Migration applied to the staging branch and registered as 20260902140000;
the pg test runs in CI (pg-real).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56

* feat(invoices): quote PDF, email and filename surfaces

The customer-facing surfaces get a quote sibling for every proforma branch:
PDF title OFFERT / QUOTE with Offertdatum and Giltig till instead of the
due date, a notice that the document is not an invoice or a payment
request, and no payment box, OCR, bankgiro, Swish, QR or payment link.
The email says the quote is attached and valid until the expiry, drops
the payment details and pay-online button, and asks about the quote
rather than the invoice. Filenames read "Offert nr OF-001". Seller VAT
number and payment accounts are skipped for quotes as for proformas:
a quote is not a faktura under ML 17 kap.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56

* feat(invoices): offert in the editor, list and detail pages

Editor: "Offert" document type with a required "Giltig till" field
(default today + 30 days) in place of the due date; the wire body mirrors
it into due_date so the shared schema is satisfied. Payment link, ROT/RUT,
periodisering and the bank box are already gated on real invoices. The
type cannot be switched on an existing quote (its OF-number belongs to
the series).

List: an Offerter tab beside Proforma, "Ny offert" in the split button,
and a status column that shows the decision or the derived expiry:
Utgången and Avböjd are exception chips, Öppen and Accepterad muted text.

Detail: Acceptera and Skapa faktura in the header, Avböj in the overflow
menu; an expired quote asks before accepting or invoicing (bypassable);
once an invoice exists the page links to it as Fakturerad and hides the
decision actions. Strings in both sv and en.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56

* feat(mcp,v1): expose offert on the MCP tools and the v1 REST surface

MCP: create_invoice takes document_type quote with a required valid_until
and allocates the OF-number at insert; the convert tool keeps its id and
accepts quotes with the registry refusal codes; new set_quote_status;
list_invoices and get_invoice expose valid_until and the effective quote
status, including a derived expired filter. The tools/list payload stays
under its ceiling without a ledger change. The MCP staged convert now
uses the shared converter.

v1: POST /invoices/{id}/quote-status (registered in the endpoint registry,
scope map and route loader), valid_until and quote_status in the list,
create and detail shapes, and a quote_status list filter. Skill atoms
mention offert. Decision log lines for the own number series, derived
expiry, accepted-not-cancelled conversion and the header action layout.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56

* test(invoices): pass route params and period id in the new quote tests

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56

* refactor(invoices): literal update payloads in the converter so the phantom-column guard can read them

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W45yD8NfQ97JhyYaXpzN56

* fix(invoices): close the quote review findings in one pass

Skeptics (correctness, compliance, regression) and CodeRabbit on #2163:

- quote_status is no longer a write-builder output, so a v1 PATCH or MCP
  update_invoice can never reset a recorded accept/decline; new quotes are
  opened by the invoices_quote_defaults trigger (20260902141000), which
  also keeps due_date and valid_until equal. v1 PATCH and the MCP update
  executor now use the shared editable-draft predicate.
- One live invoice per converted source, enforced by a partial unique
  index; the converter maps 23505 to INVOICE_QUOTE_ALREADY_INVOICED and
  both quote-status routes compare-and-set on the decision they read.
- MCP-created quotes carry remaining_amount 0; mark-paid, transaction
  match and voucher link refuse non-invoices on the MCP staging tools,
  the executors and the dashboard link route.
- Conversion of a foreign-currency source refetches the rate for the
  conversion day (ML 8 kap 21-23 paragraphs) and fails closed without one;
  0-day payment terms mean due on receipt.
- bulk-create refuses quotes per item; list_invoices rejects a
  quote_status filter combined with another document_type; an omitted
  document_type on PATCH means unchanged.
- attention, push notifications, open-AR count, FX revaluation, year-end
  and accrual auto-detect and bank-match suggestions only read fakturor.
- Quote PDF and email print Summa / Total instead of Att betala.
- Regenerated skills/accounted-api for the new v1 endpoint.

Declined with reasons in DECISIONS.md: NOT VALID + VALIDATE and CONCURRENTLY
on the migrations (repo precedent, 13.8k rows, transactional apply);
re-validating VAT treatment at conversion (the converted invoice is a
draft the user reviews; follow-up).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0111fYAUxKtpxU1BHiBioqzs

* fix(invoices): second review round: migration versions, order links, batch allocation, races

- Migrations renamed to 20260902220000 / 20260902221000: #2166 shipped its
  own 20260902141000 to prod while this PR was in review and prod's head
  moved past both files; below-head versions are skipped by branching,
  which would have left the quote trigger off prod. Staging rows renamed.
- Quote lines never carry sales_order_item_id (an offer must not count as
  invoiced kundorder quantity); the converter carries a proforma line's
  order link onto the invoice.
- Converter compare-and-sets the source (proforma cancel, quote accept):
  a concurrent cancel, proforma-to-order conversion or decision removes
  the orphan invoice with INVOICE_CONVERT_SOURCE_CHANGED instead of a
  second document for the same sale.
- MCP set_quote_status gets the same compare-and-set as the HTTP routes;
  0-row updates report INVOICE_QUOTE_CHANGED_CONCURRENTLY everywhere.
  quote-status (dashboard, v1, MCP) accepts valid_until so an expired
  sent quote can be reopened, as the docs promised.
- MCP mark-paid refuses only quotes, parity with the dashboard route
  (a sent proforma marked paid is a supported prepayment record).
- Batch allocation (dashboard route and MCP tool) refuses non-invoices
  before the RPC, which gates on status alone.
- Customer AR drill-down, v1 customer open invoices and archive guard,
  and the calendar feed read fakturor only.
- Draft quote PDF says "UTKAST" instead of "not a valid invoice"; the
  editor locks the document type on existing quotes and delivery notes.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0111fYAUxKtpxU1BHiBioqzs

* chore(invoices): use roundOre in the quote MCP summaries and FX test after main tightened the guard baseline

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0111fYAUxKtpxU1BHiBioqzs

* fix(invoices): third review round: atomic decision lock, viewer gate, lookup errors, quote payment terms

- 20260902222000: BEFORE UPDATE trigger locks an accepted quote while a
  live converted invoice exists (the compare-and-set in the three decision
  writers could still be beaten by a conversion landing in between); the
  routes and the MCP tool map the raise to 409 INVOICE_QUOTE_ALREADY_INVOICED.
  generate_quote_number now also requires a non-viewer membership so a
  viewer's session token cannot burn OF-numbers through PostgREST.
- Converter checks quote eligibility before the Riksbanken call and treats
  a failed company_settings read as a failure instead of a 30-day default.
- Re-sending the same decision keeps quote_decided_at (idempotent).
- gnubok_find_voucher_candidates_for_invoice refuses non-invoices like its
  write sibling; the dashboard link route surfaces a failed lookup.
- Late-fee and credit-term texts never print on a quote.
Applied and registered on staging; pg tests added.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0111fYAUxKtpxU1BHiBioqzs

* fix(invoices): review nits: fail-closed batch lookup, dry-run expiry, quote heading, quote-date CHECK

- match-batch surfaces a failed document lookup instead of allocating.
- v1 quote-status dry-run preview carries the new valid_until.
- Quote PDF heading reads Offertinformation / Quote information.
- 20260902222000 also pins the date invariants the trigger maintains as a
  CHECK: a quote always has valid_until = due_date, nothing else has one.
  Applied on staging.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0111fYAUxKtpxU1BHiBioqzs

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-02 22:40:25 +02:00

600 lines
25 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import type { SupabaseClient } from '@supabase/supabase-js'
import { createQueuedMockSupabase, makeCustomer } from '@/tests/helpers'
import { buildInvoiceWriteData, type InvoiceWriteInput } from '@/lib/invoices/build-invoice-write'
import { encryptPersonnummer, decryptPersonnummer } from '@/lib/salary/personnummer'
import type { Customer, InvoiceDocumentType } from '@/types'
// Uses the REAL getVatRules / rot-rut-rules / personnummer helpers (only the
// supabase lookups are mocked) so the test exercises the same computation the
// POST and PATCH routes rely on.
function call(
enqueue: ReturnType<typeof createQueuedMockSupabase>['enqueue'],
supabase: SupabaseClient,
customer: Customer,
input: InvoiceWriteInput,
documentType: InvoiceDocumentType = 'invoice',
) {
return buildInvoiceWriteData({ supabase, companyId: 'company-1', customer, documentType, input })
}
const baseHeader = {
customer_id: 'customer-1',
invoice_date: '2026-06-15',
due_date: '2026-07-15',
currency: 'SEK' as const,
}
describe('buildInvoiceWriteData', () => {
it('computes totals + item rows for a domestic 25% invoice and omits number/status', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null }) // company_settings.vat_registered
const customer = makeCustomer({ customer_type: 'swedish_business' })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [{ description: 'Konsult', quantity: 10, unit: 'tim', unit_price: 1000, vat_rate: 25 }],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.subtotal).toBe(10000)
expect(result.invoiceFields.vat_amount).toBe(2500)
expect(result.invoiceFields.total).toBe(12500)
expect(result.invoiceFields.remaining_amount).toBe(12500)
expect(result.invoiceFields.vat_rate).toBe(25)
// The route owns these: the builder must never set them.
expect(result.invoiceFields).not.toHaveProperty('invoice_number')
expect(result.invoiceFields).not.toHaveProperty('status')
expect(result.invoiceFields).not.toHaveProperty('user_id')
// Item row carries no invoice_id: the route adds it.
expect(result.items).toHaveLength(1)
expect(result.items[0]).not.toHaveProperty('invoice_id')
expect(result.items[0]).toMatchObject({
sort_order: 0,
line_type: 'product',
line_total: 10000,
vat_rate: 25,
vat_amount: 2500,
})
})
it('maps payment_link_url to a concrete trimmed value, null when absent', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({ customer_type: 'swedish_business' })
const withLink = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
payment_link_url: ' https://buy.stripe.com/test_abc123 ',
items: [{ description: 'Konsult', quantity: 1, unit: 'tim', unit_price: 1000, vat_rate: 25 }],
})
expect(withLink.ok).toBe(true)
if (!withLink.ok) return
expect(withLink.invoiceFields.payment_link_url).toBe('https://buy.stripe.com/test_abc123')
// Absent input must still produce an explicit null (not undefined):
// supabase-js drops undefined keys, and a draft edit that cleared the
// field relies on the NULL actually being written.
const { supabase: supabase2, enqueue: enqueue2 } = createQueuedMockSupabase()
enqueue2({ data: { vat_registered: true }, error: null })
const withoutLink = await call(enqueue2, supabase2 as unknown as SupabaseClient, customer, {
...baseHeader,
items: [{ description: 'Konsult', quantity: 1, unit: 'tim', unit_price: 1000, vat_rate: 25 }],
})
expect(withoutLink.ok).toBe(true)
if (!withoutLink.ok) return
expect(withoutLink.invoiceFields.payment_link_url).toBeNull()
})
it('handles a mixed-rate invoice (vat_rate becomes null on the header)', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({ customer_type: 'swedish_business' })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [
{ description: 'Tjänst', quantity: 1, unit: 'st', unit_price: 1000, vat_rate: 25 },
{ description: 'Bok', quantity: 1, unit: 'st', unit_price: 1000, vat_rate: 6 },
],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.vat_rate).toBeNull()
expect(result.invoiceFields.vat_amount).toBe(250 + 60)
})
it('zeroes VAT when the company is not VAT-registered', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: false }, error: null })
const customer = makeCustomer({ customer_type: 'swedish_business' })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [{ description: 'Konsult', quantity: 1, unit: 'tim', unit_price: 1000, vat_rate: 25 }],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.vat_amount).toBe(0)
expect(result.invoiceFields.total).toBe(1000)
expect(result.invoiceFields.vat_treatment).toBe('exempt')
expect(result.items[0].vat_rate).toBe(0)
})
it('rejects a VAT rate that is not a Swedish rate at all', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
// 10% is not a Swedish momssats (ML 9 kap: 25 / 12 / 6) for any customer.
const customer = makeCustomer({ customer_type: 'eu_business', vat_number_validated: true })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [{ description: 'Konsult', quantity: 1, unit: 'tim', unit_price: 1000, vat_rate: 10 }],
})
expect(result.ok).toBe(false)
if (result.ok) return
expect('code' in result && result.code).toBe('INVOICE_CREATE_VAT_RULE_VIOLATION')
})
// ============================================================
// Place of supply: huvudregeln vs taxed-where-performed (ML 6 kap.)
// ============================================================
it('keeps a genuine EU B2B consulting line at 0% with the reverse-charge notation', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
// Huvudregeln (ML 6 kap. 34 §): taxed where the buyer is established.
const customer = makeCustomer({ customer_type: 'eu_business', vat_number_validated: true })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [{ description: 'Konsult', quantity: 10, unit: 'tim', unit_price: 1000, vat_rate: 0 }],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.vat_amount).toBe(0)
expect(result.invoiceFields.vat_treatment).toBe('reverse_charge')
expect(result.invoiceFields.moms_ruta).toBe('39')
expect(result.invoiceFields.reverse_charge_text).toContain('Article 196')
expect(result.items[0].vat_rate).toBe(0)
})
it('defaults an EU B2B line with no explicit rate to 0%, never to 25%', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
// Widening the permitted set must not change the default: an omitted
// vat_rate still falls back to getVatRules().rate === 0.
const customer = makeCustomer({ customer_type: 'eu_business', vat_number_validated: true })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [{ description: 'Konsult', quantity: 1, unit: 'tim', unit_price: 1000 }],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.vat_amount).toBe(0)
expect(result.invoiceFields.vat_treatment).toBe('reverse_charge')
expect(result.invoiceFields.reverse_charge_text).toContain('Article 196')
})
it('accepts a taxed-where-performed line to an EU business and drops the RC notation', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
// Stockholm hotel night invoiced to a German company. Restaurang/hotell is
// taxed where performed (ML 6 kap. exception), so Swedish 12% applies even
// though the buyer is an EU business. This was refused outright before.
const customer = makeCustomer({ customer_type: 'eu_business', vat_number_validated: true })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [{ description: 'Hotellnatt Stockholm', quantity: 2, unit: 'natt', unit_price: 1000, vat_rate: 12 }],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.vat_amount).toBe(240)
expect(result.invoiceFields.total).toBe(2240)
// Nothing on this invoice is reverse-charged: the notation would be a false
// statement and would tell the buyer to self-assess VAT already collected.
expect(result.invoiceFields.reverse_charge_text).toBeNull()
expect(result.invoiceFields.vat_treatment).not.toBe('reverse_charge')
expect(result.invoiceFields.moms_ruta).toBe('05')
expect(result.items[0].vat_rate).toBe(12)
expect(result.items[0].vat_amount).toBe(240)
})
it('accepts a taxed-where-performed line to a non-EU business and drops the export notation', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
// Conference admission sold to a US company; admission to cultural/sports
// events is taxed at the event location, so Swedish 6% applies.
const customer = makeCustomer({ customer_type: 'non_eu_business' })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [{ description: 'Konferensbiljett', quantity: 1, unit: 'st', unit_price: 1000, vat_rate: 6 }],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.vat_amount).toBe(60)
expect(result.invoiceFields.reverse_charge_text).toBeNull()
expect(result.invoiceFields.vat_treatment).not.toBe('export')
expect(result.invoiceFields.moms_ruta).toBe('05')
})
it('keeps a non-EU business consulting line at 0% with the export notation', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({ customer_type: 'non_eu_business' })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [{ description: 'Konsult', quantity: 5, unit: 'tim', unit_price: 1000, vat_rate: 0 }],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.vat_amount).toBe(0)
expect(result.invoiceFields.vat_treatment).toBe('export')
expect(result.invoiceFields.moms_ruta).toBe('40')
expect(result.invoiceFields.reverse_charge_text).toContain('ML 10 kap')
})
it('keeps the RC notation on a mixed invoice that still has zero-rated lines', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
// 0% consulting (huvudregeln, reverse charge) + 12% hotel (taxed where
// performed) on one invoice. The buyer IS liable for the consulting line,
// so the notation is required; the 12% line still carries Swedish VAT.
const customer = makeCustomer({ customer_type: 'eu_business', vat_number_validated: true })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [
{ description: 'Konsult', quantity: 1, unit: 'tim', unit_price: 1000, vat_rate: 0 },
{ description: 'Hotellnatt Stockholm', quantity: 1, unit: 'natt', unit_price: 1000, vat_rate: 12 },
],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.vat_amount).toBe(120)
expect(result.invoiceFields.vat_treatment).toBe('reverse_charge')
expect(result.invoiceFields.moms_ruta).toBe('39')
expect(result.invoiceFields.reverse_charge_text).toContain('Article 196')
expect(result.invoiceFields.vat_rate).toBeNull() // mixed
})
it('excludes free-text rows from totals', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({ customer_type: 'swedish_business' })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
items: [
{ description: 'Rubrik', quantity: 0, unit: '', unit_price: 0, vat_rate: 0, line_type: 'text' },
{ description: 'Konsult', quantity: 2, unit: 'tim', unit_price: 500, vat_rate: 25 },
],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.subtotal).toBe(1000)
expect(result.invoiceFields.vat_amount).toBe(250)
expect(result.items[0]).toMatchObject({ line_type: 'text', line_total: 0, vat_amount: 0 })
})
})
describe('buildInvoiceWriteData stored ROT/RUT personnummer (edit path)', () => {
const rutItem = {
description: 'Städning',
quantity: 10,
unit: 'tim',
unit_price: 500,
vat_rate: 25,
deduction_type: 'rut' as const,
work_type: 'STAD',
labor_hours: 10,
}
it('keeps the stored ciphertext when the edit leaves personnummer empty', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({ customer_type: 'individual' })
const result = await buildInvoiceWriteData({
supabase: supabase as unknown as SupabaseClient,
companyId: 'company-1',
customer,
documentType: 'invoice',
input: { ...baseHeader, items: [rutItem] },
existingPersonnummer: { encrypted: 'stored-ciphertext', last4: '1234' },
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.deduction_personnummer_encrypted).toBe('stored-ciphertext')
expect(result.invoiceFields.deduction_personnummer_last4).toBe('1234')
})
it('still rejects a deduction invoice with no personnummer anywhere (create path)', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({ customer_type: 'individual' })
const result = await buildInvoiceWriteData({
supabase: supabase as unknown as SupabaseClient,
companyId: 'company-1',
customer,
documentType: 'invoice',
input: { ...baseHeader, items: [rutItem] },
})
expect(result.ok).toBe(false)
if (result.ok) return
expect('code' in result && result.code).toBe('INVOICE_CREATE_ROT_RUT_VALIDATION')
})
it('does not resurrect the stored personnummer when all deduction lines are removed', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({ customer_type: 'individual' })
const result = await buildInvoiceWriteData({
supabase: supabase as unknown as SupabaseClient,
companyId: 'company-1',
customer,
documentType: 'invoice',
input: { ...baseHeader, items: [{ description: 'Vanlig tjänst', quantity: 1, unit: 'st', unit_price: 100, vat_rate: 25 }] },
existingPersonnummer: { encrypted: 'stored-ciphertext', last4: '1234' },
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.deduction_personnummer_encrypted).toBeNull()
expect(result.invoiceFields.deduction_personnummer_last4).toBeNull()
})
})
describe('buildInvoiceWriteData kundkort personnummer fallback', () => {
const rutItem = {
description: 'Städning',
quantity: 10,
unit: 'tim',
unit_price: 500,
vat_rate: 25,
deduction_type: 'rut' as const,
work_type: 'STAD',
labor_hours: 10,
}
it('falls back to the customer card personal_number when the field is empty', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({
customer_type: 'individual',
personal_number: encryptPersonnummer('199001019802'),
})
const result = await buildInvoiceWriteData({
supabase: supabase as unknown as SupabaseClient,
companyId: 'company-1',
customer,
documentType: 'invoice',
input: { ...baseHeader, items: [rutItem] },
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.deduction_personnummer_last4).toBe('9802')
expect(decryptPersonnummer(result.invoiceFields.deduction_personnummer_encrypted as string)).toBe('199001019802')
})
it('expands a 10-digit legacy plaintext kundkort value to 12 digits', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({
customer_type: 'individual',
personal_number: '900101-9802',
})
const result = await buildInvoiceWriteData({
supabase: supabase as unknown as SupabaseClient,
companyId: 'company-1',
customer,
documentType: 'invoice',
input: { ...baseHeader, items: [rutItem] },
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.deduction_personnummer_last4).toBe('9802')
expect(decryptPersonnummer(result.invoiceFields.deduction_personnummer_encrypted as string)).toBe('199001019802')
})
it('lets a typed personnummer win over the customer card', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({
customer_type: 'individual',
personal_number: '250101-0025',
})
const result = await buildInvoiceWriteData({
supabase: supabase as unknown as SupabaseClient,
companyId: 'company-1',
customer,
documentType: 'invoice',
input: { ...baseHeader, deduction_personnummer: '199001019802', items: [rutItem] },
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.deduction_personnummer_last4).toBe('9802')
expect(decryptPersonnummer(result.invoiceFields.deduction_personnummer_encrypted as string)).toBe('199001019802')
})
it('lets the stored draft personnummer outrank the customer card (edit path)', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({
customer_type: 'individual',
personal_number: '900101-9802',
})
const result = await buildInvoiceWriteData({
supabase: supabase as unknown as SupabaseClient,
companyId: 'company-1',
customer,
documentType: 'invoice',
input: { ...baseHeader, items: [rutItem] },
existingPersonnummer: { encrypted: 'stored-ciphertext', last4: '1234' },
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.deduction_personnummer_encrypted).toBe('stored-ciphertext')
expect(result.invoiceFields.deduction_personnummer_last4).toBe('1234')
})
it('treats an invalid kundkort value as absent and still requires a typed one', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({
customer_type: 'individual',
// Bad Luhn: must fall through to the "Personnummer krävs" error, never
// to a confusing "invalid personnummer" for a value the user never typed.
personal_number: '900101-9803',
})
const result = await buildInvoiceWriteData({
supabase: supabase as unknown as SupabaseClient,
companyId: 'company-1',
customer,
documentType: 'invoice',
input: { ...baseHeader, items: [rutItem] },
})
expect(result.ok).toBe(false)
if (result.ok) return
expect('code' in result && result.code).toBe('INVOICE_CREATE_ROT_RUT_VALIDATION')
})
})
describe('buildInvoiceWriteData kundkort fallback customer-type gate', () => {
it('never claims on a stray personal_number of a non-individual customer', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
// personal_number is individual-only in the Zod schemas but not in the
// DB: a legacy/business row carrying one must not be claimed on
// implicitly, so the fallback stays off and validation asks for a typed
// personnummer.
const customer = makeCustomer({
customer_type: 'swedish_business',
personal_number: '900101-9802',
})
const result = await buildInvoiceWriteData({
supabase: supabase as unknown as SupabaseClient,
companyId: 'company-1',
customer,
documentType: 'invoice',
input: {
...baseHeader,
items: [{
description: 'Städning',
quantity: 10,
unit: 'tim',
unit_price: 500,
vat_rate: 25,
deduction_type: 'rut' as const,
work_type: 'STAD',
labor_hours: 10,
}],
},
})
expect(result.ok).toBe(false)
if (result.ok) return
expect('code' in result && result.code).toBe('INVOICE_CREATE_ROT_RUT_VALIDATION')
})
it('writes valid_until + quote_status open for a quote, mirrors it into due_date and keeps nothing owed', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({ customer_type: 'swedish_business' })
const result = await call(
enqueue,
supabase as unknown as SupabaseClient,
customer,
{
...baseHeader,
valid_until: '2026-08-01',
items: [{ description: 'Offererat arbete', quantity: 2, unit: 'tim', unit_price: 1000, vat_rate: 25 }],
},
'quote',
)
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.document_type).toBe('quote')
expect(result.invoiceFields.valid_until).toBe('2026-08-01')
expect(result.invoiceFields.due_date).toBe('2026-08-01')
// The decision column is never a builder output (a draft edit must not
// overwrite an accept/decline); the DB trigger opens a new quote.
expect(result.invoiceFields).not.toHaveProperty('quote_status')
expect(result.invoiceFields.total).toBe(2500)
expect(result.invoiceFields.remaining_amount).toBe(0)
expect(result.invoiceFields.deduction_total).toBe(0)
})
it('leaves the quote columns NULL on every other document type', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({ customer_type: 'swedish_business' })
const result = await call(enqueue, supabase as unknown as SupabaseClient, customer, {
...baseHeader,
valid_until: '2026-08-01',
items: [{ description: 'Konsult', quantity: 1, unit: 'tim', unit_price: 1000, vat_rate: 25 }],
})
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.invoiceFields.valid_until).toBeNull()
expect(result.invoiceFields).not.toHaveProperty('quote_status')
expect(result.invoiceFields.due_date).toBe(baseHeader.due_date)
})
it('drops sales_order_item_id on quote lines so an offer never consumes kundorder quantity', async () => {
const { supabase, enqueue } = createQueuedMockSupabase()
enqueue({ data: { vat_registered: true }, error: null })
const customer = makeCustomer({ customer_type: 'swedish_business' })
const result = await call(
enqueue,
supabase as unknown as SupabaseClient,
customer,
{
...baseHeader,
valid_until: '2026-08-01',
items: [{ description: 'Orderrad', quantity: 1, unit: 'st', unit_price: 1000, vat_rate: 25, sales_order_item_id: '33333333-3333-4333-8333-333333333333' }],
},
'quote',
)
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.items[0]).toMatchObject({ sales_order_item_id: null })
})
})