Files
accounted/lib/webshop-orders/__tests__/booking-lines.test.ts
T
MattssonandClaude Fable 5 c634430677 feat(woo): select multiple orders and book them with one template sweep (#1900)
* feat(woo): select multiple orders and book them with one template sweep

Adds bulk booking to the orders page (issue #1880): hover-reveal checkbox
column, a bulkbar with select-all/clear, and a confirm dialog that books
every selected order with the standard order template (per-store payment-
method mapping, optionally one override account for the whole selection).

Server side, POST /api/webshop-orders/bulk-book books each order as its
OWN verifikat through the exact same flow as the single-order endpoint:
the guards, FX retry and race-free draft -> claim -> commit sequence are
extracted to lib/webshop-orders/book-order.ts and shared by both routes,
so nothing added to the single path can miss the bulk path. Partial
failure is reported per order and never aborts the batch.

Fixes #1880

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(woo): replace mangled NUL byte in bulk dialog grouping key with a pipe

The account-group key template literal picked up a raw 0x00 byte during
generation (known escape-mangling hazard), making git treat the file as
binary. Same grouping semantics, plain '|' separator.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(woo): bulk sweep only books derived lines, never guessed ones (skeptic findings)

The sweep has no reviewing user, so everything the single dialog relies
on a human to catch is now refused per order or aborted:

- empty vat_breakdown: the ratio-inferred fallback split (a 25%+6% mixed
  sale classified as 12%, refunds reversing zero moms via 3004) is only
  allowed as the single dialog's editable prefill; bulk refuses with
  WEBSHOP_ORDER_VAT_BREAKDOWN_MISSING
- invoice-mode payment methods: booking would foreclose Skapa faktura
  and post a wrong clearing leg; refused with
  WEBSHOP_ORDER_INVOICE_MODE_METHOD (the account override does not
  bypass the merchant's configured flow)
- 3740 residual above ore scale (gift-card gaps booked as
  'oresavrundning'): refused with WEBSHOP_ORDER_RESIDUAL_TOO_LARGE
- settings-fetch failure now aborts the sweep instead of silently
  rebooking every order to 1686 against the confirmed dialog
- maxDuration 300 so a platform kill cannot strand an order between
  claim and commit
- per-order guard details (e.g. journal_entry_id) survive into the
  failure envelope

The dialog mirrors the skip rules up front (named order numbers, not an
anonymous count) so the confirmation describes exactly what will book.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(woo): refuse non-Swedish VAT-rate buckets in the bulk sweep

A foreign OSS bucket (e.g. German 19%) passes the non-empty breakdown
gate with zero residual, but the rate-to-account maps would fall back to
the 25% accounts and book foreign VAT as Swedish utgaende moms 2611
(skeptic finding). The sweep now refuses such orders per order with
WEBSHOP_ORDER_UNSUPPORTED_VAT_RATE (details.rates names the offending
rates); the dialog mirrors the rule and names the skipped orders. Only
the single dialog may show that prefill, as an editable guess.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-25 15:34:34 +02:00

358 lines
12 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import {
buildOrderBookingLines,
fallbackVatBreakdown,
orderBookingDescription,
resolveBookingWarnings,
resolvePaymentAccount,
DEFAULT_PAYMENT_ACCOUNT,
WEBSHOP_PREFILL_ACCOUNTS,
} from '../booking-lines'
import type { CreateJournalEntryLineInput, WebshopStoreSettings } from '@/types'
import { roundOre as round } from '@/lib/money'
function sumDebits(lines: CreateJournalEntryLineInput[]): number {
return round(lines.reduce((sum, l) => sum + l.debit_amount, 0))
}
function sumCredits(lines: CreateJournalEntryLineInput[]): number {
return round(lines.reduce((sum, l) => sum + l.credit_amount, 0))
}
function lineFor(lines: CreateJournalEntryLineInput[], account: string) {
return lines.find((l) => l.account_number === account)
}
const settings: WebshopStoreSettings = {
id: 's1',
company_id: 'c1',
user_id: 'u1',
platform: 'woocommerce',
store_scope: 'butik.example.se',
payment_method_account_map: {
swish: { mode: 'book', account: '1930' },
klarna_payments: { mode: 'book', account: '1580' },
bacs: { mode: 'invoice' },
},
created_at: '',
updated_at: '',
}
function makeOrder(overrides: Record<string, unknown> = {}) {
return {
row_type: 'order' as const,
order_number: '1042',
payment_method: 'swish',
payment_method_title: 'Swish',
currency: 'SEK',
total: 500,
total_tax: 100,
total_sek: 500,
exchange_rate: 1,
vat_breakdown: [{ rate: 25, net: 400, tax: 100 }],
...overrides,
}
}
describe('resolvePaymentAccount', () => {
it('resolves a mapped book-mode account', () => {
expect(resolvePaymentAccount(makeOrder(), settings)).toEqual({
account: '1930',
invoiceMode: false,
mapped: true,
})
})
it('flags invoice-mode methods', () => {
const result = resolvePaymentAccount(makeOrder({ payment_method: 'bacs' }), settings)
expect(result.invoiceMode).toBe(true)
})
it('falls back to the 1686 clearing account when unmapped or without settings', () => {
expect(resolvePaymentAccount(makeOrder({ payment_method: 'stripe' }), settings).account).toBe(
DEFAULT_PAYMENT_ACCOUNT,
)
expect(resolvePaymentAccount(makeOrder(), null).account).toBe(DEFAULT_PAYMENT_ACCOUNT)
expect(resolvePaymentAccount(makeOrder({ payment_method: null }), settings).mapped).toBe(false)
})
it('defaults to BAS 1686, the card/PSP receivable, not the 1680 parent', () => {
expect(DEFAULT_PAYMENT_ACCOUNT).toBe('1686')
})
})
describe('WEBSHOP_PREFILL_ACCOUNTS', () => {
it('covers every account the builder can emit', () => {
// Guards the ensure-accounts contract: an account the prefill emits but
// this set omits would resurface as AccountsNotInChartError in booking.
const emitted = new Set<string>()
for (const rate of [25, 12, 6, 0]) {
for (const lineSet of [
buildOrderBookingLines({
order: makeOrder({
total: 100.01,
total_tax: rate === 0 ? 0 : 20,
vat_breakdown: [{ rate, net: 80, tax: rate === 0 ? 0 : 20 }],
}),
settings: null,
}),
]) {
for (const line of lineSet) emitted.add(line.account_number)
}
}
for (const account of emitted) {
expect(WEBSHOP_PREFILL_ACCOUNTS).toContain(account)
}
// The residual account is only reachable through rounding drift; assert
// it explicitly so the set never silently loses it.
expect(WEBSHOP_PREFILL_ACCOUNTS).toContain('3740')
expect(WEBSHOP_PREFILL_ACCOUNTS).toContain('3004')
})
})
describe('fallbackVatBreakdown', () => {
it('infers 25/12/6 from the tax-to-net ratio', () => {
expect(fallbackVatBreakdown(500, 100)).toEqual([{ rate: 25, net: 400, tax: 100 }])
expect(fallbackVatBreakdown(112, 12)).toEqual([{ rate: 12, net: 100, tax: 12 }])
expect(fallbackVatBreakdown(106, 6)).toEqual([{ rate: 6, net: 100, tax: 6 }])
})
it('returns a 0% bucket for tax-free totals', () => {
expect(fallbackVatBreakdown(300, 0)).toEqual([{ rate: 0, net: 300, tax: 0 }])
})
it('falls back to a 25% bucket for unrecognizable mixes', () => {
expect(fallbackVatBreakdown(500, 50)).toEqual([{ rate: 25, net: 450, tax: 50 }])
})
})
describe('buildOrderBookingLines', () => {
it('books a SEK 25% order: gross to mapped account, net to 3001, VAT to 2611', () => {
const lines = buildOrderBookingLines({ order: makeOrder(), settings })
expect(lines).toHaveLength(3)
expect(lineFor(lines, '1930')).toMatchObject({ debit_amount: 500, credit_amount: 0 })
expect(lineFor(lines, '3001')).toMatchObject({ debit_amount: 0, credit_amount: 400 })
expect(lineFor(lines, '2611')).toMatchObject({ debit_amount: 0, credit_amount: 100 })
expect(sumDebits(lines)).toBe(sumCredits(lines))
})
it('splits mixed VAT rates across 3001/3002/3003 + 2611/2621/2631', () => {
const lines = buildOrderBookingLines({
order: makeOrder({
total: 723,
total_tax: 87,
total_sek: 723,
vat_breakdown: [
{ rate: 25, net: 300, tax: 75 },
{ rate: 12, net: 100, tax: 12 },
{ rate: 6, net: 200, tax: 12 },
{ rate: 0, net: 24, tax: 0 },
],
}),
settings,
})
expect(lineFor(lines, '3001')?.credit_amount).toBe(300)
expect(lineFor(lines, '3002')?.credit_amount).toBe(100)
expect(lineFor(lines, '3003')?.credit_amount).toBe(200)
expect(lineFor(lines, '3004')?.credit_amount).toBe(24)
expect(lineFor(lines, '2611')?.credit_amount).toBe(75)
expect(lineFor(lines, '2621')?.credit_amount).toBe(12)
expect(lineFor(lines, '2631')?.credit_amount).toBe(12)
expect(sumDebits(lines)).toBe(sumCredits(lines))
})
it('sends rounding residual to 3740 and stays balanced', () => {
const lines = buildOrderBookingLines({
order: makeOrder({
total: 500.05,
total_sek: 500.05,
vat_breakdown: [{ rate: 25, net: 400, tax: 100 }],
}),
settings,
})
expect(lineFor(lines, '3740')?.credit_amount).toBe(0.05)
expect(sumDebits(lines)).toBe(sumCredits(lines))
})
it('mirrors refund rows: credit the payment account, debit revenue and VAT', () => {
const lines = buildOrderBookingLines({
order: makeOrder({
row_type: 'refund',
total: -500,
total_tax: -100,
total_sek: -500,
vat_breakdown: [{ rate: 25, net: 400, tax: 100 }],
}),
settings,
})
expect(lineFor(lines, '1930')).toMatchObject({ debit_amount: 0, credit_amount: 500 })
expect(lineFor(lines, '3001')).toMatchObject({ debit_amount: 400, credit_amount: 0 })
expect(lineFor(lines, '2611')).toMatchObject({ debit_amount: 100, credit_amount: 0 })
expect(sumDebits(lines)).toBe(sumCredits(lines))
})
it('books non-SEK orders in SEK with currency metadata on money lines only', () => {
const lines = buildOrderBookingLines({
order: makeOrder({
currency: 'EUR',
total: 100,
total_tax: 20,
total_sek: 1153,
exchange_rate: 11.53,
vat_breakdown: [{ rate: 25, net: 80, tax: 20 }],
}),
settings,
})
const gross = lineFor(lines, '1930')
expect(gross).toMatchObject({
debit_amount: 1153,
currency: 'EUR',
amount_in_currency: 100,
exchange_rate: 11.53,
})
expect(lineFor(lines, '3001')).toMatchObject({
credit_amount: round(80 * 11.53),
amount_in_currency: 80,
})
const rounding = lineFor(lines, '3740')
if (rounding) expect(rounding.currency).toBeUndefined()
expect(sumDebits(lines)).toBe(sumCredits(lines))
})
it('honors an explicit payment-account override from the dialog', () => {
const lines = buildOrderBookingLines({
order: makeOrder(),
settings,
paymentAccount: '1686',
})
expect(lineFor(lines, '1686')?.debit_amount).toBe(500)
})
it('uses the fallback breakdown when the sync produced none', () => {
const lines = buildOrderBookingLines({
order: makeOrder({ vat_breakdown: [] }),
settings,
})
expect(lineFor(lines, '3001')?.credit_amount).toBe(400)
expect(lineFor(lines, '2611')?.credit_amount).toBe(100)
expect(sumDebits(lines)).toBe(sumCredits(lines))
})
it('books a NEGATIVE discount bucket on the opposite side, never abs-flipped', () => {
// Gift-card/discount plugin: 25% product 500+125, 0% discount -100.
// The old abs() logic booked C 3004 100 + D 3740 200: balanced, wrong.
const lines = buildOrderBookingLines({
order: makeOrder({
total: 525,
total_tax: 125,
total_sek: 525,
vat_breakdown: [
{ rate: 25, net: 500, tax: 125 },
{ rate: 0, net: -100, tax: 0 },
],
}),
settings,
})
expect(lineFor(lines, '1930')).toMatchObject({ debit_amount: 525 })
expect(lineFor(lines, '3001')).toMatchObject({ credit_amount: 500 })
expect(lineFor(lines, '2611')).toMatchObject({ credit_amount: 125 })
expect(lineFor(lines, '3004')).toMatchObject({ debit_amount: 100, credit_amount: 0 })
expect(lineFor(lines, '3740')).toBeUndefined()
expect(sumDebits(lines)).toBe(sumCredits(lines))
})
it('throws when a non-SEK order has no resolved SEK amount', () => {
expect(() =>
buildOrderBookingLines({
order: makeOrder({ currency: 'EUR', total_sek: null, exchange_rate: null }),
settings,
}),
).toThrow(/exchange rate/i)
})
})
describe('resolveBookingWarnings', () => {
it('flags a 0%-amount to a known non-SE country', () => {
expect(
resolveBookingWarnings({
currency: 'SEK',
total_tax: 0,
vat_breakdown: [{ rate: 0, net: 2000, tax: 0 }],
customer_country: 'NO',
}),
).toEqual(['zero_rate_foreign'])
})
it('stays quiet for domestic momsfri and unknown countries', () => {
expect(
resolveBookingWarnings({
currency: 'SEK',
total_tax: 0,
vat_breakdown: [{ rate: 0, net: 2000, tax: 0 }],
customer_country: 'SE',
}),
).toEqual([])
expect(
resolveBookingWarnings({
currency: 'SEK',
total_tax: 0,
vat_breakdown: [{ rate: 0, net: 2000, tax: 0 }],
customer_country: null,
}),
).toEqual([])
})
it('flags VAT charged on a non-SEK order (OSS check)', () => {
expect(
resolveBookingWarnings({
currency: 'EUR',
total_tax: 20,
vat_breakdown: [{ rate: 25, net: 80, tax: 20 }],
customer_country: 'DK',
}),
).toEqual(['foreign_vat'])
})
})
describe('orderBookingDescription', () => {
it('labels an order with its payment method', () => {
expect(
orderBookingDescription({
row_type: 'order',
order_number: '1001',
payment_method: 'swish',
payment_method_title: 'Swish',
}),
).toBe('Order 1001 (Swish)')
})
it('falls back to the raw method key, then to no method', () => {
expect(
orderBookingDescription({
row_type: 'order',
order_number: '1001',
payment_method: 'swish',
payment_method_title: null,
}),
).toBe('Order 1001 (swish)')
expect(
orderBookingDescription({
row_type: 'order',
order_number: '1001',
payment_method: null,
payment_method_title: null,
}),
).toBe('Order 1001')
})
it('labels refunds without the method', () => {
expect(
orderBookingDescription({
row_type: 'refund',
order_number: '1001',
payment_method: 'swish',
payment_method_title: 'Swish',
}),
).toBe('Återbetalning order 1001')
})
})