* feat(accounting): update accounting method validation and messaging for aktiebolag and enskild firma * Remove AI subsystem and related code - Deleted AI proposals and requests persistence logic from `lib/ai/proposals/persist.ts`. - Removed re-validation logic for proposals in `lib/ai/proposals/re-validate.ts`. - Cleaned up schemas related to AI flows in `lib/api/schemas.ts`. - Removed AI-related fields from bookkeeping engine in `lib/bookkeeping/engine.ts`. - Eliminated AI event types from `lib/events/types.ts`. - Updated tests to reflect the removal of AI-related functionality in `lib/extensions/__tests__/sectors.test.ts`. - Adjusted initialization logic in `lib/init.ts` to exclude AI proposal handler registration. - Cleaned up transaction ingestion logic in `lib/transactions/ingest.ts` to remove AI flow checks. - Updated helper functions in `tests/helpers.ts` to remove AI-related settings. - Removed AI-related types and interfaces from `types/index.ts`. - Added migration script to drop AI-related tables and settings from the database. * fix(migrations): ensure foreign key constraint is dropped before removing AI tables * feat(invoice-inbox): implement deterministic invoice field extraction and inbox provisioning - Added `extract-invoice-fields.ts` for extracting fields from PDF invoices using regex and pdfjs-dist, replacing the previous AI classifier. - Introduced `inbox-provisioning.ts` to manage company inbox addresses and rotation of inboxes using Supabase RPCs. - Created `resend-inbound.ts` for handling inbound email events and attachments via the Resend API. - Defined the extension manifest for the invoice inbox, specifying required environment variables and descriptions. - Migrated database schema to remove AI-related columns and tighten the status enum in `invoice_inbox_items`. * feat(invoice-inbox): remove AI-specific columns and tighten status enum * fix(skattekonto): remove manual entry creation reference from transaction input * fix(schemas): remove accounting method validation for aktiebolag in UpdateSettingsSchema
491 lines
17 KiB
TypeScript
491 lines
17 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
vi.mock('next/cache', () => ({
|
|
revalidatePath: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/supabase/server', () => ({
|
|
createClient: vi.fn(),
|
|
createServiceClient: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/company/context', () => ({
|
|
setActiveCompany: vi.fn().mockResolvedValue(undefined),
|
|
}))
|
|
|
|
import { createClient, createServiceClient } from '@/lib/supabase/server'
|
|
import { createCompanyFromTicRole, createCompanyFromOnboarding } from '../actions'
|
|
import type { CompanyLookupResult } from '@/lib/company-lookup/types'
|
|
|
|
const mockCreateClient = vi.mocked(createClient)
|
|
const mockCreateServiceClient = vi.mocked(createServiceClient)
|
|
|
|
/**
|
|
* Build a service-role client mock. Seed `existingOrgNumber` when you want
|
|
* the duplicate-org guard in createCompanyFromOnboarding to find a match.
|
|
* Any other service-role query resolves to `{ data: null, error: null }`.
|
|
*/
|
|
function mockServiceClientForOrgNumber(existingOrgNumber?: string) {
|
|
const serviceFrom = vi.fn().mockImplementation(() => {
|
|
const chain: Record<string, unknown> = {}
|
|
const methods = ['select', 'eq', 'is', 'in', 'order', 'limit', 'maybeSingle']
|
|
for (const m of methods) {
|
|
chain[m] = () => {
|
|
if (m === 'maybeSingle') {
|
|
return Promise.resolve({
|
|
data: existingOrgNumber ? { id: 'other-company', name: 'Other AB' } : null,
|
|
error: null,
|
|
})
|
|
}
|
|
return chain
|
|
}
|
|
}
|
|
chain.then = (resolve: (v: unknown) => void) => resolve({ data: null, error: null })
|
|
return chain
|
|
})
|
|
mockCreateServiceClient.mockReturnValue({ from: serviceFrom } as never)
|
|
}
|
|
|
|
type CapturedCall = { table: string; method: string; args: unknown[] }
|
|
|
|
/**
|
|
* Builds a chainable Supabase mock that records every method call, allows
|
|
* per-table result seeding, and returns a capture log the test can assert on.
|
|
*
|
|
* - `results[table][method]` (optional) is returned when the chain ends on
|
|
* that method. Chains otherwise resolve to `{ data: null, error: null }`.
|
|
* - Unknown methods on the chain no-op and return the chain so callers can
|
|
* keep chaining freely.
|
|
*/
|
|
function buildSupabase(opts: {
|
|
user: { id: string } | null
|
|
results?: Record<string, Record<string, { data?: unknown; error?: unknown }>>
|
|
rpcResults?: Record<string, { data?: unknown; error?: unknown }>
|
|
}) {
|
|
const calls: CapturedCall[] = []
|
|
const { user, results = {}, rpcResults = {} } = opts
|
|
|
|
function makeChain(table: string) {
|
|
const record = (method: string, args: unknown[]) => {
|
|
calls.push({ table, method, args })
|
|
}
|
|
const chain: Record<string, unknown> = {}
|
|
const methods = ['select', 'eq', 'is', 'in', 'order', 'limit', 'maybeSingle', 'single', 'insert', 'upsert', 'delete', 'update']
|
|
for (const m of methods) {
|
|
chain[m] = (...args: unknown[]) => {
|
|
record(m, args)
|
|
const canTerminate = results[table]?.[m]
|
|
if (canTerminate) {
|
|
return Promise.resolve({
|
|
data: canTerminate.data ?? null,
|
|
error: canTerminate.error ?? null,
|
|
})
|
|
}
|
|
return chain
|
|
}
|
|
}
|
|
chain.then = (resolve: (v: unknown) => void) => resolve({ data: null, error: null })
|
|
return chain
|
|
}
|
|
|
|
const supabase = {
|
|
auth: {
|
|
getUser: vi.fn().mockResolvedValue({ data: { user } }),
|
|
},
|
|
from: vi.fn().mockImplementation((table: string) => makeChain(table)),
|
|
rpc: vi.fn().mockImplementation((name: string) => {
|
|
const result = rpcResults[name]
|
|
if (result) {
|
|
return Promise.resolve({ data: result.data ?? null, error: result.error ?? null })
|
|
}
|
|
return Promise.resolve({ data: null, error: null })
|
|
}),
|
|
}
|
|
|
|
return { supabase, calls }
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
// Default: no existing company with this org_number. Individual tests can
|
|
// override by calling mockServiceClientForOrgNumber('...') inside the test.
|
|
mockServiceClientForOrgNumber(undefined)
|
|
})
|
|
|
|
describe('createCompanyFromTicRole', () => {
|
|
it('returns Unauthorized when no user session', async () => {
|
|
const { supabase } = buildSupabase({ user: null })
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
|
|
const result = await createCompanyFromTicRole({
|
|
teamId: 'team-1',
|
|
orgNumber: '5560125790',
|
|
legalName: 'Acme AB',
|
|
legalEntityType: 'AB',
|
|
lookup: null,
|
|
})
|
|
|
|
expect(result.error).toBe('Unauthorized')
|
|
})
|
|
|
|
it('rejects unmappable entity types before any DB work', async () => {
|
|
const { supabase, calls } = buildSupabase({ user: { id: 'user-1' } })
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
|
|
const result = await createCompanyFromTicRole({
|
|
teamId: 'team-1',
|
|
orgNumber: '969696-1212',
|
|
legalName: 'Beta HB',
|
|
legalEntityType: 'Handelsbolag',
|
|
lookup: null,
|
|
})
|
|
|
|
expect(result.error).toMatch(/manuellt/i)
|
|
// Entity-type rejection should short-circuit — no table writes.
|
|
const writes = calls.filter((c) => ['insert', 'upsert', 'delete', 'update'].includes(c.method))
|
|
expect(writes).toEqual([])
|
|
})
|
|
|
|
it('refuses to guess when TIC lookup is missing (prevents silent ML 17 kap violation)', async () => {
|
|
const { supabase, calls } = buildSupabase({ user: { id: 'user-1' } })
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
|
|
const result = await createCompanyFromTicRole({
|
|
teamId: 'team-1',
|
|
orgNumber: '5560125790',
|
|
legalName: 'Acme AB',
|
|
legalEntityType: 'AB',
|
|
lookup: null,
|
|
})
|
|
|
|
expect(result.error).toBe('lookup_missing')
|
|
// Must not have provisioned anything with a guessed VAT status.
|
|
const writes = calls.filter((c) => ['insert', 'upsert', 'delete', 'update'].includes(c.method))
|
|
expect(writes).toEqual([])
|
|
})
|
|
|
|
it('provisions with sensible defaults for a VAT-registered aktiebolag', async () => {
|
|
const lookup: CompanyLookupResult = {
|
|
companyName: 'Acme Konsult AB',
|
|
isCeased: false,
|
|
address: { street: 'Storgatan 1', postalCode: '11122', city: 'Stockholm' },
|
|
registration: { fTax: true, vat: true },
|
|
bankAccounts: [],
|
|
email: null,
|
|
phone: null,
|
|
sniCodes: [],
|
|
}
|
|
|
|
const { supabase, calls } = buildSupabase({
|
|
user: { id: 'user-1' },
|
|
results: {
|
|
// Seed an enrichment row so the cleanup branch runs and the test
|
|
// can verify it fires.
|
|
extension_data: {
|
|
maybeSingle: { data: { id: 'enrichment-1', value: {} } },
|
|
},
|
|
},
|
|
rpcResults: {
|
|
create_company_with_owner: { data: 'new-company-id' },
|
|
seed_chart_of_accounts: { data: null },
|
|
},
|
|
})
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
|
|
const result = await createCompanyFromTicRole({
|
|
teamId: 'team-1',
|
|
orgNumber: '5560125790',
|
|
legalName: 'Acme Konsult AB',
|
|
legalEntityType: 'AB',
|
|
lookup,
|
|
})
|
|
|
|
expect(result.companyId).toBe('new-company-id')
|
|
expect(result.error).toBeUndefined()
|
|
|
|
// The settings upsert on company_settings should reflect our derived defaults.
|
|
const settingsUpsert = calls.find((c) => c.table === 'company_settings' && c.method === 'upsert')
|
|
expect(settingsUpsert).toBeDefined()
|
|
const settings = (settingsUpsert!.args[0] as Record<string, unknown>)
|
|
expect(settings.entity_type).toBe('aktiebolag')
|
|
expect(settings.company_name).toBe('Acme Konsult AB')
|
|
expect(settings.org_number).toBe('5560125790')
|
|
expect(settings.f_skatt).toBe(true)
|
|
expect(settings.vat_registered).toBe(true)
|
|
expect(settings.moms_period).toBe('quarterly')
|
|
expect(settings.accounting_method).toBe('accrual')
|
|
expect(settings.address_line1).toBe('Storgatan 1')
|
|
expect(settings.postal_code).toBe('11122')
|
|
expect(settings.city).toBe('Stockholm')
|
|
|
|
// The enrichment row must be cleaned up by the one-click path so the
|
|
// picker doesn't re-offer this company on a return visit.
|
|
const enrichmentDelete = calls.find(
|
|
(c) => c.table === 'extension_data' && c.method === 'delete',
|
|
)
|
|
expect(enrichmentDelete).toBeDefined()
|
|
})
|
|
|
|
it('defaults enskild firma to kontantmetoden (K1), leaves moms_period null when non-VAT', async () => {
|
|
const lookup: CompanyLookupResult = {
|
|
companyName: 'Liten EF',
|
|
isCeased: false,
|
|
address: null,
|
|
registration: { fTax: true, vat: false },
|
|
bankAccounts: [],
|
|
email: null,
|
|
phone: null,
|
|
sniCodes: [],
|
|
}
|
|
|
|
const { supabase, calls } = buildSupabase({
|
|
user: { id: 'user-1' },
|
|
rpcResults: {
|
|
create_company_with_owner: { data: 'new-company-id' },
|
|
seed_chart_of_accounts: { data: null },
|
|
},
|
|
})
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
|
|
await createCompanyFromTicRole({
|
|
teamId: 'team-1',
|
|
orgNumber: '8001011231',
|
|
legalName: 'Liten EF',
|
|
legalEntityType: 'Enskild firma',
|
|
lookup,
|
|
})
|
|
|
|
const settingsUpsert = calls.find((c) => c.table === 'company_settings' && c.method === 'upsert')
|
|
const settings = settingsUpsert!.args[0] as Record<string, unknown>
|
|
expect(settings.entity_type).toBe('enskild_firma')
|
|
expect(settings.vat_registered).toBe(false)
|
|
expect(settings.moms_period).toBeNull()
|
|
// Default for EF is kontantmetoden (BFL 5 kap. 2 §); AB defaults to accrual but may switch.
|
|
expect(settings.accounting_method).toBe('cash')
|
|
})
|
|
})
|
|
|
|
describe('createCompanyFromOnboarding — duplicate org_number guard', () => {
|
|
it('refuses to create a company when the org number already exists', async () => {
|
|
const { supabase, calls } = buildSupabase({
|
|
user: { id: 'user-1' },
|
|
rpcResults: {
|
|
create_company_with_owner: { data: 'should-not-be-called' },
|
|
},
|
|
})
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
mockServiceClientForOrgNumber('5560125790') // pretend this org is already taken
|
|
|
|
const result = await createCompanyFromOnboarding({
|
|
teamId: 'team-1',
|
|
settings: {
|
|
entity_type: 'aktiebolag',
|
|
company_name: 'Acme AB',
|
|
org_number: '5560125790',
|
|
},
|
|
fiscalPeriod: {
|
|
startDate: '2026-01-01',
|
|
endDate: '2026-12-31',
|
|
name: 'Räkenskapsår 2026',
|
|
},
|
|
})
|
|
|
|
expect(result.error).toBe('org_number_exists')
|
|
expect(result.companyId).toBeUndefined()
|
|
|
|
// Guard must short-circuit before the create RPC runs — otherwise we'd
|
|
// leave a ghost company behind when the duplicate is detected.
|
|
const rpcCreate = supabase.rpc.mock.calls.find(([name]) => name === 'create_company_with_owner')
|
|
expect(rpcCreate).toBeUndefined()
|
|
// And no company_settings upsert should have happened.
|
|
expect(calls.find((c) => c.table === 'company_settings' && c.method === 'upsert')).toBeUndefined()
|
|
})
|
|
|
|
it('tolerates formatted org_numbers when detecting duplicates (hyphens/spaces stripped)', async () => {
|
|
const { supabase } = buildSupabase({
|
|
user: { id: 'user-1' },
|
|
rpcResults: { create_company_with_owner: { data: 'x' } },
|
|
})
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
mockServiceClientForOrgNumber('5560125790')
|
|
|
|
const result = await createCompanyFromOnboarding({
|
|
teamId: 'team-1',
|
|
settings: {
|
|
entity_type: 'aktiebolag',
|
|
company_name: 'Acme AB',
|
|
// User-typed format — the guard should still catch this as a duplicate.
|
|
org_number: '556677-8899',
|
|
},
|
|
fiscalPeriod: {
|
|
startDate: '2026-01-01',
|
|
endDate: '2026-12-31',
|
|
name: 'Räkenskapsår 2026',
|
|
},
|
|
})
|
|
|
|
expect(result.error).toBe('org_number_exists')
|
|
})
|
|
|
|
it('normalizes 12-digit personnummer input down to the 10-digit canonical form', async () => {
|
|
const { supabase } = buildSupabase({
|
|
user: { id: 'user-1' },
|
|
rpcResults: { create_company_with_owner: { data: 'x' } },
|
|
})
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
// The existing company is stored as the 10-digit canonical form.
|
|
mockServiceClientForOrgNumber('8001011231')
|
|
|
|
const result = await createCompanyFromOnboarding({
|
|
teamId: 'team-1',
|
|
settings: {
|
|
entity_type: 'enskild_firma',
|
|
company_name: 'Anna EF',
|
|
// User types full 12-digit personnummer with century prefix.
|
|
org_number: '19800101-1231',
|
|
},
|
|
fiscalPeriod: {
|
|
startDate: '2026-01-01',
|
|
endDate: '2026-12-31',
|
|
name: 'Räkenskapsår 2026',
|
|
},
|
|
})
|
|
|
|
// Should detect the duplicate despite the 12-digit input.
|
|
expect(result.error).toBe('org_number_exists')
|
|
})
|
|
|
|
it('rejects malformed org_numbers at the guard boundary', async () => {
|
|
const { supabase } = buildSupabase({
|
|
user: { id: 'user-1' },
|
|
rpcResults: { create_company_with_owner: { data: 'x' } },
|
|
})
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
|
|
const result = await createCompanyFromOnboarding({
|
|
teamId: 'team-1',
|
|
settings: {
|
|
entity_type: 'aktiebolag',
|
|
company_name: 'Broken AB',
|
|
org_number: 'abc123', // not a 10- or 12-digit number
|
|
},
|
|
fiscalPeriod: {
|
|
startDate: '2026-01-01',
|
|
endDate: '2026-12-31',
|
|
name: 'Räkenskapsår 2026',
|
|
},
|
|
})
|
|
|
|
expect(result.error).toBe('org_number_invalid')
|
|
// Must NOT have reached the create RPC — otherwise we'd save a malformed
|
|
// org_number and poison SIE/SRU exports.
|
|
const rpcCreate = supabase.rpc.mock.calls.find(([name]) => name === 'create_company_with_owner')
|
|
expect(rpcCreate).toBeUndefined()
|
|
})
|
|
|
|
it('rejects right-length org_numbers with invalid Luhn check digit', async () => {
|
|
const { supabase } = buildSupabase({
|
|
user: { id: 'user-1' },
|
|
rpcResults: { create_company_with_owner: { data: 'x' } },
|
|
})
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
|
|
const result = await createCompanyFromOnboarding({
|
|
teamId: 'team-1',
|
|
settings: {
|
|
entity_type: 'aktiebolag',
|
|
company_name: 'Fake AB',
|
|
// 10 digits but Luhn check digit is wrong (real Volvo is 5560125790;
|
|
// the trailing 1 is an intentional off-by-one). Skatteverket SRU
|
|
// validators and receiving SIE4 consumers would reject this, so we
|
|
// refuse at the boundary.
|
|
org_number: '5560125791',
|
|
},
|
|
fiscalPeriod: {
|
|
startDate: '2026-01-01',
|
|
endDate: '2026-12-31',
|
|
name: 'Räkenskapsår 2026',
|
|
},
|
|
})
|
|
|
|
expect(result.error).toBe('org_number_invalid')
|
|
const rpcCreate = supabase.rpc.mock.calls.find(([name]) => name === 'create_company_with_owner')
|
|
expect(rpcCreate).toBeUndefined()
|
|
})
|
|
|
|
it('fails closed when the duplicate lookup errors out (does not silently allow duplicates)', async () => {
|
|
const { supabase } = buildSupabase({
|
|
user: { id: 'user-1' },
|
|
rpcResults: { create_company_with_owner: { data: 'x' } },
|
|
})
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
|
|
// Seed a service client that errors on maybeSingle — simulating a DB
|
|
// outage or RLS misconfiguration.
|
|
mockCreateServiceClient.mockReturnValue({
|
|
from: vi.fn().mockReturnValue({
|
|
select: vi.fn().mockReturnThis(),
|
|
eq: vi.fn().mockReturnThis(),
|
|
is: vi.fn().mockReturnThis(),
|
|
limit: vi.fn().mockReturnThis(),
|
|
maybeSingle: vi.fn().mockResolvedValue({
|
|
data: null,
|
|
error: { message: 'connection lost' },
|
|
}),
|
|
}),
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
} as any)
|
|
|
|
const result = await createCompanyFromOnboarding({
|
|
teamId: 'team-1',
|
|
settings: {
|
|
entity_type: 'aktiebolag',
|
|
company_name: 'Acme AB',
|
|
org_number: '5560125790',
|
|
},
|
|
fiscalPeriod: {
|
|
startDate: '2026-01-01',
|
|
endDate: '2026-12-31',
|
|
name: 'Räkenskapsår 2026',
|
|
},
|
|
})
|
|
|
|
// Must return a user-facing error, NOT silently proceed with creation.
|
|
expect(result.companyId).toBeUndefined()
|
|
expect(result.error).toBeTruthy()
|
|
// And the create RPC must not have been called.
|
|
const rpcCreate = supabase.rpc.mock.calls.find(([name]) => name === 'create_company_with_owner')
|
|
expect(rpcCreate).toBeUndefined()
|
|
})
|
|
})
|
|
|
|
describe('createCompanyFromTicRole — ceased companies', () => {
|
|
it('refuses to provision when TIC lookup reports the company is ceased', async () => {
|
|
const lookup: CompanyLookupResult = {
|
|
companyName: 'Avregistrerat AB',
|
|
isCeased: true, // <- key field
|
|
address: null,
|
|
registration: { fTax: false, vat: false },
|
|
bankAccounts: [],
|
|
email: null,
|
|
phone: null,
|
|
sniCodes: [],
|
|
}
|
|
|
|
const { supabase, calls } = buildSupabase({ user: { id: 'user-1' } })
|
|
mockCreateClient.mockResolvedValue(supabase as never)
|
|
|
|
const result = await createCompanyFromTicRole({
|
|
teamId: 'team-1',
|
|
orgNumber: '5560125790',
|
|
legalName: 'Avregistrerat AB',
|
|
legalEntityType: 'AB',
|
|
lookup,
|
|
})
|
|
|
|
expect(result.error).toBe('company_ceased')
|
|
const writes = calls.filter((c) => ['insert', 'upsert', 'delete', 'update'].includes(c.method))
|
|
expect(writes).toEqual([])
|
|
})
|
|
})
|