Files
accounted/components/transactions/SkattekontoInboxCard.tsx
T
MattssonandClaude Opus 4.7 980f29dae8 Bug/momsdeklaration skv (#449)
* fix(salary): show birthdate in masked personnummer, hide the 4-digit suffix

Flip the personnummer display format from XXXXXXXX-NNNN to YYYYMMDD-XXXX so
the sensitive 4-digit suffix is hidden while the (public) birthdate stays
visible. Affects the employees list/detail, salary run, payslip PDF, payslip
email, and the MCP server tools (list_employees, get_salary_run). Each call
site now decrypts the stored personnummer before masking.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(transactions): allow deleting unbooked transactions from "Alla transaktioner"

The history list only let users delete via the inbox card; once a category or
mall was picked but the verifikation hadn't been created, the row showed
"Ej bokförd" with no way to remove it. The API already permits delete while
journal_entry_id is null, so the gap was purely a missing UI affordance.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(vat): populate ruta 20-24 for reverse charge + dishonest "Validera OK"

Three connected issues caused Skatteverket to reject momsdeklarationer
with FK004 even after our local "Validera"-knapp returned OK.

1. supplier-invoice-entries booked fiktiv moms (2614/2624/2634 + 2645/2647)
   on reverse-charge invoices but never the underlying basbelopp on 44xx/45xx.
   Ruta 30-32 filled up at SKV while ruta 20-24 stayed at 0 — SKV's FK004
   ("silent netting prohibited", ML 13 kap kräver båda sidor).

   Fix: generateReverseChargeBasisLines in vat-entries.ts emits parallel
   45xx/44xx debit + 4598 motkonto credit per rate group. Engine calls it
   from registration, cash, and credit-note paths. Skipped when the user
   booked the expense directly on a basis account to avoid double-counting.
   4598 added to BAS reference (no migration needed; account_number is
   plain text on journal_entry_lines).

2. rutorToMomsuppgift rounded each ruta independently but computed
   summaMoms from the unrounded ruta49. SKV recomputes the sum from
   integer rutor on their side, so fractional öres caused ±1 SEK drift
   and SKV rejected with FK009.

   Fix: derive summaMoms from the already-rounded VAT-amount rutor.

3. "Validera"-knappen only confirmed SKV's internal arithmetic — a
   declaration with ruta 30-32 populated and ruta 20-24 empty validated
   fine until /utkast hit FK004. Users got a false green light.

   Fix: vat-declaration-checks.ts runs locally before the SKV call,
   blocks Validera/Spara when ERROR-level findings exist, and surfaces
   them in a separate "Lokala kontroller"-section. Success message
   reworded so SKV's OK is no longer presented as filing-ready.

Tests: 4535/4536/4531/4425 lines + 4598 motkonto on EU/non-EU/byggtjänster
RC, credit-note reversal, fractional-öres summaMoms, all four pre-flight
codes (RC_BASIS_MISSING, RC_OUTPUT_MISSING, RC_INPUT_VAT_MISMATCH,
SUMMA_MOMS_DRIFT).

Backfill for already-posted entries follows in the next commit.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat: add skattekonto matching functionality

- Enhance TransactionInboxCard to display a warning for potential 1930↔1630 transfers.
- Implement match suggestions for skattekonto transactions in the backend.
- Create SkattekontoMatchDialog component for linking skattekonto rows to existing journal entries.
- Develop SkattekontoInboxCard component to handle skattekonto transactions in the inbox.
- Introduce skattekonto-match utility functions for candidate matching and linking.
- Update types to include match suggestions and enriched transaction responses.

* refactor: reorganize skattekonto types and implement bank counterpart matching logic

* docs: update CLAUDE.md to streamline integrations and clarify architecture details

* refactor: enhance reverse charge logic to handle non-basis accounts and prevent double-counting

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-12 18:04:48 +02:00

190 lines
6.5 KiB
TypeScript

'use client'
import { motion } from 'framer-motion'
import { Card, CardContent } from '@/components/ui/card'
import { Button } from '@/components/ui/button'
import { Badge } from '@/components/ui/badge'
import { cn, formatCurrency, formatDate } from '@/lib/utils'
import { AlertCircle, ArrowUpRight, ArrowDownRight, Landmark, Link2, Loader2 } from 'lucide-react'
import type {
SkattekontoMatchSuggestion,
StoredSkattekontoTransaction,
} from '@/types/skatteverket'
/**
* Skattekonto-rad in the /transactions inbox.
*
* Mirrors the visual rhythm of TransactionInboxCard (same icon circle, same
* amount placement) but with SKV-specific actions: Bokför creates a draft via
* the skatteverket extension; Matcha opens the shared dialog so users can
* link the row to an already-booked manual transfer.
*
* The Skatteverket badge is the cue that this row is fundamentally different
* from a bank tx — different counter-account (1630 vs 1930), different
* categorization rules, no AI-suggested invoice matches.
*/
export default function SkattekontoInboxCard({
row,
matchSuggestion,
processing,
onBokfor,
onMatch,
onAnimationComplete,
}: {
row: StoredSkattekontoTransaction
matchSuggestion?: SkattekontoMatchSuggestion | null
processing: boolean
onBokfor: (row: StoredSkattekontoTransaction) => void
onMatch: (row: StoredSkattekontoTransaction) => void
onAnimationComplete?: (id: string) => void
}) {
const amount = Number(row.belopp_skatteverket)
const isIncome = amount > 0
return (
<motion.div
layout
initial={{ opacity: 1, scale: 1 }}
exit={{ opacity: 0, scale: 0.95, x: -16 }}
transition={{ duration: 0.25, ease: [0.25, 0.46, 0.45, 0.94] }}
onAnimationComplete={definition => {
if (
typeof definition === 'object' &&
'opacity' in definition &&
definition.opacity === 0
) {
onAnimationComplete?.(row.id)
}
}}
>
<Card
className={cn(
'transition-colors',
matchSuggestion ? 'border-warning' : 'border-warning/50',
)}
>
<CardContent className="py-4">
<div className="flex items-start justify-between gap-4">
<div className="flex items-start gap-3 min-w-0 flex-1">
<div
className={cn(
'h-9 w-9 rounded-full flex items-center justify-center flex-shrink-0',
isIncome
? 'bg-success/10 text-success'
: 'bg-destructive/10 text-destructive',
)}
aria-hidden="true"
>
{isIncome ? (
<ArrowUpRight className="h-5 w-5" />
) : (
<ArrowDownRight className="h-5 w-5" />
)}
</div>
<div className="min-w-0">
<div className="flex items-center gap-2 flex-wrap">
<p className="font-medium truncate">{row.transaktionstext}</p>
<Badge variant="outline" className="gap-1 text-[10px]">
<Landmark className="h-3 w-3" />
Skatteverket
</Badge>
</div>
<p className="text-sm text-muted-foreground">
{formatDate(row.transaktionsdatum)}
</p>
</div>
</div>
<div className="text-right flex-shrink-0">
<p
className={cn(
'font-medium tabular-nums',
isIncome && 'text-success',
)}
>
{isIncome ? '+' : ''}
{formatCurrency(amount)}
</p>
</div>
</div>
{matchSuggestion && (
<div className="mt-3 flex items-start gap-2 rounded-md border border-warning/40 bg-warning/5 p-2 text-xs">
<AlertCircle className="h-3.5 w-3.5 mt-0.5 flex-shrink-0 text-warning" />
<div className="min-w-0">
<p className="font-medium">
Möjlig dublett av verifikat{' '}
{matchSuggestion.voucher_series && matchSuggestion.voucher_number
? `${matchSuggestion.voucher_series}${matchSuggestion.voucher_number}`
: '(utkast)'}
</p>
<p className="text-muted-foreground truncate">
{matchSuggestion.entry_date} • {matchSuggestion.description}
</p>
<p className="text-muted-foreground">
Det här ser ut som samma kassaflöde — koppla istället för
att bokföra om.
</p>
</div>
</div>
)}
<div className="flex flex-wrap items-center gap-2 mt-3 pt-3 border-t">
{matchSuggestion ? (
<>
<Button
size="sm"
variant="default"
className="h-9 text-xs"
onClick={() => onMatch(row)}
disabled={processing}
>
<Link2 className="mr-1.5 h-3 w-3" />
Koppla till verifikat
</Button>
<Button
size="sm"
variant="ghost"
className="h-9 text-xs"
onClick={() => onBokfor(row)}
disabled={processing}
>
{processing ? (
<Loader2 className="mr-1.5 h-3 w-3 animate-spin" />
) : null}
Bokför ändå
</Button>
</>
) : (
<>
<Button
size="sm"
variant="default"
className="h-9 text-xs"
onClick={() => onBokfor(row)}
disabled={processing}
>
{processing ? (
<Loader2 className="mr-1.5 h-3 w-3 animate-spin" />
) : null}
Bokför
</Button>
<Button
size="sm"
variant="outline"
className="h-9 text-xs"
onClick={() => onMatch(row)}
disabled={processing}
>
<Link2 className="mr-1.5 h-3 w-3" />
Matcha mot verifikat
</Button>
</>
)}
</div>
</CardContent>
</Card>
</motion.div>
)
}