* refactor(ui): app-wide UI/UX consistency pass
Net: +1,159 / −1,373 LOC across 77 files. No new features, no behavior
changes. Locks in a uniform design system across every dashboard surface.
What changed:
- **Foundation**: sidebar width 232→256px (md:w-64), spacing scale locked
(Tailwind 1/2/3/4/6/8/10/12; 2.5/5 forbidden), card padding p-6 default
(p-4 for compact metric cards), space-y-8 between page sections.
- **Tables unified**: all 33 thead blocks now share the Resultatrapport
pattern via shadcn Table primitive (text-[11px] font-medium uppercase
tracking-wider text-muted-foreground). Hand-rolled <table> instances
converted where they were data tables; form/edit grids kept distinct.
- **Status badges unified**: every status indicator routes through
shadcn <Badge variant>. Eliminated raw Tailwind colors
(bg-amber-100, bg-emerald-500/10, bg-blue-100, bg-purple-100, etc.)
in favor of the gnubok semantic palette (success=sage, warning=ochre,
destructive=terracotta).
- **Empty states unified**: list pages migrated from hand-rolled
"flex flex-col items-center py-12" divs to the EmptyState primitive.
- **Loading skeletons unified**: hand-rolled bg-muted rounded animate-pulse
divs replaced with shadcn <Skeleton> across 15 files.
- **Touch targets**: 6 back-buttons + edit-pencil + inbox delete bumped
from 24/32/36px to shadcn's 40px icon default. Added aria-labels on
9 icon-only navigation buttons.
- **Date formatting**: formatDate() for accounting data (ISO yyyy-MM-dd,
table-friendly) vs formatDateLong() for metadata (Swedish long form).
Raw {x.invoice_date} renderings routed through formatDate() in 18 sites.
- **Toast titles**: eliminated 33 generic "Fel" titles. Each toast title
now carries the action ("Kunde inte skapa lönekörning" etc.) with
description carrying the error detail.
- **Page-level cleanups**:
- Dashboard: dropped greeting hero + Snabbåtgärder/Att hantera nav
duplicates + Visa detaljer collapsible.
- Reports: 5-col mega-menu replaced with left-rail layout
(new ReportsNav component).
- Bookkeeping: fixed layout jump between Verifikationer/Ny verifikation
tabs (moved FiscalYearSelector inside journal tab).
- Bookkeeping: added voucher sort (A1 first / latest first) alongside
existing date sort. Required matching API param sort_by.
- KPI page: FiscalYearSelector instead of raw <select>; InfoTooltip
instead of inline info-button toggle; bigger numbers.
- Salary section: enum values translated to Swedish labels, mobile
table collapses to Anställd+Netto on <md, KPI typography aligned
with dashboard.
- Invoice forms: styled RequiredMark + aria-required, tabular-nums
on amount inputs.
- **CLAUDE.md**: new "Design System Tokens" subsection documents the
locked spacing scale, primitives table, typography rules, date helpers,
and forbidden patterns so future contributors don't drift.
Tests: 2,906 passing (unchanged). Lint: unchanged from main baseline.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address PR review feedback (Greptile + compliance bot)
- **formatDate / formatDateLong timezone fix**: switch from new Date() to
parseISO. Bare yyyy-MM-dd strings are now parsed as local midnight rather
than UTC midnight, eliminating the off-by-one display in west-of-UTC
timezones flagged by Greptile.
- **DashboardContentProps cleanup**: removed unused firstName and settings
fields from the interface, and the corresponding fetch (profiles table)
+ computation in app/(dashboard)/page.tsx. The greeting was dropped in
the dashboard cleanup; these props were dead weight.
- **Voucher sort behavior documented**: extended the comment in the journal
entries API route to explain why voucher sort intentionally uses strict
fiscal_period_id filtering (BFL 5 kap 6–7 §§ — voucher numbers are
series-scoped within a fiscal year). The row-count delta between date
sort and voucher sort is now a documented design choice.
- **delete_last_voucher migration + draft-delete test included**: the UI
already shipped the "Radera utkast" path in the previous commit; this
pulls in the backing RPC migration that allows draft deletes (with the
full safety logic — drafts skip series/period checks since they have
voucher_number=0, posted entries go through the existing unchanged
path). This was originally meant for a separate PR but the UI shipped
half the feature without it.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(migration): rename to match applied version
The function delete_last_voucher is already applied to the production DB
under version 20260509103736 (verified via pg_get_functiondef — exact
byte-for-byte match to file content). The previous file timestamp
20260509120000 would cause a fresh `supabase db push` to attempt re-applying
under a different version row. Renaming the file aligns local tracking
with what the database actually has.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address compliance bot findings (payroll label + VAT visibility)
- sick_karens label: drop "(första sjukdagen)" qualifier. Per sjuklönelagen
6 §, karensavdrag is a single calculated amount (20% of one week's
sjuklön) deducted from the first sick day's pay — not bounded to the
first day. The qualifier could mislead users when the first sick day
and return-to-work span a weekend. Swedish-payroll bot recommendation.
- Omvänd skattskyldighet badge: variant outline → warning. The reverse-
charge indicator is compliance-critical (ML 16 kap) — missing it leads
to incorrect input VAT deduction. Outline was too subtle; warning's
ochre fill matches its semantic weight.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
164 lines
5.0 KiB
TypeScript
164 lines
5.0 KiB
TypeScript
'use client'
|
|
|
|
import { Card, CardContent } from '@/components/ui/card'
|
|
import { InfoTooltip } from '@/components/ui/info-tooltip'
|
|
import { formatCurrency } from '@/lib/utils'
|
|
import { KPI_DEFINITIONS, getDefaultPreferences } from '@/lib/reports/kpi-definitions'
|
|
import type { KPIReport, KPIPreferences } from '@/types'
|
|
|
|
interface KPIHeroCardsProps {
|
|
report: KPIReport
|
|
preferences?: KPIPreferences
|
|
}
|
|
|
|
function getKPIValue(
|
|
report: KPIReport,
|
|
id: string
|
|
): { value: number | null; subtitle: string } {
|
|
switch (id) {
|
|
case 'netResult':
|
|
return { value: report.netResult, subtitle: 'netto' }
|
|
case 'cashPosition':
|
|
return { value: report.cashPosition, subtitle: 'likvida medel' }
|
|
case 'outstandingReceivables':
|
|
return {
|
|
value: report.outstandingReceivables,
|
|
subtitle:
|
|
report.overdueReceivables > 0
|
|
? `varav förfallet: ${formatCurrency(report.overdueReceivables)}`
|
|
: 'utestående',
|
|
}
|
|
case 'vatLiability':
|
|
return {
|
|
value: report.vatLiability,
|
|
subtitle:
|
|
report.vatLiability > 0
|
|
? 'att betala'
|
|
: report.vatLiability < 0
|
|
? 'att återfå'
|
|
: 'jämnt',
|
|
}
|
|
case 'grossMargin':
|
|
return { value: report.grossMargin, subtitle: 'av intäkter' }
|
|
case 'expenseRatio':
|
|
return { value: report.expenseRatio, subtitle: 'av intäkter' }
|
|
case 'avgPaymentDays':
|
|
return { value: report.avgPaymentDays, subtitle: 'snitt' }
|
|
default:
|
|
return { value: null, subtitle: '' }
|
|
}
|
|
}
|
|
|
|
function formatKPIValue(value: number | null, format: string, id: string): string {
|
|
if (value === null) return '—'
|
|
if (format === 'currency') {
|
|
if (id === 'vatLiability') return formatCurrency(Math.abs(value))
|
|
return formatCurrency(value)
|
|
}
|
|
if (format === 'percentage') return `${value}%`
|
|
if (format === 'days') return `${value} dagar`
|
|
return String(value)
|
|
}
|
|
|
|
function getValueColor(
|
|
value: number | null,
|
|
colorLogic: string
|
|
): string {
|
|
if (value === null) return 'text-muted-foreground'
|
|
if (colorLogic === 'neutral') return ''
|
|
if (colorLogic === 'positive-good') {
|
|
return value >= 0
|
|
? 'text-[hsl(var(--chart-1))]'
|
|
: 'text-[hsl(var(--chart-2))]'
|
|
}
|
|
if (colorLogic === 'negative-good') {
|
|
return value <= 0
|
|
? 'text-[hsl(var(--chart-1))]'
|
|
: 'text-[hsl(var(--chart-2))]'
|
|
}
|
|
return ''
|
|
}
|
|
|
|
export function KPIHeroCards({ report, preferences }: KPIHeroCardsProps) {
|
|
const prefs = preferences ?? getDefaultPreferences()
|
|
|
|
const visibleDefs = prefs.kpiOrder
|
|
.map((id) => KPI_DEFINITIONS.find((d) => d.id === id))
|
|
.filter((d) => d && prefs.visibleKpis.includes(d.id)) as typeof KPI_DEFINITIONS
|
|
|
|
if (visibleDefs.length === 0) {
|
|
return (
|
|
<Card>
|
|
<CardContent className="py-8 text-center text-muted-foreground text-sm">
|
|
Inga nyckeltal valda. Klicka på "Anpassa" för att välja vilka som ska visas.
|
|
</CardContent>
|
|
</Card>
|
|
)
|
|
}
|
|
|
|
const gridCols =
|
|
visibleDefs.length <= 2
|
|
? 'grid-cols-2'
|
|
: visibleDefs.length === 3
|
|
? 'grid-cols-2 md:grid-cols-3'
|
|
: 'grid-cols-2 md:grid-cols-4'
|
|
|
|
return (
|
|
<div className={`grid ${gridCols} gap-4`}>
|
|
{visibleDefs.map((def) => {
|
|
const { value, subtitle } = getKPIValue(report, def.id)
|
|
const formatted = formatKPIValue(value, def.format, def.id)
|
|
const color = getValueColor(value, def.colorLogic)
|
|
const hasOverride =
|
|
prefs.accountOverrides[def.id] &&
|
|
prefs.accountOverrides[def.id].length > 0
|
|
|
|
const tooltipContent = (
|
|
<div className="space-y-1.5 text-xs">
|
|
<p className="text-foreground/90">{def.description}</p>
|
|
<div>
|
|
<span className="font-medium">Formel: </span>
|
|
<span className="font-mono">{def.formula}</span>
|
|
</div>
|
|
<div>
|
|
<span className="font-medium">Konton: </span>
|
|
{def.accountDescription}
|
|
</div>
|
|
{hasOverride && (
|
|
<div className="text-primary">
|
|
<span className="font-medium">Anpassade: </span>
|
|
<span className="font-mono">
|
|
{prefs.accountOverrides[def.id].join(', ')}
|
|
</span>
|
|
</div>
|
|
)}
|
|
</div>
|
|
)
|
|
|
|
return (
|
|
<Card key={def.id}>
|
|
<CardContent className="p-6">
|
|
<InfoTooltip
|
|
content={tooltipContent}
|
|
side="top"
|
|
maxWidth="320px"
|
|
iconClassName="h-3 w-3"
|
|
>
|
|
<p className="text-xs text-muted-foreground">{def.label}</p>
|
|
</InfoTooltip>
|
|
<p
|
|
className={`font-display text-2xl font-medium tabular-nums tracking-tight mt-2 ${color}`}
|
|
>
|
|
{formatted}
|
|
</p>
|
|
<p className="text-xs text-muted-foreground mt-1">
|
|
{subtitle}
|
|
</p>
|
|
</CardContent>
|
|
</Card>
|
|
)
|
|
})}
|
|
</div>
|
|
)
|
|
}
|