Files
accounted/components/deadlines/TaxTodoWidget.tsx
T
Jakob WennbergandClaude Opus 4.7 d0fbc2b616 refactor(ui): app-wide UI/UX consistency pass (#436)
* refactor(ui): app-wide UI/UX consistency pass

Net: +1,159 / −1,373 LOC across 77 files. No new features, no behavior
changes. Locks in a uniform design system across every dashboard surface.

What changed:

- **Foundation**: sidebar width 232→256px (md:w-64), spacing scale locked
  (Tailwind 1/2/3/4/6/8/10/12; 2.5/5 forbidden), card padding p-6 default
  (p-4 for compact metric cards), space-y-8 between page sections.

- **Tables unified**: all 33 thead blocks now share the Resultatrapport
  pattern via shadcn Table primitive (text-[11px] font-medium uppercase
  tracking-wider text-muted-foreground). Hand-rolled <table> instances
  converted where they were data tables; form/edit grids kept distinct.

- **Status badges unified**: every status indicator routes through
  shadcn <Badge variant>. Eliminated raw Tailwind colors
  (bg-amber-100, bg-emerald-500/10, bg-blue-100, bg-purple-100, etc.)
  in favor of the gnubok semantic palette (success=sage, warning=ochre,
  destructive=terracotta).

- **Empty states unified**: list pages migrated from hand-rolled
  "flex flex-col items-center py-12" divs to the EmptyState primitive.

- **Loading skeletons unified**: hand-rolled bg-muted rounded animate-pulse
  divs replaced with shadcn <Skeleton> across 15 files.

- **Touch targets**: 6 back-buttons + edit-pencil + inbox delete bumped
  from 24/32/36px to shadcn's 40px icon default. Added aria-labels on
  9 icon-only navigation buttons.

- **Date formatting**: formatDate() for accounting data (ISO yyyy-MM-dd,
  table-friendly) vs formatDateLong() for metadata (Swedish long form).
  Raw {x.invoice_date} renderings routed through formatDate() in 18 sites.

- **Toast titles**: eliminated 33 generic "Fel" titles. Each toast title
  now carries the action ("Kunde inte skapa lönekörning" etc.) with
  description carrying the error detail.

- **Page-level cleanups**:
  - Dashboard: dropped greeting hero + Snabbåtgärder/Att hantera nav
    duplicates + Visa detaljer collapsible.
  - Reports: 5-col mega-menu replaced with left-rail layout
    (new ReportsNav component).
  - Bookkeeping: fixed layout jump between Verifikationer/Ny verifikation
    tabs (moved FiscalYearSelector inside journal tab).
  - Bookkeeping: added voucher sort (A1 first / latest first) alongside
    existing date sort. Required matching API param sort_by.
  - KPI page: FiscalYearSelector instead of raw <select>; InfoTooltip
    instead of inline info-button toggle; bigger numbers.
  - Salary section: enum values translated to Swedish labels, mobile
    table collapses to Anställd+Netto on <md, KPI typography aligned
    with dashboard.
  - Invoice forms: styled RequiredMark + aria-required, tabular-nums
    on amount inputs.

- **CLAUDE.md**: new "Design System Tokens" subsection documents the
  locked spacing scale, primitives table, typography rules, date helpers,
  and forbidden patterns so future contributors don't drift.

Tests: 2,906 passing (unchanged). Lint: unchanged from main baseline.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: address PR review feedback (Greptile + compliance bot)

- **formatDate / formatDateLong timezone fix**: switch from new Date() to
  parseISO. Bare yyyy-MM-dd strings are now parsed as local midnight rather
  than UTC midnight, eliminating the off-by-one display in west-of-UTC
  timezones flagged by Greptile.

- **DashboardContentProps cleanup**: removed unused firstName and settings
  fields from the interface, and the corresponding fetch (profiles table)
  + computation in app/(dashboard)/page.tsx. The greeting was dropped in
  the dashboard cleanup; these props were dead weight.

- **Voucher sort behavior documented**: extended the comment in the journal
  entries API route to explain why voucher sort intentionally uses strict
  fiscal_period_id filtering (BFL 5 kap 6–7 §§ — voucher numbers are
  series-scoped within a fiscal year). The row-count delta between date
  sort and voucher sort is now a documented design choice.

- **delete_last_voucher migration + draft-delete test included**: the UI
  already shipped the "Radera utkast" path in the previous commit; this
  pulls in the backing RPC migration that allows draft deletes (with the
  full safety logic — drafts skip series/period checks since they have
  voucher_number=0, posted entries go through the existing unchanged
  path). This was originally meant for a separate PR but the UI shipped
  half the feature without it.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(migration): rename to match applied version

The function delete_last_voucher is already applied to the production DB
under version 20260509103736 (verified via pg_get_functiondef — exact
byte-for-byte match to file content). The previous file timestamp
20260509120000 would cause a fresh `supabase db push` to attempt re-applying
under a different version row. Renaming the file aligns local tracking
with what the database actually has.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: address compliance bot findings (payroll label + VAT visibility)

- sick_karens label: drop "(första sjukdagen)" qualifier. Per sjuklönelagen
  6 §, karensavdrag is a single calculated amount (20% of one week's
  sjuklön) deducted from the first sick day's pay — not bounded to the
  first day. The qualifier could mislead users when the first sick day
  and return-to-work span a weekend. Swedish-payroll bot recommendation.

- Omvänd skattskyldighet badge: variant outline → warning. The reverse-
  charge indicator is compliance-critical (ML 16 kap) — missing it leads
  to incorrect input VAT deduction. Outline was too subtle; warning's
  ochre fill matches its semantic weight.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-11 16:34:07 +02:00

242 lines
8.3 KiB
TypeScript

'use client'
import { useState } from 'react'
import Link from 'next/link'
import { Card, CardContent, CardHeader, CardTitle } from '@/components/ui/card'
import { Badge } from '@/components/ui/badge'
import { Button } from '@/components/ui/button'
import { useToast } from '@/components/ui/use-toast'
import { Deadline, DeadlineStatus, TAX_DEADLINE_TYPE_LABELS, DEADLINE_STATUS_LABELS } from '@/types'
import { getReportUrl } from '@/lib/tax/deadline-config'
// Use the labels from types
const STATUS_LABELS = DEADLINE_STATUS_LABELS
import {
FileText,
ChevronRight,
AlertTriangle,
Clock,
Send,
Check,
Loader2,
ExternalLink,
} from 'lucide-react'
interface TaxTodoWidgetProps {
deadlines: Deadline[]
onStatusChange?: (deadlineId: string, newStatus: DeadlineStatus) => void
}
export function TaxTodoWidget({ deadlines, onStatusChange }: TaxTodoWidgetProps) {
const { toast } = useToast()
const [updatingId, setUpdatingId] = useState<string | null>(null)
// Filter to only tax deadlines needing attention
const taxDeadlines = deadlines.filter(
(d) =>
d.deadline_type === 'tax' &&
!d.is_completed &&
['action_needed', 'overdue', 'in_progress'].includes(d.status)
)
// Sort by urgency: overdue first, then by date
const sortedDeadlines = taxDeadlines.sort((a, b) => {
if (a.status === 'overdue' && b.status !== 'overdue') return -1
if (b.status === 'overdue' && a.status !== 'overdue') return 1
return a.due_date.localeCompare(b.due_date)
})
const overdueCount = taxDeadlines.filter((d) => d.status === 'overdue').length
const actionNeededCount = taxDeadlines.filter((d) => d.status === 'action_needed').length
if (sortedDeadlines.length === 0) {
return null
}
const formatDate = (dateStr: string) => {
const date = new Date(dateStr)
const today = new Date()
today.setHours(0, 0, 0, 0)
const diffDays = Math.ceil(
(date.getTime() - today.getTime()) / (1000 * 60 * 60 * 24)
)
if (diffDays === 0) return 'Idag'
if (diffDays === 1) return 'Imorgon'
if (diffDays < 0) return `${Math.abs(diffDays)} dagar sedan`
if (diffDays <= 7) return `Om ${diffDays} dagar`
return date.toLocaleDateString('sv-SE', { day: 'numeric', month: 'short' })
}
const handleStatusChange = async (deadlineId: string, newStatus: DeadlineStatus) => {
setUpdatingId(deadlineId)
try {
const response = await fetch(`/api/deadlines/${deadlineId}/status`, {
method: 'PATCH',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ status: newStatus }),
})
if (!response.ok) {
const data = await response.json()
throw new Error(data.error || 'Failed to update status')
}
toast({
title: 'Status uppdaterad',
description: `Markerad som ${STATUS_LABELS[newStatus].toLowerCase()}`,
})
onStatusChange?.(deadlineId, newStatus)
} catch (error) {
toast({
title: error instanceof Error ? error.message : 'Kunde inte uppdatera status',
variant: 'destructive',
})
} finally {
setUpdatingId(null)
}
}
const getReportLink = (deadline: Deadline): string | null => {
if (!deadline.linked_report_type || !deadline.linked_report_period) {
return null
}
return getReportUrl(deadline.linked_report_type, deadline.linked_report_period)
}
return (
<Card className="border-warning/30 bg-warning/5">
<CardHeader className="pb-2">
<div className="flex items-center justify-between">
<CardTitle className="text-lg flex items-center gap-2">
<FileText className="h-5 w-5 text-warning-foreground" />
Att göra - Skatt
</CardTitle>
<div className="flex gap-2">
{overdueCount > 0 && (
<Badge variant="destructive">{overdueCount} försenad</Badge>
)}
{actionNeededCount > 0 && (
<Badge variant="warning">{actionNeededCount} snart</Badge>
)}
</div>
</div>
</CardHeader>
<CardContent className="space-y-3">
{sortedDeadlines.slice(0, 5).map((deadline) => {
const isUpdating = updatingId === deadline.id
const reportLink = getReportLink(deadline)
const isOverdue = deadline.status === 'overdue'
const isActionNeeded = deadline.status === 'action_needed'
return (
<div
key={deadline.id}
className={`p-3 rounded-lg ${
isOverdue
? 'bg-destructive/5 border border-destructive/30'
: isActionNeeded
? 'bg-warning/5 border border-warning/20'
: ''
}`}
>
<div className="flex items-start justify-between gap-2">
<div className="flex items-start gap-2 min-w-0 flex-1">
{isOverdue ? (
<AlertTriangle className="h-4 w-4 text-destructive flex-shrink-0 mt-0.5" />
) : (
<Clock className="h-4 w-4 text-warning-foreground flex-shrink-0 mt-0.5" />
)}
<div className="min-w-0 flex-1">
<p className="text-sm font-medium">{deadline.title}</p>
<div className="flex items-center gap-2 mt-1">
<span
className={`text-xs ${
isOverdue ? 'text-destructive font-medium' : 'text-muted-foreground'
}`}
>
{formatDate(deadline.due_date)}
</span>
{deadline.tax_deadline_type && (
<Badge variant="outline" className="text-xs px-1.5 py-0 h-5">
{TAX_DEADLINE_TYPE_LABELS[deadline.tax_deadline_type]}
</Badge>
)}
</div>
</div>
</div>
<div className="flex items-center gap-1 flex-shrink-0">
{/* Link to report if available */}
{reportLink && (
<Link href={reportLink}>
<Button variant="ghost" size="sm" className="h-9 px-2.5">
<ExternalLink className="h-3.5 w-3.5" />
</Button>
</Link>
)}
{/* Mark as in progress */}
{['action_needed', 'overdue'].includes(deadline.status) && (
<Button
variant="outline"
size="sm"
className="h-9 px-3 text-xs"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'in_progress')}
>
{isUpdating ? (
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
'Påbörja'
)}
</Button>
)}
{/* Mark as submitted */}
{deadline.status === 'in_progress' && (
<Button
variant="default"
size="sm"
className="h-9 px-3 text-xs gap-1"
disabled={isUpdating}
onClick={() => handleStatusChange(deadline.id, 'submitted')}
>
{isUpdating ? (
<Loader2 className="h-3.5 w-3.5 animate-spin" />
) : (
<>
<Send className="h-3.5 w-3.5" />
Inskickad
</>
)}
</Button>
)}
</div>
</div>
</div>
)
})}
{sortedDeadlines.length > 5 && (
<p className="text-xs text-muted-foreground text-center">
+{sortedDeadlines.length - 5} fler uppgifter
</p>
)}
<Link href="/deadlines" className="block">
<Button variant="ghost" className="w-full justify-between">
Visa alla deadlines
<ChevronRight className="h-4 w-4" />
</Button>
</Link>
</CardContent>
</Card>
)
}