* fix(invoices): reminder emails use the per-currency payment account, never the SEK IBAN Invoice PDF and invoice email resolve payment details by invoice currency (invoice_payment_accounts, #1116), but the overdue-reminder templates still read the legacy company_settings fields, so a EUR reminder printed the SEK account's IBAN. A customer has paid to the wrong account from one. Both reminder generators now go through companyWithInvoicePaymentAccount, and sendReminder applies the same gate as invoice send: no usable account for the invoice currency means the reminder is skipped with INVOICE_PAYMENT_ACCOUNT_MISSING:<currency> in the result, instead of going out with no (or the wrong) payment details. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(invoices): run the reminder payment-account gate before the fee entry and reminder row Skeptic refutation (3/3): the gate lived in sendReminder, after processOverdueReminders had already posted the 60 kr påminnelseavgift verifikat and inserted the invoice_reminders row, so a skipped EUR reminder booked a fee for an email never sent and burned the level for good. The gate now runs in the loop before any write; sendReminder keeps it only as a backstop for direct callers. New processor test asserts no fee entry, no row and no email for the skipped case, and all three once an account exists. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
207 lines
6.8 KiB
TypeScript
207 lines
6.8 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
|
|
const chainCalls: Array<{ method: string; args: unknown[] }> = []
|
|
|
|
vi.mock('@supabase/ssr', () => {
|
|
const buildChain = (): unknown =>
|
|
new Proxy(
|
|
{},
|
|
{
|
|
get(_t, prop) {
|
|
if (prop === 'then') {
|
|
return (resolve: (v: unknown) => void) =>
|
|
resolve({ data: [], error: null, count: null })
|
|
}
|
|
return (...args: unknown[]) => {
|
|
chainCalls.push({ method: String(prop), args })
|
|
return buildChain()
|
|
}
|
|
},
|
|
},
|
|
)
|
|
|
|
return {
|
|
createServerClient: vi.fn(() => ({
|
|
from: vi.fn(() => buildChain()),
|
|
rpc: vi.fn(() => buildChain()),
|
|
})),
|
|
}
|
|
})
|
|
|
|
vi.mock('@/lib/email/invoice-sender', () => ({
|
|
resolveInvoiceSender: vi.fn().mockResolvedValue(undefined),
|
|
}))
|
|
|
|
vi.mock('@/lib/email/service', () => ({
|
|
getEmailService: () => ({
|
|
sendEmail: vi.fn().mockResolvedValue({ success: true }),
|
|
}),
|
|
}))
|
|
|
|
import {
|
|
processOverdueReminders,
|
|
determineReminderLevel,
|
|
calculateDaysOverdue,
|
|
sendReminder,
|
|
} from '../reminder-processor'
|
|
import { makeCompanySettings, makeCustomer, makeInvoice } from '@/tests/helpers'
|
|
import { getReminderDaysConfig } from '@/lib/email/reminder-templates'
|
|
|
|
describe('determineReminderLevel', () => {
|
|
it('returns null below the level-1 threshold', () => {
|
|
expect(determineReminderLevel(10, [])).toBeNull()
|
|
})
|
|
|
|
it('returns 1 at 15 days overdue', () => {
|
|
expect(determineReminderLevel(15, [])).toBe(1)
|
|
})
|
|
|
|
it('returns 2 at 30 days when level 1 already sent', () => {
|
|
expect(determineReminderLevel(30, [1])).toBe(2)
|
|
})
|
|
|
|
it('returns 3 at 45 days when 1 and 2 already sent', () => {
|
|
expect(determineReminderLevel(45, [1, 2])).toBe(3)
|
|
})
|
|
|
|
it('returns null when all levels have been sent', () => {
|
|
expect(determineReminderLevel(60, [1, 2, 3])).toBeNull()
|
|
})
|
|
|
|
it('uses a company-specific schedule', () => {
|
|
const config = { 1: 7, 2: 21, 3: 35 } as const
|
|
|
|
expect(determineReminderLevel(6, [], config)).toBeNull()
|
|
expect(determineReminderLevel(7, [], config)).toBe(1)
|
|
expect(determineReminderLevel(21, [1], config)).toBe(2)
|
|
expect(determineReminderLevel(35, [1, 2], config)).toBe(3)
|
|
})
|
|
})
|
|
|
|
describe('getReminderDaysConfig', () => {
|
|
it('returns the existing defaults when no company settings are supplied', () => {
|
|
expect(getReminderDaysConfig()).toEqual({ 1: 15, 2: 30, 3: 45 })
|
|
})
|
|
|
|
it('returns configured company thresholds', () => {
|
|
expect(getReminderDaysConfig({
|
|
reminder_days_level_1: 5,
|
|
reminder_days_level_2: 10,
|
|
reminder_days_level_3: 20,
|
|
})).toEqual({ 1: 5, 2: 10, 3: 20 })
|
|
})
|
|
|
|
it('falls back to defaults for an invalid stored schedule', () => {
|
|
expect(getReminderDaysConfig({
|
|
reminder_days_level_1: 30,
|
|
reminder_days_level_2: 20,
|
|
reminder_days_level_3: 45,
|
|
})).toEqual({ 1: 15, 2: 30, 3: 45 })
|
|
})
|
|
})
|
|
|
|
describe('calculateDaysOverdue', () => {
|
|
it('returns a positive number for a past due date', () => {
|
|
const tenDaysAgo = new Date()
|
|
tenDaysAgo.setDate(tenDaysAgo.getDate() - 10)
|
|
const days = calculateDaysOverdue(tenDaysAgo.toISOString().split('T')[0])
|
|
expect(days).toBeGreaterThanOrEqual(9)
|
|
expect(days).toBeLessThanOrEqual(10)
|
|
})
|
|
})
|
|
|
|
describe('processOverdueReminders: credit-note filter', () => {
|
|
beforeEach(() => {
|
|
chainCalls.length = 0
|
|
})
|
|
|
|
it('excludes credit notes via .is("credited_invoice_id", null)', async () => {
|
|
await processOverdueReminders()
|
|
|
|
const isCall = chainCalls.find(
|
|
(c) => c.method === 'is' && c.args[0] === 'credited_invoice_id',
|
|
)
|
|
|
|
expect(
|
|
isCall,
|
|
'overdue-invoice query must filter out credit notes: credit notes have a negative total and must never trigger a payment reminder (e.g. KR-F2026002)',
|
|
).toBeDefined()
|
|
expect(isCall?.args[1]).toBeNull()
|
|
})
|
|
|
|
it('combines the credit-note filter with status allowlist and due_date cutoff', async () => {
|
|
await processOverdueReminders()
|
|
|
|
const inStatus = chainCalls.find(
|
|
(c) => c.method === 'in' && c.args[0] === 'status',
|
|
)
|
|
const isCreditedNull = chainCalls.find(
|
|
(c) => c.method === 'is' && c.args[0] === 'credited_invoice_id',
|
|
)
|
|
const lteDueDate = chainCalls.find(
|
|
(c) => c.method === 'lte' && c.args[0] === 'due_date',
|
|
)
|
|
|
|
expect(inStatus?.args[1]).toEqual(['sent', 'overdue'])
|
|
expect(isCreditedNull?.args[1]).toBeNull()
|
|
expect(lteDueDate).toBeDefined()
|
|
})
|
|
|
|
it('uses a positive allowlist (sent + overdue) so paid / partially_paid / cancelled / credited can never match', async () => {
|
|
await processOverdueReminders()
|
|
|
|
const inStatus = chainCalls.find(
|
|
(c) => c.method === 'in' && c.args[0] === 'status',
|
|
)
|
|
expect(inStatus?.args[1]).toEqual(['sent', 'overdue'])
|
|
|
|
// Defense in depth: ensure no .eq('status', terminal) somehow snuck in.
|
|
const eqTerminal = chainCalls.find(
|
|
(c) =>
|
|
c.method === 'eq' &&
|
|
c.args[0] === 'status' &&
|
|
['paid', 'partially_paid', 'cancelled', 'credited'].includes(
|
|
c.args[1] as string,
|
|
),
|
|
)
|
|
expect(eqTerminal).toBeUndefined()
|
|
})
|
|
|
|
it('includes overdue in the allowlist so level-2 and level-3 reminders re-fire after the first reminder flips status', async () => {
|
|
await processOverdueReminders()
|
|
const inStatus = chainCalls.find(
|
|
(c) => c.method === 'in' && c.args[0] === 'status',
|
|
)
|
|
expect(inStatus?.args[1]).toContain('overdue')
|
|
})
|
|
})
|
|
|
|
describe('sendReminder payment-account gate', () => {
|
|
const customer = makeCustomer({ email: 'kund@example.se' })
|
|
const surcharges = { interestAmount: 0, interestRate: 0.1, interestDays: 0, reminderFee: 60 }
|
|
|
|
it('skips a EUR reminder when the company has no EUR payment account (no SEK fallback)', async () => {
|
|
const sekOnly = makeCompanySettings({ bankgiro: '123-4567', iban: 'SE4550000000058398257466' })
|
|
const invoice = { ...makeInvoice({ currency: 'EUR', total: 500 }), customer }
|
|
const result = await sendReminder(invoice, sekOnly, 1, 'tok', surcharges)
|
|
expect(result.success).toBe(false)
|
|
expect(result.error).toBe('INVOICE_PAYMENT_ACCOUNT_MISSING:EUR')
|
|
})
|
|
|
|
it('sends a SEK reminder on legacy SEK details', async () => {
|
|
const sekOnly = makeCompanySettings({ bankgiro: '123-4567' })
|
|
const invoice = { ...makeInvoice({ currency: 'SEK', total: 500 }), customer }
|
|
const result = await sendReminder(invoice, sekOnly, 1, 'tok', surcharges)
|
|
expect(result.success).toBe(true)
|
|
})
|
|
|
|
it('sends a EUR reminder once a EUR account is configured', async () => {
|
|
const company = makeCompanySettings({
|
|
invoice_payment_accounts: { EUR: { iban: 'DE89370400440532013000', bic: 'DEUTDEFF' } } as never,
|
|
})
|
|
const invoice = { ...makeInvoice({ currency: 'EUR', total: 500 }), customer }
|
|
const result = await sendReminder(invoice, company, 1, 'tok', surcharges)
|
|
expect(result.success).toBe(true)
|
|
})
|
|
})
|